Prevent "producer not unregistered" message (#5009)

This commit is contained in:
Amber Brown 2019-04-25 02:37:33 +10:00 committed by Richard van der Hoff
parent 1a63c7c281
commit 6b2b9a58c4
2 changed files with 5 additions and 0 deletions

1
changelog.d/5009.bugfix Normal file
View File

@ -0,0 +1 @@
Clients timing out/disappearing while downloading from the media repository will now no longer log a spurious "Producer was not unregistered" message.

View File

@ -191,6 +191,10 @@ def respond_with_responder(request, responder, media_type, file_size, upload_nam
# in that case. # in that case.
logger.warning("Failed to write to consumer: %s %s", type(e), e) logger.warning("Failed to write to consumer: %s %s", type(e), e)
# Unregister the producer, if it has one, so Twisted doesn't complain
if request.producer:
request.unregisterProducer()
finish_request(request) finish_request(request)