From 697872cf087d983d77e7c2174ad71361f703fb49 Mon Sep 17 00:00:00 2001 From: "Paul \"LeoNerd\" Evans" Date: Thu, 18 Aug 2016 17:24:39 +0100 Subject: [PATCH] More warnings about invalid results from AS 3PE query --- synapse/handlers/appservice.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/synapse/handlers/appservice.py b/synapse/handlers/appservice.py index 52c127d2c..6f162a3c0 100644 --- a/synapse/handlers/appservice.py +++ b/synapse/handlers/appservice.py @@ -187,15 +187,20 @@ class ApplicationServicesHandler(object): ret = [] for (success, result) in results: if not success: + logger.warn("Application service failed %r", result) continue if not isinstance(result, list): + logger.warn( + "Application service returned an invalid response %r", result + ) continue for r in result: if _is_valid_3pentity_result(r, field=required_field): ret.append(r) else: - logger.warn("Application service returned an " + - "invalid result %r", r) + logger.warn( + "Application service returned an invalid result %r", r + ) defer.returnValue(ret)