Matrix-Mirrors/synapse-product
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse-product.git synced 2024-08-05 04:35:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix get destinations to catch up query. (#9114)

Browse Source 
t was doing a sequential scan on `destination_rooms`, which took
minutes.
This commit is contained in:
Erik Johnston 2021-01-14 16:47:21 +00:00 committed by GitHub
parent 7036e24e98
commit 631dd06f2c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/9114.bugfix Normal file
View File

@ -0,0 +1 @@
Fix bug in federation catchup logic that caused outbound federation to be delayed for large servers after start up. Introduced in v1.21.0.

24
synapse/storage/databases/main/transactions.py
View File

@ -464,19 +464,17 @@ class TransactionStore(TransactionWorkerStore):
txn: LoggingTransaction, now_time_ms: int, after_destination: Optional[str] txn: LoggingTransaction, now_time_ms: int, after_destination: Optional[str]
) -> List[str]: ) -> List[str]:
q = """ q = """
SELECT destination FROM destinations SELECT DISTINCT destination FROM destinations
WHERE destination IN ( INNER JOIN destination_rooms USING (destination)
SELECT destination FROM destination_rooms WHERE
WHERE destination_rooms.stream_ordering > stream_ordering > last_successful_stream_ordering
destinations.last_successful_stream_ordering AND destination > ?
) AND (
AND destination > ? retry_last_ts IS NULL OR
AND ( retry_last_ts + retry_interval < ?
retry_last_ts IS NULL OR )
retry_last_ts + retry_interval < ? ORDER BY destination
) LIMIT 25
ORDER BY destination
LIMIT 25
""" """
txn.execute( txn.execute(
q, q,