mirror of
https://git.anonymousland.org/anonymousland/synapse-product.git
synced 2024-09-08 01:31:55 +00:00
Merge pull request #6334 from matrix-org/rav/url_preview_limit_title_2
Fix exception when OpenGraph tag values are ints
This commit is contained in:
commit
5570d1c93f
1
changelog.d/6334.feature
Normal file
1
changelog.d/6334.feature
Normal file
@ -0,0 +1 @@
|
||||
Limit the length of data returned by url previews, to prevent DoS attacks.
|
@ -278,7 +278,8 @@ class PreviewUrlResource(DirectServeResource):
|
||||
# filter out any stupidly long values
|
||||
keys_to_remove = []
|
||||
for k, v in og.items():
|
||||
if len(k) > OG_TAG_NAME_MAXLEN or len(v) > OG_TAG_VALUE_MAXLEN:
|
||||
# values can be numeric as well as strings, hence the cast to str
|
||||
if len(k) > OG_TAG_NAME_MAXLEN or len(str(v)) > OG_TAG_VALUE_MAXLEN:
|
||||
logger.warning(
|
||||
"Pruning overlong tag %s from OG data", k[:OG_TAG_NAME_MAXLEN]
|
||||
)
|
||||
|
Loading…
Reference in New Issue
Block a user