Matrix-Mirrors/synapse-product
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse-product.git synced 2024-12-20 20:14:19 -05:00
Code Issues Packages Projects Releases Wiki Activity

reshuffle todo & comments

Browse Source
This commit is contained in:
Matthew Hodgson 2018-03-19 01:00:12 +00:00
parent 366f730bf6
commit 478af0f720
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
synapse/handlers/sync.py
View File

@ -483,11 +483,15 @@ class SyncHandler(object):
) )
] ]
# TODO: we should opportunistically deduplicate these members here # We can't remove redundant member types at this stage as it has
# within the same sync series (based on an in-memory cache) # to be done based on event_id, and we don't have the member
# event ids until we've pulled them out of the DB.
if not types: if not types:
# an optimisation to stop needlessly trying to calculate
# member_state_ids
filter_members = False filter_members = False
types.append((None, None)) # don't just filter to room members types.append((None, None)) # don't just filter to room members
if full_state: if full_state:
@ -559,6 +563,10 @@ class SyncHandler(object):
else: else:
state_ids = {} state_ids = {}
if filter_members: if filter_members:
# TODO: filter out redundant members based on their mxids (not their
# event_ids) at this point. We know we can do it based on mxid as this
# is an non-gappy incremental sync.
# strip off the (None, None) and filter to just room members # strip off the (None, None) and filter to just room members
types = types[:-1] types = types[:-1]
if types: if types: