Use TYPE_CHECKING instead of magic MYPY variable. (#8770)

changelog.d/8770.misc

@@ -0,0 +1 @@
+Use `TYPE_CHECKING` instead of magic `MYPY` variable.

synapse/events/spamcheck.py

@@ -15,13 +15,12 @@
 # limitations under the License.
 
 import inspect
-from typing import Any, Dict, List, Optional, Tuple
+from typing import TYPE_CHECKING, Any, Dict, List, Optional, Tuple
 
 from synapse.spam_checker_api import RegistrationBehaviour
 from synapse.types import Collection
 
-MYPY = False
+if TYPE_CHECKING:
-if MYPY:
     import synapse.events
     import synapse.server
 

synapse/handlers/presence.py

@@ -25,7 +25,7 @@ The methods that define policy are:
 import abc
 import logging
 from contextlib import contextmanager
-from typing import Dict, Iterable, List, Set, Tuple
+from typing import TYPE_CHECKING, Dict, Iterable, List, Set, Tuple
 
 from prometheus_client import Counter
 from typing_extensions import ContextManager
@@ -46,8 +46,7 @@ from synapse.util.caches.descriptors import cached
 from synapse.util.metrics import Measure
 from synapse.util.wheel_timer import WheelTimer
 
-MYPY = False
+if TYPE_CHECKING:
-if MYPY:
     from synapse.server import HomeServer
 
 logger = logging.getLogger(__name__)

synapse/rest/client/v1/room.py

@@ -18,7 +18,7 @@
 
 import logging
 import re
-from typing import List, Optional
+from typing import TYPE_CHECKING, List, Optional
 from urllib import parse as urlparse
 
 from synapse.api.constants import EventTypes, Membership
@@ -48,8 +48,7 @@ from synapse.types import RoomAlias, RoomID, StreamToken, ThirdPartyInstanceID,
 from synapse.util import json_decoder
 from synapse.util.stringutils import random_string
 
-MYPY = False
+if TYPE_CHECKING:
-if MYPY:
     import synapse.server
 
 logger = logging.getLogger(__name__)