Move flake8 to end. Don't exit script on failure (#7738)

This commit is contained in:
Andrew Morgan 2020-06-25 17:58:55 +01:00 committed by GitHub
parent b099ef07d6
commit 177b2d0c19
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions

1
changelog.d/7738.misc Normal file
View File

@ -0,0 +1 @@
Move `flake8` to the end of `scripts-dev/lint.sh` as it takes the longest and could cause the script to exit early.

View File

@ -2,8 +2,8 @@
# #
# Runs linting scripts over the local Synapse checkout # Runs linting scripts over the local Synapse checkout
# isort - sorts import statements # isort - sorts import statements
# flake8 - lints and finds mistakes
# black - opinionated code formatter # black - opinionated code formatter
# flake8 - lints and finds mistakes
set -e set -e
@ -16,6 +16,6 @@ fi
echo "Linting these locations: $files" echo "Linting these locations: $files"
isort -y -rc $files isort -y -rc $files
flake8 $files
python3 -m black $files python3 -m black $files
./scripts-dev/config-lint.sh ./scripts-dev/config-lint.sh
flake8 $files