Matrix-Mirrors/schildi-web
1
0
Fork 0
mirror of https://github.com/SchildiChat/element-web.git synced 2024-10-01 01:26:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12925 from JorikSchellekens/joriks/review-review

Browse Source 
Some grammar and clarifications
This commit is contained in:
Michael Telatynski 2020-03-30 12:13:00 +01:00 committed by GitHub
commit e895fed180
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
docs/review.md
View File

@ -41,15 +41,15 @@ When reviewing code, here are some things we look for and also things we avoid:
### Workflow ### Workflow
* Authors should request review from riot-web team by default (if someone on the * Authors should request review from the riot-web team by default (if someone on
team is clearly the expert in an area, a direct review request to them may be the team is clearly the expert in an area, a direct review request to them may
more appropriate) be more appropriate)
* Reviewers should remove the team review request and request review from * Reviewers should remove the team review request and request review from
themselves when starting a review to avoid double review themselves when starting a review to avoid double review
* Authors should link to other layers of their PR in their PR before requesting * If there are multiple related PRs authors should reference each of the PRs in
review. Reviewers might be coming from different places and could miss other the others before requesting review. Reviewers might start reviewing from
required PRs. different places and could miss other required PRs.
* Avoid force pushing to a PR after first round of review * Avoid force pushing to a PR after the first round of review
* Use the GitHub default of merge commits when landing (avoid alternate options * Use the GitHub default of merge commits when landing (avoid alternate options
like squash or rebase) like squash or rebase)
* PR author merges after review (assuming they have write access) * PR author merges after review (assuming they have write access)