diff --git a/src/components/views/dialogs/ChangelogDialog.js b/src/components/views/dialogs/ChangelogDialog.js index 6bc6de60f..d14d8dc2c 100644 --- a/src/components/views/dialogs/ChangelogDialog.js +++ b/src/components/views/dialogs/ChangelogDialog.js @@ -31,9 +31,10 @@ export default class ChangelogDialog extends React.Component { const version = this.props.newVersion.split('-'); const version2 = this.props.version.split('-'); if(version == null || version2 == null) return; + // parse versions of form: [vectorversion]-react-[react-sdk-version]-js-[js-sdk-version] for(let i=0; i { if(body == null) return; this.setState({[REPOS[i]]: JSON.parse(body).commits}); diff --git a/src/components/views/globals/NewVersionBar.js b/src/components/views/globals/NewVersionBar.js index 36d6bc71b..3e03be72b 100644 --- a/src/components/views/globals/NewVersionBar.js +++ b/src/components/views/globals/NewVersionBar.js @@ -23,11 +23,11 @@ import PlatformPeg from 'matrix-react-sdk/lib/PlatformPeg'; /** * Check a version string is compatible with the Changelog - * dialog + * dialog ([vectorversion]-react-[react-sdk-version]-js-[js-sdk-version]) */ function checkVersion(ver) { const parts = ver.split('-'); - return parts[0] == 'vector' && parts[2] == 'react' && parts[4] == 'js'; + return parts.length == 5 && parts[1] == 'react' && parts[3] == 'js'; } export default React.createClass({