Matrix-Mirrors/schildi-web
1
0
Fork 0
mirror of https://github.com/SchildiChat/element-web.git synced 2024-10-01 01:26:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add notes on review request handling

Browse Source
This commit is contained in:
J. Ryan Stinnett 2020-03-18 10:59:33 +00:00
parent 3989f41985
commit 34f3671c09
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
docs/review.md
View File

@ -40,6 +40,11 @@ When reviewing code, here are some things we look for and also things we avoid:
### Workflow
* Authors should request review from riot-web team by default (if someone on the
team is clearly the expert in an area, a direct review request to them may be
more appropriate)
* Reviewers should remove the team review request and request review from
themselves when starting a review to avoid double review
* Authors should link to other layers of their PR in their PR before requesting
review. Reviewers might be coming from different places and could miss other
required PRs.