From 231ca253f20653bb6d1b30adbecb4fca01b65179 Mon Sep 17 00:00:00 2001 From: David Baker Date: Thu, 18 Oct 2018 18:31:06 +0100 Subject: [PATCH] Stop electron crashing Workaround temporarily by not closing notifs on win32 as per comment. Fixes https://github.com/vector-im/riot-web/issues/7512 --- src/vector/platform/ElectronPlatform.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/vector/platform/ElectronPlatform.js b/src/vector/platform/ElectronPlatform.js index f811192e2..e8211fdc6 100644 --- a/src/vector/platform/ElectronPlatform.js +++ b/src/vector/platform/ElectronPlatform.js @@ -169,6 +169,11 @@ export default class ElectronPlatform extends VectorBasePlatform { } clearNotification(notif: Notification) { + // This crashes on windows under certain circumstances: can't find any + // workaround othet than not closing notifs. + // https://github.com/electron/electron/issues/15251 + // https://github.com/vector-im/riot-web/issues/7512 + if (window.process.platform === 'win32') return; notif.close(); }