Matrix-Mirrors/mjolnir
1
0
Fork 0
mirror of https://github.com/matrix-org/mjolnir.git synced 2024-09-28 20:26:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make startup failures more controlled and understandable. (#270)

Browse Source 
There is no reason to call process.exit() from `index.ts` or in `Mjolnir.start()` because

https://nodejs.org/api/process.html#warning-using-uncaughtexception-correctly

>The 'uncaughtException' event is emitted when an uncaught JavaScript exception bubbles all the way back to the event loop. By default, Node.js handles such exceptions by printing the stack trace to stderr and exiting with code 1, overriding any previously set process.exitCode. Adding a handler for the 'uncaughtException' event overrides this default behaviour.
This commit is contained in:
Gnuxie 2022-04-01 16:40:10 +01:00 committed by GitHub
parent fb7167773b
commit f63edbefa0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Mjolnir.ts
View File

@ -320,11 +320,12 @@ export class Mjolnir {
try {
LogService.error("Mjolnir", "Error during startup:");
LogService.error("Mjolnir", extractRequestError(err));
this.stop();
await this.logMessage(LogLevel.ERROR, "Mjolnir@startup", "Startup failed due to error - see console");
throw err;
} catch (e) {
// If we failed to handle the error, just crash
console.error(e);
process.exit(1);
LogService.error("Mjolnir", `Failed to report startup error to the management room: ${e}`);
throw err;
}
}
}

9
src/index.ts
View File

@ -57,9 +57,14 @@ if (config.health.healthz.enabled) {
config.RUNTIME.client = client;
bot = await Mjolnir.setupMjolnirFromConfig(client);
} catch (err) {
console.error(`Failed to setup mjolnir from the config ${config.dataPath}: ${err}`);
throw err;
}
try {
await bot.start();
} catch (err) {
bot?.logMessage(LogLevel.ERROR, "index", err);
process.exit(1);
console.error(`Mjolnir failed to start: ${err}`);
throw err;
}
})();