Add mention spam protection.

This commit is contained in:
Will Hunt 2024-09-19 15:35:09 +01:00
parent 1c5b49df54
commit ea58b0b5b5
2 changed files with 93 additions and 3 deletions

View File

@ -0,0 +1,88 @@
/*
Copyright 2024 The Matrix.org Foundation C.I.C.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
import { Protection } from "./IProtection";
import { Mjolnir } from "../Mjolnir";
import { LogLevel, Permalinks, UserID } from "@vector-im/matrix-bot-sdk";
import { NumberProtectionSetting } from "./ProtectionSettings";
const MAX_MENTIONS = 8;
const USER_ID_REGEX = /@[^:]*:.+/;
export class MentionSpam extends Protection {
settings = {
maxMentions: new NumberProtectionSetting(MAX_MENTIONS),
};
constructor() {
super();
}
public get name(): string {
return 'MentionSpam';
}
public get description(): string {
return "If a user posts many mentions, that message is redacted. No bans are issued.";
}
public checkMentions(body: unknown|undefined, htmlBody: unknown|undefined, mentionArray: unknown|undefined): boolean {
const max = this.settings.maxMentions.value;
if (Array.isArray(mentionArray)) {
if (mentionArray.length > this.settings.maxMentions.value) {
return true;
}
}
if (typeof body === "string") {
let found = 0;
for (const word of body.split(/\s/)) {
if (USER_ID_REGEX.test(word.trim())) {
if (found++ > max) {
return true;
}
}
}
}
if (typeof htmlBody === "string") {
let found = 0;
for (const word of htmlBody.split(/\s/)) {
if (USER_ID_REGEX.test(word.trim())) {
if (found++ > max) {
return true;
}
}
}
}
return false;
}
public async handleEvent(mjolnir: Mjolnir, roomId: string, event: any): Promise<any> {
if (event['type'] === 'm.room.message') {
let content = event['content'] || {};
const explicitMentions = content["m.mentions"]?.["m.user_ids"];
const hitLimit = this.checkMentions(content.body, content.formatted_body, explicitMentions);
if (hitLimit) {
await mjolnir.managementRoomOutput.logMessage(LogLevel.WARN, "MessageIsMedia", `Redacting event from ${event['sender']} for spamming mentions. ${Permalinks.forEvent(roomId, event['event_id'], [new UserID(await mjolnir.client.getUserId()).domain])}`);
// Redact the event
if (!mjolnir.config.noop) {
await mjolnir.client.redactEvent(roomId, event['event_id'], "Message was detected as spam.");
} else {
await mjolnir.managementRoomOutput.logMessage(LogLevel.WARN, "MessageIsMedia", `Tried to redact ${event['event_id']} in ${roomId} but Mjolnir is running in no-op mode`, roomId);
}
}
}
}
}

View File

@ -1,5 +1,5 @@
/* /*
Copyright 2019 - 2022 The Matrix.org Foundation C.I.C. Copyright 2019 - 2024 The Matrix.org Foundation C.I.C.
Licensed under the Apache License, Version 2.0 (the "License"); Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License. you may not use this file except in compliance with the License.
@ -24,7 +24,7 @@ import { MessageIsMedia } from "./MessageIsMedia";
import { TrustedReporters } from "./TrustedReporters"; import { TrustedReporters } from "./TrustedReporters";
import { JoinWaveShortCircuit } from "./JoinWaveShortCircuit"; import { JoinWaveShortCircuit } from "./JoinWaveShortCircuit";
import { Mjolnir } from "../Mjolnir"; import { Mjolnir } from "../Mjolnir";
import { extractRequestError, LogLevel, LogService, Permalinks } from "matrix-bot-sdk"; import { extractRequestError, LogLevel, LogService, Permalinks } from "@vector-im/matrix-bot-sdk";
import { ProtectionSettingValidationError } from "./ProtectionSettings"; import { ProtectionSettingValidationError } from "./ProtectionSettings";
import { Consequence } from "./consequence"; import { Consequence } from "./consequence";
import { htmlEscape } from "../utils"; import { htmlEscape } from "../utils";
@ -32,6 +32,7 @@ import { ERROR_KIND_FATAL, ERROR_KIND_PERMISSION } from "../ErrorCache";
import { RoomUpdateError } from "../models/RoomUpdateError"; import { RoomUpdateError } from "../models/RoomUpdateError";
import { LocalAbuseReports } from "./LocalAbuseReports"; import { LocalAbuseReports } from "./LocalAbuseReports";
import {NsfwProtection} from "./NsfwProtection"; import {NsfwProtection} from "./NsfwProtection";
import { MentionSpam } from "./MentionSpam";
const PROTECTIONS: Protection[] = [ const PROTECTIONS: Protection[] = [
new FirstMessageIsImage(), new FirstMessageIsImage(),
@ -43,7 +44,8 @@ const PROTECTIONS: Protection[] = [
new DetectFederationLag(), new DetectFederationLag(),
new JoinWaveShortCircuit(), new JoinWaveShortCircuit(),
new LocalAbuseReports(), new LocalAbuseReports(),
new NsfwProtection() new NsfwProtection(),
new MentionSpam()
]; ];
const ENABLED_PROTECTIONS_EVENT_TYPE = "org.matrix.mjolnir.enabled_protections"; const ENABLED_PROTECTIONS_EVENT_TYPE = "org.matrix.mjolnir.enabled_protections";