Matrix-Mirrors/mjolnir
1
0
Fork 0
mirror of https://github.com/matrix-org/mjolnir.git synced 2024-06-28 23:52:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix incorrect type deceleration in check_username_for_spam (#250)

Browse Source 
Fixes https://github.com/matrix-org/mjolnir/issues/245
This commit is contained in:
Gnuxie 2022-03-18 17:20:53 +00:00 committed by GitHub
parent 48206a8524
commit 814e528eaf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
synapse_antispam/mjolnir/antispam.py
View File

@ -14,7 +14,7 @@
# limitations under the License.
import logging
from typing import Dict, Union
from typing import Dict, Union, Optional
from .list_rule import ALL_RULE_TYPES, RECOMMENDATION_BAN
from .ban_list import BanList
from synapse.module_api import UserID
@ -124,9 +124,12 @@ class AntiSpam(object):
# Check whether the user ID or display name matches any of the banned
# patterns.
return self.is_user_banned(user_profile["user_id"]) or self.is_user_banned(
user_profile["display_name"]
)
if user_profile["display_name"] is not None and self.is_user_banned(user_profile["display_name"]):
return True # spam
if self.is_user_banned(user_profile["user_id"]):
return True # spam
return False # not spam.
def user_may_create_room(self, user_id):
return True # allowed
@ -175,5 +178,5 @@ class Module:
) -> bool:
return self.antispam.user_may_invite(inviter_user_id, invitee_user_id, room_id)
async def check_username_for_spam(self, user_profile: Dict[str, str]) -> bool:
async def check_username_for_spam(self, user_profile: Dict[str, Optional[str]]) -> bool:
return self.antispam.check_username_for_spam(user_profile)