Matrix-Mirrors/mjolnir
1
0
Fork 0
mirror of https://github.com/matrix-org/mjolnir.git synced 2024-10-01 01:36:06 -04:00
Code Issues Packages Projects Releases Wiki Activity

Tidy makeAdminCommandTest.ts

Browse Source 
This was pretty suspect with the number of clients syncing  unnecessarily, it was
also really hard to read. It also tests the same thing twice, even if it is
a slightly different way.

https://github.com/matrix-org/mjolnir/pull/219/files#diff-4e8bbc9dde21b7b895e0c081d2e3375c8958c51a10442497dfffb677f0d59a1aR1-R107
This commit is contained in:
gnuxie 2022-04-27 13:45:52 +01:00
parent cc9f393ed7
commit 61192daff5
2 changed files with 15 additions and 84 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

96
test/integration/commands/makedminCommandTest.ts
View File

@ -2,106 +2,36 @@
import config from "../../../src/config"; import config from "../../../src/config";
import { newTestUser } from "../clientHelper"; import { newTestUser } from "../clientHelper";
import { PowerLevelAction } from "matrix-bot-sdk/lib/models/PowerLevelAction";
import { LogService } from "matrix-bot-sdk"; import { LogService } from "matrix-bot-sdk";
import { getFirstReaction } from "./commandUtils"; import { getFirstReaction } from "./commandUtils";
describe("Test: The make admin command", function () { describe("Test: The make admin command", function () {
afterEach(function () { it('make Mjölnir the room administrator by "hijacking" a room via the Synapse admin API.', async function () {
this.moderator?.stop();
this.userA?.stop();
this.userB?.stop();
this.userC?.stop();
});
it('Mjölnir make the bot self room administrator', async function () {
this.timeout(90000); this.timeout(90000);
if (!config.admin?.enableMakeRoomAdminCommand) { if (!config.admin?.enableMakeRoomAdminCommand) {
done(); LogService.warn("makedminCommandTest", `SKIPPING because the make room admin command is disabled`);
this.skip();
} }
const mjolnir = config.RUNTIME.client!; const mjolnir = config.RUNTIME.client!;
const mjolnirUserId = await mjolnir.getUserId(); const mjolnirUserId = await mjolnir.getUserId();
const moderator = await newTestUser({ name: { contains: "moderator" } }); const moderator = await newTestUser({ name: { contains: "moderator" } });
const userA = await newTestUser({ name: { contains: "a" } }); const unrelatedUser = await newTestUser({ name: { contains: "new-admin" } });
const userAId = await userA.getUserId(); const unrelatedUserId = await unrelatedUser.getUserId();
this.moderator = moderator;
this.userA = userA;
let powerLevels: any;
await moderator.joinRoom(config.managementRoom); await moderator.joinRoom(config.managementRoom);
LogService.debug("makeadminTest", `Joining managementRoom: ${config.managementRoom}`);
let targetRoom = await moderator.createRoom({ invite: [mjolnirUserId], preset: "public_chat" }); let targetRoom = await moderator.createRoom({ invite: [mjolnirUserId], preset: "public_chat" });
LogService.debug("makeadminTest", `moderator creating targetRoom: ${targetRoom}; and inviting ${mjolnirUserId}`);
await moderator.sendMessage(this.mjolnir.managementRoomId, { msgtype: 'm.text.', body: `!mjolnir rooms add ${targetRoom}` }); await moderator.sendMessage(this.mjolnir.managementRoomId, { msgtype: 'm.text.', body: `!mjolnir rooms add ${targetRoom}` });
LogService.debug("makeadminTest", `Adding targetRoom: ${targetRoom}`);
try { await unrelatedUser.joinRoom(targetRoom);
await moderator.start(); let powerLevels = await mjolnir.getRoomStateEvent(targetRoom, "m.room.power_levels", "");
await userA.start(); assert.notEqual(powerLevels["users"][mjolnirUserId], 100, `Bot should not yet be an admin of ${targetRoom}`);
await userA.joinRoom(targetRoom); await getFirstReaction(mjolnir, this.mjolnir.managementRoomId, '✅', async () => {
powerLevels = await mjolnir.getRoomStateEvent(targetRoom, "m.room.power_levels", ""); return await moderator.sendMessage(this.mjolnir.managementRoomId, { msgtype: 'm.text', body: `!mjolnir make admin ${targetRoom}` });
assert.notEqual(powerLevels["users"][mjolnirUserId], 100, `Bot should not yet be an admin of ${targetRoom}`); });
await getFirstReaction(mjolnir, this.mjolnir.managementRoomId, '✅', async () => {
LogService.debug("makeadminTest", `Sending: !mjolnir make admin ${targetRoom}`);
return await moderator.sendMessage(this.mjolnir.managementRoomId, { msgtype: 'm.text', body: `!mjolnir make admin ${targetRoom}` });
});
} finally {
await moderator.stop();
await userA.stop();
}
LogService.debug("makeadminTest", `Making self admin`); LogService.debug("makeadminTest", `Making self admin`);
powerLevels = await mjolnir.getRoomStateEvent(targetRoom, "m.room.power_levels", ""); powerLevels = await mjolnir.getRoomStateEvent(targetRoom, "m.room.power_levels", "");
assert.equal(powerLevels["users"][mjolnirUserId], 100, "Bot should be a room admin."); assert.equal(powerLevels["users"][mjolnirUserId], 100, "Bot should be a room admin.");
assert.equal(powerLevels["users"][userAId], (0 || undefined), "User A is not supposed to be a room admin."); assert.equal(powerLevels["users"][unrelatedUserId], (0 || undefined), "User A is not supposed to be a room admin.");
});
it('Mjölnir make the tester room administrator', async function () {
this.timeout(90000);
if (!config.admin?.enableMakeRoomAdminCommand) {
done();
}
const mjolnir = config.RUNTIME.client!;
const moderator = await newTestUser({ name: { contains: "moderator" } });
const userA = await newTestUser({ name: { contains: "a" } });
const userB = await newTestUser({ name: { contains: "b" } });
const userC = await newTestUser({ name: { contains: "c" } });
const userBId = await userB.getUserId();
const userCId = await userC.getUserId();
this.moderator = moderator;
this.userA = userA;
this.userB = userB;
this.userC = userC;
let powerLevels: any;
await moderator.joinRoom(this.mjolnir.managementRoomId);
LogService.debug("makeadminTest", `Joining managementRoom: ${this.mjolnir.managementRoomId}`);
let targetRoom = await userA.createRoom({ invite: [userBId, userCId] });
LogService.debug("makeadminTest", `User A creating targetRoom: ${targetRoom}; and inviting ${userBId} and ${userCId}`);
try {
await userB.start();
await userC.start();
await userB.joinRoom(targetRoom);
await userC.joinRoom(targetRoom);
} finally {
LogService.debug("makeadminTest", `${userBId} and ${userCId} joining targetRoom: ${targetRoom}`);
await userB.stop();
await userC.stop();
}
try {
await moderator.start();
powerLevels = await userA.getRoomStateEvent(targetRoom, "m.room.power_levels", "");
assert.notEqual(powerLevels["users"][userBId], 100, `User B should not yet be an admin of ${targetRoom}`);
await getFirstReaction(mjolnir, this.mjolnir.managementRoomId, '✅', async () => {
LogService.debug("makeadminTest", `Sending: !mjolnir make admin ${targetRoom} ${userBId}`);
return await moderator.sendMessage(this.mjolnir.managementRoomId, { msgtype: 'm.text', body: `!mjolnir make admin ${targetRoom} ${userBId}` });
});
} finally {
await moderator.stop();
}
LogService.debug("makeadminTest", `Making User B admin`);
powerLevels = await userA.getRoomStateEvent(targetRoom, "m.room.power_levels", "");
assert.equal(powerLevels["users"][userBId], 100, "User B should be a room admin.");
assert.equal(powerLevels["users"][userCId], (0 || undefined), "User C is not supposed to be a room admin.");
}); });
}); });

3
tsconfig.json
View File

@ -21,6 +21,7 @@
"include": [ "include": [
"./src/**/*", "./src/**/*",
"./test/integration/manualLaunchScript.ts", "./test/integration/manualLaunchScript.ts",
"./test/integration/roomMembersTest.ts" "./test/integration/roomMembersTest.ts",
"./test/integration/commands/makedminCommandTest.ts"
] ]
} }