Matrix-Mirrors/mjolnir
1
0
Fork 0
mirror of https://github.com/matrix-org/mjolnir.git synced 2024-10-01 01:36:06 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix 2 issues in !config get (#413)

Browse Source
This commit is contained in:
Jess Porter 2023-01-05 07:37:42 +00:00 committed by GitHub
parent 6abc8a7c4e
commit 5824539449
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/commands/ProtectionsCommands.ts
View File

@ -139,9 +139,9 @@ export async function execConfigRemoveProtection(roomId: string, event: any, mjo
* !mjolnir get [protection name]
*/
export async function execConfigGetProtection(roomId: string, event: any, mjolnir: Mjolnir, parts: string[]) {
let pickProtections = Object.keys(mjolnir.protectionManager.protections);
let pickProtections = Array.from(mjolnir.protectionManager.protections.keys());
if (parts.length < 3) {
if (parts.length === 0) {
// no specific protectionName provided, show all of them.
// sort output by protection name
@ -175,12 +175,12 @@ export async function execConfigGetProtection(roomId: string, event: any, mjolni
for (const settingName of settingNames) {
anySettings = true;
let value = protectionSettings[settingName].value
let value = protectionSettings[settingName].value.toString();
text += `* ${protectionName}.${settingName}: ${value}`;
// `protectionName` and `settingName` are user-provided but
// validated against the names of existing protections and their
// settings, so XSS is avoided for these already
html += `<li><code>${protectionName}.${settingName}</code>: <code>${htmlEscape(value)}</code></li>`
html += `<li><code>${protectionName}.${settingName}</code>: <code>${htmlEscape(value)}</code></li>`;
}
}