mirror of
https://mau.dev/maunium/synapse.git
synced 2024-08-26 20:22:22 +00:00
![Brendan Abolivier](/assets/img/avatar_default.png)
Fixes #6815 Before figuring out whether we should alert a user on MAU, we call get_notice_room_for_user to get some info on the existing server notices room for this user. This function, if the room doesn't exist, creates it and invites the user in it. This means that, if we decide later that no server notice is needed, the user gets invited in a room with no message in it. This happens at every restart of the server, since the room ID returned by get_notice_room_for_user is cached. This PR fixes that by moving the inviting bit to a dedicated function, that's only called when the server actually needs to send a notice to the user. A potential issue with this approach is that the room that's created by get_notice_room_for_user doesn't match how that same function looks for an existing room (i.e. it creates a room that doesn't have an invite or a join for the current user in it, so it could lead to a new room being created each time a user syncs), but I'm not sure this is a problem given it's cached until the server restarts, so that function won't run very often. It also renames get_notice_room_for_user into get_or_create_notice_room_for_user to make what it does clearer.
195 lines
6.9 KiB
Python
195 lines
6.9 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Copyright 2018 New Vector Ltd
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
import logging
|
|
|
|
from twisted.internet import defer
|
|
|
|
from synapse.api.constants import EventTypes, Membership, RoomCreationPreset
|
|
from synapse.types import UserID, create_requester
|
|
from synapse.util.caches.descriptors import cachedInlineCallbacks
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
SERVER_NOTICE_ROOM_TAG = "m.server_notice"
|
|
|
|
|
|
class ServerNoticesManager(object):
|
|
def __init__(self, hs):
|
|
"""
|
|
|
|
Args:
|
|
hs (synapse.server.HomeServer):
|
|
"""
|
|
|
|
self._store = hs.get_datastore()
|
|
self._config = hs.config
|
|
self._room_creation_handler = hs.get_room_creation_handler()
|
|
self._room_member_handler = hs.get_room_member_handler()
|
|
self._event_creation_handler = hs.get_event_creation_handler()
|
|
self._is_mine_id = hs.is_mine_id
|
|
|
|
self._notifier = hs.get_notifier()
|
|
self.server_notices_mxid = self._config.server_notices_mxid
|
|
|
|
def is_enabled(self):
|
|
"""Checks if server notices are enabled on this server.
|
|
|
|
Returns:
|
|
bool
|
|
"""
|
|
return self._config.server_notices_mxid is not None
|
|
|
|
@defer.inlineCallbacks
|
|
def send_notice(
|
|
self, user_id, event_content, type=EventTypes.Message, state_key=None
|
|
):
|
|
"""Send a notice to the given user
|
|
|
|
Creates the server notices room, if none exists.
|
|
|
|
Args:
|
|
user_id (str): mxid of user to send event to.
|
|
event_content (dict): content of event to send
|
|
type(EventTypes): type of event
|
|
is_state_event(bool): Is the event a state event
|
|
|
|
Returns:
|
|
Deferred[FrozenEvent]
|
|
"""
|
|
room_id = yield self.get_or_create_notice_room_for_user(user_id)
|
|
yield self.maybe_invite_user_to_room(user_id, room_id)
|
|
|
|
system_mxid = self._config.server_notices_mxid
|
|
requester = create_requester(system_mxid)
|
|
|
|
logger.info("Sending server notice to %s", user_id)
|
|
|
|
event_dict = {
|
|
"type": type,
|
|
"room_id": room_id,
|
|
"sender": system_mxid,
|
|
"content": event_content,
|
|
}
|
|
|
|
if state_key is not None:
|
|
event_dict["state_key"] = state_key
|
|
|
|
res = yield self._event_creation_handler.create_and_send_nonmember_event(
|
|
requester, event_dict, ratelimit=False
|
|
)
|
|
return res
|
|
|
|
@cachedInlineCallbacks()
|
|
def get_or_create_notice_room_for_user(self, user_id):
|
|
"""Get the room for notices for a given user
|
|
|
|
If we have not yet created a notice room for this user, create it, but don't
|
|
invite the user to it.
|
|
|
|
Args:
|
|
user_id (str): complete user id for the user we want a room for
|
|
|
|
Returns:
|
|
str: room id of notice room.
|
|
"""
|
|
if not self.is_enabled():
|
|
raise Exception("Server notices not enabled")
|
|
|
|
assert self._is_mine_id(user_id), "Cannot send server notices to remote users"
|
|
|
|
rooms = yield self._store.get_rooms_for_local_user_where_membership_is(
|
|
user_id, [Membership.INVITE, Membership.JOIN]
|
|
)
|
|
for room in rooms:
|
|
# it's worth noting that there is an asymmetry here in that we
|
|
# expect the user to be invited or joined, but the system user must
|
|
# be joined. This is kinda deliberate, in that if somebody somehow
|
|
# manages to invite the system user to a room, that doesn't make it
|
|
# the server notices room.
|
|
user_ids = yield self._store.get_users_in_room(room.room_id)
|
|
if self.server_notices_mxid in user_ids:
|
|
# we found a room which our user shares with the system notice
|
|
# user
|
|
logger.info(
|
|
"Using existing server notices room %s for user %s",
|
|
room.room_id,
|
|
user_id,
|
|
)
|
|
return room.room_id
|
|
|
|
# apparently no existing notice room: create a new one
|
|
logger.info("Creating server notices room for %s", user_id)
|
|
|
|
# see if we want to override the profile info for the server user.
|
|
# note that if we want to override either the display name or the
|
|
# avatar, we have to use both.
|
|
join_profile = None
|
|
if (
|
|
self._config.server_notices_mxid_display_name is not None
|
|
or self._config.server_notices_mxid_avatar_url is not None
|
|
):
|
|
join_profile = {
|
|
"displayname": self._config.server_notices_mxid_display_name,
|
|
"avatar_url": self._config.server_notices_mxid_avatar_url,
|
|
}
|
|
|
|
requester = create_requester(self.server_notices_mxid)
|
|
info = yield self._room_creation_handler.create_room(
|
|
requester,
|
|
config={
|
|
"preset": RoomCreationPreset.PRIVATE_CHAT,
|
|
"name": self._config.server_notices_room_name,
|
|
"power_level_content_override": {"users_default": -10},
|
|
},
|
|
ratelimit=False,
|
|
creator_join_profile=join_profile,
|
|
)
|
|
room_id = info["room_id"]
|
|
|
|
max_id = yield self._store.add_tag_to_room(
|
|
user_id, room_id, SERVER_NOTICE_ROOM_TAG, {}
|
|
)
|
|
self._notifier.on_new_event("account_data_key", max_id, users=[user_id])
|
|
|
|
logger.info("Created server notices room %s for %s", room_id, user_id)
|
|
return room_id
|
|
|
|
@defer.inlineCallbacks
|
|
def maybe_invite_user_to_room(self, user_id: str, room_id: str):
|
|
"""Invite the given user to the given server room, unless the user has already
|
|
joined or been invited to it.
|
|
|
|
Args:
|
|
user_id: The ID of the user to invite.
|
|
room_id: The ID of the room to invite the user to.
|
|
"""
|
|
requester = create_requester(self.server_notices_mxid)
|
|
|
|
# Check whether the user has already joined or been invited to this room. If
|
|
# that's the case, there is no need to re-invite them.
|
|
joined_rooms = yield self._store.get_rooms_for_local_user_where_membership_is(
|
|
user_id, [Membership.INVITE, Membership.JOIN]
|
|
)
|
|
for room in joined_rooms:
|
|
if room.room_id == room_id:
|
|
return
|
|
|
|
yield self._room_member_handler.update_membership(
|
|
requester=requester,
|
|
target=UserID.from_string(user_id),
|
|
room_id=room_id,
|
|
action="invite",
|
|
)
|