mirror of
https://mau.dev/maunium/synapse.git
synced 2024-07-16 16:12:44 +00:00
af2248f8bf
Background: When we receive incoming federation traffic, and notice that we are missing prev_events from the incoming traffic, first we do a `/get_missing_events` request, and then if we still have missing prev_events, we set up new backwards-extremities. To do that, we need to make a `/state_ids` request to ask the remote server for the state at those prev_events, and then we may need to then ask the remote server for any events in that state which we don't already have, as well as the auth events for those missing state events, so that we can auth them. This PR attempts to optimise the processing of that state request. The `state_ids` API returns a list of the state events, as well as a list of all the auth events for *all* of those state events. The optimisation comes from the observation that we are currently loading all of those auth events into memory at the start of the operation, but we almost certainly aren't going to need *all* of the auth events. Rather, we can check that we have them, and leave the actual load into memory for later. (Ideally the federation API would tell us which auth events we're actually going to need, but it doesn't.) The effect of this is to reduce the number of events that I need to load for an event in Matrix HQ from about 60000 to about 22000, which means it can stay in my in-memory cache, whereas previously the sheer number of events meant that all 60K events had to be loaded from db for each request, due to the amount of cache churn. (NB I've already tripled the size of the cache from its default of 10K). Unfortunately I've ended up basically C&Ping `_get_state_for_room` and `_get_events_from_store_or_dest` into a new method, because `_get_state_for_room` is also called during backfill, which expects the auth events to be returned, so the same tricks don't work. That said, I don't really know why that codepath is completely different (ultimately we're doing the same thing in setting up a new backwards extremity) so I've left a TODO suggesting that we clean it up. |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| 9458.misc | ||
| 9473.bugfix | ||
| 9508.doc | ||
| 9510.feature | ||
| 9511.feature | ||
| 9520.misc | ||
| 9523.misc | ||
| 9528.misc | ||
| 9540.feature | ||
| 9540.removal | ||
| 9541.misc | ||
| 9542.bugfix | ||
| 9543.misc | ||
| 9549.feature | ||
| 9550.doc | ||
| 9559.removal | ||
| 9560.misc | ||
| 9562.misc | ||
| 9563.misc | ||
| 9567.bugfix | ||
| 9568.misc | ||
| 9571.doc | ||
| 9573.feature | ||
| 9576.misc | ||
| 9580.doc | ||
| 9583.bugfix | ||
| 9586.misc | ||
| 9587.bugfix | ||
| 9590.misc | ||
| 9591.misc | ||
| 9596.misc | ||
| 9597.bugfix | ||
| 9601.feature | ||