mirror of
https://mau.dev/maunium/synapse.git
synced 2024-07-07 19:52:23 +00:00
a4d62ba36a
V2 Registration forced everyone (including ASes) to create a password for a user, when ASes should be able to omit passwords. Also unbreak AS registration in general which checked too early if the given username was claimed by an AS; it was checked before knowing if the AS was the one doing the registration! Add unit tests for AS reg, user reg and disabled_registration flag.
132 lines
4.5 KiB
Python
132 lines
4.5 KiB
Python
from synapse.rest.client.v2_alpha.register import RegisterRestServlet
|
|
from synapse.api.errors import SynapseError
|
|
from twisted.internet import defer
|
|
from mock import Mock, MagicMock
|
|
from tests import unittest
|
|
import json
|
|
|
|
|
|
class RegisterRestServletTestCase(unittest.TestCase):
|
|
|
|
def setUp(self):
|
|
# do the dance to hook up request data to self.request_data
|
|
self.request_data = ""
|
|
self.request = Mock(
|
|
content=Mock(read=Mock(side_effect=lambda: self.request_data)),
|
|
)
|
|
self.request.args = {}
|
|
|
|
self.appservice = None
|
|
self.auth = Mock(get_appservice_by_req=Mock(
|
|
side_effect=lambda x: defer.succeed(self.appservice))
|
|
)
|
|
|
|
self.auth_result = (False, None, None)
|
|
self.auth_handler = Mock(
|
|
check_auth=Mock(side_effect=lambda x,y,z: self.auth_result)
|
|
)
|
|
self.registration_handler = Mock()
|
|
self.identity_handler = Mock()
|
|
self.login_handler = Mock()
|
|
|
|
# do the dance to hook it up to the hs global
|
|
self.handlers = Mock(
|
|
auth_handler=self.auth_handler,
|
|
registration_handler=self.registration_handler,
|
|
identity_handler=self.identity_handler,
|
|
login_handler=self.login_handler
|
|
)
|
|
self.hs = Mock()
|
|
self.hs.hostname = "superbig~testing~thing.com"
|
|
self.hs.get_auth = Mock(return_value=self.auth)
|
|
self.hs.get_handlers = Mock(return_value=self.handlers)
|
|
self.hs.config.disable_registration = False
|
|
|
|
# init the thing we're testing
|
|
self.servlet = RegisterRestServlet(self.hs)
|
|
|
|
@defer.inlineCallbacks
|
|
def test_POST_appservice_registration_valid(self):
|
|
user_id = "@kermit:muppet"
|
|
token = "kermits_access_token"
|
|
self.request.args = {
|
|
"access_token": "i_am_an_app_service"
|
|
}
|
|
self.request_data = json.dumps({
|
|
"username": "kermit"
|
|
})
|
|
self.appservice = {
|
|
"id": "1234"
|
|
}
|
|
self.registration_handler.register = Mock(return_value=(user_id, token))
|
|
result = yield self.servlet.on_POST(self.request)
|
|
self.assertEquals(result, (200, {
|
|
"user_id": user_id,
|
|
"access_token": token,
|
|
"home_server": self.hs.hostname
|
|
}))
|
|
|
|
@defer.inlineCallbacks
|
|
def test_POST_appservice_registration_invalid(self):
|
|
self.request.args = {
|
|
"access_token": "i_am_an_app_service"
|
|
}
|
|
self.request_data = json.dumps({
|
|
"username": "kermit"
|
|
})
|
|
self.appservice = None # no application service exists
|
|
result = yield self.servlet.on_POST(self.request)
|
|
self.assertEquals(result, (401, None))
|
|
|
|
def test_POST_bad_password(self):
|
|
self.request_data = json.dumps({
|
|
"username": "kermit",
|
|
"password": 666
|
|
})
|
|
d = self.servlet.on_POST(self.request)
|
|
return self.assertFailure(d, SynapseError)
|
|
|
|
def test_POST_bad_username(self):
|
|
self.request_data = json.dumps({
|
|
"username": 777,
|
|
"password": "monkey"
|
|
})
|
|
d = self.servlet.on_POST(self.request)
|
|
return self.assertFailure(d, SynapseError)
|
|
|
|
@defer.inlineCallbacks
|
|
def test_POST_user_valid(self):
|
|
user_id = "@kermit:muppet"
|
|
token = "kermits_access_token"
|
|
self.request_data = json.dumps({
|
|
"username": "kermit",
|
|
"password": "monkey"
|
|
})
|
|
self.registration_handler.check_username = Mock(return_value=True)
|
|
self.auth_result = (True, None, {
|
|
"username": "kermit",
|
|
"password": "monkey"
|
|
})
|
|
self.registration_handler.register = Mock(return_value=(user_id, token))
|
|
|
|
result = yield self.servlet.on_POST(self.request)
|
|
self.assertEquals(result, (200, {
|
|
"user_id": user_id,
|
|
"access_token": token,
|
|
"home_server": self.hs.hostname
|
|
}))
|
|
|
|
def test_POST_disabled_registration(self):
|
|
self.hs.config.disable_registration = True
|
|
self.request_data = json.dumps({
|
|
"username": "kermit",
|
|
"password": "monkey"
|
|
})
|
|
self.registration_handler.check_username = Mock(return_value=True)
|
|
self.auth_result = (True, None, {
|
|
"username": "kermit",
|
|
"password": "monkey"
|
|
})
|
|
self.registration_handler.register = Mock(return_value=("@user:id", "t"))
|
|
d = self.servlet.on_POST(self.request)
|
|
return self.assertFailure(d, SynapseError) |