mirror of
https://mau.dev/maunium/synapse.git
synced 2024-10-01 01:36:05 -04:00
8bcfc2eaad
This PR attempts to eliminate unnecessary presence sending work when your local server joins a room, or when a remote server joins a room your server is participating in by processing state deltas in chunks rather than individually.
---
When your server joins a room for the first time, it requests the historical state as well. This chunk of new state is passed to the presence handler which, after filtering that state down to only membership joins, will send presence updates to homeservers for each join processed.
It turns out that we were being a bit naive and processing each event individually, and sending out presence updates for every one of those joins. Even if many different joins were users on the same server (hello IRC bridges), we'd send presence to that same homeserver for every remote user join we saw.
This PR attempts to deduplicate all of that by processing the entire batch of state deltas at once, instead of only doing each join individually. We process the joins and note down which servers need which presence:
* If it was a local user join, send that user's latest presence to all servers in the room
* If it was a remote user join, send the presence for all local users in the room to that homeserver
We deduplicate by inserting all of those pending updates into a dictionary of the form:
```
{
server_name1: {presence_update1, ...},
server_name2: {presence_update1, presence_update2, ...}
}
```
Only after building this dict do we then start sending out presence updates.
|
||
|---|---|---|
| .. | ||
| api | ||
| app | ||
| appservice | ||
| config | ||
| crypto | ||
| events | ||
| federation | ||
| handlers | ||
| http | ||
| logging | ||
| module_api | ||
| push | ||
| replication | ||
| rest | ||
| scripts | ||
| server_notices | ||
| state | ||
| storage | ||
| test_utils | ||
| util | ||
| __init__.py | ||
| server.py | ||
| test_distributor.py | ||
| test_event_auth.py | ||
| test_federation.py | ||
| test_mau.py | ||
| test_metrics.py | ||
| test_phone_home.py | ||
| test_preview.py | ||
| test_server.py | ||
| test_state.py | ||
| test_terms_auth.py | ||
| test_test_utils.py | ||
| test_types.py | ||
| test_visibility.py | ||
| unittest.py | ||
| utils.py | ||