forked-synapse/tests
Richard van der Hoff 85551b7a85
Factor out common code for persisting fetched auth events (#10896)
* Factor more stuff out of `_get_events_and_persist`

It turns out that the event-sorting algorithm in `_get_events_and_persist` is
also useful in other circumstances. Here we move the current
`_auth_and_persist_fetched_events` to `_auth_and_persist_fetched_events_inner`,
and then factor the sorting part out to `_auth_and_persist_fetched_events`.

* `_get_remote_auth_chain_for_event`: remove redundant `outlier` assignment

`get_event_auth` returns events with the outlier flag already set, so this is
redundant (though we need to update a test where `get_event_auth` is mocked).

* `_get_remote_auth_chain_for_event`: move existing-event tests earlier

Move a couple of tests outside the loop. This is a bit inefficient for now, but
a future commit will make it better. It should be functionally identical.

* `_get_remote_auth_chain_for_event`: use `_auth_and_persist_fetched_events`

We can use the same codepath for persisting the events fetched as part of an
auth chain as for those fetched individually by `_get_events_and_persist` for
building the state at a backwards extremity.

* `_get_remote_auth_chain_for_event`: use a dict for efficiency

`_auth_and_persist_fetched_events` sorts the events itself, so we no longer
need to care about maintaining the ordering from `get_event_auth` (and no
longer need to sort by depth in `get_event_auth`).

That means that we can use a map, making it easier to filter out events we
already have, etc.

* changelog

* `_auth_and_persist_fetched_events`: improve docstring
2021-09-24 11:56:33 +01:00
..
api Fix AuthBlocking check when requester is appservice (#10881) 2021-09-24 10:41:18 +01:00
app Use direct references for configuration variables (part 4). (#10893) 2021-09-23 12:03:01 -04:00
appservice Remove redundant "coding: utf-8" lines (#9786) 2021-04-14 15:34:27 +01:00
config Use direct references for configuration variables (part 4). (#10893) 2021-09-23 12:03:01 -04:00
crypto Rewrite the KeyRing (#10035) 2021-06-02 16:37:59 +01:00
events Support MSC3375: room version 9. (#10747) 2021-09-03 12:51:15 -04:00
federation Split FederationHandler in half (#10692) 2021-08-26 21:41:44 +01:00
handlers Factor out common code for persisting fetched auth events (#10896) 2021-09-24 11:56:33 +01:00
http Add reactor to SynapseRequest and fix up types. (#10868) 2021-09-24 11:01:25 +01:00
logging Add reactor to SynapseRequest and fix up types. (#10868) 2021-09-24 11:01:25 +01:00
module_api Extend ModuleApi with the methods we'll need to reject spam based on …IP - resolves #10832 (#10833) 2021-09-22 13:09:43 +00:00
push Synapse 1.42.0rc1 (2021-09-01) 2021-09-01 14:58:14 +01:00
replication Add reactor to SynapseRequest and fix up types. (#10868) 2021-09-24 11:01:25 +01:00
rest Add reactor to SynapseRequest and fix up types. (#10868) 2021-09-24 11:01:25 +01:00
scripts Remove redundant "coding: utf-8" lines (#9786) 2021-04-14 15:34:27 +01:00
server_notices Flatten the synapse.rest.client package (#10600) 2021-08-17 11:57:58 +00:00
state Update the MSC3083 support to verify if joins are from an authorized server. (#10254) 2021-07-26 12:17:00 -04:00
storage Use direct references for configuration variables (part 4). (#10893) 2021-09-23 12:03:01 -04:00
test_utils Create a constant for a small png image in tests. (#10834) 2021-09-16 12:01:14 -04:00
util Use direct references for configuration variables (part 4). (#10893) 2021-09-23 12:03:01 -04:00
__init__.py Remove redundant "coding: utf-8" lines (#9786) 2021-04-14 15:34:27 +01:00
server.py Add reactor to SynapseRequest and fix up types. (#10868) 2021-09-24 11:01:25 +01:00
test_distributor.py Remove redundant "coding: utf-8" lines (#9786) 2021-04-14 15:34:27 +01:00
test_event_auth.py Support MSC3289: Room version 8 (#10449) 2021-08-09 10:46:39 +02:00
test_federation.py Get rid of _auth_and_persist_event (#10781) 2021-09-08 19:03:08 +01:00
test_mau.py Flatten the synapse.rest.client package (#10600) 2021-08-17 11:57:58 +00:00
test_metrics.py Remove redundant "coding: utf-8" lines (#9786) 2021-04-14 15:34:27 +01:00
test_phone_home.py Remove redundant "coding: utf-8" lines (#9786) 2021-04-14 15:34:27 +01:00
test_preview.py Support underscores (in addition to hyphens) for charset detection. (#10410) 2021-07-27 17:29:42 +00:00
test_server.py Add reactor to SynapseRequest and fix up types. (#10868) 2021-09-24 11:01:25 +01:00
test_state.py Remove unnecessary parentheses around tuples returned from methods (#10889) 2021-09-23 11:59:07 +01:00
test_terms_auth.py Flatten the synapse.rest.client package (#10600) 2021-08-17 11:57:58 +00:00
test_test_utils.py Remove redundant "coding: utf-8" lines (#9786) 2021-04-14 15:34:27 +01:00
test_types.py [pyupgrade] tests/ (#10347) 2021-07-13 11:43:15 +01:00
test_visibility.py Remove redundant "coding: utf-8" lines (#9786) 2021-04-14 15:34:27 +01:00
unittest.py Add types to synapse.util. (#10601) 2021-09-10 17:03:18 +01:00
utils.py Remove unnecessary parentheses around tuples returned from methods (#10889) 2021-09-23 11:59:07 +01:00