forked-synapse/changelog.d
Andrew Morgan 7b06f85c0e
Ensure we use a copy of the event content dict before modifying it in serialize_event (#9585)
This bug was discovered by DINUM. We were modifying `serialized_event["content"]`, which - if you've got `USE_FROZEN_DICTS` turned on or are [using a third party rules module](17cd48fe51/synapse/events/third_party_rules.py (L73-L76)) - will raise a 500 if you try to a edit a reply to a message.

`serialized_event["content"]` could be set to the edit event's content, instead of a copy of it, which is bad as we attempt to modify it. Instead, we also end up modifying the original event's content. DINUM uses a third party rules module, which meant the event's content got frozen and thus an exception was raised.

To be clear, the problem is not that the event's content was frozen. In fact doing so helped us uncover the fact we weren't copying event content correctly.
2021-03-17 16:51:55 +00:00
..
.gitignore Correct attrs package name in requirements (#3492) 2018-07-07 10:46:59 +10:00
9411.misc Prep work for removing outlier from internal_metadata (#9411) 2021-03-17 12:33:18 +00:00
9499.misc Enable flake8-bugbear, but disable most checks. (#9499) 2021-03-16 14:19:27 -04:00
9585.bugfix Ensure we use a copy of the event content dict before modifying it in serialize_event (#9585) 2021-03-17 16:51:55 +00:00
9588.bugfix Return m.change_password.enabled=false if local database is disabled (#9588) 2021-03-16 11:44:25 -04:00
9609.feature Add SSO attribute requirements for OIDC providers (#9609) 2021-03-16 11:46:07 -04:00
9631.misc Add type hints to the room member handler. (#9631) 2021-03-17 07:14:39 -04:00
9634.misc only save remote cross-signing keys if they're different from the current ones (#9634) 2021-03-17 11:04:57 -04:00
9637.misc Fix bad naming of storage function (#9637) 2021-03-17 13:20:08 +00:00
9638.misc Fix up types for the typing handler. (#9638) 2021-03-17 11:30:21 -04:00