mirror of
https://mau.dev/maunium/synapse.git
synced 2024-10-01 01:36:05 -04:00
a4c3a361b7
* Rate-limiting for registration * Add unit test for registration rate limiting * Add config parameters for rate limiting on auth endpoints * Doc * Fix doc of rate limiting function Co-Authored-By: babolivier <contact@brendanabolivier.com> * Incorporate review * Fix config parsing * Fix linting errors * Set default config for auth rate limiting * Fix tests * Add changelog * Advance reactor instead of mocked clock * Move parameters to registration specific config and give them more sensible default values * Remove unused config options * Don't mock the rate limiter un MAU tests * Rename _register_with_store into register_with_store * Make CI happy * Remove unused import * Update sample config * Fix ratelimiting test for py2 * Add non-guest test
222 lines
7.3 KiB
Python
222 lines
7.3 KiB
Python
# -*- coding: utf-8 -*-
|
|
# Copyright 2018 New Vector Ltd
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
"""Tests REST events for /rooms paths."""
|
|
|
|
import json
|
|
|
|
from mock import Mock
|
|
|
|
from synapse.api.constants import LoginType
|
|
from synapse.api.errors import Codes, HttpResponseException, SynapseError
|
|
from synapse.rest.client.v2_alpha import register, sync
|
|
|
|
from tests import unittest
|
|
|
|
|
|
class TestMauLimit(unittest.HomeserverTestCase):
|
|
|
|
servlets = [register.register_servlets, sync.register_servlets]
|
|
|
|
def make_homeserver(self, reactor, clock):
|
|
|
|
self.hs = self.setup_test_homeserver(
|
|
"red",
|
|
http_client=None,
|
|
federation_client=Mock(),
|
|
)
|
|
|
|
self.store = self.hs.get_datastore()
|
|
|
|
self.hs.config.registrations_require_3pid = []
|
|
self.hs.config.enable_registration_captcha = False
|
|
self.hs.config.recaptcha_public_key = []
|
|
|
|
self.hs.config.limit_usage_by_mau = True
|
|
self.hs.config.hs_disabled = False
|
|
self.hs.config.max_mau_value = 2
|
|
self.hs.config.mau_trial_days = 0
|
|
self.hs.config.server_notices_mxid = "@server:red"
|
|
self.hs.config.server_notices_mxid_display_name = None
|
|
self.hs.config.server_notices_mxid_avatar_url = None
|
|
self.hs.config.server_notices_room_name = "Test Server Notice Room"
|
|
return self.hs
|
|
|
|
def test_simple_deny_mau(self):
|
|
# Create and sync so that the MAU counts get updated
|
|
token1 = self.create_user("kermit1")
|
|
self.do_sync_for_user(token1)
|
|
token2 = self.create_user("kermit2")
|
|
self.do_sync_for_user(token2)
|
|
|
|
# We've created and activated two users, we shouldn't be able to
|
|
# register new users
|
|
with self.assertRaises(SynapseError) as cm:
|
|
self.create_user("kermit3")
|
|
|
|
e = cm.exception
|
|
self.assertEqual(e.code, 403)
|
|
self.assertEqual(e.errcode, Codes.RESOURCE_LIMIT_EXCEEDED)
|
|
|
|
def test_allowed_after_a_month_mau(self):
|
|
# Create and sync so that the MAU counts get updated
|
|
token1 = self.create_user("kermit1")
|
|
self.do_sync_for_user(token1)
|
|
token2 = self.create_user("kermit2")
|
|
self.do_sync_for_user(token2)
|
|
|
|
# Advance time by 31 days
|
|
self.reactor.advance(31 * 24 * 60 * 60)
|
|
|
|
self.store.reap_monthly_active_users()
|
|
|
|
self.reactor.advance(0)
|
|
|
|
# We should be able to register more users
|
|
token3 = self.create_user("kermit3")
|
|
self.do_sync_for_user(token3)
|
|
|
|
def test_trial_delay(self):
|
|
self.hs.config.mau_trial_days = 1
|
|
|
|
# We should be able to register more than the limit initially
|
|
token1 = self.create_user("kermit1")
|
|
self.do_sync_for_user(token1)
|
|
token2 = self.create_user("kermit2")
|
|
self.do_sync_for_user(token2)
|
|
token3 = self.create_user("kermit3")
|
|
self.do_sync_for_user(token3)
|
|
|
|
# Advance time by 2 days
|
|
self.reactor.advance(2 * 24 * 60 * 60)
|
|
|
|
# Two users should be able to sync
|
|
self.do_sync_for_user(token1)
|
|
self.do_sync_for_user(token2)
|
|
|
|
# But the third should fail
|
|
with self.assertRaises(SynapseError) as cm:
|
|
self.do_sync_for_user(token3)
|
|
|
|
e = cm.exception
|
|
self.assertEqual(e.code, 403)
|
|
self.assertEqual(e.errcode, Codes.RESOURCE_LIMIT_EXCEEDED)
|
|
|
|
# And new registrations are now denied too
|
|
with self.assertRaises(SynapseError) as cm:
|
|
self.create_user("kermit4")
|
|
|
|
e = cm.exception
|
|
self.assertEqual(e.code, 403)
|
|
self.assertEqual(e.errcode, Codes.RESOURCE_LIMIT_EXCEEDED)
|
|
|
|
def test_trial_users_cant_come_back(self):
|
|
self.hs.config.mau_trial_days = 1
|
|
|
|
# We should be able to register more than the limit initially
|
|
token1 = self.create_user("kermit1")
|
|
self.do_sync_for_user(token1)
|
|
token2 = self.create_user("kermit2")
|
|
self.do_sync_for_user(token2)
|
|
token3 = self.create_user("kermit3")
|
|
self.do_sync_for_user(token3)
|
|
|
|
# Advance time by 2 days
|
|
self.reactor.advance(2 * 24 * 60 * 60)
|
|
|
|
# Two users should be able to sync
|
|
self.do_sync_for_user(token1)
|
|
self.do_sync_for_user(token2)
|
|
|
|
# Advance by 2 months so everyone falls out of MAU
|
|
self.reactor.advance(60 * 24 * 60 * 60)
|
|
self.store.reap_monthly_active_users()
|
|
self.reactor.advance(0)
|
|
|
|
# We can create as many new users as we want
|
|
token4 = self.create_user("kermit4")
|
|
self.do_sync_for_user(token4)
|
|
token5 = self.create_user("kermit5")
|
|
self.do_sync_for_user(token5)
|
|
token6 = self.create_user("kermit6")
|
|
self.do_sync_for_user(token6)
|
|
|
|
# users 2 and 3 can come back to bring us back up to MAU limit
|
|
self.do_sync_for_user(token2)
|
|
self.do_sync_for_user(token3)
|
|
|
|
# New trial users can still sync
|
|
self.do_sync_for_user(token4)
|
|
self.do_sync_for_user(token5)
|
|
self.do_sync_for_user(token6)
|
|
|
|
# But old user cant
|
|
with self.assertRaises(SynapseError) as cm:
|
|
self.do_sync_for_user(token1)
|
|
|
|
e = cm.exception
|
|
self.assertEqual(e.code, 403)
|
|
self.assertEqual(e.errcode, Codes.RESOURCE_LIMIT_EXCEEDED)
|
|
|
|
def test_tracked_but_not_limited(self):
|
|
self.hs.config.max_mau_value = 1 # should not matter
|
|
self.hs.config.limit_usage_by_mau = False
|
|
self.hs.config.mau_stats_only = True
|
|
|
|
# Simply being able to create 2 users indicates that the
|
|
# limit was not reached.
|
|
token1 = self.create_user("kermit1")
|
|
self.do_sync_for_user(token1)
|
|
token2 = self.create_user("kermit2")
|
|
self.do_sync_for_user(token2)
|
|
|
|
# We do want to verify that the number of tracked users
|
|
# matches what we want though
|
|
count = self.store.get_monthly_active_count()
|
|
self.reactor.advance(100)
|
|
self.assertEqual(2, self.successResultOf(count))
|
|
|
|
def create_user(self, localpart):
|
|
request_data = json.dumps(
|
|
{
|
|
"username": localpart,
|
|
"password": "monkey",
|
|
"auth": {"type": LoginType.DUMMY},
|
|
}
|
|
)
|
|
|
|
request, channel = self.make_request("POST", "/register", request_data)
|
|
self.render(request)
|
|
|
|
if channel.code != 200:
|
|
raise HttpResponseException(
|
|
channel.code, channel.result["reason"], channel.result["body"]
|
|
).to_synapse_error()
|
|
|
|
access_token = channel.json_body["access_token"]
|
|
|
|
return access_token
|
|
|
|
def do_sync_for_user(self, token):
|
|
request, channel = self.make_request(
|
|
"GET", "/sync", access_token=token
|
|
)
|
|
self.render(request)
|
|
|
|
if channel.code != 200:
|
|
raise HttpResponseException(
|
|
channel.code, channel.result["reason"], channel.result["body"]
|
|
).to_synapse_error()
|