forked-synapse/tests
David Robertson ffc2ee521d
Use mypy 1.0 (#15052)
* Update mypy and mypy-zope
* Remove unused ignores

These used to suppress

```
synapse/storage/engines/__init__.py:28: error: "__new__" must return a
class instance (got "NoReturn")  [misc]
```

and

```
synapse/http/matrixfederationclient.py:1270: error: "BaseException" has no attribute "reasons"  [attr-defined]
```

(note that we check `hasattr(e, "reasons")` above)

* Avoid empty body warnings, sometimes by marking methods as abstract

E.g.

```
tests/handlers/test_register.py:58: error: Missing return statement  [empty-body]
tests/handlers/test_register.py:108: error: Missing return statement  [empty-body]
```

* Suppress false positive about `JaegerConfig`

Complaint was

```
synapse/logging/opentracing.py:450: error: Function "Type[Config]" could always be true in boolean context  [truthy-function]
```

* Fix not calling `is_state()`

Oops!

```
tests/rest/client/test_third_party_rules.py:428: error: Function "Callable[[], bool]" could always be true in boolean context  [truthy-function]
```

* Suppress false positives from ParamSpecs

````
synapse/logging/opentracing.py:971: error: Argument 2 to "_custom_sync_async_decorator" has incompatible type "Callable[[Arg(Callable[P, R], 'func'), **P], _GeneratorContextManager[None]]"; expected "Callable[[Callable[P, R], **P], _GeneratorContextManager[None]]"  [arg-type]
synapse/logging/opentracing.py:1017: error: Argument 2 to "_custom_sync_async_decorator" has incompatible type "Callable[[Arg(Callable[P, R], 'func'), **P], _GeneratorContextManager[None]]"; expected "Callable[[Callable[P, R], **P], _GeneratorContextManager[None]]"  [arg-type]
````

* Drive-by improvement to `wrapping_logic` annotation

* Workaround false "unreachable" positives

See https://github.com/Shoobx/mypy-zope/issues/91

```
tests/http/test_proxyagent.py:626: error: Statement is unreachable  [unreachable]
tests/http/test_proxyagent.py:762: error: Statement is unreachable  [unreachable]
tests/http/test_proxyagent.py:826: error: Statement is unreachable  [unreachable]
tests/http/test_proxyagent.py:838: error: Statement is unreachable  [unreachable]
tests/http/test_proxyagent.py:845: error: Statement is unreachable  [unreachable]
tests/http/federation/test_matrix_federation_agent.py:151: error: Statement is unreachable  [unreachable]
tests/http/federation/test_matrix_federation_agent.py:452: error: Statement is unreachable  [unreachable]
tests/logging/test_remote_handler.py:60: error: Statement is unreachable  [unreachable]
tests/logging/test_remote_handler.py:93: error: Statement is unreachable  [unreachable]
tests/logging/test_remote_handler.py:127: error: Statement is unreachable  [unreachable]
tests/logging/test_remote_handler.py:152: error: Statement is unreachable  [unreachable]
```

* Changelog

* Tweak DBAPI2 Protocol to be accepted by mypy 1.0

Some extra context in:
- https://github.com/matrix-org/python-canonicaljson/pull/57
- https://github.com/python/mypy/issues/6002
- https://mypy.readthedocs.io/en/latest/common_issues.html#covariant-subtyping-of-mutable-protocol-members-is-rejected

* Pull in updated canonicaljson lib

so the protocol check just works

* Improve comments in opentracing

I tried to workaround the ignores but found it too much trouble.

I think the corresponding issue is
https://github.com/python/mypy/issues/12909. The mypy repo has a PR
claiming to fix this (https://github.com/python/mypy/pull/14677) which
might mean this gets resolved soon?

* Better annotation for INTERACTIVE_AUTH_CHECKERS

* Drive-by AUTH_TYPE annotation, to remove an ignore
2023-02-16 16:09:11 +00:00
..
api Properly typecheck tests.api (#14983) 2023-02-03 20:03:23 +00:00
app Add final type hint to tests.unittest. (#15072) 2023-02-14 14:03:35 -05:00
appservice Type hints for tests.appservice (#14990) 2023-02-06 12:49:06 +00:00
config Add missing type hints to tests.config. (#14681) 2022-12-16 08:53:28 -05:00
crypto Add final type hint to tests.unittest. (#15072) 2023-02-14 14:03:35 -05:00
events Add final type hint to tests.unittest. (#15072) 2023-02-14 14:03:35 -05:00
federation Add final type hint to tests.unittest. (#15072) 2023-02-14 14:03:35 -05:00
handlers Use mypy 1.0 (#15052) 2023-02-16 16:09:11 +00:00
http Use mypy 1.0 (#15052) 2023-02-16 16:09:11 +00:00
logging Use mypy 1.0 (#15052) 2023-02-16 16:09:11 +00:00
metrics Add missing type hints to tests. (#14687) 2022-12-28 08:29:35 -05:00
module_api Add final type hint to tests.unittest. (#15072) 2023-02-14 14:03:35 -05:00
push Update intentional mentions (MSC3952) to depend on exact_event_match (MSC3758). (#15037) 2023-02-16 09:51:22 -05:00
replication Add final type hint to tests.unittest. (#15072) 2023-02-14 14:03:35 -05:00
rest Use mypy 1.0 (#15052) 2023-02-16 16:09:11 +00:00
scripts Add more missing type hints to tests. (#15028) 2023-02-08 16:29:49 -05:00
server_notices Add final type hint to tests.unittest. (#15072) 2023-02-14 14:03:35 -05:00
state Fix typechecks against twisted trunk (#13061) 2022-06-15 11:49:58 +01:00
storage Add final type hint to tests.unittest. (#15072) 2023-02-14 14:03:35 -05:00
test_utils Add a class UnpersistedEventContext to allow for the batching up of storing state groups (#14675) 2023-02-09 13:05:02 -08:00
types Allow selecting "prejoin" events by state keys (#14642) 2022-12-13 00:54:46 +00:00
util Add final type hint to tests.unittest. (#15072) 2023-02-14 14:03:35 -05:00
__init__.py Remove redundant "coding: utf-8" lines (#9786) 2021-04-14 15:34:27 +01:00
server.py Properly typecheck types.http (#14988) 2023-02-07 00:20:04 +00:00
test_distributor.py Add missing type hints to tests. (#15027) 2023-02-08 19:52:37 +00:00
test_event_auth.py Add missing type hints to tests. (#15027) 2023-02-08 19:52:37 +00:00
test_federation.py Add final type hint to tests.unittest. (#15072) 2023-02-14 14:03:35 -05:00
test_mau.py Add missing type hints to tests. (#15027) 2023-02-08 19:52:37 +00:00
test_phone_home.py Add final type hint to tests.unittest. (#15072) 2023-02-14 14:03:35 -05:00
test_rust.py Add missing type hints to tests. (#15027) 2023-02-08 19:52:37 +00:00
test_server.py Respond with proper error responses on unknown paths. (#14621) 2022-12-08 11:37:05 -05:00
test_state.py Add missing types to test_state. (#14985) 2023-02-06 16:11:09 +00:00
test_terms_auth.py Proper types for tests.test_terms_auth (#15007) 2023-02-07 12:03:39 +00:00
test_test_utils.py Add missing type hints to tests. (#15027) 2023-02-08 19:52:37 +00:00
test_types.py Add missing type hints to tests. (#15027) 2023-02-08 19:52:37 +00:00
test_visibility.py Add final type hint to tests.unittest. (#15072) 2023-02-14 14:03:35 -05:00
unittest.py Add final type hint to tests.unittest. (#15072) 2023-02-14 14:03:35 -05:00
utils.py Use mypy 1.0 (#15052) 2023-02-16 16:09:11 +00:00