mirror of
https://mau.dev/maunium/synapse.git
synced 2024-07-15 23:51:58 +00:00
40bb37eb27
While https://github.com/matrix-org/synapse/pull/13635 stops us from doing the slow thing after we've already done it once, this PR stops us from doing one of the slow things in the first place. Related to - https://github.com/matrix-org/synapse/issues/13622 - https://github.com/matrix-org/synapse/pull/13635 - https://github.com/matrix-org/synapse/issues/13676 Part of https://github.com/matrix-org/synapse/issues/13356 Follow-up to https://github.com/matrix-org/synapse/pull/13815 which tracks event signature failures. With this PR, we avoid the call to the costly `_get_state_ids_after_missing_prev_event` because the signature failure will count as an attempt before and we filter events based on the backoff before calling `_get_state_ids_after_missing_prev_event` now. For example, this will save us 156s out of the 185s total that this `matrix.org` `/messages` request. If you want to see the full Jaeger trace of this, you can drag and drop this `trace.json` into your own Jaeger, https://gist.github.com/MadLittleMods/4b12d0d0afe88c2f65ffcc907306b761 To explain this exact scenario around `/messages` -> backfill, we call `/backfill` and first check the signatures of the 100 events. We see bad signature for `$luA4l7QHhf_jadH3mI-AyFqho0U2Q-IXXUbGSMq6h6M` and `$zuOn2Rd2vsC7SUia3Hp3r6JSkSFKcc5j3QTTqW_0jDw` (both member events). Then we process the 98 events remaining that have valid signatures but one of the events references `$luA4l7QHhf_jadH3mI-AyFqho0U2Q-IXXUbGSMq6h6M` as a `prev_event`. So we have to do the whole `_get_state_ids_after_missing_prev_event` rigmarole which pulls in those same events which fail again because the signatures are still invalid. - `backfill` - `outgoing-federation-request` `/backfill` - `_check_sigs_and_hash_and_fetch` - `_check_sigs_and_hash_and_fetch_one` for each event received over backfill - ❗ `$luA4l7QHhf_jadH3mI-AyFqho0U2Q-IXXUbGSMq6h6M` fails with `Signature on retrieved event was invalid.`: `unable to verify signature for sender domain xxx: 401: Failed to find any key to satisfy: _FetchKeyRequest(...)` - ❗ `$zuOn2Rd2vsC7SUia3Hp3r6JSkSFKcc5j3QTTqW_0jDw` fails with `Signature on retrieved event was invalid.`: `unable to verify signature for sender domain xxx: 401: Failed to find any key to satisfy: _FetchKeyRequest(...)` - `_process_pulled_events` - `_process_pulled_event` for each validated event - ❗ Event `$Q0iMdqtz3IJYfZQU2Xk2WjB5NDF8Gg8cFSYYyKQgKJ0` references `$luA4l7QHhf_jadH3mI-AyFqho0U2Q-IXXUbGSMq6h6M` as a `prev_event` which is missing so we try to get it - `_get_state_ids_after_missing_prev_event` - `outgoing-federation-request` `/state_ids` - ❗ `get_pdu` for `$luA4l7QHhf_jadH3mI-AyFqho0U2Q-IXXUbGSMq6h6M` which fails the signature check again - ❗ `get_pdu` for `$zuOn2Rd2vsC7SUia3Hp3r6JSkSFKcc5j3QTTqW_0jDw` which fails the signature check |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| 13394.feature | ||
| 13776.feature | ||
| 13813.bugfix | ||
| 13816.feature | ||
| 13824.feature | ||
| 13877.feature | ||
| 13878.feature | ||
| 13955.docker | ||
| 13983.misc | ||
| 13984.misc | ||
| 13985.misc | ||
| 13986.misc | ||
| 13987.misc | ||
| 13988.misc | ||
| 13991.misc | ||
| 13996.feature | ||
| 13997.feature | ||
| 14006.misc | ||
| 14007.misc | ||
| 14028.feature | ||
| 14032.feature | ||
| 14033.misc | ||
| 14034.bugfix | ||
| 14040.misc | ||
| 14041.misc | ||
| 14043.misc | ||
| 14044.misc | ||
| 14046.misc | ||
| 14050.feature | ||
| 14053.bugfix | ||
| 14054.feature | ||
| 14063.misc | ||
| 14065.misc | ||
| 14072.misc | ||
| 14077.doc | ||
| 14078.doc | ||
| 14081.doc | ||
| 14083.bugfix | ||
| 14087.doc | ||
| 14089.bugfix | ||
| 14092.misc | ||
| 14093.doc | ||
| 14094.removal | ||
| 14097.misc | ||
| 14102.bugfix | ||
| 14106.removal | ||
| 14109.misc | ||
| 14113.misc | ||
| 14114.misc | ||
| 14115.misc | ||
| 14116.misc | ||
| 14124.doc | ||
| 14125.bugfix | ||
| 14132.misc | ||
| 14134.misc | ||
| 14140.feature | ||
| 14141.docker | ||
| 14141.misc | ||
| 14142.misc | ||
| 14144.misc | ||
| 14146.removal | ||
| 14159.feature | ||
| 14163.feature | ||
| 14165.docker | ||
| 14171.feature | ||
| 14174.feature | ||
| 14175.feature | ||
| 14182.docker | ||
| 14184.feature | ||
| 14187.misc | ||
| 14188.misc | ||