mirror of
https://mau.dev/maunium/synapse.git
synced 2024-08-23 10:45:48 +00:00
![Eric Eastwood](/assets/img/avatar_default.png)
Resolve and share `state_groups` for all historical events in batch. This also helps for showing the appropriate avatar/displayname in Element and will work whenever `/messages` has one of the historical messages as the first message in the batch. This does have the flaw where if you just insert a single historical event somewhere, it probably won't resolve the state correctly from `/messages` or `/context` since it will grab a non historical event above or below with resolved state which never included the historical state back then. For the same reasions, this also does not work in Element between the transition from actual messages to historical messages. In the Gitter case, this isn't really a problem since all of the historical messages are in one big lump at the beginning of the room. For a future iteration, might be good to look at `/messages` and `/context` to additionally add the `state` for any historical messages in that batch. --- How are the `state_groups` shared? To illustrate the `state_group` sharing, see this example: **Before** (new `state_group` for every event 😬, very inefficient): ``` # Tests from https://github.com/matrix-org/complement/pull/206 $ COMPLEMENT_ALWAYS_PRINT_SERVER_LOGS=1 COMPLEMENT_DIR=../complement ./scripts-dev/complement.sh TestBackfillingHistory/parallel/should_resolve_member_state_events_for_historical_events create_new_client_event m.room.member event=$_JXfwUDIWS6xKGG4SmZXjSFrizhARM7QblhATVWWUcA state_group=None create_new_client_event org.matrix.msc2716.insertion event=$1ZBfmBKEjg94d-vGYymKrVYeghwBOuGJ3wubU1-I9y0 state_group=9 create_new_client_event org.matrix.msc2716.insertion event=$Mq2JvRetTyclPuozRI682SAjYp3GqRuPc8_cH5-ezPY state_group=10 create_new_client_event m.room.message event=$MfmY4rBQkxrIp8jVwVMTJ4PKnxSigpG9E2cn7S0AtTo state_group=11 create_new_client_event m.room.message event=$uYOv6V8wiF7xHwOMt-60d1AoOIbqLgrDLz6ZIQDdWUI state_group=12 create_new_client_event m.room.message event=$PAbkJRMxb0bX4A6av463faiAhxkE3FEObM1xB4D0UG4 state_group=13 create_new_client_event org.matrix.msc2716.batch event=$Oy_S7AWN7rJQe_MYwGPEy6RtbYklrI-tAhmfiLrCaKI state_group=14 ``` **After** (all events in batch sharing `state_group=10`) (the base insertion event has `state_group=8` which matches the `prev_event` we're inserting next to): ``` # Tests from https://github.com/matrix-org/complement/pull/206 $ COMPLEMENT_ALWAYS_PRINT_SERVER_LOGS=1 COMPLEMENT_DIR=../complement ./scripts-dev/complement.sh TestBackfillingHistory/parallel/should_resolve_member_state_events_for_historical_events create_new_client_event m.room.member event=$PWomJ8PwENYEYuVNoG30gqtybuQQSZ55eldBUSs0i0U state_group=None create_new_client_event org.matrix.msc2716.insertion event=$e_mCU7Eah9ABF6nQU7lu4E1RxIWccNF05AKaTT5m3lw state_group=9 create_new_client_event org.matrix.msc2716.insertion event=$ui7A3_GdXIcJq0C8GpyrF8X7B3DTjMd_WGCjogax7xU state_group=10 create_new_client_event m.room.message event=$EnTIM5rEGVezQJiYl62uFBl6kJ7B-sMxWqe2D_4FX1I state_group=10 create_new_client_event m.room.message event=$LGx5jGONnBPuNhAuZqHeEoXChd9ryVkuTZatGisOPjk state_group=10 create_new_client_event m.room.message event=$wW0zwoN50lbLu1KoKbybVMxLbKUj7GV_olozIc5i3M0 state_group=10 create_new_client_event org.matrix.msc2716.batch event=$5ZB6dtzqFBCEuMRgpkU201Qhx3WtXZGTz_YgldL6JrQ state_group=10 ```
57 lines
2.5 KiB
Python
57 lines
2.5 KiB
Python
# Copyright 2021 The Matrix.org Foundation C.I.C.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
SCHEMA_VERSION = 65 # remember to update the list below when updating
|
|
"""Represents the expectations made by the codebase about the database schema
|
|
|
|
This should be incremented whenever the codebase changes its requirements on the
|
|
shape of the database schema (even if those requirements are backwards-compatible with
|
|
older versions of Synapse).
|
|
|
|
See https://matrix-org.github.io/synapse/develop/development/database_schema.html
|
|
for more information on how this works.
|
|
|
|
Changes in SCHEMA_VERSION = 61:
|
|
- The `user_stats_historical` and `room_stats_historical` tables are not written and
|
|
are not read (previously, they were written but not read).
|
|
- MSC2716: Add `insertion_events` and `insertion_event_edges` tables to keep track
|
|
of insertion events in order to navigate historical chunks of messages.
|
|
- MSC2716: Add `chunk_events` table to track how the chunk is labeled and
|
|
determines which insertion event it points to.
|
|
|
|
Changes in SCHEMA_VERSION = 62:
|
|
- MSC2716: Add `insertion_event_extremities` table that keeps track of which
|
|
insertion events need to be backfilled.
|
|
|
|
Changes in SCHEMA_VERSION = 63:
|
|
- The `public_room_list_stream` table is not written nor read to
|
|
(previously, it was written and read to, but not for any significant purpose).
|
|
https://github.com/matrix-org/synapse/pull/10565
|
|
|
|
Changes in SCHEMA_VERSION = 64:
|
|
- MSC2716: Rename related tables and columns from "chunks" to "batches".
|
|
|
|
Changes in SCHEMA_VERSION = 65:
|
|
- MSC2716: Remove unique event_id constraint from insertion_event_edges
|
|
because an insertion event can have multiple edges.
|
|
"""
|
|
|
|
|
|
SCHEMA_COMPAT_VERSION = 60 # 60: "outlier" not in internal_metadata.
|
|
"""Limit on how far the synapse codebase can be rolled back without breaking db compat
|
|
|
|
This value is stored in the database, and checked on startup. If the value in the
|
|
database is greater than SCHEMA_VERSION, then Synapse will refuse to start.
|
|
"""
|