forked-synapse/scripts-dev
Kegan Dougal 259442fa4c
bugfix: make msc3967 idempotent (#16943)
MSC3967 was updated recently to make it more robust to network failures:

> there is an existing cross-signing master key and it exactly matches
the cross-signing master key provided in the request body. If there are
any additional keys provided in the request (self signing key, user
signing key) they MUST also match the existing keys stored on the
server. In other words, the request contains no new keys. If there are
new keys, UIA MUST be performed.


https://github.com/matrix-org/matrix-spec-proposals/blob/hughns/device-signing-upload-uia/proposals/3967-device-signing-upload-uia.md#proposal

This covers the case where the 200 OK is lost in transit so the client
retries the upload, only to then get UIA'd.

Complement tests: https://github.com/matrix-org/complement/pull/713 -
passing example
https://github.com/element-hq/synapse/actions/runs/7976948122/job/21778795094?pr=16943#step:7:8820

### Pull Request Checklist

<!-- Please read
https://element-hq.github.io/synapse/latest/development/contributing_guide.html
before submitting your pull request -->

* [x] Pull request is based on the develop branch
* [x] Pull request includes a [changelog
file](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#changelog).
The entry should:
- Be a short description of your change which makes sense to users.
"Fixed a bug that prevented receiving messages from other servers."
instead of "Moved X method from `EventStore` to `EventWorkerStore`.".
  - Use markdown where necessary, mostly for `code blocks`.
  - End with either a period (.) or an exclamation mark (!).
  - Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by
@github_username." or "Contributed by [Your Name]." to the end of the
entry.
* [x] [Code
style](https://element-hq.github.io/synapse/latest/code_style.html) is
correct
(run the
[linters](https://element-hq.github.io/synapse/latest/development/contributing_guide.html#run-the-linters))

---------

Co-authored-by: reivilibre <oliverw@matrix.org>
2024-04-15 10:57:56 +00:00
..
build_debian_packages.py Build Debian packages for Ubuntu 23.10 Mantic Minotaur (#16524) 2023-10-19 21:53:05 +01:00
check_line_terminators.sh Update license headers 2023-11-21 15:29:58 -05:00
check_locked_deps_have_sdists.py Correctly mention previous copyright (#16820) 2024-01-23 11:26:48 +00:00
check_pydantic_models.py Correctly mention previous copyright (#16820) 2024-01-23 11:26:48 +00:00
check_schema_delta.py Run pyupgrade for python 3.7 & 3.8. (#16110) 2023-08-15 08:11:20 -04:00
check-newsfragment.sh Update book location 2023-12-13 16:15:22 +00:00
complement.sh bugfix: make msc3967 idempotent (#16943) 2024-04-15 10:57:56 +00:00
config-lint.sh Fix Shellcheck SC2006: Use $(...) notation 2021-10-22 23:08:55 +01:00
database-save.sh Drop unused table presence (#14825) 2023-01-13 14:17:03 +00:00
docker_update_debian_changelog.sh Update license headers 2023-11-21 15:29:58 -05:00
dump_macaroon.py Change the format of access tokens away from macaroons (#5588) 2021-05-12 15:04:51 +01:00
federation_client.py Correctly mention previous copyright (#16820) 2024-01-23 11:26:48 +00:00
generate_sample_config.sh Add suffices to scripts in scripts-dev (#12137) 2022-03-02 18:00:26 +00:00
lint.sh Add developer documentation for the Federation Sender and add a documentation mechanism using Sphinx. (#15265) 2023-03-24 16:41:10 +00:00
make_full_schema.sh Make it easier to use DataGrip w/ Synapse's schema (#14982) 2023-02-15 13:51:37 +00:00
mypy_synapse_plugin.py Correctly mention previous copyright (#16820) 2024-01-23 11:26:48 +00:00
next_github_number.sh Fix typo 2023-12-13 16:37:10 +00:00
release.py Fix incorrect docker hub link in release script (#16910) 2024-02-20 12:20:31 +00:00
schema_versions.py Correctly mention previous copyright (#16820) 2024-01-23 11:26:48 +00:00
sign_json.py Correctly mention previous copyright (#16820) 2024-01-23 11:26:48 +00:00