6979 Commits

Author	SHA1	Message	Date
David Robertson	d6ae14e60e	Update frozendict 2.3.3 -> 2.3.4 (#13955) ... * Update frozendict 2.3.3 -> 2.3.4 This claims to fix more memory leaks. Could have automated this upgrade with #11828 if we wanted. * Changelog	2022-10-07 12:13:37 +01:00
David Robertson	0c853e0970	Fix broken links to README (#14093)	2022-10-06 22:49:51 +00:00
David Robertson	cb20b885cb	Always close _all_ ijson coroutines, even if doing so raises Exceptions (#14065)	2022-10-06 18:17:50 +00:00
Andre Klärner	b753f63000	The changelog entry ending in a . or ! is not optional (#14087)	2022-10-06 17:11:32 +00:00
Shay	7b7478e8b6	Batch up notifications after event persistence (#14033)	2022-10-05 10:12:48 -07:00
Richard van der Hoff	51436c8dd5	Complement test image: capture logs from nginx (#14063) ... Have nginx send its logs to stderr/out, so that we can debug https://github.com/matrix-org/synapse/issues/13334.	2022-10-05 17:37:34 +01:00
Patrick Cloke	0b037d6c91	Fix handling of public rooms filter with a network tuple. (#14053) ... Fixes two related bugs: * The handling of `[null]` for a `room_types` filter was incorrect. * The ordering of arguments when providing both a network tuple and room type field was incorrect.	2022-10-05 12:49:52 +00:00
Patrick Cloke	dcced5a8d7	Use threaded receipts when fetching events for push. (#13878) ... Update the HTTP and email pushers to consider threaded read receipts when fetching unread events.	2022-10-04 12:07:02 -04:00
dependabot[bot]	c3b0e5e178	Bump types-pyyaml from 6.0.4 to 6.0.12 (#14041) ... Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>	2022-10-04 15:53:47 +00:00
Nick Mills-Barrett	0506bb100e	Remove get rooms for user with stream ordering (#13991) ... By getting the joined rooms before the current token we avoid any reading history to confirm a user *was* in a room. We can then use any membership change events, which we already fetch during sync, to determine the final list of joined room IDs.	2022-10-04 16:42:59 +01:00
Patrick Cloke	2b6d41ebd6	Recursively fetch the thread for receipts & notifications. (#13824) ... Consider an event to be part of a thread if you can follow a chain of relations up to a thread root. Part of MSC3773 & MSC3771.	2022-10-04 11:36:16 -04:00
ffaex	3e74ad20db	update authlib from 0.15.5 to 1.1.0 (#14006) ... Signed-off-by: Fyodor Fomichev <fyodor.fomichev@gmail.com>	2022-10-04 14:49:07 +00:00
Patrick Cloke	a7ba457b2b	Mark events as read using threaded read receipts from MSC3771. (#13877) ... Applies the proper logic for unthreaded and threaded receipts to either apply to all events in the room or only events in the same thread, respectively.	2022-10-04 10:46:42 -04:00
Sean Quah	f0019f3f3b	Synapse 1.69.0rc1 (2022-10-04) ... ============================== Please note that legacy Prometheus metric names are now deprecated and will be removed in Synapse 1.73.0. Server administrators should update their dashboards and alerting rules to avoid using the deprecated metric names. See the [upgrade notes](https://matrix-org.github.io/synapse/v1.69/upgrade.html#upgrading-to-v1690) for more details. Features -------- - Allow application services to set the `origin_server_ts` of a state event by providing the query parameter `ts` in [`PUT /_matrix/client/r0/rooms/{roomId}/state/{eventType}/{stateKey}`](https://spec.matrix.org/v1.4/client-server-api/#put_matrixclientv3roomsroomidstateeventtypestatekey), per [MSC3316](https://github.com/matrix-org/matrix-doc/pull/3316). Contributed by @lukasdenk. ([\#11866](https://github.com/matrix-org/synapse/issues/11866)) - Allow server admins to require a manual approval process before new accounts can be used (using [MSC3866](https://github.com/matrix-org/matrix-spec-proposals/pull/3866)). ([\#13556](https://github.com/matrix-org/synapse/issues/13556)) - Exponentially backoff from backfilling the same event over and over. ([\#13635](https://github.com/matrix-org/synapse/issues/13635), [\#13936](https://github.com/matrix-org/synapse/issues/13936)) - Add cache invalidation across workers to module API. ([\#13667](https://github.com/matrix-org/synapse/issues/13667), [\#13947](https://github.com/matrix-org/synapse/issues/13947)) - Experimental implementation of [MSC3882](https://github.com/matrix-org/matrix-spec-proposals/pull/3882) to allow an existing device/session to generate a login token for use on a new device/session. ([\#13722](https://github.com/matrix-org/synapse/issues/13722), [\#13868](https://github.com/matrix-org/synapse/issues/13868)) - Experimental support for thread-specific receipts ([MSC3771](https://github.com/matrix-org/matrix-spec-proposals/pull/3771)). ([\#13782](https://github.com/matrix-org/synapse/issues/13782), [\#13893](https://github.com/matrix-org/synapse/issues/13893), [\#13932](https://github.com/matrix-org/synapse/issues/13932), [\#13937](https://github.com/matrix-org/synapse/issues/13937), [\#13939](https://github.com/matrix-org/synapse/issues/13939)) - Add experimental support for [MSC3881: Remotely toggle push notifications for another client](https://github.com/matrix-org/matrix-spec-proposals/pull/3881). ([\#13799](https://github.com/matrix-org/synapse/issues/13799), [\#13831](https://github.com/matrix-org/synapse/issues/13831), [\#13860](https://github.com/matrix-org/synapse/issues/13860)) - Keep track when an event pulled over federation fails its signature check so we can intelligently back-off in the future. ([\#13815](https://github.com/matrix-org/synapse/issues/13815)) - Improve validation for the unspecced, internal-only `_matrix/client/unstable/add_threepid/msisdn/submit_token` endpoint. ([\#13832](https://github.com/matrix-org/synapse/issues/13832)) - Faster remote room joins: record _when_ we first partial-join to a room. ([\#13892](https://github.com/matrix-org/synapse/issues/13892)) - Support a `dir` parameter on the `/relations` endpoint per [MSC3715](https://github.com/matrix-org/matrix-doc/pull/3715). ([\#13920](https://github.com/matrix-org/synapse/issues/13920)) - Ask mail servers receiving emails from Synapse to not send automatic replies (e.g. out-of-office responses). ([\#13957](https://github.com/matrix-org/synapse/issues/13957)) Bugfixes -------- - Send push notifications for invites received over federation. ([\#13719](https://github.com/matrix-org/synapse/issues/13719), [\#14014](https://github.com/matrix-org/synapse/issues/14014)) - Fix a long-standing bug where typing events would be accepted from remote servers not present in a room. Also fix a bug where incoming typing events would cause other incoming events to get stuck during a fast join. ([\#13830](https://github.com/matrix-org/synapse/issues/13830)) - Fix a bug introduced in Synapse v1.53.0 where the experimental implementation of [MSC3715](https://github.com/matrix-org/matrix-spec-proposals/pull/3715) would give incorrect results when paginating forward. ([\#13840](https://github.com/matrix-org/synapse/issues/13840)) - Fix access token leak to logs from proxy agent. ([\#13855](https://github.com/matrix-org/synapse/issues/13855)) - Fix `have_seen_event` cache not being invalidated after we persist an event which causes inefficiency effects like extra `/state` federation calls. ([\#13863](https://github.com/matrix-org/synapse/issues/13863)) - Faster room joins: Fix a bug introduced in 1.66.0 where an error would be logged when syncing after joining a room. ([\#13872](https://github.com/matrix-org/synapse/issues/13872)) - Fix a bug introduced in 1.66.0 where some required fields in the pushrules sent to clients were not present anymore. Contributed by Nico. ([\#13904](https://github.com/matrix-org/synapse/issues/13904)) - Fix packaging to include `Cargo.lock` in `sdist`. ([\#13909](https://github.com/matrix-org/synapse/issues/13909)) - Fix a long-standing bug where device updates could cause delays sending out to-device messages over federation. ([\#13922](https://github.com/matrix-org/synapse/issues/13922)) - Fix a bug introduced in v1.68.0 where Synapse would require `setuptools_rust` at runtime, even though the package is only required at build time. ([\#13952](https://github.com/matrix-org/synapse/issues/13952)) - Fix a long-standing bug where `POST /_matrix/client/v3/keys/query` requests could result in excessively large SQL queries. ([\#13956](https://github.com/matrix-org/synapse/issues/13956)) - Fix a performance regression in the `get_users_in_room` database query. Introduced in v1.67.0. ([\#13972](https://github.com/matrix-org/synapse/issues/13972)) - Fix a bug introduced in v1.68.0 bug where Rust extension wasn't built in `release` mode when using `poetry install`. ([\#14009](https://github.com/matrix-org/synapse/issues/14009)) - Do not return an unspecified `original_event` field when using the stable `/relations` endpoint. Introduced in Synapse v1.57.0. ([\#14025](https://github.com/matrix-org/synapse/issues/14025)) - Correctly handle a race with device lists when a remote user leaves during a partial join. ([\#13885](https://github.com/matrix-org/synapse/issues/13885)) - Correctly handle sending local device list updates to remote servers during a partial join. ([\#13934](https://github.com/matrix-org/synapse/issues/13934)) Improved Documentation ---------------------- - Add `worker_main_http_uri` for the worker generator bash script. ([\#13772](https://github.com/matrix-org/synapse/issues/13772)) - Update URL for the NixOS module for Synapse. ([\#13818](https://github.com/matrix-org/synapse/issues/13818)) - Fix a mistake in sso_mapping_providers.md: `map_user_attributes` is expected to return `display_name`, not `displayname`. ([\#13836](https://github.com/matrix-org/synapse/issues/13836)) - Fix a cross-link from the registration admin API to the `registration_shared_secret` configuration documentation. ([\#13870](https://github.com/matrix-org/synapse/issues/13870)) - Update the man page for the `hash_password` script to correct the default number of bcrypt rounds performed. ([\#13911](https://github.com/matrix-org/synapse/issues/13911), [\#13930](https://github.com/matrix-org/synapse/issues/13930)) - Emphasize the right reasons when to use `(room_id, event_id)` in a database schema. ([\#13915](https://github.com/matrix-org/synapse/issues/13915)) - Add instruction to contributing guide for running unit tests in parallel. Contributed by @ashfame. ([\#13928](https://github.com/matrix-org/synapse/issues/13928)) - Clarify that the `auto_join_rooms` config option can also be used with Space aliases. ([\#13931](https://github.com/matrix-org/synapse/issues/13931)) - Add some cross references to worker documentation. ([\#13974](https://github.com/matrix-org/synapse/issues/13974)) - Linkify urls in config documentation. ([\#14003](https://github.com/matrix-org/synapse/issues/14003)) Deprecations and Removals ------------------------- - Remove the `complete_sso_login` method from the Module API which was deprecated in Synapse 1.13.0. ([\#13843](https://github.com/matrix-org/synapse/issues/13843)) - Announce that legacy metric names are deprecated, will be turned off by default in Synapse v1.71.0 and removed altogether in Synapse v1.73.0. See the upgrade notes for more information. ([\#14024](https://github.com/matrix-org/synapse/issues/14024)) Internal Changes ---------------- - Speed up creation of DM rooms. ([\#13487](https://github.com/matrix-org/synapse/issues/13487), [\#13800](https://github.com/matrix-org/synapse/issues/13800)) - Port push rules to using Rust. ([\#13768](https://github.com/matrix-org/synapse/issues/13768), [\#13838](https://github.com/matrix-org/synapse/issues/13838), [\#13889](https://github.com/matrix-org/synapse/issues/13889)) - Optimise get rooms for user calls. Contributed by Nick @ Beeper (@fizzadar). ([\#13787](https://github.com/matrix-org/synapse/issues/13787)) - Update the script which makes full schema dumps. ([\#13792](https://github.com/matrix-org/synapse/issues/13792)) - Use shared methods for cache invalidation when persisting events, remove duplicate codepaths. Contributed by Nick @ Beeper (@fizzadar). ([\#13796](https://github.com/matrix-org/synapse/issues/13796)) - Improve the `synapse.api.auth.Auth` mock used in unit tests. ([\#13809](https://github.com/matrix-org/synapse/issues/13809)) - Faster Remote Room Joins: tell remote homeservers that we are unable to authorise them if they query a room which has partial state on our server. ([\#13823](https://github.com/matrix-org/synapse/issues/13823)) - Carry IdP Session IDs through user-mapping sessions. ([\#13839](https://github.com/matrix-org/synapse/issues/13839)) - Fix the release script not publishing binary wheels. ([\#13850](https://github.com/matrix-org/synapse/issues/13850)) - Raise issue if complement fails with latest deps. ([\#13859](https://github.com/matrix-org/synapse/issues/13859)) - Correct the comments in the complement dockerfile. ([\#13867](https://github.com/matrix-org/synapse/issues/13867)) - Create a new snapshot of the database schema. ([\#13873](https://github.com/matrix-org/synapse/issues/13873)) - Faster room joins: Send device list updates to most servers in rooms with partial state. ([\#13874](https://github.com/matrix-org/synapse/issues/13874), [\#14013](https://github.com/matrix-org/synapse/issues/14013)) - Add comments to the Prometheus recording rules to make it clear which set of rules you need for Grafana or Prometheus Console. ([\#13876](https://github.com/matrix-org/synapse/issues/13876)) - Only pull relevant backfill points from the database based on the current depth and limit (instead of all) every time we want to `/backfill`. ([\#13879](https://github.com/matrix-org/synapse/issues/13879)) - Faster room joins: Avoid waiting for full state when processing `/keys/changes` requests. ([\#13888](https://github.com/matrix-org/synapse/issues/13888)) - Improve backfill robustness by trying more servers when we get a `4xx` error back. ([\#13890](https://github.com/matrix-org/synapse/issues/13890)) - Fix mypy errors with canonicaljson 1.6.3. ([\#13905](https://github.com/matrix-org/synapse/issues/13905)) - Faster remote room joins: correctly handle remote device list updates during a partial join. ([\#13913](https://github.com/matrix-org/synapse/issues/13913)) - Complement image: propagate SIGTERM to all workers. ([\#13914](https://github.com/matrix-org/synapse/issues/13914)) - Update an innaccurate comment in Synapse's upsert database helper. ([\#13924](https://github.com/matrix-org/synapse/issues/13924)) - Update mypy (0.950 -> 0.981) and mypy-zope (0.3.7 -> 0.3.11). ([\#13925](https://github.com/matrix-org/synapse/issues/13925), [\#13993](https://github.com/matrix-org/synapse/issues/13993)) - Use dedicated `get_local_users_in_room(room_id)` function to find local users when calculating users to copy over during a room upgrade. ([\#13960](https://github.com/matrix-org/synapse/issues/13960)) - Refactor language in user directory `_track_user_joined_room` code to make it more clear that we use both local and remote users. ([\#13966](https://github.com/matrix-org/synapse/issues/13966)) - Revert catch-all exceptions being recorded as event pull attempt failures (only handle what we know about). ([\#13969](https://github.com/matrix-org/synapse/issues/13969)) - Speed up calculating push actions in large rooms. ([\#13973](https://github.com/matrix-org/synapse/issues/13973), [\#13992](https://github.com/matrix-org/synapse/issues/13992)) - Enable update notifications from Github's dependabot. ([\#13976](https://github.com/matrix-org/synapse/issues/13976)) - Prototype a workflow to automatically add changelogs to dependabot PRs. ([\#13998](https://github.com/matrix-org/synapse/issues/13998), [\#14011](https://github.com/matrix-org/synapse/issues/14011), [\#14017](https://github.com/matrix-org/synapse/issues/14017), [\#14021](https://github.com/matrix-org/synapse/issues/14021), [\#14027](https://github.com/matrix-org/synapse/issues/14027)) - Fix type annotations to be compatible with new annotations in development versions of twisted. ([\#14012](https://github.com/matrix-org/synapse/issues/14012)) - Clear out stale entries in `event_push_actions_staging` table. ([\#14020](https://github.com/matrix-org/synapse/issues/14020)) - Bump versions of GitHub actions. ([\#13978](https://github.com/matrix-org/synapse/issues/13978), [\#13979](https://github.com/matrix-org/synapse/issues/13979), [\#13980](https://github.com/matrix-org/synapse/issues/13980), [\#13982](https://github.com/matrix-org/synapse/issues/13982), [\#14015](https://github.com/matrix-org/synapse/issues/14015), [\#14019](https://github.com/matrix-org/synapse/issues/14019), [\#14022](https://github.com/matrix-org/synapse/issues/14022), [\#14023](https://github.com/matrix-org/synapse/issues/14023)) -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEWMTnW8Z8khaaf90R+84KzgcyGG8FAmM8IQMACgkQ+84Kzgcy GG+eewv/fl+SluS/J5xQ/bJU/rCp1TREd29vafWbCapjLFI4g/2CsLjWXXfP+zFi xHbGA/lWK7Vju/SV/9cURbouosxeCtbc5MrB5l2WmQB21Uw1Ql2DUkGBPVQKb45/ OkCG3J5qAID9r+OsGf6Ir1pJ6+38r5zliEuTn7557B5Fuawjbx7BWX5dfotjH49r WvhyKV+2EzVenmA82iLwC+RSykYcbTkCvKyoNd4Ry6oBOIBDFgLQIVivnQp6W/RK CneP7Q64Ga9+WvLUt9Xgp0B1vIWJcPoM9uPeeifb9Pzq7m7jPo48Zld6Sxdp/zAs NrLFdTQa+YfgvyvtxDXr8fLPjJ91F1Gv6wyPPtd57tZDLgcn3U2UMifDAjMgCWKB 7IEKNOH5fSY00q50cnSr2wS2azYPAS4KFfgXArZ0t1RaU2LDkjyZVjJj7eI7zuex rlqVqvZtqjdreOVUBkf401zTD/hD4+Vld8BnbHX3liAcGObOUIRSsGCwhFh6bquw 8hYy9V6Y =wV0r -----END PGP SIGNATURE----- Merge tag 'v1.69.0rc1' into develop Synapse 1.69.0rc1 (2022-10-04) ============================== Please note that legacy Prometheus metric names are now deprecated and will be removed in Synapse 1.73.0. Server administrators should update their dashboards and alerting rules to avoid using the deprecated metric names. See the [upgrade notes](https://matrix-org.github.io/synapse/v1.69/upgrade.html#upgrading-to-v1690) for more details. Features -------- - Allow application services to set the `origin_server_ts` of a state event by providing the query parameter `ts` in [`PUT /_matrix/client/r0/rooms/{roomId}/state/{eventType}/{stateKey}`](https://spec.matrix.org/v1.4/client-server-api/#put_matrixclientv3roomsroomidstateeventtypestatekey), per [MSC3316](https://github.com/matrix-org/matrix-doc/pull/3316). Contributed by @lukasdenk. ([\#11866](https://github.com/matrix-org/synapse/issues/11866)) - Allow server admins to require a manual approval process before new accounts can be used (using [MSC3866](https://github.com/matrix-org/matrix-spec-proposals/pull/3866)). ([\#13556](https://github.com/matrix-org/synapse/issues/13556)) - Exponentially backoff from backfilling the same event over and over. ([\#13635](https://github.com/matrix-org/synapse/issues/13635), [\#13936](https://github.com/matrix-org/synapse/issues/13936)) - Add cache invalidation across workers to module API. ([\#13667](https://github.com/matrix-org/synapse/issues/13667), [\#13947](https://github.com/matrix-org/synapse/issues/13947)) - Experimental implementation of [MSC3882](https://github.com/matrix-org/matrix-spec-proposals/pull/3882) to allow an existing device/session to generate a login token for use on a new device/session. ([\#13722](https://github.com/matrix-org/synapse/issues/13722), [\#13868](https://github.com/matrix-org/synapse/issues/13868)) - Experimental support for thread-specific receipts ([MSC3771](https://github.com/matrix-org/matrix-spec-proposals/pull/3771)). ([\#13782](https://github.com/matrix-org/synapse/issues/13782), [\#13893](https://github.com/matrix-org/synapse/issues/13893), [\#13932](https://github.com/matrix-org/synapse/issues/13932), [\#13937](https://github.com/matrix-org/synapse/issues/13937), [\#13939](https://github.com/matrix-org/synapse/issues/13939)) - Add experimental support for [MSC3881: Remotely toggle push notifications for another client](https://github.com/matrix-org/matrix-spec-proposals/pull/3881). ([\#13799](https://github.com/matrix-org/synapse/issues/13799), [\#13831](https://github.com/matrix-org/synapse/issues/13831), [\#13860](https://github.com/matrix-org/synapse/issues/13860)) - Keep track when an event pulled over federation fails its signature check so we can intelligently back-off in the future. ([\#13815](https://github.com/matrix-org/synapse/issues/13815)) - Improve validation for the unspecced, internal-only `_matrix/client/unstable/add_threepid/msisdn/submit_token` endpoint. ([\#13832](https://github.com/matrix-org/synapse/issues/13832)) - Faster remote room joins: record _when_ we first partial-join to a room. ([\#13892](https://github.com/matrix-org/synapse/issues/13892)) - Support a `dir` parameter on the `/relations` endpoint per [MSC3715](https://github.com/matrix-org/matrix-doc/pull/3715). ([\#13920](https://github.com/matrix-org/synapse/issues/13920)) - Ask mail servers receiving emails from Synapse to not send automatic replies (e.g. out-of-office responses). ([\#13957](https://github.com/matrix-org/synapse/issues/13957)) Bugfixes -------- - Send push notifications for invites received over federation. ([\#13719](https://github.com/matrix-org/synapse/issues/13719), [\#14014](https://github.com/matrix-org/synapse/issues/14014)) - Fix a long-standing bug where typing events would be accepted from remote servers not present in a room. Also fix a bug where incoming typing events would cause other incoming events to get stuck during a fast join. ([\#13830](https://github.com/matrix-org/synapse/issues/13830)) - Fix a bug introduced in Synapse v1.53.0 where the experimental implementation of [MSC3715](https://github.com/matrix-org/matrix-spec-proposals/pull/3715) would give incorrect results when paginating forward. ([\#13840](https://github.com/matrix-org/synapse/issues/13840)) - Fix access token leak to logs from proxy agent. ([\#13855](https://github.com/matrix-org/synapse/issues/13855)) - Fix `have_seen_event` cache not being invalidated after we persist an event which causes inefficiency effects like extra `/state` federation calls. ([\#13863](https://github.com/matrix-org/synapse/issues/13863)) - Faster room joins: Fix a bug introduced in 1.66.0 where an error would be logged when syncing after joining a room. ([\#13872](https://github.com/matrix-org/synapse/issues/13872)) - Fix a bug introduced in 1.66.0 where some required fields in the pushrules sent to clients were not present anymore. Contributed by Nico. ([\#13904](https://github.com/matrix-org/synapse/issues/13904)) - Fix packaging to include `Cargo.lock` in `sdist`. ([\#13909](https://github.com/matrix-org/synapse/issues/13909)) - Fix a long-standing bug where device updates could cause delays sending out to-device messages over federation. ([\#13922](https://github.com/matrix-org/synapse/issues/13922)) - Fix a bug introduced in v1.68.0 where Synapse would require `setuptools_rust` at runtime, even though the package is only required at build time. ([\#13952](https://github.com/matrix-org/synapse/issues/13952)) - Fix a long-standing bug where `POST /_matrix/client/v3/keys/query` requests could result in excessively large SQL queries. ([\#13956](https://github.com/matrix-org/synapse/issues/13956)) - Fix a performance regression in the `get_users_in_room` database query. Introduced in v1.67.0. ([\#13972](https://github.com/matrix-org/synapse/issues/13972)) - Fix a bug introduced in v1.68.0 bug where Rust extension wasn't built in `release` mode when using `poetry install`. ([\#14009](https://github.com/matrix-org/synapse/issues/14009)) - Do not return an unspecified `original_event` field when using the stable `/relations` endpoint. Introduced in Synapse v1.57.0. ([\#14025](https://github.com/matrix-org/synapse/issues/14025)) - Correctly handle a race with device lists when a remote user leaves during a partial join. ([\#13885](https://github.com/matrix-org/synapse/issues/13885)) - Correctly handle sending local device list updates to remote servers during a partial join. ([\#13934](https://github.com/matrix-org/synapse/issues/13934)) Improved Documentation ---------------------- - Add `worker_main_http_uri` for the worker generator bash script. ([\#13772](https://github.com/matrix-org/synapse/issues/13772)) - Update URL for the NixOS module for Synapse. ([\#13818](https://github.com/matrix-org/synapse/issues/13818)) - Fix a mistake in sso_mapping_providers.md: `map_user_attributes` is expected to return `display_name`, not `displayname`. ([\#13836](https://github.com/matrix-org/synapse/issues/13836)) - Fix a cross-link from the registration admin API to the `registration_shared_secret` configuration documentation. ([\#13870](https://github.com/matrix-org/synapse/issues/13870)) - Update the man page for the `hash_password` script to correct the default number of bcrypt rounds performed. ([\#13911](https://github.com/matrix-org/synapse/issues/13911), [\#13930](https://github.com/matrix-org/synapse/issues/13930)) - Emphasize the right reasons when to use `(room_id, event_id)` in a database schema. ([\#13915](https://github.com/matrix-org/synapse/issues/13915)) - Add instruction to contributing guide for running unit tests in parallel. Contributed by @ashfame. ([\#13928](https://github.com/matrix-org/synapse/issues/13928)) - Clarify that the `auto_join_rooms` config option can also be used with Space aliases. ([\#13931](https://github.com/matrix-org/synapse/issues/13931)) - Add some cross references to worker documentation. ([\#13974](https://github.com/matrix-org/synapse/issues/13974)) - Linkify urls in config documentation. ([\#14003](https://github.com/matrix-org/synapse/issues/14003)) Deprecations and Removals ------------------------- - Remove the `complete_sso_login` method from the Module API which was deprecated in Synapse 1.13.0. ([\#13843](https://github.com/matrix-org/synapse/issues/13843)) - Announce that legacy metric names are deprecated, will be turned off by default in Synapse v1.71.0 and removed altogether in Synapse v1.73.0. See the upgrade notes for more information. ([\#14024](https://github.com/matrix-org/synapse/issues/14024)) Internal Changes ---------------- - Speed up creation of DM rooms. ([\#13487](https://github.com/matrix-org/synapse/issues/13487), [\#13800](https://github.com/matrix-org/synapse/issues/13800)) - Port push rules to using Rust. ([\#13768](https://github.com/matrix-org/synapse/issues/13768), [\#13838](https://github.com/matrix-org/synapse/issues/13838), [\#13889](https://github.com/matrix-org/synapse/issues/13889)) - Optimise get rooms for user calls. Contributed by Nick @ Beeper (@fizzadar). ([\#13787](https://github.com/matrix-org/synapse/issues/13787)) - Update the script which makes full schema dumps. ([\#13792](https://github.com/matrix-org/synapse/issues/13792)) - Use shared methods for cache invalidation when persisting events, remove duplicate codepaths. Contributed by Nick @ Beeper (@fizzadar). ([\#13796](https://github.com/matrix-org/synapse/issues/13796)) - Improve the `synapse.api.auth.Auth` mock used in unit tests. ([\#13809](https://github.com/matrix-org/synapse/issues/13809)) - Faster Remote Room Joins: tell remote homeservers that we are unable to authorise them if they query a room which has partial state on our server. ([\#13823](https://github.com/matrix-org/synapse/issues/13823)) - Carry IdP Session IDs through user-mapping sessions. ([\#13839](https://github.com/matrix-org/synapse/issues/13839)) - Fix the release script not publishing binary wheels. ([\#13850](https://github.com/matrix-org/synapse/issues/13850)) - Raise issue if complement fails with latest deps. ([\#13859](https://github.com/matrix-org/synapse/issues/13859)) - Correct the comments in the complement dockerfile. ([\#13867](https://github.com/matrix-org/synapse/issues/13867)) - Create a new snapshot of the database schema. ([\#13873](https://github.com/matrix-org/synapse/issues/13873)) - Faster room joins: Send device list updates to most servers in rooms with partial state. ([\#13874](https://github.com/matrix-org/synapse/issues/13874), [\#14013](https://github.com/matrix-org/synapse/issues/14013)) - Add comments to the Prometheus recording rules to make it clear which set of rules you need for Grafana or Prometheus Console. ([\#13876](https://github.com/matrix-org/synapse/issues/13876)) - Only pull relevant backfill points from the database based on the current depth and limit (instead of all) every time we want to `/backfill`. ([\#13879](https://github.com/matrix-org/synapse/issues/13879)) - Faster room joins: Avoid waiting for full state when processing `/keys/changes` requests. ([\#13888](https://github.com/matrix-org/synapse/issues/13888)) - Improve backfill robustness by trying more servers when we get a `4xx` error back. ([\#13890](https://github.com/matrix-org/synapse/issues/13890)) - Fix mypy errors with canonicaljson 1.6.3. ([\#13905](https://github.com/matrix-org/synapse/issues/13905)) - Faster remote room joins: correctly handle remote device list updates during a partial join. ([\#13913](https://github.com/matrix-org/synapse/issues/13913)) - Complement image: propagate SIGTERM to all workers. ([\#13914](https://github.com/matrix-org/synapse/issues/13914)) - Update an innaccurate comment in Synapse's upsert database helper. ([\#13924](https://github.com/matrix-org/synapse/issues/13924)) - Update mypy (0.950 -> 0.981) and mypy-zope (0.3.7 -> 0.3.11). ([\#13925](https://github.com/matrix-org/synapse/issues/13925), [\#13993](https://github.com/matrix-org/synapse/issues/13993)) - Use dedicated `get_local_users_in_room(room_id)` function to find local users when calculating users to copy over during a room upgrade. ([\#13960](https://github.com/matrix-org/synapse/issues/13960)) - Refactor language in user directory `_track_user_joined_room` code to make it more clear that we use both local and remote users. ([\#13966](https://github.com/matrix-org/synapse/issues/13966)) - Revert catch-all exceptions being recorded as event pull attempt failures (only handle what we know about). ([\#13969](https://github.com/matrix-org/synapse/issues/13969)) - Speed up calculating push actions in large rooms. ([\#13973](https://github.com/matrix-org/synapse/issues/13973), [\#13992](https://github.com/matrix-org/synapse/issues/13992)) - Enable update notifications from Github's dependabot. ([\#13976](https://github.com/matrix-org/synapse/issues/13976)) - Prototype a workflow to automatically add changelogs to dependabot PRs. ([\#13998](https://github.com/matrix-org/synapse/issues/13998), [\#14011](https://github.com/matrix-org/synapse/issues/14011), [\#14017](https://github.com/matrix-org/synapse/issues/14017), [\#14021](https://github.com/matrix-org/synapse/issues/14021), [\#14027](https://github.com/matrix-org/synapse/issues/14027)) - Fix type annotations to be compatible with new annotations in development versions of twisted. ([\#14012](https://github.com/matrix-org/synapse/issues/14012)) - Clear out stale entries in `event_push_actions_staging` table. ([\#14020](https://github.com/matrix-org/synapse/issues/14020)) - Bump versions of GitHub actions. ([\#13978](https://github.com/matrix-org/synapse/issues/13978), [\#13979](https://github.com/matrix-org/synapse/issues/13979), [\#13980](https://github.com/matrix-org/synapse/issues/13980), [\#13982](https://github.com/matrix-org/synapse/issues/13982), [\#14015](https://github.com/matrix-org/synapse/issues/14015), [\#14019](https://github.com/matrix-org/synapse/issues/14019), [\#14022](https://github.com/matrix-org/synapse/issues/14022), [\#14023](https://github.com/matrix-org/synapse/issues/14023))	2022-10-04 15:26:37 +01:00
Patrick Cloke	d8663f5e63	Advertise supporting version 1.3 of the Matrix spec. (#14032) ... Now that all features / changes in 1.3 are supported in Synapse.	2022-10-04 10:21:16 -04:00
David Robertson	04ce2edddc	Fix building wheels on OSX (#14046) ... * Fix building wheels on OSX Follow-up to #13983. I missed a breaking change in setup-python v4. Serves me right for rushing to cut through the dependabot spam. * Changelog * Merge changelog	2022-10-04 14:59:30 +01:00
Patrick Cloke	b4ec4f5e71	Track notification counts per thread (implement MSC3773). (#13776) ... When retrieving counts of notifications segment the results based on the thread ID, but choose whether to return them as individual threads or as a single summed field by letting the client opt-in via a sync flag. The summarization code is also updated to be per thread, instead of per room.	2022-10-04 09:47:04 -04:00
dependabot[bot]	94017e867d	Bump isort from 5.7.0 to 5.10.1 (#13988) ... Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>	2022-10-04 13:19:40 +01:00
dependabot[bot]	6ec9fcc808	Bump jsonschema from 4.4.0 to 4.16.0 (#13985) ... * Bump jsonschema from 4.4.0 to 4.16.0 Bumps [jsonschema](https://github.com/python-jsonschema/jsonschema) from 4.4.0 to 4.16.0. - [Release notes](https://github.com/python-jsonschema/jsonschema/releases) - [Changelog](https://github.com/python-jsonschema/jsonschema/blob/main/CHANGELOG.rst) - [Commits](https://github.com/python-jsonschema/jsonschema/compare/v4.4.0...v4.16.0) --- updated-dependencies: - dependency-name: jsonschema dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>	2022-10-04 12:34:08 +01:00
dependabot[bot]	b95d8b463e	Bump types-pyopenssl from 22.0.0 to 22.0.10 (#13984) ... Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>	2022-10-04 12:27:41 +01:00
dependabot[bot]	b64b7297f2	Bump actions/setup-python from 2 to 4 (#13983) ... Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>	2022-10-04 12:24:36 +01:00
dependabot[bot]	0e5106a0cc	Bump types-requests from 2.27.11 to 2.28.11 (#13987) ... Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>	2022-10-04 12:24:18 +01:00
dependabot[bot]	23a4973b83	Bump types-setuptools from 57.4.9 to 65.4.0.0 (#13986) ... Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-10-04 12:21:20 +01:00
Patrick Cloke	e70c6b720e	Disable pushing for server ACL events (MSC3786). (#13997) ... Switches to the stable identifier for MSC3786 and enables it by default. This disables pushes of m.room.server_acl events.	2022-10-04 07:08:27 -04:00
Patrick Cloke	27fa0fa698	Send the appservice access token as a header. (#13996) ... Implements MSC2832 by sending application service access tokens in the Authorization header. The access token is also still sent as a query parameter until the application service ecosystem has fully migrated to using headers. In the future this could be made opt-in, or removed completely.	2022-10-04 07:06:41 -04:00
Sean Quah	471e13a103	1.69.0rc1	2022-10-04 11:18:37 +01:00
Akshit Tyagi	1613857b90	Linkify config documentation. (#14003)	2022-10-04 09:03:31 +00:00
Eric Eastwood	70a4317692	Track when the pulled event signature fails (#13815) ... Because we're doing the recording in `_check_sigs_and_hash_for_pulled_events_and_fetch` (previously named `_check_sigs_and_hash_and_fetch`), this means we will track signature failures for `backfill`, `get_room_state`, `get_event_auth`, and `get_missing_events` (all pulled event scenarios). And we also record signature failures from `get_pdu`. Part of https://github.com/matrix-org/synapse/issues/13700 Part of https://github.com/matrix-org/synapse/issues/13676 and https://github.com/matrix-org/synapse/issues/13356 This PR will be especially important for https://github.com/matrix-org/synapse/pull/13816 so we can avoid the costly `_get_state_ids_after_missing_prev_event` down the line when `/messages` calls backfill.	2022-10-03 14:53:29 -05:00
dependabot[bot]	0c9c159f45	Bump actions/upload-artifact from 2 to 3 (#14023) ... * Bump actions/upload-artifact from 2 to 3 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 3. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](https://github.com/actions/upload-artifact/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>	2022-10-03 19:11:22 +01:00
Erik Johnston	5a6d025246	Clear out old rows from event_push_actions_staging (#14020) ... On matrix.org we have ~5 million stale rows in `event_push_actions_staging`, let's add a background job to make sure we clear them out.	2022-10-03 18:44:44 +01:00
reivilibre	b381701f8c	Announce that legacy metric names are deprecated, will be turned off by default in Synapse v1.71.0 and removed altogether in Synapse v1.73.0. (#14024)	2022-10-03 17:16:15 +00:00
dependabot[bot]	4cb0f5a99d	Bump actions/cache from 2 to 3 (#13980) ... * Bump actions/cache from 2 to 3 Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>	2022-10-03 17:54:06 +01:00
dependabot[bot]	8e8638ac40	Bump actions/download-artifact from 2 to 3 (#13979) ... * Bump actions/download-artifact from 2 to 3 Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 3. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](https://github.com/actions/download-artifact/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>	2022-10-03 17:50:06 +01:00
Patrick Cloke	b706111b78	Do not return unspecced original_event field when using the stable /relations endpoint. (#14025) ... Keep the old behavior (of including the original_event field) for any requests to the /unstable version of the endpoint, but do not include the field when the /v1 version is used. This should avoid new clients from depending on this field, but will not help with current dependencies.	2022-10-03 16:47:15 +00:00
dependabot[bot]	d42541733d	Bump docker/login-action from 1 to 2 (#13978) ... * Bump docker/login-action from 1 to 2 Bumps [docker/login-action](https://github.com/docker/login-action) from 1 to 2. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](https://github.com/docker/login-action/compare/v1...v2) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: GitHub Actions <github-actions[bot]@users.noreply.github.com>	2022-10-03 17:32:48 +01:00
David Robertson	2d5ce8c087	Dependabot changelogs: trigger CI explicitly (#14027) ... * Dependabot changelogs: trigger CI explicitly * Changelog * Use merge ref, not head ref ref ref ref ref ref * explanatory note	2022-10-03 17:16:45 +01:00
dependabot[bot]	4cceb6ba66	Bump docker/build-push-action from 2 to 3 (#14022) ... * Bump docker/build-push-action from 2 to 3 Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 2 to 3. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](https://github.com/docker/build-push-action/compare/v2...v3) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>	2022-10-03 17:15:27 +01:00
dependabot[bot]	6c85796769	Bump docker/setup-qemu-action from 1 to 2 (#14019) ... * Bump docker/setup-qemu-action from 1 to 2 Bumps [docker/setup-qemu-action](https://github.com/docker/setup-qemu-action) from 1 to 2. - [Release notes](https://github.com/docker/setup-qemu-action/releases) - [Commits](https://github.com/docker/setup-qemu-action/compare/v1...v2) --- updated-dependencies: - dependency-name: docker/setup-qemu-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>	2022-10-03 16:07:39 +01:00
David Robertson	3ac0e76b79	yet another attempt to make dependabot changelogs work (#14021) ... * yet another attempt to make dependabot changelogs work * Changelog	2022-10-03 15:59:32 +01:00
dependabot[bot]	a52d27a68b	Bump docker/setup-buildx-action from 1 to 2 (#14015) ... Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>	2022-10-03 14:13:15 +00:00
Erik Johnston	2c237debd3	Fix bug where we didn't delete staging push actions (#14014) ... Introduced in #13719	2022-10-03 13:45:19 +00:00
David Robertson	cc8a3582e0	Try again to automate dependabot changelogs (#14017) ... * Try again to automate dependabot changelogs * Changelog	2022-10-03 14:34:50 +01:00
lukasdenk	719488dda8	Add query parameter ts to allow appservices set the origin_server_ts for state events. (#11866) ... MSC3316 declares that both /rooms/{roomId}/send and /rooms/{roomId}/state should accept a ts parameter for appservices. This change expands support to /state and adds tests.	2022-10-03 13:30:45 +00:00
David Robertson	a423f45294	Fix twisted trunk mypy errors (#14012)	2022-10-03 13:26:49 +00:00
dependabot[bot]	7f4f2a3782	Bump actions/checkout from 2 to 3 (#13982) ... * Bump actions/checkout from 2 to 3 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Changelog Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>	2022-10-03 14:20:32 +01:00
Erik Johnston	606b2d9009	Add cache to get_partial_state_servers_at_join (#14013)	2022-10-03 13:13:11 +00:00
Sean Quah	d65862c41f	Refactor _get_e2e_device_keys_txn to split large queries (#13956) ... Instead of running a single large query, run a single query for user-only lookups and additional queries for batches of user device lookups. Resolves #13580. Signed-off-by: Sean Quah <seanq@matrix.org>	2022-10-03 13:46:36 +01:00
David Robertson	061739d10f	Change dependabot CL suffix (#14011) ... * Change dependabot CL suffix * Changelog	2022-10-03 11:51:57 +01:00
David Robertson	7a441c4f30	Protoype automatic changelogs for dependabot PRs (#13998)	2022-10-03 11:30:21 +01:00
Erik Johnston	343038c3c3	Always build Rust extension in release mode (#14009) ... Fixes #13990	2022-10-03 11:20:18 +01:00
Eric Eastwood	2769ef4df1	Revert the general exception recording introduced in #13814 (#13969) ... * Maybe not catch all errors to avoid things in the nature-of CancelledError See https://github.com/matrix-org/synapse/pull/13815#discussion_r983384698 * Remove general exception tracking * Add changelog	2022-10-03 10:14:45 +01:00
Eric Eastwood	a52c40e2a6	Fix get_users_in_room mis-use in transfer_room_state_on_room_upgrade (#13960) ... Spawning from looking into `get_users_in_room` while investigating https://github.com/matrix-org/synapse/issues/13942#issuecomment-1262787050. See https://github.com/matrix-org/synapse/pull/13575#discussion_r953023755 for the original exploration around finding `get_users_in_room` mis-uses. Related to the following PRs where we also cleaned up some `get_users_in_room` mis-uses: - https://github.com/matrix-org/synapse/pull/13605 - https://github.com/matrix-org/synapse/pull/13608 - https://github.com/matrix-org/synapse/pull/13606 - https://github.com/matrix-org/synapse/pull/13958	2022-09-30 20:10:50 -05:00
Eric Eastwood	ad4c14e4b0	Clarifications in user directory for users who share rooms tracking (#13966) ... Spawned while working on [`get_users_in_room` mis-uses](https://github.com/matrix-org/synapse/pull/13958#discussion_r984074897) and thinking we could use `get_local_users_in_room` here but we can't. From first glance, it seemed like this was only using local users from all of the `is_mine_id(user_id)` checks but I see that it does actually use remote users. Just making things a little more clear here what it does and mentions remote users so maybe that will be more obvious in the future.	2022-09-30 14:40:18 -05:00
Erik Johnston	535f8c8f7d	Skip filtering during push if there are no push actions (#13992)	2022-09-30 17:40:33 +01:00
David Robertson	285d72556b	Update mypy and mypy-zope, attempt 3 (#13993) ... Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-09-30 17:36:28 +01:00
David Robertson	8e52cb0bce	Revert "Update mypy and mypy-zope (#13925)" ... This reverts commit 6d543d6d9f.	2022-09-30 16:37:48 +01:00
David Robertson	6d543d6d9f	Update mypy and mypy-zope (#13925) ... * Update mypy and mypy-zope * Unignore assigning to LogRecord attributes Presumably https://github.com/python/typeshed/pull/8064 makes this ok Cherry-picked from #13521 * Remove unused ignores due to mypy ParamSpec fixes https://github.com/python/mypy/pull/12668 Cherry-picked from #13521 * Remove additional unused ignores * Fix new mypy complaints related to `assertGreater` Presumably due to https://github.com/python/typeshed/pull/8077 * Changelog * Reword changelog Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-09-30 16:34:47 +01:00
Richard van der Hoff	b2aadd81a8	Enable dependabot updates (#13976) ... Fixes https://github.com/matrix-org/synapse/issues/11828	2022-09-30 14:28:34 +01:00
Erik Johnston	285b9e9b6c	Speed up calculating push actions in large rooms (#13973) ... We move the expensive check of visibility to after calculating push actions, avoiding the expensive check for users who won't get pushed anyway. I think this should have a big impact on rooms with large numbers of local users that have pushed disabled.	2022-09-30 14:27:00 +01:00
David Robertson	5507bfa769	Discourage automatic replies to Synapse's emails (#13957) ... Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-09-30 13:23:37 +00:00
Dirk Klimpel	4490697b98	Add some cross references to worker documentation (#13974) ... Signed-off-by: Dirk Klimpel <dirk@klimpel.org>	2022-09-30 13:41:32 +01:00
Erik Johnston	3dfc4a08dc	Fix performance regression in get_users_in_room (#13972) ... Fixes #13942. Introduced in #13575. Basically, let's only get the ordered set of hosts out of the DB if we need an ordered set of hosts. Since we split the function up the caching won't be as good, but I think it will still be fine as e.g. multiple backfill requests for the same room will hit the cache.	2022-09-30 13:15:32 +01:00
David Robertson	e8f30a76ca	Fix overflows in /messages backfill calculation (#13936) ... * Reproduce bug * Compute `least_function` first * Substitute `least_function` with an f-string * Bugfix: avoid overflow Co-authored-by: Eric Eastwood <erice@element.io>	2022-09-30 11:54:53 +01:00
Brendan Abolivier	1cc2ca81ba	Add missing version information in the ModuleApi (#13947)	2022-09-30 12:27:21 +02:00
David Robertson	6f0c3e669d	Don't require setuptools_rust at runtime (#13952)	2022-09-29 20:16:08 +00:00
David Robertson	15754d720f	Update UPSERT comment now that native upserts are the default (#13924)	2022-09-29 19:10:47 +01:00
Erik Johnston	ebd9e2dac6	Implement push rule evaluation in Rust. (#13838)	2022-09-29 16:12:09 +01:00
Nick Mills-Barrett	a466164647	Optimise get_rooms_for_user (drop with_stream_ordering) (#13787)	2022-09-29 13:55:12 +00:00
Brendan Abolivier	be76cd8200	Allow admins to require a manual approval process before new accounts can be used (using MSC3866) (#13556)	2022-09-29 15:23:24 +02:00
Patrick Cloke	8625ad8099	Explicit cast to enforce type hints. (#13939)	2022-09-29 07:22:41 -04:00
Hugh Nimmo-Smith	e5fdf16d46	Expose MSC3882 only be under an unstable endpoint. (#13868)	2022-09-29 07:22:27 -04:00
Patrick Cloke	568016929f	Clarify that a method returns only unthreaded receipts. (#13937) ... By renaming it and updating the docstring. Additionally, refactors a method which is used only by tests.	2022-09-29 07:07:31 -04:00
Nicolas Werner	99a7e7e023	Always send default and rule_id to clients (#13904)	2022-09-29 11:57:00 +01:00
reivilibre	73ecff7e9e	Improve backfill robustness by trying more servers. (#13890) ... Co-authored-by: Eric Eastwood <erice@element.io>	2022-09-29 10:00:02 +00:00
Erik Johnston	5f659d4a88	Handle local device list updates during partial join (#13934)	2022-09-28 23:22:35 +01:00
Eric Eastwood	df8b91ed2b	Limit and filter the number of backfill points to get from the database (#13879) ... There is no need to grab thousands of backfill points when we only need 5 to make the `/backfill` request with. We need to grab a few extra in case the first few aren't visible in the history. Previously, we grabbed thousands of backfill points from the database, then sorted and filtered them in the app. Fetching the 4.6k backfill points for `#matrix:matrix.org` from the database takes ~50ms - ~570ms so it's not like this saves a lot of time 🤷. But it might save us more time now that `get_backfill_points_in_room`/`get_insertion_event_backward_extremities_in_room` are more complicated after https://github.com/matrix-org/synapse/pull/13635 This PR moves the filtering and limiting to the SQL query so we just have less data to work with in the first place. Part of https://github.com/matrix-org/synapse/issues/13356	2022-09-28 15:26:16 -05:00
Patrick Cloke	d768c50c0e	Add upgrade notes for changes to receipts replication. (#13932)	2022-09-28 11:33:31 -04:00
Patrick Cloke	1386ce4735	Revert "Stop returning an unused column when handling new receipts. (#13933)" (#13935) ... This reverts commit 7766bd5b35 (#13933). The unused column is actually used, but much further down in the function.	2022-09-28 11:01:41 -04:00
Patrick Cloke	7766bd5b35	Stop returning an unused column when handling new receipts. (#13933)	2022-09-28 10:58:25 -04:00
Andrew Morgan	25c0e69392	Document that the 'auto_join_rooms' option works with Spaces (#13931)	2022-09-28 14:13:19 +00:00
Andrew Morgan	220b21936e	Correct default number of bcrypt hash rounds in .1 man page (#13930)	2022-09-28 14:45:13 +01:00
Erik Johnston	4b17a5ace8	Handle remote device list updates during partial join (#13913) ... c.f. #12993 (comment), point 3 This stores all device list updates that we receive while partial joins are ongoing, and processes them once we have the full state. Note: We don't actually process the device lists in the same ways as if we weren't partially joined. Instead of updating the device list remote cache, we simply notify local users that a change in the remote user's devices has happened. I think this is safe as if the local user requests the keys for the remote user and we don't have them we'll simply fetch them as normal.	2022-09-28 13:42:43 +00:00
Kateřina Churanová	6caa303083	fix: Push notifications for invite over federation (#13719)	2022-09-28 12:31:53 +00:00
Ashish Kumar	5c429b86b4	Add instruction for running unit tests in parallel (#13928)	2022-09-28 11:14:35 +00:00
Shay	8ab16a92ed	Persist CreateRoom events to DB in a batch (#13800)	2022-09-28 10:11:48 +00:00
Shay	a2cf66a94d	Prepatory work for batching events to send (#13487) ... This PR begins work on batching up events during the creation of a room. The PR splits out the creation and sending/persisting of the events. The first three events in the creation of the room-creating the room, joining the creator to the room, and the power levels event are sent sequentially, while the subsequent events are created and collected to be sent at the end of the function. This is currently done by appending them to a list and then iterating over the list to send, the next step (after this PR) would be to send and persist the collected events as a batch.	2022-09-28 10:39:03 +01:00
Eric Eastwood	29269d9d3f	Fix have_seen_event cache not being invalidated (#13863) ... Fix https://github.com/matrix-org/synapse/issues/13856 Fix https://github.com/matrix-org/synapse/issues/13865 > Discovered while trying to make Synapse fast enough for [this MSC2716 test for importing many batches](https://github.com/matrix-org/complement/pull/214#discussion_r741678240). As an example, disabling the `have_seen_event` cache saves 10 seconds for each `/messages` request in that MSC2716 Complement test because we're not making as many federation requests for `/state` (speeding up `have_seen_event` itself is related to https://github.com/matrix-org/synapse/issues/13625) > > But this will also make `/messages` faster in general so we can include it in the [faster `/messages` milestone](https://github.com/matrix-org/synapse/milestone/11). > > *-- https://github.com/matrix-org/synapse/issues/13856* ### The problem `_invalidate_caches_for_event` doesn't run in monolith mode which means we never even tried to clear the `have_seen_event` and other caches. And even in worker mode, it only runs on the workers, not the master (AFAICT). Additionally there was bug with the key being wrong so `_invalidate_caches_for_event` never invalidates the `have_seen_event` cache even when it does run. Because we were using the `@cachedList` wrong, it was putting items in the cache under keys like `((room_id, event_id),)` with a `set` in a `set` (ex. `(('!TnCIJPKzdQdUlIyXdQ:test', '$Iu0eqEBN7qcyF1S9B3oNB3I91v2o5YOgRNPwi_78s-k'),)`) and we we're trying to invalidate with just `(room_id, event_id)` which did nothing.	2022-09-27 15:55:43 -05:00
Eric Eastwood	35e9d6a616	Emphasize the right reasons to use (room_id, event_id) in a schema (#13915) ... * Emphasize the right reasons to use (room_id, event_id) Follow-up to: - https://github.com/matrix-org/synapse/pull/13701 - https://github.com/matrix-org/synapse/pull/13771	2022-09-27 19:43:16 +00:00
David Robertson	f5aaa55e27	Add new columns tracking when we partial-joined (#13892)	2022-09-27 17:26:35 +01:00
Patrick Cloke	87fe9db467	Support the stable dir parameter for /relations. (#13920) ... Since MSC3715 has passed FCP, the stable parameter can be used. This currently falls back to the unstable parameter if the stable parameter is not provided (and MSC3715 support is enabled in the configuration).	2022-09-27 10:47:34 -04:00
Erik Johnston	299b00d968	Prioritize outbound to-device over device list updates (#13922) ... Otherwise device list changes for large accounts can temporarily delay to-device messages.	2022-09-27 15:17:41 +01:00
Mathieu Velten	42dd992bb7	Dockerfile for tests: align comments with current behavior (#13867) ... Signed-off-by: Mathieu Velten <mathieuv@matrix.org> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-09-27 15:55:43 +02:00
Quentin Gliech	50c92f3a69	Carry IdP Session IDs through user-mapping sessions. (#13839) ... Since #11482, we're saving sessions IDs from upstream IdPs, but we've been losing them when the user goes through a user mapping session on account registration.	2022-09-27 14:38:14 +01:00
Erik Johnston	e8318a4333	Handle the case of remote users leaving a partial join room for device lists (#13885)	2022-09-27 13:01:08 +01:00
Sean Quah	85e161631a	Faster room joins: Fix spurious error when joining a room (#13872) ... During a `lazy_load_members` `/sync`, we look through auth events in rooms with partial state to find prior membership events. When such a membership is not found, an error is logged. Since the first join event for a user never has a prior membership event to cite, the error would always be logged when one appeared in the room timeline. Avoid logging errors for such events. Introduced in #13477. Signed-off-by: Sean Quah <seanq@matrix.org>	2022-09-27 11:17:23 +01:00
Richard van der Hoff	d6b85a2a7d	Complement image: propagate SIGTERM to all workers (#13914) ... This should mean that logs from worker processes are flushed before shutdown. When a test completes, Complement stops the docker container, which means that synapse will receive a SIGTERM. Currently, the `complement_fork_starter` exits immediately (without notifying the worker processes), which means that the workers never get a chance to flush their logs before the whole container is vaped. We can fix this by propagating the SIGTERM to the children.	2022-09-26 23:07:02 +01:00
Patrick Cloke	2fae1a3f78	Improve tests for get_unread_push_actions_for_user_in_range_*. (#13893) ... * Adds a docstring. * Reduces a small amount of duplicated code. * Improves tests.	2022-09-26 18:28:12 +00:00
Andrew Morgan	58ab96747c	Update the manpage documentation for the hash_password script (#13911)	2022-09-26 18:18:41 +00:00
David Robertson	0a38c7ec6d	Snapshot schema 72 (#13873) ... Including another batch of fixes to the schema dump script	2022-09-26 18:28:32 +01:00
Mathieu Velten	41461fd4d6	typing: check origin server of typing event against room's servers (#13830) ... This is also using the partial state approximation if needed so we do not block here during a fast join. Signed-off-by: Mathieu Velten <mathieuv@matrix.org> Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-09-26 17:33:32 +02:00
Nick Mills-Barrett	6b4593a80f	Simplify cache invalidation after event persist txn (#13796) ... This moves all the invalidations into a single place and de-duplicates the code involved in invalidating caches for a given event by using the base class method.	2022-09-26 16:26:35 +01:00
enterprisey	f34b0bc262	Update NixOS module URL (#13818) ... * Update NixOS module URL * Create 13818.doc	2022-09-26 15:26:59 +01:00
Erik Johnston	c5defa4cba	Correctly add Cargo.lock to sdsit (#13909)	2022-09-26 13:58:10 +00:00
David Robertson	dcdd50e458	Fix mypy errors with latest canonicaljson (#13905) ... * Lockfile: update canonicaljson 1.6.0 -> 1.6.3 * Fix mypy errors with latest canonicaljson The change to `_encode_json_bytes` definition wasn't sufficient: ``` synapse/http/server.py:751: error: Incompatible types in assignment (expression has type "Callable[[Arg(object, 'json_object')], bytes]", variable has type "Callable[[Arg(object, 'data')], bytes]") [assignment] ``` Which I think is mypy warning us that the two functions accept different sets of kwargs. Fair enough! * Changelog	2022-09-26 13:30:00 +01:00
Eric Eastwood	ac1a31740b	Only try to backfill event if we haven't tried before recently (#13635) ... Only try to backfill event if we haven't tried before recently (exponential backoff). No need to keep trying the same backfill point that fails over and over. Fix https://github.com/matrix-org/synapse/issues/13622 Fix https://github.com/matrix-org/synapse/issues/8451 Follow-up to https://github.com/matrix-org/synapse/pull/13589 Part of https://github.com/matrix-org/synapse/issues/13356	2022-09-23 14:01:29 -05:00
Sean Quah	f49f73c0da	Faster room joins: Avoid blocking /keys/changes (#13888) ... Part of the work for #12993. Once #12993 is fully resolved, we expect `/keys/changes` to behave sensibly when joined to a room with partial state. Signed-off-by: Sean Quah <seanq@matrix.org>	2022-09-23 17:55:15 +01:00
Eric Eastwood	db868db594	Fix access token leak to logs from proxyagent (#13855) ... This can happen specifically with an application service `/transactions/10722?access_token=leaked` request Fix https://github.com/matrix-org/synapse/issues/13010 --- Saw an example leak in https://github.com/matrix-org/synapse/issues/13423#issuecomment-1205348482 ``` 2022-08-04 14:47:57,925 - synapse.http.client - 401 - DEBUG - as-sender-signal-1 - Sending request PUT http://localhost:29328/transactions/10722?access_token=<redacted> 2022-08-04 14:47:57,926 - synapse.http.proxyagent - 223 - DEBUG - as-sender-signal-1 - Requesting b'http://localhost:29328/transactions/10722?access_token=leaked' via <HostnameEndpoint localhost:29328> ```	2022-09-23 11:49:39 -05:00
Patrick Cloke	e3512a7719	Update Cargo.lock file. (#13889)	2022-09-23 11:59:39 -04:00
Patrick Cloke	efd108b45d	Accept & store thread IDs for receipts (implement MSC3771). (#13782) ... Updates the `/receipts` endpoint and receipt EDU handler to parse a `thread_id` from the body and insert it in the database.	2022-09-23 14:33:28 +00:00
Sean Quah	03c2bfb7f8	Send device list updates out to servers in partially joined rooms (#13874) ... Use the provided list of servers in the room from the `/send_join` response, since we will not know which users are in the room. This isn't sufficient to ensure that all remote servers receive the right device list updates, since the `/send_join` response may be inaccurate or we may calculate the membership state of new users in the room incorrectly. Signed-off-by: Sean Quah <seanq@matrix.org>	2022-09-23 13:44:03 +01:00
reivilibre	c06b2b7142	Faster Remote Room Joins: tell remote homeservers that we are unable to authorise them if they query a room which has partial state on our server. (#13823)	2022-09-23 11:47:16 +01:00
reivilibre	ac7e5683d6	Add comments to the Prometheus recording rules to make it clear which set of rules you need for Grafana or Prometheus Console. (#13876)	2022-09-23 11:46:45 +01:00
David Robertson	f7c89c44c5	Raise issue if complement fails with latest deps (#13859)	2022-09-22 17:33:37 +01:00
Patrick Cloke	8c3dcdf1b9	Fix the cross-link from register admin API to config docs. (#13870)	2022-09-22 09:11:50 -04:00
Patrick Cloke	b7272b73aa	Properly paginate forward in the /relations API. (#13840) ... This fixes a bug where the `/relations` API with `dir=f` would skip the first item of each page (except the first page), causing incomplete data to be returned to the client.	2022-09-22 12:47:49 +00:00
David Robertson	1a1abdda42	Last batch of Pydantic for synapse/rest/client/account.py (#13832) ... * Validation for `/add_threepid/msisdn/submit_token` * Don't validate deprecated endpoint * Changelog	2022-09-21 22:23:44 +01:00
Brendan Abolivier	efabf44c76	Add version flag for MSC3881 (#13860)	2022-09-21 18:18:44 +02:00
Brendan Abolivier	ccca14140a	Track device IDs for pushers (#13831) ... Second half of the MSC3881 implementation	2022-09-21 15:31:53 +00:00
Hugh Nimmo-Smith	0fd2f2d460	Implementation of MSC3882 login token request (#13722)	2022-09-21 15:12:29 +00:00
villepeh	269eddad6f	Add worker_main_http_uri to the contrib bash script (#13772) ... * Add worker_main_http_uri, replace >> with > Co-authored-by: Dirk Klimpel <5740567+dklimpel@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>	2022-09-21 15:58:46 +01:00
Brendan Abolivier	8ae42ab8fa	Support enabling/disabling pushers (from MSC3881) (#13799) ... Partial implementation of MSC3881	2022-09-21 14:39:01 +00:00
Mathieu Velten	6bd8763804	Add cache invalidation across workers to module API (#13667) ... Signed-off-by: Mathieu Velten <mathieuv@matrix.org>	2022-09-21 15:32:01 +02:00
Peter Scheu	16e1a9d9a7	Correct documentation for map_user_attributes of OpenID Mapping Providers (#13836) ... Co-authored-by: David Robertson <davidr@element.io>	2022-09-21 13:08:16 +00:00
Quentin Gliech	e0804ef898	Improve the synapse.api.auth.Auth mock used in unit tests. (#13809) ... To return the proper type (`Requester`) instead of a `dict`.	2022-09-21 12:40:34 +00:00
reivilibre	a35842caec	Fix the release script not publishing binary wheels. (#13850)	2022-09-21 09:43:08 +00:00
Olivier Wilkinson (reivilibre)	2b522cceb6	Merge branch 'release-v1.68' into develop	2022-09-20 14:54:05 +01:00
Quentin Gliech	85fc7ea1a1	Remove the complete_sso_login method from the Module API which was deprecated in Synapse 1.13.0. (#13843) ... Signed-off-by: Quentin Gliech <quenting@element.io>	2022-09-20 15:18:07 +02:00
David Robertson	fff9b955fa	Generate separate snapshots for logical databases (#13792) ... * Generate separate snapshots for sqlite, postgres and common * Cleanup postgres dbs in the TRAP * Say which logical DB we're applying updates to * Run background updates on the state DB * Add new option for accepting a SCHEMA_NUMBER	2022-09-20 14:14:12 +01:00
Erik Johnston	42d261c32f	Port the push rule classes to Rust. (#13768)	2022-09-20 12:10:31 +01:00
Olivier Wilkinson (reivilibre)	e124b24ad9	1.68.0rc1	2022-09-20 11:30:48 +01:00
Denis	c802ef1411	Don't include redundant prev_state in new events (#13791)	2022-09-20 09:44:38 +01:00
Eric Eastwood	44be42338e	Add support to purge rows from MSC2716 and other tables when purging a room (#13825) ... `event_failed_pull_attempts` added in https://github.com/matrix-org/synapse/pull/13589 MSC2716 related tables added in: - https://github.com/matrix-org/synapse/pull/10245/files#diff-3d42dfb44d02f7de3aada105e0bdc1cc9dd7f953cbf0f36c5d0f50827bf0320aR1 - Renamed in https://github.com/matrix-org/synapse/pull/10838/files#diff-2730bfbe9e688b55e46f9371aefe67dac2bd2b2b7d9d6b92774eea1fcfae156dR1 - https://github.com/matrix-org/synapse/pull/10498/files#diff-c52bbfbb5921a3f6f023b24343668479d966fac164f13b7c39d2197ce3afa7a5R1	2022-09-16 10:56:56 -05:00
Mathieu Velten	d5292b8017	Fix Docker build when Rust .so has been build locally first (#13811) ... Signed-off-by: Mathieu Velten <mathieuv@matrix.org>	2022-09-16 15:38:54 +00:00
David Robertson	642c4b253d	Compare ported to unported PG schemas in portdb test job (#13808)	2022-09-16 16:25:54 +01:00
David Robertson	5e84461653	Minor speedups to CI linting (#13827)	2022-09-16 16:18:32 +01:00
Sean Quah	d64e85197a	Remove error spam when users query the keys of departed remote users (#13826) ... The error message introduced in #13749 has turned out to be very spammy. Remove it for now.	2022-09-16 16:16:05 +01:00
Mathieu Velten	384dca53d6	complement: init postgres DB directly inside the target image (#13819) ... Doing so in the base postgres image doesn't work with buildah because changes in a declared VOLUME in the Dockerfile is supposed to be discarded, cf https://docs.docker.com/engine/reference/builder/#volume Signed-off-by: Mathieu Velten <mathieuv@matrix.org>	2022-09-16 17:12:45 +02:00
Quentin Gliech	74f60cec92	Add an admin API endpoint to find a user based on its external ID in an auth provider. (#13810)	2022-09-16 12:29:03 +00:00
reivilibre	f7a77ad717	Update request log format documentation to mention the format used when the authenticated user is controlling another user. (#13794)	2022-09-16 11:48:41 +00:00
Sean Quah	b73cbb8215	Avoid putting rejected events in room state (#13723) ... Signed-off-by: Sean Quah <seanq@matrix.org>	2022-09-16 12:45:04 +01:00
Eric Eastwood	6986bcbf39	Document common fix of Poetry problems by removing egg-info (#13785) ... `matrix_synapse.egg-info/` Mentioned at https://matrix.to/#/!vcyiEtMVHIhWXcJAfl:sw1v.org/$aKy_IjrKwb70aTVZWeW_6zt0k7OIZ1YkyZpkP9uiRaM?via=matrix.org&via=element.io&via=beeper.com and many other places.	2022-09-15 16:28:03 -05:00
Eric Eastwood	5093cbf88d	Be able to correlate timeouts in reverse-proxy layer in front of Synapse (pull request ID from header) (#13801) ... Fix https://github.com/matrix-org/synapse/issues/13685 New config: ```diff listeners: - port: 8008 tls: false type: http x_forwarded: true + request_id_header: "cf-ray" bind_addresses: ['::1', '127.0.0.1', '0.0.0.0'] ```	2022-09-15 15:32:25 -05:00
Eric Eastwood	140af0cdb6	Record any exception when processing a pulled event (#13814) ... Part of https://github.com/matrix-org/synapse/issues/13700 and https://github.com/matrix-org/synapse/issues/13356 Follow-up to https://github.com/matrix-org/synapse/pull/13589	2022-09-15 14:40:49 -05:00
Patrick Cloke	b2b0c85279	Support providing an index predicate for upserts. (#13822) ... This is useful to upsert against a table which has a unique partial index while avoiding conflicts.	2022-09-15 18:28:48 +00:00
David Robertson	742f9f9d78	A third batch of Pydantic validation for rest/client/account.py (#13736)	2022-09-15 18:36:02 +01:00
Andrew Morgan	918c74bfb5	Add a MXCUri class to make working with mxc uri's easier. (#13162)	2022-09-15 12:57:16 +00:00
Eric Eastwood	957e3d74fc	Keep track when we try and fail to process a pulled event (#13589) ... We can follow-up this PR with: 1. Only try to backfill from an event if we haven't tried recently -> https://github.com/matrix-org/synapse/issues/13622 1. When we decide to backfill that event again, process it in the background so it doesn't block and make `/messages` slow when we know it will probably fail again -> https://github.com/matrix-org/synapse/issues/13623 1. Generally track failures everywhere we try and fail to pull an event over federation -> https://github.com/matrix-org/synapse/issues/13700 Fix https://github.com/matrix-org/synapse/issues/13621 Part of https://github.com/matrix-org/synapse/issues/13356 Mentioned in [internal doc](https://docs.google.com/document/d/1lvUoVfYUiy6UaHB6Rb4HicjaJAU40-APue9Q4vzuW3c/edit#bookmark=id.qv7cj51sv9i5)	2022-09-14 13:57:50 -05:00
Patrick Cloke	666ae87729	Update event push action and receipt tables to support threads. (#13753) ... Adds a `thread_id` column to the `event_push_actions`, `event_push_actions_staging`, and `event_push_summary` tables. This will notifications to be segmented by the thread in a future pull request. The `thread_id` column stores the root event ID or the special value `"main"`. The `thread_id` column for `event_push_actions` and `event_push_summary` is backfilled with `"main"` for all existing rows. New entries into `event_push_actions` and `event_push_actions_staging` will get the proper thread ID. `receipts_linearized` and `receipts_graph` also gain a `thread_id` column, which is similar, except `NULL` is a special value meaning the receipt is "unthreaded". See MSC3771 and MSC3773 for where this data will be useful.	2022-09-14 17:11:16 +00:00
Patrick Cloke	f2d12ccabe	Use partial indices on SQLIte. (#13802) ... Partial indices have been supported since SQLite 3.8, but Synapse now requires >= 3.27, so we can enable support for them. This requires rebuilding previous indices which were partial on PostgreSQL, but not on SQLite.	2022-09-14 12:01:42 -04:00
reivilibre	6302753012	Deduplicate is_server_notices_room. (#13780)	2022-09-14 15:53:18 +00:00
reivilibre	cf65433de2	Fix a memory leak when running the unit tests. (#13798)	2022-09-14 15:29:05 +00:00
Quentin Gliech	eaed4e6113	Remove unused method in synapse.api.auth.Auth. (#13795) ... Clean-up from b19060a29b (#13094) and 73af10f419 (#13093) which removed all callers.	2022-09-14 10:33:54 -04:00
David Robertson	51a77e990b	Remove incorrect migration file from state logical DB (#13788) ... * Remove incorrect migration file from `state` logical DB The table `ex_outlier_stream` is part of the `main` logical DB; it should not have been created in the `state` logical DB. We remove this migration now as a tidy-up. Note: we cannot `DROP TABLE IF EXISTS ex_outlier_stream` in a new migration, because some (most) instances of Synapse host both of these logical DBs on the same DB cluster. * Changelog	2022-09-14 14:16:12 +01:00
Sean Quah	c73774467e	Fix bug in device list caching when remote users leave rooms (#13749) ... When a remote user leaves the last room shared with the homeserver, we have to mark their device list as unsubscribed, otherwise we would hold on to a stale device list in our cache. Crucially, the device list would remain cached even after the remote user rejoined the room, which could lead to E2EE failures until the next change to the remote user's device list. Fixes #13651. Signed-off-by: Sean Quah <seanq@matrix.org>	2022-09-14 10:42:57 +01:00
reivilibre	21687ec189	Fix a long-standing spec compliance bug where Synapse would accept a trailing slash on the end of /get_missing_events federation requests. (#13789) ... * Don't accept a trailing slash on the end of /get_missing_events * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>	2022-09-14 09:28:12 +01:00
Mathieu Velten	12dacecabd	Make sequence cache_invalidation_stream_seq begin at 2 (#13766) ... Signed-off-by: Mathieu Velten <mathieuv@matrix.org> Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-09-13 16:14:28 +02:00
Erik Johnston	9772e362aa	Merge branch 'master' into develop	2022-09-13 12:11:53 +01:00
David Robertson	b60d47ab2c	Updates to the schema dump script (#13770)	2022-09-13 10:53:11 +01:00
David Robertson	540afb0bfc	Simplify CI tests DAG (#13784) ... * Simplify CI tests DAG * Changelog	2022-09-13 10:17:23 +01:00
Richard van der Hoff	41df25bbbd	installation.md: require libpq on M1 macs (#13480)	2022-09-13 09:01:21 +00:00
Nick Mills-Barrett	cdbb641232	Add receipts event stream ordering (#13703)	2022-09-13 08:16:37 +01:00
Mathieu Velten	fa2f3d8d0c	Fix GHA skippable syntax (#13778) ... Signed-off-by: Mathieu Velten <mathieuv@matrix.org>	2022-09-12 17:31:23 +00:00
Brendan Abolivier	7571337445	Fix typo in ratelimiting documentation (#13727)	2022-09-12 14:11:18 +01:00
Erik Johnston	dd7484b562	Fix CI on non-PR builds (#13769) ... Mark cargo-test as skippable since it only runs on Rust code change.	2022-09-12 13:26:33 +01:00
Nick Mills-Barrett	da41a7cd61	Remove check current state membership up to date (#13745) ... * Remove checks for membership column in current_state_events * Add schema script to force through the `current_state_events_membership` background job Contributed by Nick @ Beeper (@fizzadar).	2022-09-12 12:58:33 +01:00
Erik Johnston	ebfeac7c5d	Check if Rust lib needs rebuilding. (#13759) ... This protects against the common mistake of failing to remember to rebuild Rust code after making changes.	2022-09-12 10:03:42 +00:00
Nick Mills-Barrett	4c4889cac0	Concurrently collect room unread counts for push badges (#13765) ... Most of the time this function is heavily cached, but when that isn't the case fetching the counts room by room slows down push delivery on users with many (thousands) of rooms. Signed off by Nick @ Beeper.	2022-09-09 19:00:21 +01:00
Eric Eastwood	a911ffb42c	Tag trace with instance name (#13761) ... We tag the Synapse instance name so that it's an easy jumping off point into the logs. Can also be used to filter for an instance that is under load. As suggested by @clokep and @reivilibre in, - https://github.com/matrix-org/synapse/pull/13729#discussion_r964719258 - https://github.com/matrix-org/synapse/pull/13729#discussion_r964733578	2022-09-09 11:31:37 -05:00
Eric Eastwood	f694bb71b7	Strip number suffix from instance name to consolidate services that traces are spread over (#13729) ... The problem with many services is that it makes it hard to find which service has the trace you want, see https://github.com/jaegertracing/jaeger-ui/issues/985 Previously, we split traces out into services based on their instance name like `matrix.org client_reader-1`, etc but there are many worker instances of the same `client_reader` so there is a lot to click through. With this PR, all of the traces are just collected under the worker type like `client_reader`, `event_persister` 😇 Note: A Synapse worker instance name is an opaque string with the number convention only being our own thing for the `matrix.org` deployment. But seems pretty sensible to group things this way.	2022-09-09 11:30:06 -05:00
Patrick Cloke	3d9f82efcb	Use an upsert for receipts_graph. (#13752) ... Instead of a delete, then insert. This was previously done for `receipts_linearized` in 2dc430d36e (#7607).	2022-09-09 07:08:41 -04:00
Erik Johnston	c85c5ace52	Add rust to CI (#13763)	2022-09-09 11:29:04 +01:00
David Robertson	f2d2481e56	Require SQLite >= 3.27.0 (#13760)	2022-09-09 11:14:10 +01:00
Sean Quah	69fa29700e	Re-type hint some collections in /sync code as read-only (#13754) ... Signed-off-by: Sean Quah <seanq@matrix.org>	2022-09-08 20:13:39 +01:00
reivilibre	5261d2e2e8	Remove unused Prometheus recording rules from synapse-v2.rules and add comments describing where the rest are used. (#13756)	2022-09-08 17:50:15 +00:00
Dirk Klimpel	f799eac7ea	Add timestamp to user's consent (#13741) ... Co-authored-by: reivilibre <olivier@librepush.net>	2022-09-08 15:41:48 +00:00
Sean Quah	906cead9ca	Update docstrings to explain the impact of partial state (#13750) ... Update the docstrings for `get_users_in_room` and `get_current_hosts_in_room` to explain the impact of partial state. Signed-off-by: Sean Quah <seanq@matrix.org>	2022-09-08 15:55:29 +01:00
Sean Quah	89e8b98b65	Avoid raising errors due to malformed IDs in get_current_hosts_in_room (#13748) ... Handle malformed user IDs with no colons in `get_current_hosts_in_room`. It's not currently possible for a malformed user ID to join a room, so this error would never be hit. Signed-off-by: Sean Quah <seanq@matrix.org>	2022-09-08 15:55:03 +01:00
Sean Quah	8ef0c8ff14	Fix error in is_mine_id when encountering a malformed ID (#13746) ... Previously, `is_mine_id` would raise an exception when passed an ID with no colons. Return `False` instead. Fixes #13040. Signed-off-by: Sean Quah <seanq@matrix.org>	2022-09-08 15:54:36 +01:00
reivilibre	cf11919ddd	Fix cache metrics not being updated when not using the legacy exposition module. (#13717)	2022-09-08 15:30:48 +01:00
reivilibre	526f84bc2e	Fix Prometheus recording rules to not use legacy metric names. (#13718)	2022-09-08 15:01:42 +01:00
Erik Johnston	1cc729c177	Fix latest deps (#13743)	2022-09-08 13:58:31 +01:00
reivilibre	b7e4bfd005	Fix a bug where Synapse fails to start if a signing key file contains an empty line. (#13738)	2022-09-08 11:18:03 +01:00
Eric Eastwood	d4d3249ded	Instrument get_metadata_for_events for tracing (#13730) ... When backfilling, `_get_state_ids_after_missing_prev_event` calls [`get_metadata_for_events`](26bc26586b/synapse/handlers/federation_event.py (L1133)). For `#matrix:matrix.org`, it's called with 77k `state_events` which means 77 calls to the database and takes 28 seconds.	2022-09-07 11:41:52 -05:00
Erik Johnston	8d7fcf9b76	Fix latest deps CI (#13734)	2022-09-07 14:07:06 +00:00
Erik Johnston	dc0e896b68	Add some rust caching to CI (#13735)	2022-09-07 13:56:59 +00:00
David Robertson	c46fecd1f2	Correct out-of-date doc for event_cache_size (#13726)	2022-09-07 14:46:11 +01:00
David Robertson	77f3986451	Define SQLite compat policy (#13728)	2022-09-07 12:07:42 +00:00
David Robertson	b58386e37e	A second batch of Pydantic models for rest/client/account.py (#13687)	2022-09-07 12:16:10 +01:00
reivilibre	d3d9ca156e	Cancel the processing of key query requests when they time out. (#13680)	2022-09-07 12:03:32 +01:00
reivilibre	c2fe48a6ff	Rename the EventFormatVersions enum values so that they line up with room version numbers. (#13706)	2022-09-07 11:08:20 +01:00
Connor Davis	bb5b47b62a	Add Admin API to Fetch Messages Within a Particular Window (#13672) ... This adds two new admin APIs that allow us to fetch messages from a room within a particular time.	2022-09-07 10:54:44 +01:00
reivilibre	26bc26586b	Remove the unspecced room_id field in the /hierarchy response. (#13506) ... This is a re-do of 57d334a13d (#13365), which was backed out in 12abd72497 (#13501). The `room_id` field represented the parent space for each room and was made redundant by changes in the API shape where the `children_state` is now nested underneath each `room`. The room ID of each child is in the `state_key` field and is still available.	2022-09-06 15:28:44 -04:00
Erik Johnston	c9b7e97355	Add a stub Rust crate (#12595)	2022-09-06 19:01:37 +01:00
Erik Johnston	3d20115115	Fix trial-olddeps (#13725)	2022-09-06 14:21:55 +00:00
David Robertson	a4ecb8e353	Actually fix typechecking with latest types-jsonschema (#13724)	2022-09-06 14:29:16 +01:00
Erik Johnston	b5effc7201	Update trial old deps CI to use poetry 1.2.0 (#13707)	2022-09-06 11:43:04 +00:00
reivilibre	b455c2a5ec	Update Grafana dashboard to not use legacy metric names. (#13714)	2022-09-06 12:21:21 +01:00
Erik Johnston	cdf7fb737b	1.67.0rc1	2022-09-06 09:01:26 +01:00
Patrick Cloke	32fc3b7ba4	Remove configuration options for direct TCP replication. (#13647) ... Removes the ability to configure legacy direct TCP replication. Workers now require Redis to run.	2022-09-06 07:50:02 +00:00
Erik Johnston	8edf3f66d5	Reduce number of CI jobs run on PRs (#13713) ... * Reduce number of CI jobs run on PRs * Newsfile * Also limit sytest jobs * Fix typo * Fix up * Fixup	2022-09-05 13:31:42 +01:00
reivilibre	c7b18d9d44	Extend the release script to wait for GitHub Actions to finish and to be usable as a guide for the whole process. (#13483)	2022-09-05 12:16:59 +01:00
David Robertson	8cb9261598	Fix typechecking with latest types-jsonschema (#13712)	2022-09-05 11:13:13 +00:00
Brendan Abolivier	898fef2789	Share some metrics between the Prometheus exporter and the phone home stats (#13671)	2022-09-05 10:26:43 +00:00
Eric Eastwood	877bdfa889	Clarify (room_id, event_id) global uniqueness (#13701) ... Summarized from @richvdh's reply at https://github.com/matrix-org/synapse/pull/13589#discussion_r961116999	2022-09-02 14:05:39 -05:00
Eric Eastwood	36b184b782	Update docs to make enabling metrics more clear (#13678) ... It was really easy to miss the `enable_metrics: True` step with the previous language.	2022-09-02 11:29:51 -05:00
Erik Johnston	4fee4a339d	Update lock file for Poetry v1.2.0 (#13689)	2022-09-02 13:20:03 +00:00
Erik Johnston	0fdb685c2b	Only run trial CI on all python versions on non-PRs (#13698)	2022-09-02 13:12:47 +01:00
Dirk Klimpel	044900af6c	Fix two typos with colon in headlines (#13665)	2022-09-01 20:38:37 +00:00
Patrick Cloke	48a5c47a9f	Add a schema delta to drop unstable private read receipts. (#13692) ... Otherwise they'll be leaked due to the filtering code only respecting the stable identifiers for private read receipts.	2022-09-01 14:57:47 -04:00
Patrick Cloke	390b7ce946	Disable calculating unread counts unless the config flag is enabled. (#13694) ... This avoids doing work that will never be used (since the resulting unread counts will never be sent in a /sync response). The negative of doing this is that unread counts will be incorrect when the feature is initially enabled.	2022-09-01 16:52:03 +00:00
reivilibre	f48f4dd59e	Update the Grafana dashboard that is included with Synapse in the contrib directory. (#13697) ... * Add missing graph to contrib * Update with minor but plausible changes, including positioning changes * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org> Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>	2022-09-01 16:27:06 +01:00
Erik Johnston	9d2823ab70	Cache is_partial_state_room (#13693) ... Fixes #13613.	2022-09-01 16:07:01 +01:00
Will Hunt	c913e440c0	Add monthly active users documentation (#13617) ... * Add monthly active users documentation * changelog * Tidy up notes * more tidyup * Rewrite #1 * link back to mau docs * fix links * s/appservice|AS/application service * further review * a newline * Remove bit about shadow banned users. I think talking about them is confusing, and the current text doesn't imply they get any special treatment. * Update docs/usage/administration/monthly_active_users.md Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Update docs/usage/administration/monthly_active_users.md Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-09-01 14:48:43 +00:00
Erik Johnston	2318603772	Add some logging to help track down #13444 (#13679)	2022-09-01 13:54:52 +01:00
Richard van der Hoff	e8130f219b	Return keys for unwhitelisted servers from /_matrix/key/v2/query (#13683)	2022-09-01 13:54:02 +01:00
Erik Johnston	18e4092801	Bump docker image to use stable poetry version (#13688)	2022-09-01 13:46:47 +01:00
Šimon Brandner	0e99f07952	Remove support for unstable private read receipts (#13653) ... Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>	2022-09-01 13:31:54 +01:00
Jacek Kuśnierz	84ddcd7bbf	Drop support for calling /_matrix/client/v3/rooms/{roomId}/invite without an id_access_token (#13241) ... Fixes #13206 Signed-off-by: Jacek Kusnierz jacek.kusnierz@tum.de	2022-08-31 12:10:25 +00:00
Nick Mills-Barrett	42b11d5565	Remove cached wrap on _get_joined_users_from_context method (#13569) ... The method doesn't actually do any data fetching and the method that does, `_get_joined_profile_from_event_id`, has its own cache. Signed off by Nick @ Beeper (@Fizzadar).	2022-08-31 12:19:39 +01:00
reivilibre	7bc110a19e	Generalise the @cancellable annotation so it can be used on functions other than just servlet methods. (#13662)	2022-08-31 11:16:05 +00:00
David Robertson	a160406d24	Fix admin List Room API return type on sqlite (#13509)	2022-08-31 10:38:16 +00:00
Eric Eastwood	92c5817e34	Give the correct next event when the message timestamps are the same - MSC3030 (#13658) ... Discovered while working on https://github.com/matrix-org/synapse/pull/13589 and I had all the messages at the same timestamp in the tests. Part of https://github.com/matrix-org/matrix-spec-proposals/pull/3030 Complement tests: https://github.com/matrix-org/complement/pull/457	2022-08-30 14:50:06 -05:00
Shay	20c76cecb9	Drop unused column application_services_state.last_txn (#13627)	2022-08-30 10:29:16 -07:00
Richard van der Hoff	372136d3a8	Remove documentation of legacy frontend_proxy worker app (#13645) ... This has been the same as a generic_worker since #6964, so let's get rid of it. Fixes #3717	2022-08-30 18:01:51 +01:00
Patrick Cloke	e761e8b475	Clarify documentation about replication traffic. (#13656) ... It can be authenticated with the worker_replication_secret setting, but is always unencrypted.	2022-08-30 12:21:19 +00:00
Erik Johnston	1c26acd815	Fix bug where we wedge media plugins if clients disconnect early (#13660) ... We incorrectly didn't use the returned `Responder` if the client had disconnected, which meant that the resource used by the Responder wasn't correctly released. In particular, this exhausted the thread pools so that *all* requests timed out.	2022-08-30 12:17:48 +01:00
Patrick Cloke	303b40b988	Do not wait for background updates to complete do expire URL cache. (#13657) ... Media downloaded as part of a URL preview is normally deleted after two days. However, while a background database migration is running, the process is stopped. A long-running database migration can therefore cause the media store to fill up with old preview files. This logic was added in #2697 to make sure that we didn't try to run the expiry without an index on `local_media_repository.created_ts`; the original logic that needs that index was added in #2478 (in `get_url_cache_media_before`, as amended by 93247a424a), and is still present. Given that the background update was added before Synapse v1.0.0, just drop this check and assume the index exists.	2022-08-30 07:15:54 -04:00
Patrick Cloke	20df96a7a7	Speed up inserting event_push_actions_staging. (#13634) ... By using `execute_values` instead of `execute_batch`.	2022-08-30 07:12:48 -04:00
Dirk Klimpel	682dfcfc0d	Fix that user cannot /forget rooms after the last member has left (#13546)	2022-08-30 09:58:38 +00:00
Eric Eastwood	51d732db3b	Optimize how we calculate likely_domains during backfill (#13575) ... Optimize how we calculate `likely_domains` during backfill because I've seen this take 17s in production just to `get_current_state` which is used to `get_domains_from_state` (see case [*2. Loading tons of events* in the `/messages` investigation issue](https://github.com/matrix-org/synapse/issues/13356)). There are 3 ways we currently calculate hosts that are in the room: 1. `get_current_state` -> `get_domains_from_state` - Used in `backfill` to calculate `likely_domains` and `/timestamp_to_event` because it was cargo-culted from `backfill` - This one is being eliminated in favor of `get_current_hosts_in_room` in this PR 🕳 1. `get_current_hosts_in_room` - Used for other federation things like sending read receipts and typing indicators 1. `get_hosts_in_room_at_events` - Used when pushing out events over federation to other servers in the `_process_event_queue_loop` Fix https://github.com/matrix-org/synapse/issues/13626 Part of https://github.com/matrix-org/synapse/issues/13356 Mentioned in [internal doc](https://docs.google.com/document/d/1lvUoVfYUiy6UaHB6Rb4HicjaJAU40-APue9Q4vzuW3c/edit#bookmark=id.2tvwz3yhcafh) ### Query performance #### Before The query from `get_current_state` sucks just because we have to get all 80k events. And we see almost the exact same performance locally trying to get all of these events (16s vs 17s): ``` synapse=# SELECT type, state_key, event_id FROM current_state_events WHERE room_id = '!OGEhHVWSdvArJzumhm:matrix.org'; Time: 16035.612 ms (00:16.036) synapse=# SELECT type, state_key, event_id FROM current_state_events WHERE room_id = '!OGEhHVWSdvArJzumhm:matrix.org'; Time: 4243.237 ms (00:04.243) ``` But what about `get_current_hosts_in_room`: When there is 8M rows in the `current_state_events` table, the previous query in `get_current_hosts_in_room` took 13s from complete freshness (when the events were first added). But takes 930ms after a Postgres restart or 390ms if running back to back to back. ```sh $ psql synapse synapse=# \timing on synapse=# SELECT COUNT(DISTINCT substring(state_key FROM '@[^:]*:(.*)$')) FROM current_state_events WHERE type = 'm.room.member' AND membership = 'join' AND room_id = '!OGEhHVWSdvArJzumhm:matrix.org'; count ------- 4130 (1 row) Time: 13181.598 ms (00:13.182) synapse=# SELECT COUNT(*) from current_state_events where room_id = '!OGEhHVWSdvArJzumhm:matrix.org'; count ------- 80814 synapse=# SELECT COUNT(*) from current_state_events; count --------- 8162847 synapse=# SELECT pg_size_pretty( pg_total_relation_size('current_state_events') ); pg_size_pretty ---------------- 4702 MB ``` #### After I'm not sure how long it takes from complete freshness as I only really get that opportunity once (maybe restarting computer but that's cumbersome) and it's not really relevant to normal operating times. Maybe you get closer to the fresh times the more access variability there is so that Postgres caches aren't as exact. Update: The longest I've seen this run for is 6.4s and 4.5s after a computer restart. After a Postgres restart, it takes 330ms and running back to back takes 260ms. ```sh $ psql synapse synapse=# \timing on Timing is on. synapse=# SELECT substring(c.state_key FROM '@[^:]*:(.*)$') as host FROM current_state_events c /* Get the depth of the event from the events table */ INNER JOIN events AS e USING (event_id) WHERE c.type = 'm.room.member' AND c.membership = 'join' AND c.room_id = '!OGEhHVWSdvArJzumhm:matrix.org' GROUP BY host ORDER BY min(e.depth) ASC; Time: 333.800 ms ``` #### Going further To improve things further we could add a `limit` parameter to `get_current_hosts_in_room`. Realistically, we don't need 4k domains to choose from because there is no way we're going to query that many before we a) probably get an answer or b) we give up. Another thing we can do is optimize the query to use a index skip scan: - https://wiki.postgresql.org/wiki/Loose_indexscan - Index Skip Scan, https://commitfest.postgresql.org/37/1741/ - https://www.timescale.com/blog/how-we-made-distinct-queries-up-to-8000x-faster-on-postgresql/	2022-08-30 01:38:14 -05:00
Richard van der Hoff	4f6de33f41	Print complement failure results last (#13639) ... Since github always scrolls to the bottom of any test output, let's put the failed tests last and hide any successful packages.	2022-08-28 20:05:30 +00:00
Richard van der Hoff	c4e29b6908	Improve documentation around user registration (#13640) ... Update a bunch of the documentation for user registration, add some cross links, etc.	2022-08-26 13:29:31 +00:00
Richard van der Hoff	5e5c8150d7	Generate missing configuration files at startup (#13615) ... If things like the signing key file are missing, let's just try to generate them on startup. Again, this is useful for k8s-like deployments where we just want to generate keys on the first run.	2022-08-26 11:26:06 +00:00
Brad Murray	967d7bad6c	Move the execution of the retention purge_jobs to the main worker (#13632) ... Fixes #9927 Signed-off-by: Brad Murray brad@beeper.com	2022-08-26 08:38:10 +01:00
Richard van der Hoff	d092e6f32a	Support registration_shared_secret in a file (#13614) ... A new `registration_shared_secret_path` option. This is kinda handy for k8s deployments and things.	2022-08-25 16:27:46 +00:00
Richard van der Hoff	a2ce614447	register_new_matrix_user: read server url from config (#13616) ... Fixes https://github.com/matrix-org/synapse/issues/3672: `https://localhost:8448` is virtually never right.	2022-08-25 15:29:08 +01:00
Eric Eastwood	0bf180cbb4	Comment about a better future where we can get the state diff between two events (#13586) ... Split off from https://github.com/matrix-org/synapse/pull/13561 Part of https://github.com/matrix-org/synapse/issues/13356 Mentioned in [internal doc](https://docs.google.com/document/d/1lvUoVfYUiy6UaHB6Rb4HicjaJAU40-APue9Q4vzuW3c/edit#bookmark=id.2tvwz3yhcafh)	2022-08-24 18:59:27 -05:00
David Robertson	c406d50d2d	Rename event_map to unpersisted_events (#13603)	2022-08-24 21:06:31 +01:00
Eric Eastwood	1a209efdb2	Update get_users_in_room mis-use to get hosts with dedicated get_current_hosts_in_room (#13605) ... See https://github.com/matrix-org/synapse/pull/13575#discussion_r953023755	2022-08-24 14:15:37 -05:00
Eric Eastwood	d58615c82c	Directly lookup local membership instead of getting all members in a room first (get_users_in_room mis-use) (#13608) ... See https://github.com/matrix-org/synapse/pull/13575#discussion_r953023755	2022-08-24 14:13:12 -05:00
Eric Eastwood	b93bd95e8a	When loading current ids, sort by stream_id to avoid incorrect overwrite and avoid errors caused by sorting alphabetical instance name which can be null (#13585) ... When loading current ids, sort by stream ID so that we don't want to overwrite the `current_position` of an instance to a lower stream ID than we're actually at ([discussion](https://github.com/matrix-org/synapse/pull/13585#discussion_r951795379)). Previously, it sorted alphabetically by instance name which can be `null` and throw errors but more importantly, accomplishes nothing. Fixes the following startup error which is why I started looking into this area: ``` $ poetry run synapse_homeserver --config-path homeserver.yaml **************************************************************** Error during initialisation: '<' not supported between instances of 'NoneType' and 'str' There may be more information in the logs. **************************************************************** ``` Somehow my database ended up looking like the following, notice the `instance_name` is `null` in the db, and we can't sort `NoneType` things. Another question is why do we see the `instance_name` as `null` sometimes instead of `master` in monolith mode? ``` $ psql synapse synapse=# SELECT * FROM stream_positions; stream_name | instance_name | stream_id -----------------+---------------+----------- account_data | master | 1242 events | master | 1787 to_device | master | 58 presence_stream | master | 485638 receipts | master | 341 backfill | master | -139106 (6 rows) synapse=# SELECT instance_name, stream_id FROM receipts_linearized; instance_name | stream_id ---------------+----------- | 211 | 3 | 4 | 212 | 213 | 224 | 228 | 164 | 313 | 253 | 38 | 321 | 324 | 189 | 192 | 193 | 194 | 195 | 197 | 198 | 275 | 79 | 339 | 340 | 82 | 341 | 84 | 85 | 91 | 119 ```	2022-08-24 12:53:46 -05:00
Eric Eastwood	c807b814ae	Use dedicated get_local_users_in_room to find local users when calculating join_authorised_via_users_server of a /make_join request (#13606) ... Use dedicated `get_local_users_in_room` to find local users when calculating `join_authorised_via_users_server` ("the authorising user for joining a restricted room") of a `/make_join` request. Found while working on https://github.com/matrix-org/synapse/pull/13575#discussion_r953023755 but it's not related.	2022-08-24 11:14:28 -05:00
reivilibre	be4250c7a8	Add experimental configuration option to allow disabling legacy Prometheus metric names. (#13540) ... Co-authored-by: David Robertson <davidr@element.io>	2022-08-24 11:35:54 +00:00
Nick Mills-Barrett	b687010f89	Rewrite get push actions queries (#13597)	2022-08-24 10:12:51 +01:00
reivilibre	ba882c0357	Faster Room Joins: fix /make_knock blocking indefinitely when the room in question is a partial-stated room. (#13583) ... Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-08-24 09:09:59 +00:00
Eric Eastwood	7af07f9716	Instrument _check_sigs_and_hash_and_fetch to trace time spent in child concurrent calls (#13588) ... Instrument `_check_sigs_and_hash_and_fetch` to trace time spent in child concurrent calls because I've see `_check_sigs_and_hash_and_fetch` take [10.41s to process 100 events](https://github.com/matrix-org/synapse/issues/13587) Fix https://github.com/matrix-org/synapse/issues/13587 Part of https://github.com/matrix-org/synapse/issues/13356	2022-08-23 21:53:37 -05:00
David Robertson	a25a37002c	Write about the chain cover a little. (#13602) ... Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-08-23 17:41:55 +00:00
Erik Johnston	f7ddfe17a3	Speed up @cachedList (#13591) ... This speeds things up by ~2x. The vast majority of the time is now spent in `LruCache` moving things around the linked lists. We do this via two things: 1. Don't create a deferred per-key during bulk set operations in `DeferredCache`. Instead, only create them if a subsequent caller asks for the key. 2. Add a bulk lookup API to `DeferredCache` rather than use a loop.	2022-08-23 14:53:27 +00:00
Erik Johnston	05c9c7363b	Fix regression caused by #13573 (#13600) ... Broke in #13573.	2022-08-23 14:14:05 +00:00
David Robertson	ca3d19b05f	Synapse 1.66.0rc1 (2022-08-23) ... ============================== This release removes the ability for homeservers to delegate email ownership verification and password reset confirmation to identity servers. This removal was originally planned for Synapse 1.64, but was later deferred until now. See the [upgrade notes](https://matrix-org.github.io/synapse/v1.66/upgrade.html#upgrading-to-v1660) for more details. Features -------- - Improve validation of request bodies for the following client-server API endpoints: [`/account/password`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3accountpassword), [`/account/password/email/requestToken`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3accountpasswordemailrequesttoken), [`/account/deactivate`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3accountdeactivate) and [`/account/3pid/email/requestToken`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3account3pidemailrequesttoken). ([\#13188](https://github.com/matrix-org/synapse/issues/13188), [\#13563](https://github.com/matrix-org/synapse/issues/13563)) - Add forgotten status to [Room Details Admin API](https://matrix-org.github.io/synapse/latest/admin_api/rooms.html#room-details-api). ([\#13503](https://github.com/matrix-org/synapse/issues/13503)) - Add an experimental implementation for [MSC3852 (Expose user agents on `Device`)](https://github.com/matrix-org/matrix-spec-proposals/pull/3852). ([\#13549](https://github.com/matrix-org/synapse/issues/13549)) - Add `org.matrix.msc2716v4` experimental room version with updated content fields. Part of [MSC2716 (Importing history)](https://github.com/matrix-org/matrix-spec-proposals/pull/2716). ([\#13551](https://github.com/matrix-org/synapse/issues/13551)) - Add support for compression to federation responses. ([\#13537](https://github.com/matrix-org/synapse/issues/13537)) - Improve performance of sending messages in rooms with thousands of local users. ([\#13522](https://github.com/matrix-org/synapse/issues/13522), [\#13547](https://github.com/matrix-org/synapse/issues/13547)) Bugfixes -------- - Faster room joins: make `/joined_members` block whilst the room is partial stated. ([\#13514](https://github.com/matrix-org/synapse/issues/13514)) - Fix a bug introduced in Synapse 1.21.0 where the [`/event_reports` Admin API](https://matrix-org.github.io/synapse/develop/admin_api/event_reports.html) could return a total count which was larger than the number of results you can actually query for. ([\#13525](https://github.com/matrix-org/synapse/issues/13525)) - Fix a bug introduced in Synapse 1.52.0 where sending server notices fails if `max_avatar_size` or `allowed_avatar_mimetypes` is set and not `system_mxid_avatar_url`. ([\#13566](https://github.com/matrix-org/synapse/issues/13566)) - Fix a bug where the `opentracing.force_tracing_for_users` config option would not apply to [`/sendToDevice`](https://spec.matrix.org/v1.3/client-server-api/#put_matrixclientv3sendtodeviceeventtypetxnid) and [`/keys/upload`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3keysupload) requests. ([\#13574](https://github.com/matrix-org/synapse/issues/13574)) Improved Documentation ---------------------- - Add `openssl` example for generating registration HMAC digest. ([\#13472](https://github.com/matrix-org/synapse/issues/13472)) - Tidy up Synapse's README. ([\#13491](https://github.com/matrix-org/synapse/issues/13491)) - Document that event purging related to the `redaction_retention_period` config option is executed only every 5 minutes. ([\#13492](https://github.com/matrix-org/synapse/issues/13492)) - Add a warning to retention documentation regarding the possibility of database corruption. ([\#13497](https://github.com/matrix-org/synapse/issues/13497)) - Document that the `DOCKER_BUILDKIT=1` flag is needed to build the docker image. ([\#13515](https://github.com/matrix-org/synapse/issues/13515)) - Add missing links in `user_consent` section of configuration manual. ([\#13536](https://github.com/matrix-org/synapse/issues/13536)) - Fix the doc and some warnings that were referring to the nonexistent `custom_templates_directory` setting (instead of `custom_template_directory`). ([\#13538](https://github.com/matrix-org/synapse/issues/13538)) Deprecations and Removals ------------------------- - Remove the ability for homeservers to delegate email ownership verification and password reset confirmation to identity servers. See [upgrade notes](https://matrix-org.github.io/synapse/v1.66/upgrade.html#upgrading-to-v1660) for more details. Internal Changes ---------------- - Update the rejected state of events during de-partial-stating. ([\#13459](https://github.com/matrix-org/synapse/issues/13459)) - Avoid blocking lazy-loading `/sync`s during partial joins due to remote memberships. Pull remote memberships from auth events instead of the room state. ([\#13477](https://github.com/matrix-org/synapse/issues/13477)) - Refuse to start when faster joins is enabled on a deployment with workers, since worker configurations are not currently supported. ([\#13531](https://github.com/matrix-org/synapse/issues/13531)) - Allow use of both `@trace` and `@tag_args` stacked on the same function. ([\#13453](https://github.com/matrix-org/synapse/issues/13453)) - Instrument the federation/backfill part of `/messages` for understandable traces in Jaeger. ([\#13489](https://github.com/matrix-org/synapse/issues/13489)) - Instrument `FederationStateIdsServlet` (`/state_ids`) for understandable traces in Jaeger. ([\#13499](https://github.com/matrix-org/synapse/issues/13499), [\#13554](https://github.com/matrix-org/synapse/issues/13554)) - Track HTTP response times over 10 seconds from `/messages` (`synapse_room_message_list_rest_servlet_response_time_seconds`). ([\#13533](https://github.com/matrix-org/synapse/issues/13533)) - Add metrics to track how the rate limiter is affecting requests (sleep/reject). ([\#13534](https://github.com/matrix-org/synapse/issues/13534), [\#13541](https://github.com/matrix-org/synapse/issues/13541)) - Add metrics to time how long it takes us to do backfill processing (`synapse_federation_backfill_processing_before_time_seconds`, `synapse_federation_backfill_processing_after_time_seconds`). ([\#13535](https://github.com/matrix-org/synapse/issues/13535), [\#13584](https://github.com/matrix-org/synapse/issues/13584)) - Add metrics to track rate limiter queue timing (`synapse_rate_limit_queue_wait_time_seconds`). ([\#13544](https://github.com/matrix-org/synapse/issues/13544)) - Update metrics to track `/messages` response time by room size. ([\#13545](https://github.com/matrix-org/synapse/issues/13545)) - Refactor methods in `synapse.api.auth.Auth` to use `Requester` objects everywhere instead of user IDs. ([\#13024](https://github.com/matrix-org/synapse/issues/13024)) - Clean-up tests for notifications. ([\#13471](https://github.com/matrix-org/synapse/issues/13471)) - Add some miscellaneous comments to document sync, especially around `compute_state_delta`. ([\#13474](https://github.com/matrix-org/synapse/issues/13474)) - Use literals in place of `HTTPStatus` constants in tests. ([\#13479](https://github.com/matrix-org/synapse/issues/13479), [\#13488](https://github.com/matrix-org/synapse/issues/13488)) - Add comments about how event push actions are rotated. ([\#13485](https://github.com/matrix-org/synapse/issues/13485)) - Modify HTML template content to better support mobile devices' screen sizes. ([\#13493](https://github.com/matrix-org/synapse/issues/13493)) - Add a linter script which will reject non-strict types in Pydantic models. ([\#13502](https://github.com/matrix-org/synapse/issues/13502)) - Reduce the number of tests using legacy TCP replication. ([\#13543](https://github.com/matrix-org/synapse/issues/13543)) - Allow specifying additional request fields when using the `HomeServerTestCase.login` helper method. ([\#13549](https://github.com/matrix-org/synapse/issues/13549)) - Make `HomeServerTestCase` load any configured homeserver modules automatically. ([\#13558](https://github.com/matrix-org/synapse/issues/13558)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE1508oLYUKainYFJakD7OEIo53t0FAmMExBwACgkQkD7OEIo5 3t0sGA/9FLZLdTWeROLUenbInvz3POqi6DgqlE0f8IDdp3zHjjuDJIE4HZwnPhhj c3H5FcUnTPhQoVZ8Ybno3J3KN8jfpe4tFhnhlM1x9hOi1fujfqCnFd2qWvlzkYXX J4oN6Dz0BbhqdhqnS2tcNacZJOielJ47UtNNBZkzprpzjL3qqRUK3Hm/gGK8GtGN BLon7JK0pKG1GFMVaoIWsr+j7880QD8DGXTjoZrjo/yGdp+zJldwJTbN2ymNdMw1 3Caq7eCk+m6jzCUJxI7tTJVioXvf7+TScIsozAXuQtBy9W1RctvVMMoR9cIlN+JJ dj5GKhKBv8uJpJU6dJnlYpjNC5+5hPHr1gfnkoYbcyFF6PybJrHx9jfhEIEXmI1+ j0DlJJdFnX+eeq4deFd+LPU5hYaF8SkSVRK3G+/NmKI3YYTReD6ootZzV5O4Z9P0 NUwLK/OSMZrsFUfuwysUttfHq0uHGGs7mytlRgeqb/1RKRC80nxVJu3qv/xF6kKj KF98Yr2IDgp/MFhBpGAO3ylNgK8aQ3YxED4qW+kfnDeHPkma5mTdAtJ1bpvKcec+ 3awpFGWcmYVQPflwp9J3HFJHqWkj32LMfuSgDffLs8mWuj87fP7eAdjzv6M4zeAM 4qh+cmvNC7ArfQ+ngz3g+xVD1lHi84s+fMgo7L+ySGfgDqTLhT4= =1F3P -----END PGP SIGNATURE----- gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE1508oLYUKainYFJakD7OEIo53t0FAmMEz10ACgkQkD7OEIo5 3t02GhAApioIpEedKaeSATI42N8rWhfuni3vaPFAXwmOD6BvBkZlP0gcg+vUoBjP I0VIkGWZ3MKIhCSJkjwPJh1vHcpE09KYqIYRKO5vSbqHZKHYUJ+ThjcCR4IkOBPD 3Dc3IRgQaM2Nh8eMcyRY7eyxo+2y+VN2G+SXr1B+A5/4N58ZrxfV97MtLYJ1a6AH 0iIknOxb9FPArYs4ORbk6x2rvRO2QPGh88uKwJ8uHXvHlUbJ3fmHLVvRa1m0RKAW ojkzj/Dysa+4gasMIvtzPePtIQnMyovaQLul+bGXzE0js4lqzSOIP12x1zNpLuuq LSiyD3gMgGeogumhCAU6b23xF6jBaGtgtKKpaYuK8pqkuBTRNN8kQ6LB+7g3WQ2L QWVos+/+wKUEHoVVD/q3u7o4CrKYqv4zE9Pj6kw5e1USOoy7803ub2ccjY1UgG3M mZ7c48WNQQ61o9oH2+9+Ct6bab3R/Lo1MbS3zIKN8uktB4CdrhVAz3kYgV5Bl8bo PsldxUccOTTeS5qmUGvm2/szVKjdqyCWRx9AY9eUH9Kc4u/GzmNq0UVOZF8yxM0q WEo7GFgjM3k9IIC3K/fSmSC1iBjPSHpYvqO+c8oSNnjq2iucZeIhiEB07e89+KSa Wiz9DDWP8Z7W6D9wRAeXyPJFB6ZdSSBgP1I90z6lQjSMzy46Kv4= =pJ2V -----END PGP SIGNATURE----- Merge tag 'v1.66.0rc1' into develop Synapse 1.66.0rc1 (2022-08-23) ============================== This release removes the ability for homeservers to delegate email ownership verification and password reset confirmation to identity servers. This removal was originally planned for Synapse 1.64, but was later deferred until now. See the [upgrade notes](https://matrix-org.github.io/synapse/v1.66/upgrade.html#upgrading-to-v1660) for more details. Features -------- - Improve validation of request bodies for the following client-server API endpoints: [`/account/password`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3accountpassword), [`/account/password/email/requestToken`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3accountpasswordemailrequesttoken), [`/account/deactivate`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3accountdeactivate) and [`/account/3pid/email/requestToken`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3account3pidemailrequesttoken). ([\#13188](https://github.com/matrix-org/synapse/issues/13188), [\#13563](https://github.com/matrix-org/synapse/issues/13563)) - Add forgotten status to [Room Details Admin API](https://matrix-org.github.io/synapse/latest/admin_api/rooms.html#room-details-api). ([\#13503](https://github.com/matrix-org/synapse/issues/13503)) - Add an experimental implementation for [MSC3852 (Expose user agents on `Device`)](https://github.com/matrix-org/matrix-spec-proposals/pull/3852). ([\#13549](https://github.com/matrix-org/synapse/issues/13549)) - Add `org.matrix.msc2716v4` experimental room version with updated content fields. Part of [MSC2716 (Importing history)](https://github.com/matrix-org/matrix-spec-proposals/pull/2716). ([\#13551](https://github.com/matrix-org/synapse/issues/13551)) - Add support for compression to federation responses. ([\#13537](https://github.com/matrix-org/synapse/issues/13537)) - Improve performance of sending messages in rooms with thousands of local users. ([\#13522](https://github.com/matrix-org/synapse/issues/13522), [\#13547](https://github.com/matrix-org/synapse/issues/13547)) Bugfixes -------- - Faster room joins: make `/joined_members` block whilst the room is partial stated. ([\#13514](https://github.com/matrix-org/synapse/issues/13514)) - Fix a bug introduced in Synapse 1.21.0 where the [`/event_reports` Admin API](https://matrix-org.github.io/synapse/develop/admin_api/event_reports.html) could return a total count which was larger than the number of results you can actually query for. ([\#13525](https://github.com/matrix-org/synapse/issues/13525)) - Fix a bug introduced in Synapse 1.52.0 where sending server notices fails if `max_avatar_size` or `allowed_avatar_mimetypes` is set and not `system_mxid_avatar_url`. ([\#13566](https://github.com/matrix-org/synapse/issues/13566)) - Fix a bug where the `opentracing.force_tracing_for_users` config option would not apply to [`/sendToDevice`](https://spec.matrix.org/v1.3/client-server-api/#put_matrixclientv3sendtodeviceeventtypetxnid) and [`/keys/upload`](https://spec.matrix.org/v1.3/client-server-api/#post_matrixclientv3keysupload) requests. ([\#13574](https://github.com/matrix-org/synapse/issues/13574)) Improved Documentation ---------------------- - Add `openssl` example for generating registration HMAC digest. ([\#13472](https://github.com/matrix-org/synapse/issues/13472)) - Tidy up Synapse's README. ([\#13491](https://github.com/matrix-org/synapse/issues/13491)) - Document that event purging related to the `redaction_retention_period` config option is executed only every 5 minutes. ([\#13492](https://github.com/matrix-org/synapse/issues/13492)) - Add a warning to retention documentation regarding the possibility of database corruption. ([\#13497](https://github.com/matrix-org/synapse/issues/13497)) - Document that the `DOCKER_BUILDKIT=1` flag is needed to build the docker image. ([\#13515](https://github.com/matrix-org/synapse/issues/13515)) - Add missing links in `user_consent` section of configuration manual. ([\#13536](https://github.com/matrix-org/synapse/issues/13536)) - Fix the doc and some warnings that were referring to the nonexistent `custom_templates_directory` setting (instead of `custom_template_directory`). ([\#13538](https://github.com/matrix-org/synapse/issues/13538)) Deprecations and Removals ------------------------- - Remove the ability for homeservers to delegate email ownership verification and password reset confirmation to identity servers. See [upgrade notes](https://matrix-org.github.io/synapse/v1.66/upgrade.html#upgrading-to-v1660) for more details. Internal Changes ---------------- - Update the rejected state of events during de-partial-stating. ([\#13459](https://github.com/matrix-org/synapse/issues/13459)) - Avoid blocking lazy-loading `/sync`s during partial joins due to remote memberships. Pull remote memberships from auth events instead of the room state. ([\#13477](https://github.com/matrix-org/synapse/issues/13477)) - Refuse to start when faster joins is enabled on a deployment with workers, since worker configurations are not currently supported. ([\#13531](https://github.com/matrix-org/synapse/issues/13531)) - Allow use of both `@trace` and `@tag_args` stacked on the same function. ([\#13453](https://github.com/matrix-org/synapse/issues/13453)) - Instrument the federation/backfill part of `/messages` for understandable traces in Jaeger. ([\#13489](https://github.com/matrix-org/synapse/issues/13489)) - Instrument `FederationStateIdsServlet` (`/state_ids`) for understandable traces in Jaeger. ([\#13499](https://github.com/matrix-org/synapse/issues/13499), [\#13554](https://github.com/matrix-org/synapse/issues/13554)) - Track HTTP response times over 10 seconds from `/messages` (`synapse_room_message_list_rest_servlet_response_time_seconds`). ([\#13533](https://github.com/matrix-org/synapse/issues/13533)) - Add metrics to track how the rate limiter is affecting requests (sleep/reject). ([\#13534](https://github.com/matrix-org/synapse/issues/13534), [\#13541](https://github.com/matrix-org/synapse/issues/13541)) - Add metrics to time how long it takes us to do backfill processing (`synapse_federation_backfill_processing_before_time_seconds`, `synapse_federation_backfill_processing_after_time_seconds`). ([\#13535](https://github.com/matrix-org/synapse/issues/13535), [\#13584](https://github.com/matrix-org/synapse/issues/13584)) - Add metrics to track rate limiter queue timing (`synapse_rate_limit_queue_wait_time_seconds`). ([\#13544](https://github.com/matrix-org/synapse/issues/13544)) - Update metrics to track `/messages` response time by room size. ([\#13545](https://github.com/matrix-org/synapse/issues/13545)) - Refactor methods in `synapse.api.auth.Auth` to use `Requester` objects everywhere instead of user IDs. ([\#13024](https://github.com/matrix-org/synapse/issues/13024)) - Clean-up tests for notifications. ([\#13471](https://github.com/matrix-org/synapse/issues/13471)) - Add some miscellaneous comments to document sync, especially around `compute_state_delta`. ([\#13474](https://github.com/matrix-org/synapse/issues/13474)) - Use literals in place of `HTTPStatus` constants in tests. ([\#13479](https://github.com/matrix-org/synapse/issues/13479), [\#13488](https://github.com/matrix-org/synapse/issues/13488)) - Add comments about how event push actions are rotated. ([\#13485](https://github.com/matrix-org/synapse/issues/13485)) - Modify HTML template content to better support mobile devices' screen sizes. ([\#13493](https://github.com/matrix-org/synapse/issues/13493)) - Add a linter script which will reject non-strict types in Pydantic models. ([\#13502](https://github.com/matrix-org/synapse/issues/13502)) - Reduce the number of tests using legacy TCP replication. ([\#13543](https://github.com/matrix-org/synapse/issues/13543)) - Allow specifying additional request fields when using the `HomeServerTestCase.login` helper method. ([\#13549](https://github.com/matrix-org/synapse/issues/13549)) - Make `HomeServerTestCase` load any configured homeserver modules automatically. ([\#13558](https://github.com/matrix-org/synapse/issues/13558))	2022-08-23 14:00:09 +01:00
Erik Johnston	aec87a0f93	Speed up fetching large numbers of push rules (#13592)	2022-08-23 13:15:43 +01:00
David Robertson	ea85a2bf6c	Remove manually-added changelog	2022-08-23 12:40:35 +01:00
David Robertson	956e015413	Drop support for delegating email validation, round 2 (#13596)	2022-08-23 11:40:00 +00:00
Nick Mills-Barrett	5e7847dc92	Cache user IDs instead of profile objects (#13573) ... The profile objects are never used and increase cache size significantly.	2022-08-23 09:49:59 +00:00
David Robertson	f0b23927fc	1.66.0rc1	2022-08-23 09:49:51 +01:00
Dirk Klimpel	37f329c9ad	Fix that sending server notices fail if avatar is None (#13566) ... Indroduced in #11846.	2022-08-23 09:48:35 +01:00
Eric Eastwood	9385c41ba4	Fix Prometheus metrics being negative (mixed up start/end) (#13584) ... Fix: - https://github.com/matrix-org/synapse/pull/13535#discussion_r949582508 - https://github.com/matrix-org/synapse/pull/13533#discussion_r949577244	2022-08-23 08:47:30 +01:00
Quentin Gliech	3dd175b628	synapse.api.auth.Auth cleanup: make permission-related methods use Requester instead of the UserID (#13024) ... Part of #13019 This changes all the permission-related methods to rely on the Requester instead of the UserID. This is a first step towards enabling scoped access tokens at some point, since I expect the Requester to have scope-related informations in it. It also changes methods which figure out the user/device/appservice out of the access token to return a Requester instead of something else. This avoids having store-related objects in the methods signatures.	2022-08-22 14:17:59 +01:00
Andrew Morgan	94375f7a91	Remove redundant opentracing spans for /sendToDevice and /keys/upload (#13574)	2022-08-22 10:03:11 +01:00
Eric Eastwood	06df5d4250	MSC2716v4 room version - remove namespace from MSC2716 event content fields (#13551) ... Complement PR: https://github.com/matrix-org/complement/pull/450 As suggested in https://github.com/matrix-org/matrix-spec-proposals/pull/2716#discussion_r941444525	2022-08-19 15:37:01 -05:00
Andrew Morgan	f9f03426de	Implement MSC3852: Expose last_seen_user_agent to users for their own devices; also expose to Admin API (#13549)	2022-08-19 16:17:10 +00:00
Andrew Morgan	40e3e68cd7	Register homeserver modules when creating test homeserver (#13558)	2022-08-19 16:52:20 +01:00
Patrick Cloke	f3fba4914d	Reduce the number of tests using TCP replication. (#13543) ... Uses Redis replication in additional test cases (instead of TCP replication). A small step towards dropping TCP replication.	2022-08-19 08:25:24 -04:00
reivilibre	3a245f6cfe	Fix validation problem that occurs when a user tries to deactivate their account or change their password. (#13563)	2022-08-19 11:03:29 +00:00
Eric Eastwood	2c42673a9b	Add metrics to track /messages response time by room size (#13545) ... Follow-up to https://github.com/matrix-org/synapse/pull/13533 Part of https://github.com/matrix-org/synapse/issues/13356	2022-08-18 14:15:53 -05:00
Sean Quah	b251cff819	Fix incorrect juggling of logging contexts in _PerHostRatelimiter (#13554) ... Signed-off-by: Sean Quah <seanq@matrix.org> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-08-18 16:26:26 +01:00
Eric Eastwood	d64653d062	Track number of hosts affected by the rate limiter (#13541) ... Track number of hosts affected by the rate limiter so we can differentiate one really noisy homeserver from a general ratelimit tuning problem across the federation. Follow-up to https://github.com/matrix-org/synapse/pull/13534 Part of https://github.com/matrix-org/synapse/issues/13356	2022-08-18 10:05:07 -05:00
Ayush Anand	22ea51faf9	Add support for compression to federation responses (#13537) ... Closes #13415. Signed-off-by: Ayush Anand <iamayushanand@gmail.com>	2022-08-18 15:14:47 +01:00
Sean Quah	84169a82dc	Avoid blocking lazy-loading /syncs during partial joins (#13477) ... Use a state filter or accept partial state in a few places where we request state, to avoid blocking. To make lazy-loading `/sync`s work, we need to provide the memberships of event senders, which are not guaranteed to be in the room state. Instead we dig through auth events for memberships to present to clients. The auth events of an event are guaranteed to contain a passable membership event, otherwise the event would have been rejected. Note that this only covers the common code paths encountered during testing. There has been no exhaustive checking of all sync code paths. Fixes #13146. Signed-off-by: Sean Quah <seanq@matrix.org>	2022-08-18 11:53:02 +01:00
Eric Eastwood	49d04e43df	Add metrics to track how the rate limiter is affecting requests (sleep/reject) (#13534) ... Related to https://github.com/matrix-org/synapse/pull/13499 Part of https://github.com/matrix-org/synapse/issues/13356	2022-08-17 16:10:07 -05:00
reivilibre	8bdf2bd31e	Fix a bug in the /event_reports Admin API which meant that the total count could be larger than the number of results you can actually query for. (#13525) ... Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-08-17 18:08:23 +00:00
David Robertson	82a0752f32	A first pass at pruning the Synapse README (#13491)	2022-08-17 16:46:09 +01:00
Erik Johnston	436e0eb39a	Fix breaking event sending due to bad push rule (#13547) ... Broke by #13522 It looks like we have some rules in the DB with a priority class less than 0 that don't override the base rules. Before these were just dropped, but #13522 made that a hard error.	2022-08-17 11:02:38 +00:00
David Robertson	ba8938b090	Reject non-strict types in Pydantic models (#13502)	2022-08-17 11:17:04 +01:00
Antonin Loubiere	b71b41c7bd	Fix a typo in docs and in some warnings (#13538)	2022-08-17 10:59:05 +01:00
Dirk Klimpel	d75512d19e	Add forgotten status to Room Details API (#13503)	2022-08-17 09:42:01 +00:00
Eric Eastwood	c6ee9c0ee4	Add metrics to track rate limiter queue timing (#13544)	2022-08-17 10:38:05 +01:00
Eric Eastwood	088bcb7ecb	Time how long it takes us to do backfill processing (#13535)	2022-08-17 10:33:19 +01:00
Eric Eastwood	2c8cfd6d85	Add specific metric to time long-running /messages requests (#13533)	2022-08-17 10:19:21 +01:00
Eric Eastwood	0a4efbc1dd	Instrument the federation/backfill part of /messages (#13489) ... Instrument the federation/backfill part of `/messages` so it's easier to follow what's going on in Jaeger when viewing a trace. Split out from https://github.com/matrix-org/synapse/pull/13440 Follow-up from https://github.com/matrix-org/synapse/pull/13368 Part of https://github.com/matrix-org/synapse/issues/13356	2022-08-16 12:39:40 -05:00
Sean Quah	f4ab6a4a96	Refuse to start when faster_joins is enabled on a worker deployment (#13531) ... Synapse does not currently support faster room joins on deployments with workers. Signed-off-by: Sean Quah <seanq@matrix.org>	2022-08-16 16:21:55 +01:00
Dirk Klimpel	14e673ef9d	Add missing links in user_consent section of configuration manual (#13536) ... Signed-off-by: Dirk Klimpel <dirk@klimpel.org>	2022-08-16 16:20:56 +01:00
reivilibre	c3516e9dec	Faster room joins: make /joined_members block whilst the room is partial stated. (#13514)	2022-08-16 13:16:56 +01:00
Erik Johnston	5442891cbc	Make push rules use proper structures. (#13522) ... This improves load times for push rules: | Version | Time per user | Time for 1k users | | -------------------- | ------------- | ----------------- | | Before | 138 µs | 138ms | | Now (with custom) | 2.11 µs | 2.11ms | | Now (without custom) | 49.7 ns | 0.05 ms | This therefore has a large impact on send times for rooms with large numbers of local users in the room.	2022-08-16 12:22:17 +01:00
David Robertson	d642ce4b32	Use Pydantic to systematically validate a first batch of endpoints in synapse.rest.client.account. (#13188)	2022-08-15 19:05:57 +00:00
Shay	73c83c6411	Add a warning to retention documentation regarding the possibility of database corruption (#13497)	2022-08-15 11:54:23 -07:00
Eric Eastwood	344a2f767c	Instrument FederationStateIdsServlet - /state_ids (#13499) ... Instrument FederationStateIdsServlet - `/state_ids` so it's easier to follow what's going on in Jaeger when viewing a trace.	2022-08-15 19:41:23 +01:00
David Robertson	19e5d44886	Revert "Update locked versions of mypy and mypy-zope (#13521)" ... This reverts commit f383b9b3ec. Other PRs were seeing mypy failures that looked to be related to mypy-zope. Confusingly, we didn't see this on #13521. Revert this for now and investigate later.	2022-08-15 14:51:05 +01:00
Patrick Cloke	46bd7f4ed9	Clarifications for event push action processing. (#13485) ... * Clarifies comments. * Fixes an erroneous comment (about return type) added in #13455 (ec24813220). * Clarifies the name of a variable. * Simplifies logic of pulling out the latest join for the requesting user.	2022-08-15 09:33:17 -04:00
David Robertson	f383b9b3ec	Update locked versions of mypy and mypy-zope (#13521)	2022-08-15 11:32:30 +01:00
reivilibre	2c5e2ae898	Document that the DOCKER_BUILDKIT=1 flag is needed to build the docker image. (#13515)	2022-08-12 14:25:47 +01:00
James Barton	e825f7366b	Add openssl example for registration HMAC (#13472) ... Signed-off-by: James Barton <james@neodon.com>	2022-08-11 21:10:10 +01:00
Andrew Morgan	953df2ad88	Add note to redaction_retention_period documentation mentioning that event purging runs at most every 5m (#13492)	2022-08-11 14:06:09 +01:00
Germain	4390121684	Add viewport directive to HTML templates to optimise for mobile (#13493)	2022-08-11 14:04:20 +01:00
Richard van der Hoff	507c1cb330	Update the rejected state of events during resync (#13459) ... Events can be un-rejected or newly-rejected during resync, so ensure we update the database and caches when that happens.	2022-08-11 10:42:24 +00:00
Dirk Klimpel	2281427175	Use literals in place of HTTPStatus constants in tests (#13488) ... * Use literals in place of `HTTPStatus` constants in tests * newsfile * code style * code style	2022-08-10 11:01:12 -07:00
Sean Quah	51c01d450a	Add some miscellaneous comments around sync (#13474) ... Add some miscellaneous comments to document sync, especially around `compute_state_delta`. Signed-off-by: Sean Quah <seanq@matrix.org> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-08-10 12:58:20 +01:00
Eric Eastwood	1b09b0832e	Allow use of both @trace and @tag_args stacked on the same function (#13453) ... ```py @trace @tag_args async def get_oldest_event_ids_with_depth_in_room(...) ... ``` Before this PR, you would see a warning in the logs and the span was not exported: ``` 2022-08-03 19:11:59,383 - synapse.logging.opentracing - 835 - ERROR - GET-0 - @trace may not have wrapped EventFederationWorkerStore.get_oldest_event_ids_with_depth_in_room correctly! The function is not async but returned a coroutine. ```	2022-08-09 14:32:33 -05:00
Dirk Klimpel	1595052b26	Use literals in place of HTTPStatus constants in tests (#13479) ... Replace - `HTTPStatus.NOT_FOUND` - `HTTPStatus.FORBIDDEN` - `HTTPStatus.UNAUTHORIZED` - `HTTPStatus.CONFLICT` - `HTTPStatus.CREATED` Signed-off-by: Dirk Klimpel <dirk@klimpel.org>	2022-08-09 14:56:43 +01:00
Olivier Wilkinson (reivilibre)	54fb517c28	Merge branch 'release-v1.65' into develop	2022-08-09 13:45:11 +01:00
Patrick Cloke	5ce2887653	Strengthen tests about deleted old push actions. (#13471)	2022-08-09 07:56:16 -04:00
Olivier Wilkinson (reivilibre)	827f0669bf	1.65.0rc1	2022-08-09 11:43:30 +01:00
Dirk Klimpel	70d3e70009	Make the configuration for the cache clearer (#13481)	2022-08-09 11:30:22 +01:00
Shay	0f954466c4	Update matrix-synapse-ldap3 version in lockfile to v0.2.2. (#13470)	2022-08-08 13:44:43 -07:00
Dirk Klimpel	c97042f7ee	Use literals in place of HTTPStatus constants in tests (#13469)	2022-08-08 13:21:27 -07:00
David Robertson	7a19995120	Correct a misnamed argument in state res v2 (#13467) ... In state res v2, we apply two passes of iterative auth checks. The first pass replays power events and events in their auth chains, but only those belonging to the full conflicted set. The source code as written suggests that we want only those belonging to the auth difference (which is a smaller set of events). At runtime we were doing the correct thing anyway, because the only callsite of `_reverse_topological_power_sort` passes in the `full_conflicted_set`. So this really is just a rename.	2022-08-08 16:59:56 +01:00
Šimon Brandner	ab18441573	Support stable identifiers for MSC2285: private read receipts. (#13273) ... This adds support for the stable identifiers of MSC2285 while continuing to support the unstable identifiers behind the configuration flag. These will be removed in a future version.	2022-08-05 11:09:33 -04:00
Dirk Klimpel	e2ed1b7155	Use literals in place of HTTPStatus constants in tests (#13463)	2022-08-05 16:59:09 +02:00
Julian-Samuel Gebühr	3d2cabf966	Mark token-authenticaticated-registration API as not-experimental (#11897)	2022-08-05 11:15:35 +00:00
Matt C	026ac4486c	Update module API "update room membership" method to allow for remote joins (#13441) ... Co-authored-by: MattC <buffless-matt@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-08-05 09:37:58 +00:00
Erik Johnston	b6a6bb4027	Add comments about how event push actions are stored. (#13445)	2022-08-04 19:38:08 +00:00
Eric Eastwood	860fdd9098	Fix @tag_args being off-by-one (ahead) (#13452) ... Fix @tag_args being off-by-one (ahead) Example: ``` argspec.args=[ 'self', 'room_id' ] args=( <synapse.storage.databases.main.DataStore object at 0x10d0b8d00>, '!HBehERstyQBxyJDLfR:my.synapse.server' ) ``` --- The previous logic was also flawed and we can end up in a situation like this: ``` argspec.args=['self', 'dest', 'room_id', 'limit', 'extremities'] args=(<synapse.federation.federation_client.FederationClient object at 0x7f1651c18160>, 'hs1', '!jAEHKIubyIfuLOdfpY:hs1') ``` From this source: ```py async def backfill( self, dest: str, room_id: str, limit: int, extremities: Collection[str] ) -> Optional[List[EventBase]]: ``` And this usage: ```py events = await self._federation_client.backfill( dest, room_id, limit=limit, extremities=extremities ) ``` which would previously cause this error: ``` synapse_main | 2022-08-04 06:13:12,051 - synapse.handlers.federation - 424 - ERROR - GET-5 - Failed to backfill from hs1 because tuple index out of range synapse_main | Traceback (most recent call last): synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/handlers/federation.py", line 392, in try_backfill synapse_main | await self._federation_event_handler.backfill( synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 828, in _wrapper synapse_main | return await func(*args, **kwargs) synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/handlers/federation_event.py", line 593, in backfill synapse_main | events = await self._federation_client.backfill( synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 828, in _wrapper synapse_main | return await func(*args, **kwargs) synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 827, in _wrapper synapse_main | with wrapping_logic(func, *args, **kwargs): synapse_main | File "/usr/local/lib/python3.9/contextlib.py", line 119, in __enter__ synapse_main | return next(self.gen) synapse_main | File "/usr/local/lib/python3.9/site-packages/synapse/logging/tracing.py", line 922, in _wrapping_logic synapse_main | set_attribute("ARG_" + arg, str(args[i + 1])) # type: ignore[index] synapse_main | IndexError: tuple index out of range ```	2022-08-04 14:29:41 -05:00
Patrick Cloke	ec24813220	Improve comments (& avoid a duplicate query) in push actions processing. (#13455) ... * Adds docstrings and inline comments. * Formats SQL queries using triple quoted strings. * Minor formatting changes. * Avoid fetching `event_push_summary_stream_ordering` multiple times in the same transactions.	2022-08-04 19:24:44 +00:00
Richard van der Hoff	96d92156d0	Update type of EventContext.rejected (#13460)	2022-08-04 17:45:01 +01:00
reivilibre	e9e6aacfbe	Faster Room Joins: prevent Synapse from answering federated join requests for a room which it has not fully joined yet. (#13416)	2022-08-04 16:27:04 +01:00
Nick Mills-Barrett	41320a0554	Optimise async get event lookups (#13435) ... Still maintains local in memory lookup optimisation, but does any external lookup as part of the deferred that prevents duplicate lookups for the same event at once. This makes the assumption that fetching from an external cache is a non-zero load operation.	2022-08-04 15:49:55 +01:00
Dirk Klimpel	6dd7fa12dc	Update some outdated information on sso_mapping_providers.md (#13449)	2022-08-04 13:06:02 +01:00
Dirk Klimpel	afbdbe0634	Fix return value in example on password_auth_provider_callbacks.md (#13450) ... Fixes: #12534 Signed-off-by: Dirk Klimpel <dirk@klimpel.org>	2022-08-04 13:03:36 +01:00
Richard van der Hoff	166fafdf8d	synapse-workers docker: copy nginx and redis in from base images (#13447) ... Part of my continuing quest to make the docker images build quicker: copy nginx and redis in from base docker images, rather than apt installing each time.	2022-08-04 12:59:27 +01:00
Matt C	a91078200d	Add module API method to create a room (#13429) ... Co-authored-by: MattC <buffless-matt@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-08-04 09:34:05 +00:00
Brendan Abolivier	845732be45	Fix rooms not being properly excluded from incremental sync (#13408)	2022-08-04 11:02:29 +02:00
Shay	a648a06d52	Add some tracing spans to give insight into local joins (#13439)	2022-08-03 10:19:34 -07:00
Eric Eastwood	92d21faf12	Instrument /messages for understandable traces in Jaeger (#13368) ... In Jaeger: - Before: huge list of uncategorized database calls - After: nice and collapsible into units of work	2022-08-03 10:57:38 -05:00
andrew do	78a3111c41	Return 404 or member list when getting joined_members after leaving (#13374) ... Signed-off-by: Andrew Doh <andrewddo@gmail.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Andrew Morgan <andrewm@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-08-03 14:26:31 +02:00
Jasper Spaans	503a95804e	Install cryptography build dependencies in requirements image. (#13372)	2022-08-03 11:16:32 +01:00
jejo86	668597214f	Improve documentation on becoming server admin (#13230) ... * Improved section regarding server admin Added steps describing how to elevate an existing user to administrator by manipulating a `postgres` database. Signed-off-by: jejo86 28619134+jejo86@users.noreply.github.com * Improved section regarding server admin * Reference database settings Add instructions to check database settings to find out the database name, instead of listing all available PostgreSQL databases. * Add suggestions from PR conversation Replace config filename `homeserver.yaml`. with "config file". Remove instructions to switch to `postgres` user. Add instructions how to connect to SQLite database. * Update changelog.d/13230.doc Co-authored-by: reivilibre <olivier@librepush.net>	2022-08-03 11:15:23 +01:00
Dirk Klimpel	fb7a2cc4cc	Update doc for setting macaroon_secret_key (#13443) ... * Update doc for setting `macaroon_secret_key` * newsfile	2022-08-03 10:41:19 +01:00
Dirk Klimpel	d6e94ad9d9	Rename RateLimitConfig to RatelimitSettings (#13442)	2022-08-03 10:40:20 +01:00
Matt C	570bf32bbb	Add module API method to resolve a room alias to a room ID (#13428) ... Co-authored-by: MattC <buffless-matt@users.noreply.github.com> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-08-03 09:25:36 +00:00
Dirk Klimpel	5eccfdfafd	Remove 'Contents' section from the Configuration Manual (#13438) ... Fixes: #13053	2022-08-03 09:19:20 +00:00
Dirk Klimpel	ec6758d472	Fix wrong headline for url_preview_accept_language in docs (#13437) ... Fixes: #13433	2022-08-03 09:41:57 +01:00
reivilibre	1c910e2216	Add a merge-back command to the release script, which automates merging the correct branches after a release. (#13393)	2022-08-02 15:56:28 +00:00
Sean Quah	8d317f6da5	Fix error when out of servers to sync partial state with (#13432) ... so that we raise the intended error instead. Signed-off-by: Sean Quah <seanq@matrix.org>	2022-08-02 12:12:44 +01:00
reivilibre	e17e5c97e0	Faster Room Joins: don't leave a stuck room partial state flag if the join fails. (#13403)	2022-08-01 16:45:39 +00:00
Patrick Cloke	f8e7a9418a	Fix missing import in federation_event handler. (#13431) ... #13404 removed an import of `Optional` which was still needed due to #13413 added more usages.	2022-08-01 14:14:29 +00:00
Sean Quah	224d792dd7	Refactor _resolve_state_at_missing_prevs to return an EventContext (#13404) ... Previously, `_resolve_state_at_missing_prevs` returned the resolved state before an event and a partial state flag. These were unwieldy to carry around would only ever be used to build an event context. Build the event context directly instead. Signed-off-by: Sean Quah <seanq@matrix.org>	2022-08-01 13:53:56 +01:00
reivilibre	05aeeb3a80	Enable Complement CI tests in the 'latest deps' test run. (#13213) ... Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-08-01 10:55:31 +00:00
reivilibre	b817574be7	Re-enable running Complement tests against Synapse with workers. (#13420)	2022-08-01 11:51:44 +01:00
Richard van der Hoff	23768ccb4d	Faster joins: fix rejected events becoming un-rejected during resync (#13413) ... Make sure that we re-check the auth rules during state resync, otherwise rejected events get un-rejected.	2022-08-01 11:20:05 +01:00
Brendan Abolivier	24ef1460f6	Explicitly mention which resources support compression in the config guide (#13221)	2022-07-29 09:09:57 +00:00
Šimon Brandner	583f22780f	Use stable prefixes for MSC3827: filtering of /publicRooms by room type (#13370) ... Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>	2022-07-27 19:46:57 +01:00
Patrick Cloke	922b771337	Add missing type hints for tests.unittest. (#13397)	2022-07-27 17:18:41 +00:00
Will Hunt	502f075e96	Implement MSC3848: Introduce errcodes for specific event sending failures (#13343) ... Implements MSC3848	2022-07-27 13:44:40 +01:00
reivilibre	39be5bc550	Make minor clarifications to the error messages given when we fail to join a room via any server. (#13160)	2022-07-27 10:37:50 +00:00
Eric Eastwood	4f3082d6bf	Fix get_pdu asking every remote destination even after it finds an event (#13346)	2022-07-27 10:40:04 +01:00
Nick Mills-Barrett	bf3115584c	Copy room serials before handling in get_new_events_as (#13392)	2022-07-26 17:45:27 +00:00
reivilibre	543dc9c93e	Extend the release script to automatically push a new SyTest branch, rather than having that be a manual process. (#12978) ... Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2022-07-26 18:08:14 +01:00
Olivier Wilkinson (reivilibre)	6236afc621	Merge branch 'release-v1.64' into develop	2022-07-26 16:26:30 +01:00
Patrick Cloke	57d334a13d	Remove the unspecced room_id field in the /hierarchy response. (#13365) ... The `room_id` field represented the parent space for each room and was made redundant by changes in the API shape where the `children_state` is now nested underneath each `room`. The room ID of each child is in the `state_key` field and is still available.	2022-07-26 08:02:34 -04:00
Richard van der Hoff	ca3db044a3	Fix infinite loop in partial-state resync (#13353) ... Make sure that we only pull out events from the db once they have no prev-events with partial state.	2022-07-26 11:47:31 +00:00
Sean Quah	335ebb21cc	Faster room joins: avoid blocking when pulling events with missing prevs (#13355) ... Avoid blocking on full state in `_resolve_state_at_missing_prevs` and return a new flag indicating whether the resolved state is partial. Thread that flag around so that it makes it into the event context. Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-07-26 12:39:23 +01:00
Patrick Cloke	8b603299bf	Remove unused argument for get_relations_for_event. (#13383)	2022-07-26 07:19:20 -04:00
Olivier Wilkinson (reivilibre)	641412decd	1.64.0rc1	2022-07-26 12:12:22 +01:00
Doug	549c55606a	Disable autocorrect and autocaptialisation when entering username for SSO registration. (#13350) ... When registering a new account via SSO on iOS, the text field becomes pretty annoying as it autocapitalises and autocorrects your input. This PR fixes that (although I have only tested the raw HTML file on the simulator, I'm not sure how to get the complete setup available for testing in the flow).	2022-07-26 08:08:20 +00:00
Matt Holt	935e73efed	Update Caddy reverse proxy documentation (#13344) ... Improve/simplify Caddy examples. Remove Caddy v1 (has long been EOL'ed) Signed-off-by: Matthew Holt <mholt@users.noreply.github.com>	2022-07-25 16:07:26 +00:00
Jan Schär	e8519e0ed2	Support Implicit TLS for sending emails (#13317) ... Previously, TLS could only be used with STARTTLS. Add a new option `force_tls`, where TLS is used from the start. Implicit TLS is recommended over STARTLS, see https://datatracker.ietf.org/doc/html/rfc8314 Fixes #8046. Signed-off-by: Jan Schär <jan@jschaer.ch>	2022-07-25 16:27:19 +01:00
Patrick Cloke	908aeac44a	Additional fixes for opentracing type hints. (#13362)	2022-07-25 08:34:06 -04:00
Erik Johnston	43adf2521c	Refactor presence so we can prune user in room caches (#13313) ... See #10826 and #10786 for context as to why we had to disable pruning on those caches. Now that `get_users_who_share_room_with_user` is called frequently only for presence, we just need to make calls to it less frequent and then we can remove the various levels of caching that is going on.	2022-07-25 09:21:06 +00:00
Eric Eastwood	357561c1a2	Backfill remote event fetched by MSC3030 so we can paginate from it later (#13205) ... Depends on https://github.com/matrix-org/synapse/pull/13320 Complement tests: https://github.com/matrix-org/complement/pull/406 We could use the same method to backfill for `/context` as well in the future, see https://github.com/matrix-org/synapse/issues/3848	2022-07-22 16:00:11 -05:00
Sean Quah	0fa41a7b17	Update locked frozendict version to 2.3.3 (#13352) ... frozendict 2.3.3 includes fixes for memory leaks that get triggered during `/sync`.	2022-07-22 10:26:09 +01:00
Sean Quah	158782c3ce	Skip soft fail checks for rooms with partial state (#13354) ... When a room has the partial state flag, we may not have an accurate `m.room.member` event for event senders in the room's current state, and so cannot perform soft fail checks correctly. Skip the soft fail check entirely in this case. As an alternative, we could block until we have full state, but that would prevent us from receiving incoming events over federation, which is undesirable. Signed-off-by: Sean Quah <seanq@matrix.org>	2022-07-22 10:13:01 +01:00
Nick Mills-Barrett	86e366a46e	Remove old empty/redundant slaved stores. (#13349)	2022-07-21 17:56:45 +00:00
Erik Johnston	0b87eb8e0c	Make DictionaryCache have better expiry properties (#13292)	2022-07-21 17:13:44 +01:00
Erik Johnston	13341dde5a	Don't hold onto full state in state cache (#13324)	2022-07-21 16:02:02 +01:00
Brendan Abolivier	10e4093839	Call out buildkit is required when building test docker images (#13338) ... Co-authored-by: David Robertson <davidr@element.io>	2022-07-21 14:29:58 +02:00
David Robertson	34949ead1f	Track DB txn times w/ two counters, not histogram (#13342)	2022-07-21 13:23:05 +01:00
Patrick Cloke	50122754c8	Add missing types to opentracing. (#13345) ... After this change `synapse.logging` is fully typed.	2022-07-21 12:01:52 +00:00
Nick Mills-Barrett	190f49d8ab	Use cache store remove base slaved (#13329) ... This comes from two identical definitions in each of the base stores, and means the base slaved store is now empty and can be removed.	2022-07-21 11:51:30 +01:00
David Robertson	4f57ef0b18	Merge branch 'master' into develop	2022-07-21 11:27:08 +01:00
David Teller	b909d5327b	Document rc_invites.per_issuer, added in v1.63. ... Resolves #13330. Missed in #13125. Signed-off-by: David Teller <davidt@element.io>	2022-07-21 11:26:34 +01:00
Eric Eastwood	0f971ca68e	Update get_pdu to return the original, pristine EventBase (#13320) ... Update `get_pdu` to return the untouched, pristine `EventBase` as it was originally seen over federation (no metadata added). Previously, we returned the same `event` reference that we stored in the cache which downstream code modified in place and added metadata like setting it as an `outlier` and essentially poisoned our cache. Now we always return a copy of the `event` so the original can stay pristine in our cache and re-used for the next cache call. Split out from https://github.com/matrix-org/synapse/pull/13205 As discussed at: - https://github.com/matrix-org/synapse/pull/13205#discussion_r918365746 - https://github.com/matrix-org/synapse/pull/13205#discussion_r918366125 Related to https://github.com/matrix-org/synapse/issues/12584. This PR doesn't fix that issue because it hits [`get_event` which exists from the local database before it tries to `get_pdu`](7864f33e28/synapse/federation/federation_client.py (L581-L594)).	2022-07-20 15:58:51 -05:00
Shay	a1b62af2af	Validate federation destinations and log an error if server name is invalid. (#13318)	2022-07-20 11:17:26 -07:00
Erik Johnston	93740cae57	1.63.1	2022-07-20 13:37:00 +01:00
Erik Johnston	b4ae3b0d44	Don't include appservice users when calculating push rules (#13332) ... This can cause a lot of extra load on servers with lots of appservice users. Introduced in #13078	2022-07-20 12:06:13 +01:00
Sean Quah	172ce29b14	Fix spurious warning when fetching state after a missing prev event (#13258)	2022-07-19 19:15:54 +01:00
Patrick Cloke	a6895dd576	Add type annotations to trace decorator. (#13328) ... Functions that are decorated with `trace` are now properly typed and the type hints for them are fixed.	2022-07-19 14:14:30 -04:00
Erik Johnston	de70b25e84	Reduce memory usage of state group cache (#13323)	2022-07-19 14:40:37 +01:00
Patrick Cloke	1efe6b8c41	Stop building Ubuntu 21.10 (Impish Indri) which is end of life. (#13326)	2022-07-19 09:08:46 -04:00
Brendan Abolivier	097afd0e0b	1.63.0	2022-07-19 14:43:28 +02:00
Andrew Morgan	6faaf76a32	Remove 'anonymised' from the phone home stats documentation (#13321)	2022-07-19 12:38:29 +00:00
villepeh	84c5e6b1fd	Bash script for creating multiple stream writers (#13271) ... Add another bash script to the contrib directory. It creates multiple stream writers and also prints out the example configuration for homeserver.yaml. Signed-off-by: Ville Petteri Huh.	2022-07-19 12:37:20 +00:00
Jörg Behrmann	87a917e8c8	Add notes when config options were changed to config documentation (#13314) ... Signed-off-by: Jörg Behrmann <behrmann@physik.fu-berlin.de>	2022-07-19 12:36:29 +00:00
David Robertson	b977867358	Rate limit joins per-room (#13276)	2022-07-19 11:45:17 +00:00
Nick Mills-Barrett	2ee0b6ef4b	Safe async event cache (#13308) ... Fix race conditions in the async cache invalidation logic, by separating the async & local invalidation calls and ensuring any async call i executed first. Signed off by Nick @ Beeper (@Fizzadar).	2022-07-19 11:25:29 +00:00
Shay	7864f33e28	Increase batch size of bulk_get_push_rules and _get_joined_profiles_from_event_ids. (#13300)	2022-07-18 13:15:23 -07:00
Shay	15edf23626	Improve performance of query _get_subset_users_in_room_with_profiles (#13299)	2022-07-18 12:35:45 -07:00
Sean Quah	5526f9fc4f	Fix overcounting of pushers when they are replaced (#13296) ... Signed-off-by: Sean Quah <seanq@matrix.org>	2022-07-18 17:39:39 +01:00
Brendan Abolivier	8c60c572f0	Up the dependency on canonicaljson to ^1.5.0 (#13172) ... Co-authored-by: David Robertson <davidr@element.io>	2022-07-18 17:30:59 +02:00
Andrew Morgan	bb25dd81e3	Prevent #3679 from appearing in blame results (#13311)	2022-07-18 14:02:32 +00:00
Erik Johnston	f721f1baba	Revert "Make all process_replication_rows methods async (#13304)" (#13312) ... This reverts commit 5d4028f217.	2022-07-18 14:28:14 +01:00
Erik Johnston	cf5fa5063d	Don't pull out full state when sending dummy events (#13310)	2022-07-18 14:19:11 +01:00
Nick Mills-Barrett	6785b0f39d	Use READ COMMITTED isolation level when purging rooms (#12942) ... To close: #10294. Signed off by Nick @ Beeper.	2022-07-18 14:17:24 +01:00
Andrew Morgan	c5f487b7cb	Update expected DB query count when creating a room (#13307)	2022-07-18 13:02:25 +01:00
Erik Johnston	c6a05063ff	Don't pull out the full state when creating an event (#13281)	2022-07-18 10:05:30 +01:00
Dirk Klimpel	efee345b45	Remove unnecessary json.dumps from tests (#13303)	2022-07-17 22:28:45 +01:00
Nick Mills-Barrett	5d4028f217	Make all process_replication_rows methods async (#13304) ... More prep work for asyncronous caching, also makes all process_replication_rows methods consistent (presence handler already is so). Signed off by Nick @ Beeper (@Fizzadar)	2022-07-17 22:19:43 +01:00
Dirk Klimpel	96cf81e312	Use HTTPStatus constants in place of literals in tests. (#13297)	2022-07-15 19:31:27 +00:00
Eric Eastwood	7b67e93d49	Provide more info why we don't have any thumbnails to serve (#13038) ... Fix https://github.com/matrix-org/synapse/issues/13016 ## New error code and status ### Before Previously, we returned a `404` for `/thumbnail` which isn't even in the spec. ```json { "errcode": "M_NOT_FOUND", "error": "Not found [b'hs1', b'tefQeZhmVxoiBfuFQUKRzJxc']" } ``` ### After What does the spec say? > 400: The request does not make sense to the server, or the server cannot thumbnail the content. For example, the client requested non-integer dimensions or asked for negatively-sized images. > > *-- https://spec.matrix.org/v1.1/client-server-api/#get_matrixmediav3thumbnailservernamemediaid* Now with this PR, we respond with a `400` when we don't have thumbnails to serve and we explain why we might not have any thumbnails. ```json { "errcode": "M_UNKNOWN", "error": "Cannot find any thumbnails for the requested media ([b'example.com', b'12345']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.)", } ``` > Cannot find any thumbnails for the requested media ([b'example.com', b'12345']). This might mean the media is not a supported_media_format=(image/jpeg, image/jpg, image/webp, image/gif, image/png) or that thumbnailing failed for some other reason. (Dynamic thumbnails are disabled on this server.) --- We still respond with a 404 in many other places. But we can iterate on those later and maybe keep some in some specific places after spec updates/clarification: https://github.com/matrix-org/matrix-spec/issues/1122 We can also iterate on the bugs where Synapse doesn't thumbnail when it should in other issues/PRs.	2022-07-15 11:42:21 -05:00
David Robertson	e9ce4d089b	Use and recommend poetry 1.1.14, up from 1.1.12 (#13285)	2022-07-15 16:18:47 +01:00
Erik Johnston	0731e0829c	Don't pull out the full state when storing state (#13274)	2022-07-15 12:59:45 +00:00
Patrick Cloke	3343035a06	Use a real room in the notification rotation tests. (#13260) ... Instead of manually inserting fake data. This fixes some issues with having to manually calculate stream orderings and other oddities.	2022-07-15 08:22:43 -04:00
David Robertson	7281591f4c	Use state before join to determine if we _should_perform_remote_join (#13270) ... Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-07-15 12:20:47 +00:00
Sean Quah	d765ada84f	Update locked frozendict version to 2.3.2 (#13284) ... `frozendict` 2.3.2 includes a fix for a memory leak in `frozendict.__hash__`. This likely has no impact outside of the deprecated `/initialSync` endpoint, which uses `StreamToken`s, containing `RoomStreamToken`s, containing `frozendict`s, as cache keys. Signed-off-by: Sean Quah <seanq@matrix.org>	2022-07-15 13:18:51 +01:00
Richard van der Hoff	b116d3ce00	Bg update to populate new events table columns (#13215) ... These columns were added back in Synapse 1.52, and have been populated for new events since then. It's now (beyond) time to back-populate them for existing events.	2022-07-15 12:47:26 +01:00
Erik Johnston	7be954f59b	Fix a bug which could lead to incorrect state (#13278) ... There are two fixes here: 1. A long-standing bug where we incorrectly calculated `delta_ids`; and 2. A bug introduced in #13267 where we got current state incorrect.	2022-07-15 11:06:41 +00:00
Richard van der Hoff	512486bbeb	Docker: copy postgres from base image (#13279) ... When building the docker images for complement testing, copy a preinstalled complement over from a base image, rather than apt installing it. This avoids network traffic and is much faster.	2022-07-15 11:13:40 +01:00
Nick Mills-Barrett	cc21a431f3	Async get event cache prep (#13242) ... Some experimental prep work to enable external event caching based on #9379 & #12955. Doesn't actually move the cache at all, just lays the groundwork for async implemented caches. Signed off by Nick @ Beeper (@Fizzadar)	2022-07-15 09:30:46 +00:00
Nick Mills-Barrett	21eeacc995	Federation Sender & Appservice Pusher Stream Optimisations (#13251) ... * Replace `get_new_events_for_appservice` with `get_all_new_events_stream` The functions were near identical and this brings the AS worker closer to the way federation senders work which can allow for multiple workers to handle AS traffic. * Pull received TS alongside events when processing the stream This avoids an extra query -per event- when both federation sender and appservice pusher process events.	2022-07-15 09:36:56 +01:00
Richard van der Hoff	fe15a865a5	Rip out auth-event reconciliation code (#12943) ... There is a corner in `_check_event_auth` (long known as "the weird corner") where, if we get an event with auth_events which don't match those we were expecting, we attempt to resolve the diffence between our state and the remote's with a state resolution. This isn't specced, and there's general agreement we shouldn't be doing it. However, it turns out that the faster-joins code was relying on it, so we need to introduce something similar (but rather simpler) for that.	2022-07-14 21:52:26 +00:00
Erik Johnston	0ca4172b5d	Don't pull out state in compute_event_context for unconflicted state (#13267)	2022-07-14 13:57:02 +00:00
David Robertson	599c403d99	Allow rate limiters to passively record actions they cannot limit (#13253) ... Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-07-13 19:09:42 +00:00
David Robertson	0eb7e69768	Notifier: accept callbacks to fire on room joins (#13254)	2022-07-13 19:48:24 +01:00
Jacek Kuśnierz	cc1071598a	Call the v2 identity service /3pid/unbind endpoint, rather than v1. (#13240) ... * Drop support for v1 unbind Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de> * Add changelog Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de> * Update changelog.d/13240.misc	2022-07-13 19:43:17 +01:00
Shay	ad5761b65c	Add support for room version 10 (#13220)	2022-07-13 11:36:02 -07:00
jejo86	2341032cf2	Document advising against publicly exposing the Admin API and provide a usage example (#13231) ... * Admin API request explanation improved Pointed out, that the Admin API is not accessible by default from any remote computer, but only from the PC `matrix-synapse` is running on. Added a full, working example, making sure to include the cURL flag `-X`, which needs to be prepended to `GET`, `POST`, `PUT` etc. and listing the full query string including protocol, IP address and port. * Admin API request explanation improved * Apply suggestions from code review Update changelog. Reword prose. Co-authored-by: David Robertson <david.m.robertson1@gmail.com>	2022-07-13 19:33:33 +01:00
Nick Mills-Barrett	982fe29655	Optimise room creation event lookups part 2 (#13224)	2022-07-13 19:32:46 +01:00
Patrick Cloke	1d5c80b161	Reduce duplicate code in receipts servlets. (#13198)	2022-07-13 13:23:16 -04:00
Brad Murray	3371e1abcb	Add prometheus counters for content types other than events (#13175)	2022-07-13 15:18:20 +01:00
Patrick Cloke	4db7862e0f	Drop unused tables from groups/communities. (#12967) ... These tables have been unused since Synapse v1.61.0, although schema version 72 was added in Synapse v1.62.0.	2022-07-13 09:55:14 -04:00
Patrick Cloke	90e9b4fa1e	Do not fail build if complement with workers fails. (#13266)	2022-07-13 08:30:42 -04:00
Thomas Weston	0312ff44c6	Fix "add user" admin api error when request contains a "msisdn" threepid (#13263) ... Co-authored-by: Thomas Weston <thomas.weston@clearspancloud.com> Co-authored-by: David Robertson <david.m.robertson1@gmail.com>	2022-07-13 11:33:21 +01:00
Patrick Cloke	1381563988	Inline URL preview documentation. (#13261) ... Inline URL preview documentation near the implementation.	2022-07-12 15:01:58 -04:00
Richard van der Hoff	a366b75b72	Drop unused table event_reference_hashes (#13218) ... This is unused since Synapse 1.60.0 (#12679). It's time for it to go.	2022-07-12 18:52:06 +00:00
Jacek Kuśnierz	7218a0ca18	Drop support for calling /_matrix/client/v3/account/3pid/bind without an id_access_token (#13239) ... Fixes #13201 Signed-off-by: Jacek Kusnierz jacek.kusnierz@tum.de	2022-07-12 18:48:29 +00:00
David Robertson	52a0c8f2f7	Rename test case method to add_hashes_and_signatures_from_other_server (#13255)	2022-07-12 18:46:32 +00:00
Richard van der Hoff	fa71bb18b5	Drop support for delegating email validation (#13192) ... * Drop support for delegating email validation Delegating email validation to an IS is insecure (since it allows the owner of the IS to do a password reset on your HS), and has long been deprecated. It will now cause a config error at startup. * Update unit test which checks for email verification Give it an `email` config instead of a threepid delegate * Remove unused method `requestEmailToken` * Simplify config handling for email verification Rather than an enum and a boolean, all we need here is a single bool, which says whether we are or are not doing email verification. * update docs * changelog * upgrade.md: fix typo * update version number this will be in 1.64, not 1.63 * update version number this one too	2022-07-12 19:18:53 +01:00
Sean Quah	3f178332d6	Log the stack when waiting for an entire room to be un-partial stated (#13257) ... The stack is already logged when waiting for an event to be un-partial stated. Log the stack for rooms as well, to aid in debugging.	2022-07-12 18:57:38 +01:00
Shay	6f30eb5b8e	Add info about configuration in the url preview docs (#13233) ... Cross-link doc pages for easier navigation.	2022-07-12 13:48:47 -04:00
Quentin Gliech	b19060a29b	Make the AS login method call Auth.get_user_by_req for checking the AS token. (#13094) ... This gets rid of another usage of get_appservice_by_req, with all the benefits, including correctly tracking the appservice IP and setting the tracing attributes correctly. Signed-off-by: Quentin Gliech <quenting@element.io>	2022-07-12 18:06:29 +01:00
andrew do	2d82cdafd2	expose whether a room is a space in the Admin API (#13208)	2022-07-12 15:30:53 +01:00
Sean Quah	6173d585df	1.63.0rc1	2022-07-12 11:26:25 +01:00
Erik Johnston	e5716b631c	Don't pull out the full state when calculating push actions (#13078)	2022-07-11 20:08:39 +00:00
villepeh	bc8eefc1e1	Add a sample bash script to docs for creating multiple worker files (#13032) ... Signed-off-by: Ville Petteri Huh.	2022-07-11 18:33:53 +01:00
Nick Mills-Barrett	92202ce867	Reduce event lookups during room creation by passing known event IDs (#13210) ... Inspired by the room batch handler, this uses previous event inserts to pre-populate prev events during room creation, reducing the number of queries required to create a room. Signed off by Nick @ Beeper (@Fizzadar)	2022-07-11 18:00:12 +01:00
David Teller	11f811470f	Uniformize spam-checker API, part 5: expand other spam-checker callbacks to return Tuple[Codes, dict] (#13044) ... Signed-off-by: David Teller <davidt@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-07-11 16:52:10 +00:00
Travis Ralston	d736d5cfad	Fix to-device messages not being sent to MSC3202-enabled appservices (#13235) ... The field name was simply incorrect, leading to errors.	2022-07-11 17:22:17 +01:00
Erik Johnston	f1711e1f5c	Remove delay when rotating event push actions (#13211) ... We want to be as up to date as possible, and sleeping doesn't help here and can mean we fall behind.	2022-07-11 16:51:30 +01:00
Andrew Morgan	5ef2f87569	Document the 'databases' homeserver config option (#13212)	2022-07-11 14:05:24 +00:00
Erik Johnston	e610128c50	Add a filter_event_for_clients_with_state function (#13222)	2022-07-11 14:14:09 +01:00
Travis Ralston	a113011794	Fix appservice EDUs failing to send if the EDU doesn't have a room ID (#13236) ... * Fix appservice EDUs failing to send if the EDU doesn't have a room ID As is in the case of presence. * changelog * linter * fix linter again	2022-07-11 14:12:28 +01:00
David Robertson	28d96cb2b4	Ensure portdb selects _all_ rows with negative rowids (#13226)	2022-07-11 10:36:18 +01:00
Sumner Evans	739adf1551	editorconfig: add max_line_length for Python files (#13228) ... See the documentation for the property here: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length Signed-off-by: Sumner Evans <me@sumnerevans.com>	2022-07-08 16:40:25 +00:00
Erik Johnston	757bc0caef	Fix notification count after a highlighted message (#13223) ... Fixes #13196 Broke by #13005	2022-07-08 14:00:29 +01:00
Eric Eastwood	a962c5a56d	Fix exception when using MSC3030 to look for remote federated events before room creation (#13197) ... Complement tests: https://github.com/matrix-org/complement/pull/405 This happens when you have some messages imported before the room is created. Then use MSC3030 to look backwards before the room creation from a remote federated server. The server won't find anything locally, but will ask over federation which will have the remote event. The previous logic would choke on not having the local event assigned. ``` Failed to fetch /timestamp_to_event from hs2 because of exception(UnboundLocalError) local variable 'local_event' referenced before assignment args=("local variable 'local_event' referenced before assignment",) ```	2022-07-07 11:52:45 -05:00
reivilibre	0c95313a44	Add --build-only option to complement.sh to prevent actually running Complement. (#13158)	2022-07-07 14:18:38 +00:00
Petr Vaněk	bb20113c8f	Remove obsolete RoomEventsStoreTestCase (#13200) ... All tests are prefixed with `STALE_` and therefore they are silently skipped. They were moved to `STALE_` in version `v0.5.0` in commit 2fcce3b3c5 - `Remove stale tests`. Tests from `RoomEventsStoreTestCase` class are not used for last 8 years, I believe the best would be to remove them entirely. Signed-off-by: Petr Vaněk <arkamar@atlas.cz>	2022-07-07 13:47:26 +01:00
Sean Quah	1391a76cd2	Faster room joins: fix race in recalculation of current room state (#13151) ... Bounce recalculation of current state to the correct event persister and move recalculation of current state into the event persistence queue, to avoid concurrent updates to a room's current state. Also give recalculation of a room's current state a real stream ordering. Signed-off-by: Sean Quah <seanq@matrix.org>	2022-07-07 12:19:31 +00:00
Nick Mills-Barrett	2b5ab8e367	Use a single query in ProfileHandler.get_profile (#13209)	2022-07-07 11:02:09 +00:00
dependabot[bot]	4aaeb87dad	Bump lxml from 4.8.0 to 4.9.1 (#13207) ... Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: David Robertson <davidr@element.io>	2022-07-07 10:56:52 +00:00
reivilibre	fb7d24ab6d	Check that auto_vacuum is disabled when porting a SQLite database to Postgres, as VACUUMs must not be performed between runs of the script. (#13195)	2022-07-07 10:08:04 +00:00