forked-synapse

mirror of https://mau.dev/maunium/synapse.git synced 2024-10-01 01:36:05 -04:00

Author	SHA1	Message	Date
Patrick Cloke	d2fd7f7b5c	Fix a stale comment in get_room_version_id_txn. (#12969 )	2022-06-07 07:44:31 -04:00
Patrick Cloke	9dc3293e0b	Consolidate the logic of delete_device/delete_devices. (#12970 ) By always using delete_devices and sometimes passing a list with a single device ID. Previously these methods had gotten out of sync with each other and it seems there's little benefit to the single-device variant.	2022-06-07 07:43:35 -04:00
Andrew Morgan	c51f5b9592	Prevent breaking old sqlite's when media retention is enabled (#12977 )	2022-06-07 11:28:08 +00:00
Andrew Morgan	a47636c570	Prevent local quarantined media from being claimed by media retention (#12972 )	2022-06-07 10:53:47 +00:00
Patrick Cloke	f7baffd8ec	Remove remaining pieces of groups code. (#12966 ) * Remove an unused stream ID generator. * Remove the now unused remote profile cache.	2022-06-06 13:20:05 -04:00
Erik Johnston	44de53bb79	Reduce state pulled from DB due to sending typing and receipts over federation (#12964 ) Reducing the amount of state we pull from the DB is useful as fetching state is expensive in terms of DB, CPU and memory.	2022-06-06 16:46:11 +01:00
Patrick Cloke	148fe58a24	Do not break URL previews if an image is unreachable. (#12950 ) Avoid breaking a URL preview completely if the chosen image 404s or is unreachable for some other reason (e.g. DNS).	2022-06-06 07:46:04 -04:00
Patrick Cloke	1acc897c31	Implement MSC3816, consider the root event for thread participation. (#12766 ) As opposed to only considering a user to have "participated" if they replied to the thread.	2022-06-06 07:18:04 -04:00
Jan Christian Grünhage	fcd8703508	Allow updating passwords using the admin api without logging out devices (#12952 )	2022-06-06 12:10:13 +01:00
Erik Johnston	e3163e2e11	Reduce the amount of state we pull from the DB (#12811 )	2022-06-06 09:24:12 +01:00
Patrick Cloke	6b46c3eb3d	Remove groups code from synapse_port_db. (#12899 )	2022-06-03 12:13:35 -04:00
Patrick Cloke	01df5bacac	Improve URL previews for some pages (#12951 ) * Skip `og` and `meta` tags where the value is empty. * Fallback to the favicon if there are no other images. * Ignore tags meant for navigation.	2022-06-03 12:09:12 -04:00
Erik Johnston	888a29f412	Wait for lazy join to complete when getting current state (#12872 )	2022-06-01 16:02:53 +01:00
Patrick Cloke	7bc08f3201	Remove remaining bits of groups code. (#12936 ) * Update worker docs to remove group endpoints. * Removes an unused parameter to `ApplicationService`. * Break dependency between media repo and groups. * Avoid copying `m.room.related_groups` state events during room upgrades.	2022-06-01 09:41:25 -04:00
Richard van der Hoff	79dadf7216	Fix 404 on `/sync` when the last event is a redaction of an unknown/purged event (#12905 ) Currently, we try to pull the event corresponding to a sync token from the database. However, when we fetch redaction events, we check the target of that redaction (because we aren't allowed to send redactions to clients without validating them). So, if the sync token points to a redaction of an event that we don't have, we have a problem. It turns out we don't really need that event, and can just work with its ID and metadata, which sidesteps the whole problem.	2022-06-01 11:29:51 +00:00
Erik Johnston	5949ab86f8	Fix potential thumbnail memory leaks. (#12932 )	2022-06-01 10:57:49 +00:00
Patrick Cloke	2e8763ec96	Remove most groups datastore code. (#12895 ) The remaining piece is a background update that is needed for backwards compatibility.	2022-05-31 20:28:17 -04:00
Richard van der Hoff	f0aec0abef	Improve logging when signature checks fail (#12925 ) * Raise a dedicated `InvalidEventSignatureError` from `_check_sigs_on_pdu` * Downgrade logging about redactions to DEBUG this can be very spammy during a room join, and it's not very useful. * Raise `InvalidEventSignatureError` from `_check_sigs_and_hash` ... and, more importantly, move the logging out to the callers. * changelog	2022-05-31 23:32:56 +01:00
Patrick Cloke	cf05258f76	Remove groups replication code. (#12900 ) The replication logic for groups is no longer used, so the message passing infrastructure can be removed.	2022-05-31 13:04:08 -04:00
Andrew Morgan	2fc787c341	Add config options for media retention (#12732 )	2022-05-31 16:35:29 +00:00
Sean Quah	641908f72f	Faster room joins: Resume state re-syncing after a Synapse restart (#12813 ) Signed-off-by: Sean Quah <seanq@matrix.org>	2022-05-31 15:15:08 +00:00
Sean Quah	2fba1076c5	Faster room joins: Try other destinations when resyncing the state of a partial-state room (#12812 ) Signed-off-by: Sean Quah <seanq@matrix.org>	2022-05-31 15:50:29 +01:00
Erik Johnston	3594f6c1f3	Merge branch 'master' into develop	2022-05-31 14:48:22 +01:00
Erik Johnston	c8684e6792	Reduce DB load of /sync when using presence (#12885 ) While the query was fast, we were calling it a lot.	2022-05-31 13:01:05 +00:00
Richard van der Hoff	5e17922ef7	Stop reading from `event_edges.room_id`. (#12914 ) event_edges.room_id is implied by the event id, so there is no need to join on the room id.	2022-05-31 13:51:49 +01:00
Erik Johnston	1e453053cb	Rename storage classes (#12913 )	2022-05-31 12:17:50 +00:00
Patrick Cloke	e541bb9eed	Rework stream token to stop caring about groups. (#12897 )	2022-05-31 07:42:50 -04:00
Brendan Abolivier	8fd87739bf	Fix import in module_api module and docs on the new check_event_for_spam signature (#12918 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-05-31 12:04:53 +02:00
Travis Ralston	d0e40dfe29	Fix M_USER_ACCOUNT_SUSPENDED error code for spec compliance (#12923 )	2022-05-31 08:42:18 +01:00
Travis Ralston	bcfdfeb65d	Revert "Fix M_USER_ACCOUNT_SUSPENDED error code for spec compliance (#12922 )" This reverts commit `e0fae823e9`.	2022-05-30 20:29:40 -06:00
Travis Ralston	e0fae823e9	Fix M_USER_ACCOUNT_SUSPENDED error code for spec compliance (#12922 ) `M_` is a reserved namespace.	2022-05-31 02:27:19 +00:00
Jacek Kuśnierz	c4f548e05d	Don't return `end` from `/messages` if there are no more events (#12903 ) Signed-off-by: Jacek Kusnierz <jacek.kusnierz@tum.de>	2022-05-30 21:03:52 +01:00
Brendan Abolivier	cd9fc058de	Document the Synapse version of a new module API method (#12917 )	2022-05-30 18:37:52 +02:00
David Teller	af7db19e1e	Uniformize spam-checker API, part 3: Expand check_event_for_spam with the ability to return additional fields (#12846 ) Signed-off-by: David Teller <davidt@element.io>	2022-05-30 18:24:56 +02:00
Mathieu Velten	7f92ac4c1c	Add a migration step to cleanup potential leftovers of bug 11833 (#12784 ) Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-05-30 16:51:37 +02:00
DeepBlueV7.X	b10211871f	Fix invite notifications for users without pushers (#12840 ) Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de> Co-authored-by: Brendan Abolivier <github@brendanabolivier.com>	2022-05-30 13:14:43 +02:00
Richard van der Hoff	2480461879	Fix `get_metadata_for_events` (#12904 ) This method was introduced in #12852. It is using the `state_key` column from the `events` table, which is not (yet) reliable (see #11496).	2022-05-30 10:51:09 +01:00
David Robertson	796a0312e1	Bump jsonschema stubs (#12912 )	2022-05-30 10:47:09 +01:00
Jonathan de Jong	6be4953b99	Mutual rooms: Remove dependency on user directory (#12836 )	2022-05-30 10:05:31 +01:00
Sumner Evans	bda4600399	LockStore: fix acquiring a lock via `LockStore.try_acquire_lock` (#12832 ) Signed-off-by: Sumner Evans <sumner@beeper.com>	2022-05-30 09:41:13 +01:00
Brendan Abolivier	28989cb301	Add a background job to automatically delete stale devices (#12855 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-05-27 17:47:32 +02:00
David Teller	888eb736a1	Add code M_USER_ACCOUNT_SUSPENDED, as per MSC3823. (#12845 ) Signed-off-by: David Teller <davidt@element.io> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-05-27 13:13:29 +00:00
Patrick Cloke	724e11d620	Clean-up some receipts code (#12888 ) * Properly marks private methods as private. * Adds missing docstrings. * Rework inline methods.	2022-05-27 07:44:10 -04:00
Patrick Cloke	c52abc1cfd	Additional constants for EDU types. (#12884 ) Instead of hard-coding strings in many places.	2022-05-27 07:14:36 -04:00
Patrick Cloke	d9f092285b	Remove federation client code for groups. (#12563 )	2022-05-27 07:13:58 -04:00
Sean Quah	053ca5f3ca	Synapse 1.60.0rc2 (2022-05-27) ============================== This release of Synapse adds a unique index to the `state_group_edges` table, in order to prevent accidentally introducing duplicate information (for example, because a database backup was restored multiple times). If your Synapse database already has duplicate rows in this table, this could fail with an error and require manual remediation. Additionally, the signature of the `check_event_for_spam` module callback has changed. The previous signature has been deprecated and remains working for now. Module authors should update their modules to use the new signature where possible. See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1600) for more details. Features -------- - Add an option allowing users to use their password to reauthenticate for privileged actions even though password login is disabled. ([\#12883](https://github.com/matrix-org/synapse/issues/12883)) Bugfixes -------- - Explicitly close `ijson` coroutines once we are done with them, instead of leaving the garbage collector to close them. ([\#12875](https://github.com/matrix-org/synapse/issues/12875)) Internal Changes ---------------- - Improve URL previews by not including the content of media tags in the generated description. ([\#12887](https://github.com/matrix-org/synapse/issues/12887)) -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEWMTnW8Z8khaaf90R+84KzgcyGG8FAmKQqMcACgkQ+84Kzgcy GG9Z2Av+N+b/fvaB3D56UkFqTW/xLmCEyri65njcXU8625bWiLSPM6hssmyJB1FA xlc2RBKr8QxlnHRS/v31wDtONC8YZ2O3fyzYPFfY1fF5Ul7Kg3XCzLeUH4/j1/Ar 5bqriDqaN9FQ/6QJybShXlA4l7lY1Fs0C4P23jDBgqfKjnlToeVLqhVA70dDaFu/ ir+vVprKCkQI1iqnYXwIxGRmgBzLWGoVqQFGbSI6hugGwXpGIyX7+2I+0v8tI6vA SZ99vLFWcvnd6DJTyBhIeV22Ff4qA7eQsyPvSrMETdsaZmrxGlG+t332HNCgplv8 gv2gUpJL0br++5WTAX+nRc7HpfKo/74vKeTktqPmlvFP8kUOg+PbzmoJFUu21PhA rnq5TzgsPHK0dqBhM1RC2vtOiJ5v3ZBqzJJzSRXl6lsFpWxxFmwesEcIDAYS0Nmh QoJb7/L8cPCHksHvZM76bzB465tSH9NhuFYZQoLGHcpxa0kYekrdlYasP8U0FU7L nF3C0Pgw =D3F+ -----END PGP SIGNATURE----- Merge tag 'v1.60.0rc2' into develop Synapse 1.60.0rc2 (2022-05-27) ============================== This release of Synapse adds a unique index to the `state_group_edges` table, in order to prevent accidentally introducing duplicate information (for example, because a database backup was restored multiple times). If your Synapse database already has duplicate rows in this table, this could fail with an error and require manual remediation. Additionally, the signature of the `check_event_for_spam` module callback has changed. The previous signature has been deprecated and remains working for now. Module authors should update their modules to use the new signature where possible. See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1600) for more details. Features -------- - Add an option allowing users to use their password to reauthenticate for privileged actions even though password login is disabled. ([\#12883](https://github.com/matrix-org/synapse/issues/12883)) Bugfixes -------- - Explicitly close `ijson` coroutines once we are done with them, instead of leaving the garbage collector to close them. ([\#12875](https://github.com/matrix-org/synapse/issues/12875)) Internal Changes ---------------- - Improve URL previews by not including the content of media tags in the generated description. ([\#12887](https://github.com/matrix-org/synapse/issues/12887))	2022-05-27 12:07:18 +01:00
Matt C	a7da00d4f7	Add storage and module API methods to get monthly active users and their appservices (#12838 )	2022-05-27 10:25:57 +00:00
David Robertson	3503f42741	Easy type hints in synapse.logging.opentracing (#12894 )	2022-05-27 11:17:33 +01:00
Sean Quah	bb7a637765	Close `ijson` coroutines ourselves instead of letting the GC close them (#12875 ) Hopefully this means that exceptions raised due to truncated JSON get a sensible logging context and stack. Signed-off-by: Sean Quah <seanq@matrix.org>	2022-05-27 11:03:05 +01:00
reivilibre	7b88f5a107	Add an option allowing users to use their password to reauthenticate even though password authentication is disabled. (#12883 )	2022-05-27 09:44:51 +00:00
Richard van der Hoff	f1605b7447	Fix room deletion (#12889 ) * Fix room deletion `ae7858f` broke room deletion by attempting to delete the entry from `rooms` before the tables that reference it. * faster_joins: remove database rows on purge	2022-05-27 10:31:08 +01:00
Richard van der Hoff	bc1beebc27	Refactor have_seen_events to reduce OOMs (#12886 ) My server is currently OOMing in the middle of have_seen_events, so let's try to fix that.	2022-05-27 10:27:33 +01:00
reivilibre	317248d42c	Improve URL previews by not including the content of media tags in the generated description. (#12887 )	2022-05-26 16:07:27 +01:00
Patrick Cloke	49f06866e4	Remove backing code for groups/communities (#12558 ) Including handlers, configuration code, appservice support, and the GroupID construct.	2022-05-26 09:04:34 -04:00
reivilibre	e768644368	Fix ambiguous column name that would prevent use of MSC2716 History Import when using Postgres as a database. (#12843 )	2022-05-26 11:19:01 +00:00
Patrick Cloke	1885ee0113	Remove unstable APIs for /hierarchy. (#12851 ) Removes the unstable endpoint as well as a duplicated field which was modified during stabilization.	2022-05-26 07:10:28 -04:00
Patrick Cloke	b5707ceaba	Avoid attempting to delete push actions for remote users. (#12879 ) Remote users will never have push actions, so we can avoid a database round-trip/transaction completely.	2022-05-26 07:09:16 -04:00
Erik Johnston	b83bc5fab5	Pull out less state when handling gaps mk2 (#12852 )	2022-05-26 09:48:12 +00:00
Richard van der Hoff	1b338476af	Allow bigger responses to `/federation/v1/state` (#12877 ) * Refactor HTTP response size limits Rather than passing a separate `max_response_size` down the stack, make it an attribute of the `parser`. * Allow bigger responses on `federation/v1/state` `/state` can return huge responses, so we need to handle that.	2022-05-25 22:24:28 +01:00
Erik Johnston	4660d9fdcf	Fix up `state_store` naming (#12871 )	2022-05-25 12:59:04 +01:00
Patrick Cloke	a8db8c6eba	Remove user-visible groups/communities code (#12553 ) Makes it so that groups/communities no longer exist from a user-POV. E.g. we remove: * All API endpoints (including Client-Server, Server-Server, and admin). * Documented configuration options (and the experimental flag, which is now unused). * Special handling during room upgrades. * The `groups` section of the `/sync` response.	2022-05-25 07:53:40 -04:00
Patrick Cloke	759f9c09e1	Fix caching behavior for relations push rules. (#12859 ) By always returning all requested values from the function wrapped by cachedList. Otherwise implicit None values get added into the cache, which are unexpected.	2022-05-25 07:49:54 -04:00
Patrick Cloke	4cbcd4a999	Misc clean-up of push rules datastore (#12856 )	2022-05-25 07:49:12 -04:00
Nick Mills-Barrett	1f9013ce60	Add the `batch_send` endpoint to generic workers (#12868 )	2022-05-25 09:51:07 +00:00
Nick Mills-Barrett	33e2916858	Don't create empty AS txns when the AS is down (#12869 )	2022-05-25 09:46:05 +00:00
Nick Mills-Barrett	2e5f88b5e6	Add the `/account/whoami` endpoint to generic workers (#12866 )	2022-05-25 10:41:41 +01:00
Carl Bordum Hansen	774ac4930d	Make sure `prev_ids` defaults to empty list (#12829 ) Signed-off-by: Carl Bordum Hansen <carl@bordum.dk>	2022-05-25 09:14:45 +00:00
David Robertson	e7c77a8750	Correct annotation of `_iterate_over_text` (#12860 )	2022-05-24 18:17:21 +00:00
David Robertson	81d9f2a8e9	Fixes to MSC3787 implementation (#12858 )	2022-05-24 16:50:50 +00:00
Šimon Brandner	042e47970b	Remove `dont_notify` from the `.m.rule.room.server_acl` rule (#12849 ) Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>	2022-05-24 17:42:32 +01:00
Will Hunt	6855024e0a	Add authentication to thirdparty bridge APIs (#12746 ) Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-05-24 16:39:54 +02:00
Patrick Cloke	88ce3080d4	Experimental support for MSC3772 (#12740 ) Implements the following behind an experimental configuration flag: * A new push rule kind for mutually related events. * A new default push rule (`.m.rule.thread_reply`) under an unstable prefix. This is missing part of MSC3772: * The `.m.rule.thread_reply_to_me` push rule, this depends on MSC3664 / #11804.	2022-05-24 13:23:23 +00:00
Eric Eastwood	7c2a78bb3b	Marker events as state - MSC2716 (#12718 ) Sending marker events as state now so they are always able to be seen by homeservers (not lost in some timeline gap). Part of [MSC2716](https://github.com/matrix-org/matrix-spec-proposals/pull/2716) Complement tests: https://github.com/matrix-org/complement/pull/371 As initially discussed at https://github.com/matrix-org/matrix-spec-proposals/pull/2716#discussion_r782629097 and https://github.com/matrix-org/matrix-spec-proposals/pull/2716#discussion_r876684431 When someone joins a room, process all of the marker events we see in the current state. Marker events should be sent with a unique `state_key` so that they can all resolve in the current state to easily be discovered. Marker events as state - If we re-use the same `state_key` (like `""`), then we would have to fetch previous snapshots of state up through time to find all of the marker events. This way we can avoid all of that. This PR was originally doing this but then thought of the smarter way to tackle in an [out of band discussion with @erikjohnston](https://docs.google.com/document/d/1JJDuPfcPNX75fprdTWlxlaKjWOdbdJylbpZ03hzo638/edit#bookmark=id.sm92fqyq7vpp). - Also avoids state resolution conflicts where only one of the marker events win As a homeserver, when we see new marker state, we know there is new history imported somewhere back in time and should process it to fetch the insertion event where the historical messages are and set it as an insertion extremity. This way we know where to backfill more messages when someone asks for scrollback.	2022-05-23 20:43:37 -05:00
David Teller	28199e9357	Uniformize spam-checker API, part 2: check_event_for_spam (#12808 ) Signed-off-by: David Teller <davidt@element.io>	2022-05-23 17:27:39 +00:00
Brendan Abolivier	4cc4229cd7	Prevent expired events from being filtered out when retention is disabled (#12611 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-05-23 17:18:23 +00:00
Jess Porter	a608ac847b	add SpamChecker callback for silently dropping inbound federated events (#12744 ) Signed-off-by: jesopo <github@lolnerd.net>	2022-05-23 16:36:21 +00:00
reivilibre	fbf904bd54	Fix media thumbnails being unusable before the index had been added in the background. (#12823 )	2022-05-23 10:28:56 +01:00
reivilibre	39dee30f01	Send `USER_IP` commands on a different Redis channel, in order to reduce traffic to workers that do not process these commands. (#12809 )	2022-05-20 15:28:23 +01:00
David Teller	10280fc943	Uniformize spam-checker API, part 1: the `Code` enum. (#12703 )	2022-05-20 14:53:25 +02:00
Shay	71e8afe34d	Update EventContext `get_current_event_ids` and `get_prev_event_ids` to accept state filters and update calls where possible (#12791 )	2022-05-20 09:54:12 +01:00
Sean Quah	2be5a2b07b	Fix `RetryDestinationLimiter` re-starting finished log contexts (#12803 ) Signed-off-by: Sean Quah <seanq@matrix.org>	2022-05-19 20:17:10 +01:00
Andrew Morgan	96df31239c	Add a unit test for copying over arbitrary room types when upgrading a room (#12792 )	2022-05-19 18:32:48 +01:00
reivilibre	177b884ad7	Lay some foundation work to allow workers to only subscribe to some kinds of messages, reducing replication traffic. (#12672 )	2022-05-19 16:29:08 +01:00
Petr Vaněk	684feeaf2f	Properly close providers.json file stream. (#12794 )	2022-05-19 14:23:59 +00:00
reivilibre	66a5f6c400	Add a unique index to `state_group_edges` to prevent duplicates being accidentally introduced and the consequential impact to performance. (#12687 )	2022-05-19 14:16:49 +01:00
Jae Lo Presti	f16ec055cc	hash_password: raise an error if no config file is specified (#12789 )	2022-05-19 13:03:13 +00:00
Aminda Suomalainen	d25935cd3d	Implement MSC3818: copy room type on upgrade (#12786 ) Resolves: #11896 Signed-off-by: Aminda Suomalainen <suomalainen+git@mikaela.info>	2022-05-19 12:28:10 +01:00
David Robertson	6ff99e3bea	Downgrade some OIDC exceptions to warnings (#12723 )	2022-05-18 20:10:21 +01:00
Richard van der Hoff	d38c73e9ab	Skip waiting for full state if a StateFilter does not require it (#12498 ) If `StateFilter` specifies a state set which we will have regardless of state-syncing, then we may as well return it immediately.	2022-05-18 18:33:57 +00:00
Shay	19d79b6ebe	Refactor `resolve_state_groups_for_events` to not pull out full state when no state resolution happens. (#12775 )	2022-05-18 10:15:52 -07:00
Dirk Klimpel	50ae4eafe1	Add some type hints to `event_federation` datastore (#12753 ) Co-authored-by: David Robertson <david.m.robertson1@gmail.com>	2022-05-18 16:02:10 +01:00
reivilibre	635f0d916b	Do not keep going if there are 5 back-to-back background update failures. (#12781 )	2022-05-18 13:57:59 +00:00
reivilibre	df4963548b	Give a meaningful error message when a client tries to create a room with an invalid alias localpart. (#12779 )	2022-05-18 11:46:06 +00:00
David Robertson	d4713d3e33	Discard null-containing strings before updating the user directory (#12762 )	2022-05-18 11:28:14 +01:00
Hubert Chathi	8afb7b55d0	Make handling of federation Authorization header (more) compliant with RFC7230 (#12774 ) The main differences are: - values with delimiters (such as colons) should be quoted, so always quote the origin, since it could contain a colon followed by a port number - should allow more than one space after "X-Matrix" - quoted values with backslash-escaped characters should be unescaped - names should be case insensitive	2022-05-18 11:19:30 +01:00
Adam	37935b5183	Move methods that call add_push_rule to PushRuleStore (#12772 ) Signed-off-by: Adam Roddick <ajroddick@tuta.io>	2022-05-18 09:37:48 +00:00
Mathieu Velten	182ca78a12	Delete events from federation_inbound_events_staging table on purge (#12770 )	2022-05-17 17:01:06 +00:00
David Robertson	5331fb5b47	allow `on_invalidate=None` in `@cached` methods (#12769 )	2022-05-17 16:06:45 +00:00
Dirk Klimpel	6edefef602	Add some type hints to datastore (#12717 )	2022-05-17 15:29:06 +01:00
Travis Ralston	942c30b16b	Add a new room version for MSC3787's knock+restricted join rule (#12623 )	2022-05-17 10:41:39 +00:00
Richard van der Hoff	24b590de32	Remove code which updates `application_services_state.last_txn` (#12680 ) This column is unused as of #12209, so let's stop writing to it.	2022-05-17 11:07:18 +01:00
SpiritCroc	a34a41f135	Fix push for m.read events (#12721 ) badge_count_last_call was always zero when the response for push notifications included a "rejected" key which mapped to an empty list.	2022-05-17 11:03:07 +01:00
David Robertson	1402159bb8	Merge branch 'master' into develop	2022-05-17 11:00:54 +01:00
Erik Johnston	32ef24fbd7	Add index to cache invalidations (#12747 ) For workers that rarely write to the cache the `get_all_updated_caches` query can become expensive if the worker falls behind when reading the cache.	2022-05-17 09:34:59 +00:00
Erik Johnston	fcf951d5dc	Track in memory events using weakrefs (#10533 )	2022-05-17 10:34:27 +01:00
David Robertson	1fe202a1a3	Tidy up and type-hint the database engine modules (#12734 ) Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-05-17 00:34:38 +01:00
Andrew Morgan	83be72d76c	Add `StreamKeyType` class and replace string literals with constants (#12567 )	2022-05-16 15:35:31 +00:00
Erik Johnston	4ea546067d	Fix query performance for /sync (#12745 )	2022-05-16 16:30:35 +01:00
Šimon Brandner	3ce15cc7be	Avoid unnecessary copies when filtering private read receipts. (#12711 ) A minor optimization to avoid unnecessary copying/building identical dictionaries when filtering private read receipts. Also clarifies comments and cleans-up some tests.	2022-05-16 15:06:23 +00:00
David Robertson	b4eb163434	Synapse 1.59.0rc2 (2022-05-16) ============================== Synapse 1.59 makes several changes that server administrators should be aware of: - Device name lookup over federation is now disabled by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - The `synapse.app.appservice` and `synapse.app.user_dir` worker application types are now deprecated. ([\#12452](https://github.com/matrix-org/synapse/issues/12452), [\#12654](https://github.com/matrix-org/synapse/issues/12654)) See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1590) for more details. Additionally, this release removes the non-standard `m.login.jwt` login type from Synapse. It can be replaced with `org.matrix.login.jwt` for identical behaviour. This is only used if `jwt_config.enabled` is set to `true` in the configuration. ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) Bugfixes -------- - Fix a bug introduced in Synapse 1.58.0 where `/sync` would fail if the most recent event in a room was rejected. ([\#12729](https://github.com/matrix-org/synapse/issues/12729)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE1508oLYUKainYFJakD7OEIo53t0FAmKCTJQACgkQkD7OEIo5 3t1JFw/+NCKc2jBSXQHfcN6cSqfmBFd3sCLDkTiVtQy8k55OW4ioE+qvL7NlMWQW 4Qon/DpCGV5KV3mJ3CdqaUqaA6B69L68JSUAkDgIlMfPNOsAPHvojp+Pf1uSPApc PXjhHhiV/BHRLjNmfoavbWB1XfvVfDXCg/9hCH7+EFktmsCAyyzJSb/oaFLKtP/l dUCivzAe2JcQcCSx/cO0zU4NqIoeSymK/ffjvHdEr+FHGR6vyT//7t/71Rm2tbZ6 6j2utZ4VlT9gXylcQKP37Q2HKMP3pgocDwXWTLk2ZJU47oYc9S+iXGwP75fX900L bkmxzx2opKw6LCyvU3sMcw+GHpqfcOG1A6uJEGP6JzVj27xDEOto4EYWkhnSz5Cn LMHHSh1ZPNtq/aqm6SxlSdgs6uWpyxTAxeniBItSL80HgtOGCeFbddepKu/hcU1G V97AdP5+K4aXC36yVGibsFooBgcXRb+xdzrmQoeYHj4Ky3sybBVkBJ7uS4tp5TB5 h+YbYSpWLDZy/ldbOL3NAqbjhg+l87QnKHAUhpdU1T48a672mE6hWSRq41N0HyP+ ldEtgzfyjGFMOQ3lvzZ9HUweivgyBQZKxhXKHTB7IQQDtNAKR14YWx3syA76tJki RhOdcNwAmVB8L0BEGBVYWKLnw7qoU838hcFMZFBRAkNAY8xZjXk= =iA2S -----END PGP SIGNATURE----- gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE1508oLYUKainYFJakD7OEIo53t0FAmKCV9EACgkQkD7OEIo5 3t0sIQ//RR816yuZT2Ln4hFyHLxafO7wyzmSCLFMaMixJNPYrq3dwGTz92mjHUY/ tV0XY3Yjg9YqzHps/eQy9hvhnZao0RZDxoXRPnXlDqMYiHsIe61UmYH0F1E6Nz1U xln5T/Sl+iIlfR3NskOxRaMk/PIbQYKHb0tQIDhkQo5KkuZZsrf0t/IL+9RO6Tmy DFYOpSs7L5U+NufeO2/xR4jCltLb1zunypjNIOBb0G3LJvyTtRSoFscaYdSFEFEJ v9lPfJwhUnKJ/NWiH0CgViboN5Z2Igk1jlPdb8o2p7ketD58w4gGMn67Eq0hotau esy8FA/sx5/V+pf8mYDeZNTdgBk03W2A5XxYB4JUsCQChtMaELqMZCL6Vk8hi1oi S8WnfFoc9EWAbOh/J4bBv00zzA54vGf8ra1qeirndKDyd5pkZnsMaJxohU9LhEJb OSTED1NNZuhuO+phwVx0CtnsSkf2Sz2xc8E5sm891s/dU0cRZmXgCt7rMFreEsD3 IdzUd1oDQ47JhV8EMntRw1Y8/CDPrml5wZ9On18btxfTPTjUJNtLSaIkZ462/AgZ naBk1OlzaPV8QwerDqrxy0c891CVqrr3iJ62luFb40kTyy85Facdfw8OyrCtMmvL TEgXM5xaFxfydjX2Sfz3Y8QAAokEzLhVlj3sR93acSEDdzN+Gms= =JmDV -----END PGP SIGNATURE----- Merge tag 'v1.59.0rc2' into develop Synapse 1.59.0rc2 (2022-05-16) ============================== Synapse 1.59 makes several changes that server administrators should be aware of: - Device name lookup over federation is now disabled by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - The `synapse.app.appservice` and `synapse.app.user_dir` worker application types are now deprecated. ([\#12452](https://github.com/matrix-org/synapse/issues/12452), [\#12654](https://github.com/matrix-org/synapse/issues/12654)) See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1590) for more details. Additionally, this release removes the non-standard `m.login.jwt` login type from Synapse. It can be replaced with `org.matrix.login.jwt` for identical behaviour. This is only used if `jwt_config.enabled` is set to `true` in the configuration. ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) Bugfixes -------- - Fix a bug introduced in Synapse 1.58.0 where `/sync` would fail if the most recent event in a room was rejected. ([\#12729](https://github.com/matrix-org/synapse/issues/12729))	2022-05-16 14:55:18 +01:00
Dirk Klimpel	8060034612	Fix typo in listener config (#12742 )	2022-05-16 13:50:07 +00:00
Sean Quah	a5c26750b5	Fix room upgrades creating an empty room when auth fails (#12696 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-05-16 14:06:04 +01:00
Patrick Cloke	86a515ccbf	Consolidate logic for parsing relations. (#12693 ) Parse the `m.relates_to` event content field (which describes relations) in a single place, this is used during: * Event persistence. * Validation of the Client-Server API. * Fetching bundled aggregations. * Processing of push rules. Each of these separately implement the logic and each made slightly different assumptions about what was valid. Some had minor / potential bugs.	2022-05-16 12:42:45 +00:00
Erik Johnston	8689230a55	Fix bug /sync returning 404 (#12729 ) * Fix bug /sync returning 404 Fixes #12571	2022-05-16 12:06:56 +01:00
Shay	cde8af9a49	Add config flags to allow for cache auto-tuning (#12701 )	2022-05-13 12:32:39 -07:00
Brendan Abolivier	9013104429	Don't create an empty room when checking for MAU limits (#12713 )	2022-05-13 15:30:15 +02:00
David Robertson	aec69d2481	Another batch of type annotations (#12726 )	2022-05-13 12:35:31 +01:00
Jess Porter	39bed28b28	SpamChecker metrics (#12513 ) * add Measure blocks all over SpamChecker Signed-off-by: jesopo <github@lolnerd.net> * fix test_spam_checker_may_join_room and test_threepid_invite_spamcheck * better changelog entry	2022-05-13 12:17:38 +01:00
Andrew Morgan	57f6c496d0	URL preview cache expiry logs: INFO -> DEBUG, text clarifications (#12720 )	2022-05-12 18:16:32 +01:00
David Robertson	17e1eb7749	Reduce the number of "untyped defs" (#12716 )	2022-05-12 14:33:50 +00:00
Andy Balaam	de1e599b9d	add default_power_level_content_override config option. (#12618 ) Co-authored-by: Matthew Hodgson <matthew@matrix.org>	2022-05-12 10:41:35 +00:00
Sean Quah	bf7ce92bf7	Enable cancellation of `GET /members` and `GET /state` requests (#12708 ) Enable cancellation of `GET /rooms/$room_id/members`, `GET /rooms/$room_id/state` and `GET /rooms/$room_id/state/$state_key/*` requests. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-11 17:22:34 +01:00
David Robertson	db10f2c037	No longer permit empty body when sending receipts (#12709 )	2022-05-11 15:34:17 +00:00
Sean Quah	6ee61b9052	Complain if a federation endpoint has the `@cancellable` flag (#12705 ) `BaseFederationServlet` wraps its endpoints in a bunch of async code that has not been vetted for compatibility with cancellation. Fail CI if a `@cancellable` flag is applied to a federation endpoint. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-11 14:52:26 +01:00
David Robertson	d38d242411	Reload cache factors from disk on SIGHUP (#12673 )	2022-05-11 13:43:22 +00:00
Sean Quah	a559c8b0d9	Respect the `@cancellable` flag for `ReplicationEndpoint`s (#12700 ) While `ReplicationEndpoint`s register themselves via `JsonResource`, they pass a method that calls the handler, instead of the handler itself, to `register_paths`. As a result, `JsonResource` will not correctly pick up the `@cancellable` flag and we have to apply it ourselves. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-11 12:25:39 +01:00
Sean Quah	9d8e380d2e	Respect the `@cancellable` flag for `RestServlet`s and `BaseFederationServlet`s (#12699 ) Both `RestServlet`s and `BaseFederationServlet`s register their handlers with `HttpServer.register_paths` / `JsonResource.register_paths`. Update `JsonResource` to respect the `@cancellable` flag on handlers registered in this way. Although `ReplicationEndpoint` also registers itself using `register_paths`, it does not pass the handler method that would have the `@cancellable` flag directly, and so needs separate handling. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-11 12:25:13 +01:00
Sean Quah	dffecade7d	Respect the `@cancellable` flag for `DirectServe{Html,Json}Resource`s (#12698 ) `DirectServeHtmlResource` and `DirectServeJsonResource` both inherit from `_AsyncResource`. These classes expect to be subclassed with `_async_render_*` methods. This commit has no effect on `JsonResource`, despite inheriting from `_AsyncResource`. `JsonResource` has its own `_async_render` override which will need to be updated separately. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-11 12:24:48 +01:00
Patrick Cloke	a4c75918b3	Remove unneeded `ActionGenerator` class. (#12691 ) It simply passes through to `BulkPushRuleEvaluator`, which can be called directly instead.	2022-05-11 07:15:21 -04:00
Eric Eastwood	84facf769e	Fix `/messages` throwing a 500 when querying for non-existent room (#12683 ) Fix https://github.com/matrix-org/synapse/issues/12678 Complement test added: https://github.com/matrix-org/complement/pull/369 Before: 500 internal server error After: According to the [spec](https://spec.matrix.org/latest/client-server-api/#get_matrixclientv3roomsroomidmessages), calling `/messages` against a non-existent `room_id` should throw a 403 forbidden (since you're not part of the room). This also matches the behavior before https://github.com/matrix-org/synapse/pull/12370 which regressed Synapse to the 500 behavior. ```json { "errcode": "M_FORBIDDEN", "error": "User @test:my.synapse.server not in room !dne:my.synapse.server, and room previews are disabled" } ```	2022-05-10 23:39:14 -05:00
Erik Johnston	c72d26c1e1	Refactor `EventContext` (#12689 ) Refactor how the `EventContext` class works, with the intention of reducing the amount of state we fetch from the DB during event processing. The idea here is to get rid of the cached `current_state_ids` and `prev_state_ids` that live in the `EventContext`, and instead defer straight to the database (and its caching). One change that may have a noticeable effect is that we now no longer prefill the `get_current_state_ids` cache on a state change. However, that query is relatively light, since its just a case of reading a table from the DB (unlike fetching state at an event which is more heavyweight). For deployments with workers this cache isn't even used. Part of #12684	2022-05-10 19:43:13 +00:00
Sean Quah	c997bfb926	Capture the `Deferred` for request cancellation in `_AsyncResource` (#12694 ) All async request processing goes through `_AsyncResource`, so this is the only place where a `Deferred` needs to be captured for cancellation. Unfortunately, the same isn't true for determining whether a request can be cancelled. Each of `RestServlet`, `BaseFederationServlet`, `DirectServe{Html,Json}Resource` and `ReplicationEndpoint` have different wrappers around the method doing the request handling and they all need to be handled separately. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-10 20:39:05 +01:00
Patrick Cloke	29f06704b8	Fix incorrect type hint in filtering code. (#12695 )	2022-05-10 14:10:22 -04:00
Dirk Klimpel	989fa33096	Add some type hints to datastore. (#12477 )	2022-05-10 14:07:48 -04:00
Richard van der Hoff	147f098fb4	Stop writing to `event_reference_hashes` (#12679 ) This table is never read, since #11794. We stop writing to it; in future we can drop it altogether.	2022-05-10 15:35:08 +01:00
Sean Quah	5cfb004595	Add ability to cancel disconnected requests to `SynapseRequest` (#12588 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-05-10 14:06:08 +01:00
Sean Quah	5c00151c28	Add `@cancellable` decorator, for use on request handlers (#12586 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-05-10 14:05:22 +01:00
David Robertson	2aad0ae57f	Synapse 1.59.0rc1 (2022-05-10) ============================== This release makes several changes that server administrators should be aware of: - Device name lookup over federation is now disabled by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - The `synapse.app.appservice` and `synapse.app.user_dir` worker application types are now deprecated. ([\#12452](https://github.com/matrix-org/synapse/issues/12452), [\#12654](https://github.com/matrix-org/synapse/issues/12654)) See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1590) for more details. Additionally, this release removes the non-standard `m.login.jwt` login type from Synapse. It can be replaced with `org.matrix.login.jwt` for identical behaviour. This is only used if `jwt_config.enabled` is set to `true` in the configuration. ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) Features -------- - Support [MSC3266](https://github.com/matrix-org/matrix-doc/pull/3266) room summaries over federation. ([\#11507](https://github.com/matrix-org/synapse/issues/11507)) - Implement [changes](`4a77139249`) to [MSC2285 (hidden read receipts)](https://github.com/matrix-org/matrix-spec-proposals/pull/2285). Contributed by @SimonBrandner. ([\#12168](https://github.com/matrix-org/synapse/issues/12168), [\#12635](https://github.com/matrix-org/synapse/issues/12635), [\#12636](https://github.com/matrix-org/synapse/issues/12636), [\#12670](https://github.com/matrix-org/synapse/issues/12670)) - Extend the [module API](https://github.com/matrix-org/synapse/blob/release-v1.59/synapse/module_api/__init__.py) to allow modules to change actions for existing push rules of local users. ([\#12406](https://github.com/matrix-org/synapse/issues/12406)) - Add the `notify_appservices_from_worker` configuration option (superseding `notify_appservices`) to allow a generic worker to be designated as the worker to send traffic to Application Services. ([\#12452](https://github.com/matrix-org/synapse/issues/12452)) - Add the `update_user_directory_from_worker` configuration option (superseding `update_user_directory`) to allow a generic worker to be designated as the worker to update the user directory. ([\#12654](https://github.com/matrix-org/synapse/issues/12654)) - Add new `enable_registration_token_3pid_bypass` configuration option to allow registrations via token as an alternative to verifying a 3pid. ([\#12526](https://github.com/matrix-org/synapse/issues/12526)) - Implement [MSC3786](https://github.com/matrix-org/matrix-spec-proposals/pull/3786): Add a default push rule to ignore `m.room.server_acl` events. ([\#12601](https://github.com/matrix-org/synapse/issues/12601)) - Add new `mau_appservice_trial_days` configuration option to specify a different trial period for users registered via an appservice. ([\#12619](https://github.com/matrix-org/synapse/issues/12619)) Bugfixes -------- - Fix a bug introduced in Synapse 1.48.0 where the latest thread reply provided failed to include the proper bundled aggregations. ([\#12273](https://github.com/matrix-org/synapse/issues/12273)) - Fix a bug introduced in Synapse 1.22.0 where attempting to send a large amount of read receipts to an application service all at once would result in duplicate content and abnormally high memory usage. Contributed by Brad & Nick @ Beeper. ([\#12544](https://github.com/matrix-org/synapse/issues/12544)) - Fix a bug introduced in Synapse 1.57.0 which could cause `Failed to calculate hosts in room` errors to be logged for outbound federation. ([\#12570](https://github.com/matrix-org/synapse/issues/12570)) - Fix a long-standing bug where status codes would almost always get logged as `200!`, irrespective of the actual status code, when clients disconnect before a request has finished processing. ([\#12580](https://github.com/matrix-org/synapse/issues/12580)) - Fix race when persisting an event and deleting a room that could lead to outbound federation breaking. ([\#12594](https://github.com/matrix-org/synapse/issues/12594)) - Fix a bug introduced in Synapse 1.53.0 where bundled aggregations for annotations/edits were incorrectly calculated. ([\#12633](https://github.com/matrix-org/synapse/issues/12633)) - Fix a long-standing bug where rooms containing power levels with string values could not be upgraded. ([\#12657](https://github.com/matrix-org/synapse/issues/12657)) - Prevent memory leak from reoccurring when presence is disabled. ([\#12656](https://github.com/matrix-org/synapse/issues/12656)) Updates to the Docker image --------------------------- - Explicitly opt-in to using [BuildKit-specific features](https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/syntax.md) in the Dockerfile. This fixes issues with building images in some GitLab CI environments. ([\#12541](https://github.com/matrix-org/synapse/issues/12541)) - Update the "Build docker images" GitHub Actions workflow to use `docker/metadata-action` to generate docker image tags, instead of a custom shell script. Contributed by @henryclw. ([\#12573](https://github.com/matrix-org/synapse/issues/12573)) Improved Documentation ---------------------- - Update SQL statements and replace use of old table `user_stats_historical` in docs for Synapse Admins. ([\#12536](https://github.com/matrix-org/synapse/issues/12536)) - Add missing linebreak to `pipx` install instructions. ([\#12579](https://github.com/matrix-org/synapse/issues/12579)) - Add information about the TCP replication module to docs. ([\#12621](https://github.com/matrix-org/synapse/issues/12621)) - Fixes to the formatting of `README.rst`. ([\#12627](https://github.com/matrix-org/synapse/issues/12627)) - Fix docs on how to run specific Complement tests using the `complement.sh` test runner. ([\#12664](https://github.com/matrix-org/synapse/issues/12664)) Deprecations and Removals ------------------------- - Remove unstable identifiers from [MSC3069](https://github.com/matrix-org/matrix-doc/pull/3069). ([\#12596](https://github.com/matrix-org/synapse/issues/12596)) - Remove the unspecified `m.login.jwt` login type and the unstable `uk.half-shot.msc2778.login.application_service` from [MSC2778](https://github.com/matrix-org/matrix-doc/pull/2778). ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) - Synapse now requires at least Python 3.7.1 (up from 3.7.0), for compatibility with the latest Twisted trunk. ([\#12613](https://github.com/matrix-org/synapse/issues/12613)) Internal Changes ---------------- - Use supervisord to supervise Postgres and Caddy in the Complement image to reduce restart time. ([\#12480](https://github.com/matrix-org/synapse/issues/12480)) - Immediately retry any requests that have backed off when a server comes back online. ([\#12500](https://github.com/matrix-org/synapse/issues/12500)) - Use `make_awaitable` instead of `defer.succeed` for return values of mocks in tests. ([\#12505](https://github.com/matrix-org/synapse/issues/12505)) - Consistently check if an object is a `frozendict`. ([\#12564](https://github.com/matrix-org/synapse/issues/12564)) - Protect module callbacks with read semantics against cancellation. ([\#12568](https://github.com/matrix-org/synapse/issues/12568)) - Improve comments and error messages around access tokens. ([\#12577](https://github.com/matrix-org/synapse/issues/12577)) - Improve docstrings for the receipts store. ([\#12581](https://github.com/matrix-org/synapse/issues/12581)) - Use constants for read-receipts in tests. ([\#12582](https://github.com/matrix-org/synapse/issues/12582)) - Log status code of cancelled requests as 499 and avoid logging stack traces for them. ([\#12587](https://github.com/matrix-org/synapse/issues/12587), [\#12663](https://github.com/matrix-org/synapse/issues/12663)) - Remove special-case for `twisted` logger from default log config. ([\#12589](https://github.com/matrix-org/synapse/issues/12589)) - Use `getClientAddress` instead of the deprecated `getClientIP`. ([\#12599](https://github.com/matrix-org/synapse/issues/12599)) - Add link to documentation in Grafana Dashboard. ([\#12602](https://github.com/matrix-org/synapse/issues/12602)) - Reduce log spam when running multiple event persisters. ([\#12610](https://github.com/matrix-org/synapse/issues/12610)) - Add extra debug logging to federation sender. ([\#12614](https://github.com/matrix-org/synapse/issues/12614)) - Prevent remote homeservers from requesting local user device names by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - Add a consistency check on events which we read from the database. ([\#12620](https://github.com/matrix-org/synapse/issues/12620)) - Remove use of the `constantly` library and switch to enums for `EventRedactBehaviour`. Contributed by @andrewdoh. ([\#12624](https://github.com/matrix-org/synapse/issues/12624)) - Remove unused code related to receipts. ([\#12632](https://github.com/matrix-org/synapse/issues/12632)) - Minor improvements to the scripts for running Synapse in worker mode under Complement. ([\#12637](https://github.com/matrix-org/synapse/issues/12637)) - Move `pympler` back in to the `all` extras. ([\#12652](https://github.com/matrix-org/synapse/issues/12652)) - Fix spelling of `M_UNRECOGNIZED` in comments. ([\#12665](https://github.com/matrix-org/synapse/issues/12665)) - Release script: confirm the commit to be tagged before tagging. ([\#12556](https://github.com/matrix-org/synapse/issues/12556)) - Fix a typo in the announcement text generated by the Synapse release development script. ([\#12612](https://github.com/matrix-org/synapse/issues/12612)) - Fix scripts-dev to pass typechecking. ([\#12356](https://github.com/matrix-org/synapse/issues/12356)) - Add some type hints to datastore. ([\#12485](https://github.com/matrix-org/synapse/issues/12485)) - Remove unused `# type: ignore`s. ([\#12531](https://github.com/matrix-org/synapse/issues/12531)) - Allow unused `# type: ignore` comments in bleeding edge CI jobs. ([\#12576](https://github.com/matrix-org/synapse/issues/12576)) - Remove redundant lines of config from `mypy.ini`. ([\#12608](https://github.com/matrix-org/synapse/issues/12608)) - Update to mypy 0.950. ([\#12650](https://github.com/matrix-org/synapse/issues/12650)) - Use `Concatenate` to better annotate `_do_execute`. ([\#12666](https://github.com/matrix-org/synapse/issues/12666)) - Use `ParamSpec` to refine type hints. ([\#12667](https://github.com/matrix-org/synapse/issues/12667)) - Fix mypy against latest pillow stubs. ([\#12671](https://github.com/matrix-org/synapse/issues/12671)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE1508oLYUKainYFJakD7OEIo53t0FAmJ6UDoACgkQkD7OEIo5 3t3XMw/9GfROfC///lio77EhdI0lh39bkgvfqkFE/wRYtTs4n3ZSiclgVBnNmgnN WnLvjL/4wXRjzJZ8vcO+qG0OasT3H9l5xdGE+7h8oUMIYCG7Xdyx37xnhv5IC8Y5 dAjqs2mMnIWnAqyOAVZQVgmNLDhRAb9YGCJ3fJY9cV8dmzr8/RzR8gXrFPaBT9Nj w5Xag0jkiJuff4+Y5oan2yBxMvHT/zAb8rQf5wNjen00lwYHSAr/5aiAsbnHcMYM q0ZahVB/hVaA5GqxwrySlE0mqrPP6M/CpbcLr1h8LlmLdgA6f3vcf/sREGq6wCRK Z8yYXM4RyvNTyYirQfnP5QseVazJqcCY0pCXrMnQxwXda7nSDKjXo0WFBmyIQpK4 YqDvlOhECr+Pcac/EAviH2OEvTMBg4cUs1xdm4/CBElIOZQPyXHJ0DLku8R0CRx/ i01fN0I/r/wX1Oliy4wFJgSYt/uUQzZaJmRieK8fznlFibM3Gk1GvniX0M5Hu6cZ PQuHdPqRxQzvBmEAA1hxTfyOaDeP3g29NnOz9cjsBiAVNqUbEV5KFusjwksI4kcT Bsdk+v/i8/Kx6t0ovRI2i3JJAFNWmUzpY0iDzY3kJCn1YmEMZ7rs+e5qRmv2eBLW oS9dhLGsW7A/mJC6fLM+CATwbFiL/SqB5ocnl4POodZ/b27eDyw= =NPHq -----END PGP SIGNATURE----- gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE1508oLYUKainYFJakD7OEIo53t0FAmJ6V/YACgkQkD7OEIo5 3t0ANA/7BZ762LAjLNsFvJVxnH8LjDEjsjCyjHQ/zzVkAete3354zcW/mqN2YzMl shaxHucfZ9sKCXlOSuwY9N+1Q24ALMAb8QebCQZjNamxKqddpMD0+ijeaKRoFq8P 6VY5saL+rjW0g2QaKE/IHc99UKnw/cNN/vGa3xc3dJFRiiNkK95jS8R7aaaT2mXB 9frbbN0Q45Q6JTU9qJTP6jqdYmKZNjvIHBJcEXkstGqS8NPJXpfVKMZIgTj/8nGL RVJqOStsnHdx4vywZ76GPTAxQ+ZjXMilIbz+bF/6Zw1SCJEZfwFOelYApwMi0qU7 yDK7xeokKxzXyykzmptmiqmePCbr9fHbk+BJtE7VblMdj7OaM7jX7foSX6J1elIp zwDwBK0VH3CJzk9SRoy4JW3PI9K45DZodev33CT+sT39/wYTiV3mbGIYkgP8oSDH rd588QZDovVDy6NWzxkT0MsutHE5Rhx2aP+hkIFDHL4WWnKeFRD5HbiZfg/eC6r0 0nPRY2CCikvqLRqefTi4dgxb+twVBnioPZiDBTEKA/M1/qVg978SIpdHsfmaDJf9 BzWsvfsns0t54J2QnazOjKx2yxIYH6pZ2VFnrb47404O5O3+TuKZL9eX8oNZeBFl JKZKD2xii/ktkw5p27RxEpBJ13hrssN+RMd0JrvS3LTa5G9aIUM= =2gaD -----END PGP SIGNATURE----- Merge tag 'v1.59.0rc1' into develop Synapse 1.59.0rc1 (2022-05-10) ============================== This release makes several changes that server administrators should be aware of: - Device name lookup over federation is now disabled by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - The `synapse.app.appservice` and `synapse.app.user_dir` worker application types are now deprecated. ([\#12452](https://github.com/matrix-org/synapse/issues/12452), [\#12654](https://github.com/matrix-org/synapse/issues/12654)) See [the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/docs/upgrade.md#upgrading-to-v1590) for more details. Additionally, this release removes the non-standard `m.login.jwt` login type from Synapse. It can be replaced with `org.matrix.login.jwt` for identical behaviour. This is only used if `jwt_config.enabled` is set to `true` in the configuration. ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) Features -------- - Support [MSC3266](https://github.com/matrix-org/matrix-doc/pull/3266) room summaries over federation. ([\#11507](https://github.com/matrix-org/synapse/issues/11507)) - Implement [changes](`4a77139249`) to [MSC2285 (hidden read receipts)](https://github.com/matrix-org/matrix-spec-proposals/pull/2285). Contributed by @SimonBrandner. ([\#12168](https://github.com/matrix-org/synapse/issues/12168), [\#12635](https://github.com/matrix-org/synapse/issues/12635), [\#12636](https://github.com/matrix-org/synapse/issues/12636), [\#12670](https://github.com/matrix-org/synapse/issues/12670)) - Extend the [module API](https://github.com/matrix-org/synapse/blob/release-v1.59/synapse/module_api/__init__.py) to allow modules to change actions for existing push rules of local users. ([\#12406](https://github.com/matrix-org/synapse/issues/12406)) - Add the `notify_appservices_from_worker` configuration option (superseding `notify_appservices`) to allow a generic worker to be designated as the worker to send traffic to Application Services. ([\#12452](https://github.com/matrix-org/synapse/issues/12452)) - Add the `update_user_directory_from_worker` configuration option (superseding `update_user_directory`) to allow a generic worker to be designated as the worker to update the user directory. ([\#12654](https://github.com/matrix-org/synapse/issues/12654)) - Add new `enable_registration_token_3pid_bypass` configuration option to allow registrations via token as an alternative to verifying a 3pid. ([\#12526](https://github.com/matrix-org/synapse/issues/12526)) - Implement [MSC3786](https://github.com/matrix-org/matrix-spec-proposals/pull/3786): Add a default push rule to ignore `m.room.server_acl` events. ([\#12601](https://github.com/matrix-org/synapse/issues/12601)) - Add new `mau_appservice_trial_days` configuration option to specify a different trial period for users registered via an appservice. ([\#12619](https://github.com/matrix-org/synapse/issues/12619)) Bugfixes -------- - Fix a bug introduced in Synapse 1.48.0 where the latest thread reply provided failed to include the proper bundled aggregations. ([\#12273](https://github.com/matrix-org/synapse/issues/12273)) - Fix a bug introduced in Synapse 1.22.0 where attempting to send a large amount of read receipts to an application service all at once would result in duplicate content and abnormally high memory usage. Contributed by Brad & Nick @ Beeper. ([\#12544](https://github.com/matrix-org/synapse/issues/12544)) - Fix a bug introduced in Synapse 1.57.0 which could cause `Failed to calculate hosts in room` errors to be logged for outbound federation. ([\#12570](https://github.com/matrix-org/synapse/issues/12570)) - Fix a long-standing bug where status codes would almost always get logged as `200!`, irrespective of the actual status code, when clients disconnect before a request has finished processing. ([\#12580](https://github.com/matrix-org/synapse/issues/12580)) - Fix race when persisting an event and deleting a room that could lead to outbound federation breaking. ([\#12594](https://github.com/matrix-org/synapse/issues/12594)) - Fix a bug introduced in Synapse 1.53.0 where bundled aggregations for annotations/edits were incorrectly calculated. ([\#12633](https://github.com/matrix-org/synapse/issues/12633)) - Fix a long-standing bug where rooms containing power levels with string values could not be upgraded. ([\#12657](https://github.com/matrix-org/synapse/issues/12657)) - Prevent memory leak from reoccurring when presence is disabled. ([\#12656](https://github.com/matrix-org/synapse/issues/12656)) Updates to the Docker image --------------------------- - Explicitly opt-in to using [BuildKit-specific features](https://github.com/moby/buildkit/blob/master/frontend/dockerfile/docs/syntax.md) in the Dockerfile. This fixes issues with building images in some GitLab CI environments. ([\#12541](https://github.com/matrix-org/synapse/issues/12541)) - Update the "Build docker images" GitHub Actions workflow to use `docker/metadata-action` to generate docker image tags, instead of a custom shell script. Contributed by @henryclw. ([\#12573](https://github.com/matrix-org/synapse/issues/12573)) Improved Documentation ---------------------- - Update SQL statements and replace use of old table `user_stats_historical` in docs for Synapse Admins. ([\#12536](https://github.com/matrix-org/synapse/issues/12536)) - Add missing linebreak to `pipx` install instructions. ([\#12579](https://github.com/matrix-org/synapse/issues/12579)) - Add information about the TCP replication module to docs. ([\#12621](https://github.com/matrix-org/synapse/issues/12621)) - Fixes to the formatting of `README.rst`. ([\#12627](https://github.com/matrix-org/synapse/issues/12627)) - Fix docs on how to run specific Complement tests using the `complement.sh` test runner. ([\#12664](https://github.com/matrix-org/synapse/issues/12664)) Deprecations and Removals ------------------------- - Remove unstable identifiers from [MSC3069](https://github.com/matrix-org/matrix-doc/pull/3069). ([\#12596](https://github.com/matrix-org/synapse/issues/12596)) - Remove the unspecified `m.login.jwt` login type and the unstable `uk.half-shot.msc2778.login.application_service` from [MSC2778](https://github.com/matrix-org/matrix-doc/pull/2778). ([\#12597](https://github.com/matrix-org/synapse/issues/12597)) - Synapse now requires at least Python 3.7.1 (up from 3.7.0), for compatibility with the latest Twisted trunk. ([\#12613](https://github.com/matrix-org/synapse/issues/12613)) Internal Changes ---------------- - Use supervisord to supervise Postgres and Caddy in the Complement image to reduce restart time. ([\#12480](https://github.com/matrix-org/synapse/issues/12480)) - Immediately retry any requests that have backed off when a server comes back online. ([\#12500](https://github.com/matrix-org/synapse/issues/12500)) - Use `make_awaitable` instead of `defer.succeed` for return values of mocks in tests. ([\#12505](https://github.com/matrix-org/synapse/issues/12505)) - Consistently check if an object is a `frozendict`. ([\#12564](https://github.com/matrix-org/synapse/issues/12564)) - Protect module callbacks with read semantics against cancellation. ([\#12568](https://github.com/matrix-org/synapse/issues/12568)) - Improve comments and error messages around access tokens. ([\#12577](https://github.com/matrix-org/synapse/issues/12577)) - Improve docstrings for the receipts store. ([\#12581](https://github.com/matrix-org/synapse/issues/12581)) - Use constants for read-receipts in tests. ([\#12582](https://github.com/matrix-org/synapse/issues/12582)) - Log status code of cancelled requests as 499 and avoid logging stack traces for them. ([\#12587](https://github.com/matrix-org/synapse/issues/12587), [\#12663](https://github.com/matrix-org/synapse/issues/12663)) - Remove special-case for `twisted` logger from default log config. ([\#12589](https://github.com/matrix-org/synapse/issues/12589)) - Use `getClientAddress` instead of the deprecated `getClientIP`. ([\#12599](https://github.com/matrix-org/synapse/issues/12599)) - Add link to documentation in Grafana Dashboard. ([\#12602](https://github.com/matrix-org/synapse/issues/12602)) - Reduce log spam when running multiple event persisters. ([\#12610](https://github.com/matrix-org/synapse/issues/12610)) - Add extra debug logging to federation sender. ([\#12614](https://github.com/matrix-org/synapse/issues/12614)) - Prevent remote homeservers from requesting local user device names by default. ([\#12616](https://github.com/matrix-org/synapse/issues/12616)) - Add a consistency check on events which we read from the database. ([\#12620](https://github.com/matrix-org/synapse/issues/12620)) - Remove use of the `constantly` library and switch to enums for `EventRedactBehaviour`. Contributed by @andrewdoh. ([\#12624](https://github.com/matrix-org/synapse/issues/12624)) - Remove unused code related to receipts. ([\#12632](https://github.com/matrix-org/synapse/issues/12632)) - Minor improvements to the scripts for running Synapse in worker mode under Complement. ([\#12637](https://github.com/matrix-org/synapse/issues/12637)) - Move `pympler` back in to the `all` extras. ([\#12652](https://github.com/matrix-org/synapse/issues/12652)) - Fix spelling of `M_UNRECOGNIZED` in comments. ([\#12665](https://github.com/matrix-org/synapse/issues/12665)) - Release script: confirm the commit to be tagged before tagging. ([\#12556](https://github.com/matrix-org/synapse/issues/12556)) - Fix a typo in the announcement text generated by the Synapse release development script. ([\#12612](https://github.com/matrix-org/synapse/issues/12612)) - Fix scripts-dev to pass typechecking. ([\#12356](https://github.com/matrix-org/synapse/issues/12356)) - Add some type hints to datastore. ([\#12485](https://github.com/matrix-org/synapse/issues/12485)) - Remove unused `# type: ignore`s. ([\#12531](https://github.com/matrix-org/synapse/issues/12531)) - Allow unused `# type: ignore` comments in bleeding edge CI jobs. ([\#12576](https://github.com/matrix-org/synapse/issues/12576)) - Remove redundant lines of config from `mypy.ini`. ([\#12608](https://github.com/matrix-org/synapse/issues/12608)) - Update to mypy 0.950. ([\#12650](https://github.com/matrix-org/synapse/issues/12650)) - Use `Concatenate` to better annotate `_do_execute`. ([\#12666](https://github.com/matrix-org/synapse/issues/12666)) - Use `ParamSpec` to refine type hints. ([\#12667](https://github.com/matrix-org/synapse/issues/12667)) - Fix mypy against latest pillow stubs. ([\#12671](https://github.com/matrix-org/synapse/issues/12671))	2022-05-10 13:17:56 +01:00
Patrick Cloke	b44fbdffa4	Move free functions into PushRuleEvaluatorForEvent. (#12677 ) * Move `_condition_checker` into `PushRuleEvaluatorForEvent`. * Move the condition cache into `PushRuleEvaluatorForEvent`. * Improve docstrings. * Inline a method which is only called once.	2022-05-10 07:54:30 -04:00
Patrick Cloke	02cdace707	Add class-diagrams and notes for push. (#12676 )	2022-05-10 07:43:34 -04:00
reivilibre	699192fc1a	Add the `update_user_directory_from_worker` configuration option (superseding `update_user_directory`) to allow a generic worker to be designated as the worker to update the user directory. (#12654 ) Co-authored-by: Shay <hillerys@element.io>	2022-05-10 11:08:45 +01:00
Erik Johnston	8dd3e0e084	Immediately retry any requests that have backed off when a server comes back online. (#12500 ) Otherwise it can take up to a minute for any in-flight `/send` requests to be retried.	2022-05-10 10:39:54 +01:00
Šimon Brandner	ade3008821	Implement MSC3786: Add a default push rule to ignore m.room.server_acl events (#12601 ) Fixes vector-im/element-web#20788 Implements matrix-org/matrix-spec-proposals#3786	2022-05-10 08:57:36 +01:00
Shay	d80a7ab151	Update `replication.md` with info on TCP module structure (#12621 )	2022-05-09 14:46:43 -07:00
Val Lorentz	bf0c3ca20a	Fix inconsistent spelling of 'M_UNRECOGNIZED'. (#12665 )	2022-05-09 20:29:07 +00:00
Sean Quah	a00462dd99	Implement cancellation support/protection for module callbacks (#12568 ) There's no guarantee that module callbacks will handle cancellation appropriately. Protect module callbacks with read semantics from cancellation and avoid swallowing `CancelledError`s that arise. Other module callbacks, such as the `on_*` callbacks, are presumed to live on code paths that involve writes and aren't cancellation-friendly. These module callbacks have been left alone. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-09 12:31:14 +01:00
David Robertson	8de0facaae	Fix mypy against latest pillow stubs (#12671 )	2022-05-09 10:48:14 +00:00
David Robertson	fa0eab9c8e	Use `ParamSpec` in a few places (#12667 )	2022-05-09 10:27:39 +00:00
Erik Johnston	c5969b346d	Don't error on unknown receipt types (#12670 ) Fixes #12669	2022-05-09 11:09:19 +01:00
David Robertson	26c1ad71c5	Use `Concatenate` to annotate `do_execute` (#12666 )	2022-05-09 10:28:38 +01:00
David Robertson	051a1c3f22	Convert stringy power levels to integers on room upgrade (#12657 )	2022-05-07 13:37:29 +01:00
Erik Johnston	4337d33a73	Prevent memory leak from reoccurring when presence is disabled. (#12656 )	2022-05-06 16:41:57 +00:00
David Robertson	2607b3e181	Update mypy to 0.950 and fix complaints (#12650 )	2022-05-06 12:35:20 +00:00
reivilibre	c2d50e9f6c	Add the `notify_appservices_from_worker` configuration option (superseding `notify_appservices`) to allow a generic worker to be designated as the worker to send traffic to Application Services. (#12452 )	2022-05-06 11:43:53 +01:00
DeepBlueV7.X	a377a43386	Support MSC3266 room summaries over federation (#11507 ) Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>	2022-05-05 15:25:00 +01:00
Šimon Brandner	ef86cf3d28	Update `_on_new_receipts()` to work with MSC2285 changes. (#12636 )	2022-05-05 13:25:51 +00:00
reivilibre	07fa53ec40	Improve comments and error messages around access tokens. (#12577 )	2022-05-05 13:39:59 +01:00
Šimon Brandner	9ae0253f4e	Use `private` instead of `hidden` in MSC2285 related code. (#12635 )	2022-05-05 12:31:25 +00:00
Patrick Cloke	f90d381c7b	Edits/annotations should not have any bundled aggregations calculated. (#12633 ) Fixes a regression from `8b309adb43` (#11660) and `b65acead42` (#11752) where events which themselves were an edit or an annotation could have bundled aggregations calculated, which is not allowed.	2022-05-05 08:15:12 -04:00
Patrick Cloke	ddc8bba00f	Remove unused receipt datastore methods. (#12632 ) The last usage was removed in `5a1dd297c3` (#8059).	2022-05-05 07:51:19 -04:00
Will Hunt	cc7656099d	Fix typo in some instances of enable_registration_token_3pid_bypass. (#12639 )	2022-05-05 07:11:52 -04:00
Erik Johnston	c0379d6e5b	Reduce log spam when running multiple event persisters (#12610 )	2022-05-05 10:20:23 +01:00
Will Hunt	2d74a8c178	Add `mau_appservice_trial_days` config (#12619 ) * Add mau_appservice_trial_days * Add a test * Tweaks * changelog * Ensure we sync after the delay * Fix types * Add config statement * Fix test * Reinstate logging that got removed * Fix feature name	2022-05-04 19:33:26 +01:00
Patrick Cloke	7fbf42499d	Use `getClientAddress` instead of `getClientIP`. (#12599 ) getClientIP was deprecated in Twisted 18.4.0, which also added getClientAddress. The Synapse minimum version for Twisted is currently 18.9.0, so all supported versions have the new API.	2022-05-04 14:11:21 -04:00
Šimon Brandner	116a4c8340	Implement changes to MSC2285 (hidden read receipts) (#12168 ) * Changes hidden read receipts to be a separate receipt type (instead of a field on `m.read`). * Updates the `/receipts` endpoint to accept `m.fully_read`.	2022-05-04 11:59:22 -04:00
Andrew Morgan	332cce8dcf	Disable device name lookup over federation by default (#12616 )	2022-05-04 16:41:40 +01:00
Patrick Cloke	ba3fd54bad	Remove unstable/unspecced login types. (#12597 ) * `m.login.jwt`, which was never specced and has been deprecated since Synapse 1.16.0. (`org.matrix.login.jwt` can be used instead.) * `uk.half-shot.msc2778.login.application_service`, which was stabilized as part of the Matrix spec v1.2 release.	2022-05-04 13:53:21 +00:00
Sean Quah	b2df0716bc	Improve logging for cancelled requests (#12587 ) Don't log stack traces for cancelled requests and use a custom HTTP status code of 499. Signed-off-by: Sean Quah <seanq@element.io>	2022-05-04 13:38:55 +01:00
Patrick Cloke	75dff3dc98	Include bundled aggregations for the latest event in a thread. (#12273 ) The `latest_event` field of the bundled aggregations for `m.thread` relations did not include bundled aggregations itself. This resulted in clients needing to immediately request the event from the server (and thus making it useless that the latest event itself was serialized instead of just including an event ID).	2022-05-04 08:38:18 -04:00
andrew do	01e625513a	remove constantly lib use and switch to enums. (#12624 )	2022-05-04 11:26:11 +00:00
Richard van der Hoff	96e0cdbc5a	Add a consistency check on events read from the database (#12620 ) I've seen a few errors which can only plausibly be explained by the calculated event id for an event being different from the ID of the event in the database. It should be cheap to check this, so let's do so and raise an exception.	2022-05-03 21:27:52 +01:00
Patrick Cloke	aa5f5ede33	Remove unstable identifiers for MSC3069. (#12596 )	2022-05-03 12:43:12 -04:00
Richard van der Hoff	d66d68f917	Add extra debug logging to federation sender (#12614 ) ... in order to debug some problems we've been having with certain events not being sent when expected.	2022-05-03 16:32:40 +01:00
Richard van der Hoff	77dee1b451	fix imports broken in `5938928` :-S	2022-05-03 13:59:28 +01:00
Richard van der Hoff	5938928c59	minor wording fix in docstring	2022-05-03 13:50:50 +01:00
Richard van der Hoff	db2edf5a65	Exclude OOB memberships from the federation sender (#12570 ) As the comment says, there is no need to process such events, and indeed we need to avoid doing so. Fixes #12509.	2022-05-03 12:47:56 +00:00
Erik Johnston	ae7858f184	Fix race when persisting an event and deleting a room (#12594 ) This works by taking a row level lock on the `rooms` table at the start of both transactions, ensuring that they don't run at the same time. In the event persistence transaction we also check that there is an entry still in the `rooms` table. I can't figure out how to do this in SQLite. I was just going to lock the table, but it seems that we don't support that in SQLite either, so I'm really confused as to how we maintain integrity in SQLite when using `lock_table`....	2022-05-03 11:47:21 +01:00
Richard van der Hoff	8d156ec0ba	Remove special-case for `twisted` logger (#12589 ) This was originally added when we first added a `MemoryHandler` to the default log config back in https://github.com/matrix-org/synapse/pull/8040, to ensure that we didn't explode with an infinite loop if there was an error formatting the logs. Since then, we made additional improvements to logging which make this workaround redundant. In particular: * we no longer attempt to log un-UTF8-decodable byte sequences, which were the most likely cause of an error in the first place. * https://github.com/matrix-org/synapse/pull/8268 ensures that in the unlikely case that there is an error, it won't cause an infinite loop.	2022-04-29 22:05:18 +01:00
Patrick Cloke	3ae56d125c	Improve the docstrings for the receipts store. (#12581 )	2022-04-28 17:58:58 +00:00
Sean Quah	0b684b59e5	Fix logging of incorrect status codes for disconnected requests (#12580 ) The status code of requests must always be set, regardless of client disconnection, otherwise they will always be logged as 200!. Broken for `respond_with_json` in `f48792eec4`. Broken for `respond_with_json_bytes` in `3e58ce72b4`. Broken for `respond_with_html_bytes` in `ea26e9a98b`. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-28 15:49:50 +00:00
Sean Quah	78b99de7c2	Prefer `make_awaitable` over `defer.succeed` in tests (#12505 ) When configuring the return values of mocks, prefer awaitables from `make_awaitable` over `defer.succeed`. `Deferred`s are only awaitable once, so it is inappropriate for a mock to return the same `Deferred` multiple times. Also update `run_in_background` to support functions that return arbitrary awaitables. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-27 14:58:26 +01:00
Brendan Abolivier	5ef673de4f	Add a module API to allow modules to edit push rule actions (#12406 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-04-27 13:55:33 +00:00
David Robertson	6463244375	Remove unused `# type: ignore`s (#12531 ) Over time we've begun to use newer versions of mypy, typeshed, stub packages---and of course we've improved our own annotations. This makes some type ignore comments no longer necessary. I have removed them. There was one exception: a module that imports `select.epoll`. The ignore is redundant on Linux, but I've kept it ignored for those of us who work on the source tree using not-Linux. (#11771) I'm more interested in the config line which enforces this. I want unused ignores to be reported, because I think it's useful feedback when annotating to know when you've fixed a problem you had to previously ignore. * Installing extras before typechecking Lacking an easy way to install all extras generically, let's bite the bullet and make install the hand-maintained `all` extra before typechecking. Now that https://github.com/matrix-org/backend-meta/pull/6 is merged to the release/v1 branch.	2022-04-27 14:03:44 +01:00
Patrick Cloke	8a23bde823	Consistently use collections.abc.Mapping to check frozendict. (#12564 )	2022-04-27 09:00:07 -04:00
Will Hunt	e8d1ec0e92	Add option to enable token registration without requiring 3pids (#12526 )	2022-04-27 12:57:53 +00:00
Dirk Klimpel	b76f1a4d5f	Add some type hints to datastore (#12485 )	2022-04-27 13:05:00 +01:00
Nick Mills-Barrett	63ba9ba38b	Bound ephemeral events by key (#12544 ) Co-authored-by: Brad Murray <bradtgmurray@gmail.com> Co-authored-by: Andrew Morgan <andrewm@element.io>	2022-04-26 20:14:21 +01:00
Erik Johnston	f59e3f4c90	Mark remote device list updates as already handled (#12557 )	2022-04-26 17:07:21 +01:00
David Robertson	6d89f1239c	Comment out dodgy log-kv (#12554 )	2022-04-26 15:53:06 +01:00
Erik Johnston	c48ab3734e	Fix sending opentracing contexts to remote servers (#12555 )	2022-04-26 14:48:16 +00:00
Richard van der Hoff	17d99f758a	Optimise backfill calculation (#12522 ) Try to avoid an OOM by checking fewer extremities. Generally this is a big rewrite of _maybe_backfill, to try and fix some of the TODOs and other problems in it. It's best reviewed commit-by-commit.	2022-04-26 10:27:11 +01:00
Sean Quah	8a87b4435a	Handle cancellation in `EventsWorkerStore._get_events_from_cache_or_db` (#12529 ) Multiple calls to `EventsWorkerStore._get_events_from_cache_or_db` can reuse the same database fetch, which is initiated by the first call. Ensure that cancelling the first call doesn't cancel the other calls sharing the same database fetch. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-25 19:39:17 +01:00
Patrick Cloke	185da8f0f2	Misc. clean-ups to the relations code (#12519 ) * Corrects some typos / copy & paste errors in tests. * Clarifies docstrings. * Removes an unnecessary method.	2022-04-25 08:25:56 -04:00
Sean Quah	a50fb411b3	Update `delay_cancellation` to accept any awaitable (#12468 ) This will mainly be useful when dealing with module callbacks, which are all typed as returning `Awaitable`s instead of coroutines or `Deferred`s. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-22 18:20:06 +01:00
Will Hunt	b82fff66df	MSC3202: Fix device_unused_fallback_keys -> device_unused_fallback_key_types (#12520 ) * Fix device_unused_fallback_keys -> device_unused_fallback_key_types * changelog	2022-04-22 16:03:46 +01:00
Richard van der Hoff	f5668f0b4a	Await un-partial-stating after a partial-state join (#12399 ) When we join a room via the faster-joins mechanism, we end up with "partial state" at some points on the event DAG. Many parts of the codebase need to wait for the full state to load. So, we implement a mechanism to keep track of which events have partial state, and wait for them to be fully-populated.	2022-04-21 07:42:03 +01:00
David Robertson	e5a76ec00b	Dump setuptools; correct pyproject version number (#12478 )	2022-04-20 17:33:20 +01:00
Patrick Cloke	103f51d867	Fix Jinja templating error when generating thumbnail URLs. (#12510 ) scale is meant to be a constant string, not refer to a variable.	2022-04-20 12:03:03 -04:00
Tulir Asokan	4bc8cb4669	Implement MSC2815: allow room moderators to view redacted event content (#12427 ) Implements matrix-org/matrix-spec-proposals#2815 Signed-off-by: Tulir Asokan <tulir@maunium.net>	2022-04-20 12:57:39 +01:00
Erik Johnston	c1482a352a	Fix returned count of delete extremities admin API (#12496 )	2022-04-19 16:49:45 +01:00
Richard van der Hoff	b80bb7e452	Fix `/room/.../event/...` to return the original event after any edits (#12476 ) This is what the MSC (now) requires. Fixes https://github.com/matrix-org/synapse/issues/10310.	2022-04-19 16:42:19 +01:00
Jan Christian Grünhage	a1f87f57ff	Implement MSC3383: include destination in X-Matrix auth header (#11398 ) Co-authored-by: Jan Christian Grünhage <jan.christian@gruenhage.xyz> Co-authored-by: Marcus Hoffmann <bubu@bubu1.eu>	2022-04-19 16:23:53 +01:00
Olivier Wilkinson (reivilibre)	0921d93dcd	Merge branch 'master' into develop	2022-04-19 13:28:28 +01:00
Richard van der Hoff	b121a3ad2b	Back out implementation of MSC2314 (#12474 ) MSC2314 has now been closed, so we're backing out its implementation, which originally happened in #6176. Unfortunately it's not a direct revert, as that PR mixed in a bunch of unrelated changes to tests etc.	2022-04-19 11:17:29 +00:00
Olivier Wilkinson (reivilibre)	88fe72cc1e	1.57.0	2022-04-19 11:00:37 +01:00
Travis Ralston	f8d3ee9570	Fix grammatical error in error message (#12483 ) * Fix grammatical error in error message * changelog	2022-04-18 12:41:55 -06:00
Erik Johnston	0b014eb25e	Only send out device list updates for our own users (#12465 ) Broke in #12365	2022-04-14 13:05:31 +01:00
Shay	8e2759f2d8	Limit `device_id` size to 512B (#12454 ) *	2022-04-13 10:04:01 -07:00
David Baker	73d8ded0b0	Prevent a sync request from removing a user's busy presence status (#12213 ) In trying to use the MSC3026 busy presence status, the user's status would be set back to 'online' next time they synced. This change makes it so that syncing does not affect a user's presence status if it is currently set to 'busy': it must be removed through the presence API. The MSC defers to implementations on the behaviour of busy presence, so this ought to remain compatible with the MSC.	2022-04-13 16:21:07 +01:00
Nick Mills-Barrett	e3a49f4784	Fix missing sync events during historical batch imports (#12319 ) Discovered after much in-depth investigation in #12281. Closes: #12281 Closes: #3305 Signed off by: Nick Mills-Barrett nick@beeper.com	2022-04-13 11:38:35 +01:00
Jonathan de Jong	36d8b83888	Rename Mutual Rooms `unstable_features` flag to match MSC (#12445 ) Signed-off-by: Jonathan de Jong <jonathan@automatia.nl>	2022-04-13 10:32:44 +01:00
Erik Johnston	aa28110264	Process device list updates asynchronously (#12365 )	2022-04-12 16:50:40 +01:00
Patrick Cloke	4bdbebccb9	Remove the unstable event field for `/send_join` per MSC3083. (#12395 ) This was missed when initially stabilising room version 8 and was left in as a compatibility shim. Most homeservers have upgraded to a version which expects the proper field name, and the failure mode is reasonable (a user on an older server may have to attempt joining the room twice with an obscure error message the first time).	2022-04-12 11:27:45 -04:00
Erik Johnston	a468768104	Merge branch 'release-v1.57' into develop	2022-04-12 15:28:41 +01:00
Patrick Cloke	9535fd0f9c	Disable groups/communities by default. (#12344 ) This disables the endpoints (and sync response fields) for groups/communities by default.	2022-04-12 10:20:46 -04:00
Richard van der Hoff	320186319a	Resync state after partial-state join (#12394 ) We work through all the events with partial state, updating the state at each of them. Once it's done, we recalculate the state for the whole room, and then mark the room as having complete state.	2022-04-12 13:23:43 +00:00
Patrick Cloke	86cf6a3a17	Remove references to unstable identifiers from MSC3440. (#12382 ) Removes references to unstable thread relation, unstable identifiers for filtering parameters, and the experimental config flag.	2022-04-12 08:42:03 -04:00
Erik Johnston	641f43ba81	1.57.0rc1	2022-04-12 13:39:35 +01:00
Dirk Klimpel	1783156dbc	Add some type hints to datastore (#12423 ) * Add some type hints to datastore * newsfile * change `Collection` to `List` * refactor return type of `select_users_txn` * correct type hint in `stream.py` * Remove `Optional` in `select_users_txn` * remove not needed return type in `__init__` * Revert change in `get_stream_id_for_event_txn` * Remove import from `Literal`	2022-04-12 11:54:00 +01:00
Erik Johnston	3ad74b63e5	Specify tls extra for Twisted dependency. (#12444 ) * Specify `tls` extra for Twisted dependency. It was already pulled in for us by `treq`, but we should be explicit that we do use the `tls` functionality of Twisted directly. * Mark `idna` as dev-dependency This doesn't actually change anything, as `Twisted[tls]` will put it in as a main dependency anyway.	2022-04-12 10:49:02 +00:00
Patrick Cloke	ab3165efb7	Remove experimental configuration flag for MSC3666. (#12436 )	2022-04-11 15:37:46 -04:00
Patrick Cloke	4586119f0b	Add missing type hints to config classes. (#12402 )	2022-04-11 12:07:23 -04:00
Patrick Cloke	772bad2562	Do not consider events by ignored users for bundled aggregations (#12235 ) Consider the requester's ignored users when calculating the bundled aggregations. See #12285 / `4df10d3214` for corresponding changes for the `/relations` endpoint.	2022-04-11 10:09:57 -04:00
David Robertson	961ee75a9b	Disallow untyped defs in synapse._scripts (#12422 ) Of note: * No untyped defs in `register_new_matrix_user` This one might be contraversial. `request_registration` has three dependency-injection arguments used for testing. I'm removing the injection of the `requests` module and using `unitest.mock.patch` in the test cases instead. Doing `reveal_type(requests)` and `reveal_type(requests.get)` before the change: ``` synapse/_scripts/register_new_matrix_user.py:45: note: Revealed type is "Any" synapse/_scripts/register_new_matrix_user.py:46: note: Revealed type is "Any" ``` And after: ``` synapse/_scripts/register_new_matrix_user.py:44: note: Revealed type is "types.ModuleType" synapse/_scripts/register_new_matrix_user.py:45: note: Revealed type is "def (url: Union[builtins.str, builtins.bytes], params: Union[Union[_typeshed.SupportsItems[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]], Tuple[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]], typing.Iterable[Tuple[Union[builtins.str, builtins.bytes, builtins.int, builtins.float], Union[builtins.str, builtins.bytes, builtins.int, builtins.float, typing.Iterable[Union[builtins.str, builtins.bytes, builtins.int, builtins.float]], None]]], builtins.str, builtins.bytes], None] =, data: Union[Any, None] =, headers: Union[Any, None] =, cookies: Union[Any, None] =, files: Union[Any, None] =, auth: Union[Any, None] =, timeout: Union[Any, None] =, allow_redirects: builtins.bool =, proxies: Union[Any, None] =, hooks: Union[Any, None] =, stream: Union[Any, None] =, verify: Union[Any, None] =, cert: Union[Any, None] =, json: Union[Any, None] =) -> requests.models.Response" ``` * Drive-by comment in `synapse.storage.types` * No untyped defs in `synapse_port_db` This was by far the most painful. I'm happy to break this up into smaller pieces for review if it's not managable as-is.	2022-04-11 12:41:55 +01:00
reivilibre	85ca963c1a	Add Module API for reading and writing global account data. (#12391 )	2022-04-11 10:05:43 +01:00
reivilibre	e630722f11	Optimise `_update_client_ips_batch_txn` to batch together database operations. (#12252 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-04-08 15:29:13 +01:00
David Robertson	0cd182f296	Make `synapse._scripts` pass typechecks (#12421 )	2022-04-08 14:00:12 +00:00
David Robertson	95a038c106	Unify HTTP query parameter type hints (#12415 ) * Pull out query param types to `synapse.http.types` * Use QueryParams everywhere * Simplify `encode_query_args` * Add annotation which would have caught #12410	2022-04-08 13:06:51 +01:00
Jorge Florian	2e2d8cc2f9	Update the server notices user profile in room if changed. (#12115 )	2022-04-08 07:51:27 -04:00
Erik Johnston	7732c4902c	Fix rejecting invites over federation (#12409 ) Currently causes future incremental syncs to fail. Broke by #12191	2022-04-07 15:54:16 +01:00
Erik Johnston	36af768c13	Fix fetching public rooms over federation (#12410 ) Broke by #12364	2022-04-07 14:18:02 +00:00
Patrick Cloke	1a90c1e3af	Do not add groups to sync results if disabled. (#12408 )	2022-04-07 09:29:56 -04:00
Erik Johnston	d1cd96ce29	Add opentracing spans to calls to external cache (#12380 )	2022-04-07 13:18:29 +01:00
Patrick Cloke	0bcb651b3f	Support the v1 endpoint for `/relations`. (#12403 ) Now that MSC2675 has passed FCP and the implementation is compliant with the final version.	2022-04-07 07:08:23 -04:00
Patrick Cloke	05a37f4008	Remove support for the unstable identifier from MSC3288. (#12398 )	2022-04-06 13:27:46 -04:00
David Robertson	2cf74cf2fc	Narrow the `importlib_metadata` dependency (#12400 )	2022-04-06 17:37:56 +01:00
Richard van der Hoff	6fe757d69e	Fix `synapse_event_persisted_position` metric (#12390 ) Fixes a bug introduced in #11417 where we would only included backfilled events in `synapse_event_persisted_position`	2022-04-06 13:52:39 +00:00
Richard van der Hoff	ae01a7edd3	Update type annotations for compatiblity with prometheus_client 0.14 (#12389 ) Principally, `prometheus_client.REGISTRY.register` now requires its argument to extend `prometheus_client.Collector`. Additionally, `Gauge.set` is now annotated so that passing `Optional[int]` causes an error.	2022-04-06 12:59:04 +00:00
Eric Eastwood	793d03e2c5	Generate historic pagination token for `/messages` when no `?from` token provided (#12370 )	2022-04-06 11:40:28 +01:00
David Robertson	573cd0f92f	Add missing dependency on importlib_metadata (#12384 )	2022-04-05 18:25:56 +00:00
Sean Quah	fd1e7d0fc2	Post 1.56.0 release tidy up (#12379 )	2022-04-05 17:35:20 +01:00
Sean Quah	79e7c2c426	Fix edge case where a `Linearizer` could get stuck (#12358 ) Just after a task acquires a contended `Linearizer` lock, it sleeps. If the task is cancelled during this sleep, we need to release the lock. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-05 17:19:16 +01:00
Sean Quah	31c1209c50	Make `StreamToken` and `RoomStreamToken` methods propagate cancellations (#12366 ) `StreamToken.from_string` and `RoomStreamToken.parse` are both async methods that could be cancelled. These methods must not replace `CancelledError`s with `SynapseError`s. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-05 16:56:52 +01:00
Sean Quah	800ba87cc8	Refactor and convert `Linearizer` to async (#12357 ) Refactor and convert `Linearizer` to async. This makes a `Linearizer` cancellation bug easier to fix. Also refactor to use an async context manager, which eliminates an unlikely footgun where code that doesn't immediately use the context manager could forget to release the lock. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-05 15:43:52 +01:00
Sean Quah	ab3fdcf960	Merge branch 'master' into develop	2022-04-05 15:14:53 +01:00
Erik Johnston	66053b6bfb	Prefill more stream change caches. (#12372 )	2022-04-05 14:26:41 +01:00
reivilibre	42d8710f38	Fix a spec compliance issue where requests to the `/publicRooms` federation API would specify `limit` as a string. (#12364 )	2022-04-05 12:45:36 +01:00
Sean Quah	7a95e80418	1.56.0	2022-04-05 12:44:00 +01:00
Richard van der Hoff	efdbcfd6af	Synapse 1.56.0rc1 (2022-03-29) ============================== Features -------- - Allow modules to store already existing 3PID associations. ([\#12195](https://github.com/matrix-org/synapse/issues/12195)) - Allow registering server administrators using the module API. Contributed by Famedly. ([\#12250](https://github.com/matrix-org/synapse/issues/12250)) Bugfixes -------- - Fix a long-standing bug which caused the `/_matrix/federation/v1/state` and `/_matrix/federation/v1/state_ids` endpoints to return incorrect or invalid data when called for an event which we have stored as an "outlier". ([\#12087](https://github.com/matrix-org/synapse/issues/12087)) - Fix a long-standing bug where events from ignored users would still be considered for relations. ([\#12227](https://github.com/matrix-org/synapse/issues/12227), [\#12232](https://github.com/matrix-org/synapse/issues/12232), [\#12285](https://github.com/matrix-org/synapse/issues/12285)) - Fix a bug introduced in Synapse 1.53.0 where an unnecessary query could be performed when fetching bundled aggregations for threads. ([\#12228](https://github.com/matrix-org/synapse/issues/12228)) - Fix a bug introduced in Synapse 1.52.0 where admins could not deactivate and GDPR-erase a user if Synapse was configured with limits on avatars. ([\#12261](https://github.com/matrix-org/synapse/issues/12261)) Improved Documentation ---------------------- - Fix the link to the module documentation in the legacy spam checker warning message. ([\#12231](https://github.com/matrix-org/synapse/issues/12231)) - Remove incorrect prefixes in the worker documentation for some endpoints. ([\#12243](https://github.com/matrix-org/synapse/issues/12243)) - Correct `check_username_for_spam` annotations and docs. ([\#12246](https://github.com/matrix-org/synapse/issues/12246)) - Correct Authentik OpenID typo, and add notes on troubleshooting. Contributed by @IronTooch. ([\#12275](https://github.com/matrix-org/synapse/issues/12275)) - HAProxy reverse proxy guide update to stop sending IPv4-mapped address to homeserver. Contributed by @villepeh. ([\#12279](https://github.com/matrix-org/synapse/issues/12279)) Internal Changes ---------------- - Rename `shared_rooms` to `mutual_rooms` ([MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)), as per proposal changes. ([\#12036](https://github.com/matrix-org/synapse/issues/12036)) - Remove check on `update_user_directory` for shared rooms handler ([MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)), and update/expand documentation. ([\#12038](https://github.com/matrix-org/synapse/issues/12038)) - Refactor `create_new_client_event` to use a new parameter, `state_event_ids`, which accurately describes the usage with [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) instead of abusing `auth_event_ids`. ([\#12083](https://github.com/matrix-org/synapse/issues/12083), [\#12304](https://github.com/matrix-org/synapse/issues/12304)) - Refuse to start if registration is enabled without email, captcha, or token-based verification unless the new config flag `enable_registration_without_verification` is set. ([\#12091](https://github.com/matrix-org/synapse/issues/12091)) - Add tests for database transaction callbacks. ([\#12198](https://github.com/matrix-org/synapse/issues/12198)) - Handle cancellation in `DatabasePool.runInteraction`. ([\#12199](https://github.com/matrix-org/synapse/issues/12199)) - Add missing type hints for cache storage. ([\#12216](https://github.com/matrix-org/synapse/issues/12216)) - Add missing type hints for storage. ([\#12248](https://github.com/matrix-org/synapse/issues/12248), [\#12255](https://github.com/matrix-org/synapse/issues/12255)) - Add type hints to tests files. ([\#12224](https://github.com/matrix-org/synapse/issues/12224), [\#12240](https://github.com/matrix-org/synapse/issues/12240), [\#12256](https://github.com/matrix-org/synapse/issues/12256)) - Use type stubs for `psycopg2`. ([\#12269](https://github.com/matrix-org/synapse/issues/12269)) - Improve type annotations for `execute_values`. ([\#12311](https://github.com/matrix-org/synapse/issues/12311)) - Clean-up logic around rebasing URLs for URL image previews. ([\#12219](https://github.com/matrix-org/synapse/issues/12219)) - Use the `ignored_users` table in additional places instead of re-parsing the account data. ([\#12225](https://github.com/matrix-org/synapse/issues/12225)) - Refactor the relations endpoints to add a `RelationsHandler`. ([\#12237](https://github.com/matrix-org/synapse/issues/12237)) - Generate announcement links in the release script. ([\#12242](https://github.com/matrix-org/synapse/issues/12242)) - Improve error message when dependencies check finds a broken installation. ([\#12244](https://github.com/matrix-org/synapse/issues/12244)) - Compress metrics HTTP resource when enabled. Contributed by Nick @ Beeper. ([\#12258](https://github.com/matrix-org/synapse/issues/12258)) - Refuse to start if the PostgreSQL database has a non-`C` locale, unless the config flag `allow_unsafe_db_locale` is set to true. ([\#12262](https://github.com/matrix-org/synapse/issues/12262), [\#12288](https://github.com/matrix-org/synapse/issues/12288)) - Optionally include account validity expiration information to experimental [MSC3720](https://github.com/matrix-org/matrix-doc/pull/3720) account status responses. ([\#12266](https://github.com/matrix-org/synapse/issues/12266)) - Add a new cache `_get_membership_from_event_id` to speed up push rule calculations in large rooms. ([\#12272](https://github.com/matrix-org/synapse/issues/12272)) - Re-enable Complement concurrency in CI. ([\#12283](https://github.com/matrix-org/synapse/issues/12283)) - Remove unused test utilities. ([\#12291](https://github.com/matrix-org/synapse/issues/12291)) - Enhance logging for inbound federation events. ([\#12301](https://github.com/matrix-org/synapse/issues/12301)) - Fix compatibility with the recently-released Jinja 3.1. ([\#12313](https://github.com/matrix-org/synapse/issues/12313)) - Avoid trying to calculate the state at outlier events. ([\#12314](https://github.com/matrix-org/synapse/issues/12314)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEdVkXOgzrGzds0jtrHgFcFF8ZFs0FAmJC33MACgkQHgFcFF8Z Fs0IFhAAhz45kNCqWfBip8yc7GE95ZnMfX4PymrIQeJOtloecQCyRrcS8r0GJhvq j5cRfMNoaoMZKOQsqyjLiY02QUX/8hUOgAD4SEa9Jmc4a2ZwjJ3hxy8dKx89gdZ+ E+uUhJZUNV9UovDIOYd+DPB1//tFdzfYtZmbmddJbWv2jZwb4fmTEnK+j5dp4TMR Z6/aA1IQB2PZqihQLmtKHCC6xCv7zaCmvS7Z1oUACOm7W1cX0F2P51M11+rK5ipi tasRBhdGmMu9eGm9QfeQkY++5HLjTfNuSwSP37tP5RMjKckpJS7f6vooJ7EtVtaY YPlTsjsngWaDk+ETK9ZN3ATtI1StB+6agiTAjO3kJzai++eKQaNrkzIhhftLYfsa 2CIoy2BM7iPp/u+MF5VkxN/QCcnK43VuDU+iR8MCzjTQJPSxsAYrjsd8MMD0rCBa dib2IdF1Xlijg0iSdV/ToeMx/KDYh+l5hcltkLy1To68IvFqf0kGvlcDk2rtLWzz QsWf5PGc+YXQM8IMF38BmuE1HCI0rEJH5V/Jl1UkXFaQdf1bIXmWxKTNHjVP/2Uq dfI4qPtszWOjJT7bBgJbjqX1QBzzIU7ShM8cRlj4Lfc6bdhWG3G+CCACl29t/T9K NBboIPEbCqw2GJMz1EoNciRHhFnsvQyG1QaHywRwaIuzNX8ohEw= =J5w/ -----END PGP SIGNATURE----- Merge tag 'v1.56.0rc1' into develop Synapse 1.56.0rc1 (2022-03-29) ============================== Features -------- - Allow modules to store already existing 3PID associations. ([\#12195](https://github.com/matrix-org/synapse/issues/12195)) - Allow registering server administrators using the module API. Contributed by Famedly. ([\#12250](https://github.com/matrix-org/synapse/issues/12250)) Bugfixes -------- - Fix a long-standing bug which caused the `/_matrix/federation/v1/state` and `/_matrix/federation/v1/state_ids` endpoints to return incorrect or invalid data when called for an event which we have stored as an "outlier". ([\#12087](https://github.com/matrix-org/synapse/issues/12087)) - Fix a long-standing bug where events from ignored users would still be considered for relations. ([\#12227](https://github.com/matrix-org/synapse/issues/12227), [\#12232](https://github.com/matrix-org/synapse/issues/12232), [\#12285](https://github.com/matrix-org/synapse/issues/12285)) - Fix a bug introduced in Synapse 1.53.0 where an unnecessary query could be performed when fetching bundled aggregations for threads. ([\#12228](https://github.com/matrix-org/synapse/issues/12228)) - Fix a bug introduced in Synapse 1.52.0 where admins could not deactivate and GDPR-erase a user if Synapse was configured with limits on avatars. ([\#12261](https://github.com/matrix-org/synapse/issues/12261)) Improved Documentation ---------------------- - Fix the link to the module documentation in the legacy spam checker warning message. ([\#12231](https://github.com/matrix-org/synapse/issues/12231)) - Remove incorrect prefixes in the worker documentation for some endpoints. ([\#12243](https://github.com/matrix-org/synapse/issues/12243)) - Correct `check_username_for_spam` annotations and docs. ([\#12246](https://github.com/matrix-org/synapse/issues/12246)) - Correct Authentik OpenID typo, and add notes on troubleshooting. Contributed by @IronTooch. ([\#12275](https://github.com/matrix-org/synapse/issues/12275)) - HAProxy reverse proxy guide update to stop sending IPv4-mapped address to homeserver. Contributed by @villepeh. ([\#12279](https://github.com/matrix-org/synapse/issues/12279)) Internal Changes ---------------- - Rename `shared_rooms` to `mutual_rooms` ([MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)), as per proposal changes. ([\#12036](https://github.com/matrix-org/synapse/issues/12036)) - Remove check on `update_user_directory` for shared rooms handler ([MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666)), and update/expand documentation. ([\#12038](https://github.com/matrix-org/synapse/issues/12038)) - Refactor `create_new_client_event` to use a new parameter, `state_event_ids`, which accurately describes the usage with [MSC2716](https://github.com/matrix-org/matrix-doc/pull/2716) instead of abusing `auth_event_ids`. ([\#12083](https://github.com/matrix-org/synapse/issues/12083), [\#12304](https://github.com/matrix-org/synapse/issues/12304)) - Refuse to start if registration is enabled without email, captcha, or token-based verification unless the new config flag `enable_registration_without_verification` is set. ([\#12091](https://github.com/matrix-org/synapse/issues/12091)) - Add tests for database transaction callbacks. ([\#12198](https://github.com/matrix-org/synapse/issues/12198)) - Handle cancellation in `DatabasePool.runInteraction`. ([\#12199](https://github.com/matrix-org/synapse/issues/12199)) - Add missing type hints for cache storage. ([\#12216](https://github.com/matrix-org/synapse/issues/12216)) - Add missing type hints for storage. ([\#12248](https://github.com/matrix-org/synapse/issues/12248), [\#12255](https://github.com/matrix-org/synapse/issues/12255)) - Add type hints to tests files. ([\#12224](https://github.com/matrix-org/synapse/issues/12224), [\#12240](https://github.com/matrix-org/synapse/issues/12240), [\#12256](https://github.com/matrix-org/synapse/issues/12256)) - Use type stubs for `psycopg2`. ([\#12269](https://github.com/matrix-org/synapse/issues/12269)) - Improve type annotations for `execute_values`. ([\#12311](https://github.com/matrix-org/synapse/issues/12311)) - Clean-up logic around rebasing URLs for URL image previews. ([\#12219](https://github.com/matrix-org/synapse/issues/12219)) - Use the `ignored_users` table in additional places instead of re-parsing the account data. ([\#12225](https://github.com/matrix-org/synapse/issues/12225)) - Refactor the relations endpoints to add a `RelationsHandler`. ([\#12237](https://github.com/matrix-org/synapse/issues/12237)) - Generate announcement links in the release script. ([\#12242](https://github.com/matrix-org/synapse/issues/12242)) - Improve error message when dependencies check finds a broken installation. ([\#12244](https://github.com/matrix-org/synapse/issues/12244)) - Compress metrics HTTP resource when enabled. Contributed by Nick @ Beeper. ([\#12258](https://github.com/matrix-org/synapse/issues/12258)) - Refuse to start if the PostgreSQL database has a non-`C` locale, unless the config flag `allow_unsafe_db_locale` is set to true. ([\#12262](https://github.com/matrix-org/synapse/issues/12262), [\#12288](https://github.com/matrix-org/synapse/issues/12288)) - Optionally include account validity expiration information to experimental [MSC3720](https://github.com/matrix-org/matrix-doc/pull/3720) account status responses. ([\#12266](https://github.com/matrix-org/synapse/issues/12266)) - Add a new cache `_get_membership_from_event_id` to speed up push rule calculations in large rooms. ([\#12272](https://github.com/matrix-org/synapse/issues/12272)) - Re-enable Complement concurrency in CI. ([\#12283](https://github.com/matrix-org/synapse/issues/12283)) - Remove unused test utilities. ([\#12291](https://github.com/matrix-org/synapse/issues/12291)) - Enhance logging for inbound federation events. ([\#12301](https://github.com/matrix-org/synapse/issues/12301)) - Fix compatibility with the recently-released Jinja 3.1. ([\#12313](https://github.com/matrix-org/synapse/issues/12313)) - Avoid trying to calculate the state at outlier events. ([\#12314](https://github.com/matrix-org/synapse/issues/12314))	2022-04-05 12:26:20 +01:00
Sean Quah	ca7e34cb57	Pin signedjson to <= 1.1.1 as a temporary workaround for #12324 To be reverted after the Synapse 1.56 release. Signed-off-by: Sean Quah <seanq@element.io>	2022-04-05 12:13:44 +01:00
David Robertson	a7293ef16f	Bump `black` and `click` versions (#12320 )	2022-04-05 11:04:28 +01:00
Eric Eastwood	5218fe7670	Explain how to decipher live and historic pagination tokens (#12317 )	2022-04-05 10:57:09 +01:00
Eric Eastwood	9633eb2162	Allow non-member state sent in room batch to resolve for historic events (MSC2716) (#12329 ) Part of https://github.com/matrix-org/synapse/issues/12110 Complement test: https://github.com/matrix-org/complement/pull/354 Previously, they didn't resolve because async `filter_events_for_client` removes all outlier state except for out-of-band membership. And fundamentally, we have the state at these events so they shouldn't be marked as outliers.	2022-04-04 14:54:50 -05:00
Erik Johnston	b446c99ac9	Prefill the device_list_stream_cache (#12367 ) * Prefill the device_list_stream_cache * Newsfile * Newsfile	2022-04-04 20:12:25 +01:00
Erik Johnston	5c9e39e619	Track device list updates per room. (#12321 ) This is a first step in dealing with #7721. The idea is basically that rather than calculating the full set of users a device list update needs to be sent to up front, we instead simply record the rooms the user was in at the time of the change. This will allow a few things: 1. we can defer calculating the set of remote servers that need to be poked about the change; and 2. during `/sync` and `/keys/changes` we can avoid also avoid calculating users who share rooms with other users, and instead just look at the rooms that have changed. However, care needs to be taken to correctly handle server downgrades. As such this PR writes to both `device_lists_changes_in_room` and the `device_lists_outbound_pokes` table synchronously. In a future release we can then bump the database schema compat version to `69` and then we can assume that the new `device_lists_changes_in_room` exists and is handled. There is a temporary option to disable writing to `device_lists_outbound_pokes` synchronously, allowing us to test the new code path does work (and by implication upgrading to a future release and downgrading to this one will work correctly). Note: Ideally we'd do the calculation of room to servers on a worker (e.g. the background worker), but currently only master can write to the `device_list_outbound_pokes` table.	2022-04-04 15:25:20 +01:00
reivilibre	c4cf916ed7	Default to `private` room visibility rather than `public` when a client does not specify one, according to spec. (#12350 )	2022-04-01 15:55:09 +01:00
Nick Mills-Barrett	993d90f82b	Use a sequence to generate AS transaction IDs, drop `last_txn` AS state (#12209 ) Switching to a sequence means there's no need to track `last_txn` on the AS state table to generate new TXN IDs. This also means that there is no longer contention between the AS scheduler and AS handler on updates to the `application_services_state` table, which will prevent serialization errors during the complete AS txn transaction.	2022-04-01 13:33:25 +00:00
reivilibre	f871222880	Move `update_client_ip` background job from the main process to the background worker. (#12251 )	2022-04-01 13:08:55 +01:00
Richard van der Hoff	319a805cd3	Raise an exception when getting state at an outlier (#12191 ) It seems like calling `_get_state_group_for_events` for an event where the state is unknown is an error. Accordingly, let's raise an exception rather than silently returning an empty result.	2022-04-01 13:01:49 +01:00
Richard van der Hoff	9b43df1f7b	Optimise `_get_state_after_missing_prev_event`: use `/state` (#12040 ) If we're missing most of the events in the room state, then we may as well call the /state endpoint, instead of individually requesting each and every event.	2022-04-01 12:53:42 +01:00
Brendan Abolivier	e4409301ba	Add a module callback to react to account data changes (#12327 ) Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2022-04-01 11:22:48 +02:00
Amanda Graven	4e900ece42	Add set_user_admin function to the module API (#12341 )	2022-04-01 09:31:30 +01:00
Patrick Cloke	bebf994ee8	Move MSC2654 support behind an experimental configuration flag. (#12295 ) To match the current thinking on disabling experimental features by default.	2022-03-31 15:05:13 -04:00
Richard van der Hoff	6927d87254	Handle outliers in `/federation/v1/event` (#12332 ) The intention here is to avoid doing state lookups for outliers in `/_matrix/federation/v1/event`. Unfortunately that's expanded into something of a rewrite of `filter_events_for_server`, which ended up trying to do that operation in a couple of places.	2022-03-31 17:39:34 +00:00
Patrick Cloke	11df4ec6c2	Add more type hints to the main state store. (#12267 )	2022-03-31 13:38:09 -04:00
Brendan Abolivier	5e88143dff	Add a callback to react to 3PID associations (#12302 )	2022-03-31 18:27:21 +02:00
Patrick Cloke	adbf975623	Remove an unnecessary class from the relations code. (#12338 ) The PaginationChunk class attempted to bundle some properties together, but really just caused callers to jump through hoops and hid implementation details.	2022-03-31 07:13:49 -04:00
Brendan Abolivier	f96b85eca8	Ensure the type of URL attributes is always str when matching against preview blacklist (#12333 )	2022-03-31 11:49:49 +02:00
Patrick Cloke	c31c1091d4	Remove the unused and unstable `/aggregations` endpoint. (#12293 ) This endpoint was removed from MSC2675 before it was approved. It is currently unspecified (even in any MSCs) and therefore subject to removal. It is not implemented by any known clients. This also changes the bundled aggregation format for `m.annotation`, which previously included pagination tokens for the `/aggregations` endpoint, which are no longer useful.	2022-03-30 11:45:32 -04:00
Andrew Morgan	d8d0271977	Send device list updates to application services (MSC3202) - part 1 (#11881 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-30 14:39:27 +01:00
Andrew Morgan	c8cbd66d3b	Start application service stream token tracking from 1 (#12193 ) Co-authored-by: Erik Johnston <erik@matrix.org>	2022-03-30 11:10:12 +00:00
Richard van der Hoff	9b67715bc3	Disable proactive sends for remote joins (#12330 ) Do not attempt to send remote joins out over federation. Normally, it will do nothing; occasionally, it will do the wrong thing.	2022-03-30 12:04:35 +01:00
Brendan Abolivier	437a8ed9ef	Add a configuration to exclude rooms from sync response (#12310 )	2022-03-30 09:43:04 +00:00
David Robertson	e0bb268134	Fix typechecker problems exposed by signedjson 1.1.2 (#12326 )	2022-03-29 21:37:50 +00:00
Richard van der Hoff	1f32b90b0f	Room batch: fix up handling of unknown prev_event_ids (#12316 )	2022-03-29 14:56:25 +01:00
Sean Quah	8a519f8abc	Update `LoggingTransaction.call_after` and `call_on_exception` docstrings (#12315 ) Document the behaviour of `LoggingTransaction.call_after` and `LoggingTransaction.call_on_exception` when transactions are retried. Signed-off-by: Sean Quah <seanq@element.io>	2022-03-29 12:31:05 +01:00
David Robertson	a2b00a4486	Bump `black` and `click` versions (#12320 )	2022-03-29 10:41:19 +00:00
Brendan Abolivier	b690fe749b	1.56.0rc1	2022-03-29 10:41:04 +01:00
Eric Eastwood	6f2943714b	Remove unused `auth_event_ids` argument plumbing (#12304 ) Follow-up to https://github.com/matrix-org/synapse/pull/12083 Since we are now using the new `state_event_ids` parameter to do all of the heavy lifting. We can remove any spots where we plumbed `auth_event_ids` just for MSC2716 things in https://github.com/matrix-org/synapse/pull/9247/files. Removing `auth_event_ids` from following functions: - `create_and_send_nonmember_event` - `_local_membership_update` - `update_membership` - `update_membership_locked`	2022-03-29 09:18:52 +01:00
Richard van der Hoff	287a9c1e20	Exclude outliers in `on_backfill_request` (#12314 ) When we are processing a `/backfill` request from a remote server, exclude any outliers from consideration early on. We can't return outliers anyway (since we don't know the state at the outlier), and filtering them out earlier means that we won't attempt to calulate the state for them.	2022-03-28 19:20:14 +01:00
Dirk Klimpel	ac95167d2f	Add some type hints to datastore. (#12255 )	2022-03-28 14:11:14 -04:00
Brendan Abolivier	4ba55a620f	Un-revert Jinja2 fix (#12313 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2022-03-28 17:02:57 +00:00
Brendan Abolivier	8cd760fca8	Allow modules to store already existing 3PID associations (#12195 )	2022-03-28 18:57:19 +02:00
reivilibre	89f11f8c6f	Improve type annotations for `execute_values`. (#12311 )	2022-03-28 17:21:23 +01:00
Shay	3c41d87b67	Add restrictions by default to open registration in Synapse (#12091 )	2022-03-25 10:11:01 -07:00
Erik Johnston	7ca8ee67a5	Add cache for `get_membership_from_event_ids` (#12272 ) This should speed up push rule calculations for rooms with large numbers of local users when the main push rule cache fails. Co-authored-by: reivilibre <oliverw@matrix.org>	2022-03-25 14:58:56 +00:00
Richard van der Hoff	38adf14998	Enhance logging for inbound federation events (#12301 ) It is currently rather hard to see which rooms are causing inbound federation traffic. Add the room id to the logs.	2022-03-25 14:44:57 +00:00
Eric Eastwood	14662d3c18	Refactor `create_new_client_event` to use a new parameter, `state_event_ids`, which accurately describes the usage with MSC2716 instead of abusing `auth_event_ids` (#12083 ) Spawned from https://github.com/matrix-org/synapse/pull/10975#discussion_r813183430 Part of [MSC2716](https://github.com/matrix-org/matrix-spec-proposals/pull/2716)	2022-03-25 09:21:06 -05:00
David Robertson	fffb3c4c8f	Always allow the empty string as an avatar_url. (#12261 ) Hopefully this fixes #12257. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-25 13:28:42 +00:00
Richard van der Hoff	b0659a112d	Merge branch 'master' into develop	2022-03-24 19:39:45 +00:00
Richard van der Hoff	1642abd77e	1.55.2	2022-03-24 19:13:20 +00:00
Andrew Morgan	84eb14c4d2	Pin Jinja to <3.1.0 (#12297 ) as 3.1.0 removed the deprecated jinja2.Markup class which we still rely on.	2022-03-24 18:59:31 +00:00
Andrew Morgan	0004260952	Revert "Replace instances of deprecated `Jinja2.Markup` with `markupsafe.Markup`" (#12296 ) This reverts commit `8810c93e82`.	2022-03-24 18:42:04 +00:00
Andrew Morgan	a503c2c388	Merge branch 'master' into develop	2022-03-24 18:14:26 +00:00
Andrew Morgan	088f3ae182	1.55.1	2022-03-24 17:47:03 +00:00
Andrew Morgan	8810c93e82	Replace instances of deprecated `Jinja2.Markup` with `markupsafe.Markup` (#12289 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-24 17:16:13 +00:00
Patrick Cloke	4df10d3214	Do not consider events by ignored users for relations (#12285 ) Filter the events returned from `/relations` for the requester's ignored users in a similar way to `/messages` (and `/sync`).	2022-03-24 10:25:42 -04:00
Brendan Abolivier	5436b014f4	Optionally include account validity in MSC3720 account status responses (#12266 )	2022-03-24 11:19:41 +01:00
Shay	e78d4f61fc	Refuse to start if DB has an unsafe locale (#12262 )	2022-03-23 10:23:05 -07:00
David Robertson	f4c5e5864c	Use psycopg2 type stubs (#12269 )	2022-03-23 14:03:24 +00:00
Jonathan de Jong	c5776780f0	Remove mutual_rooms `update_user_directory` check, and add extra documentation (#12038 ) Resolves #10339	2022-03-23 12:47:07 +00:00
Nicolas Werner	692b82838e	Allow registering admin users using the module API (#12250 ) Signed-off-by: Nicolas Werner <n.werner@famedly.com>	2022-03-23 12:48:47 +01:00
Jonathan de Jong	516d092ff9	Rename shared_rooms to mutual_rooms (#12036 ) Co-authored-by: reivilibre <olivier@librepush.net>	2022-03-23 11:19:20 +00:00
Andrew Morgan	831d4797ab	Merge branch 'master' into develop	2022-03-22 16:31:28 +00:00
Andrew Morgan	34baf76451	1.55.0	2022-03-22 14:02:52 +00:00
Michael Telatynski	01211e0c16	Tweak copy for sso account details template (#12265 ) * Tweak copy for sso account details template * Update sso footer copyright year * Add newsfragment Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>	2022-03-22 10:22:25 +00:00
David Robertson	0a59f977a2	Merge branch 'release-v1.55' into develop	2022-03-21 12:29:53 +00:00
reivilibre	6134b3079e	Reword 'Choose your user name' as 'Choose your account name' in the SSO registration template, in order to comply with SIWA guidelines. (#12260 ) * Reword as 'Choose your account name' * Newsfile Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>	2022-03-21 12:16:46 +00:00
Nick Mills-Barrett	1530cef192	Make it possible to enable compression for the metrics HTTP resource (#12258 ) * Make it possible to enable compression for the metrics HTTP resource This can provide significant bandwidth savings pulling metrics from synapse instances. * Add changelog file. * Fix type hint	2022-03-21 11:52:10 +00:00
Richard van der Hoff	afa17f0eab	Return a 404 from `/state` for an outlier (#12087 ) * Replace `get_state_for_pdu` with `get_state_ids_for_pdu` and `get_events_as_list`. * Return a 404 from `/state` and `/state_ids` for an outlier	2022-03-21 11:23:32 +00:00
David Robertson	bf9d549e3a	Try to detect borked package installations. (#12244 ) * Try to detect borked package installations. Fixes #12223. Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-03-18 19:03:46 +00:00
Patrick Cloke	8fe930c215	Move get_bundled_aggregations to relations handler. (#12237 ) The get_bundled_aggregations code is fairly high-level and uses a lot of store methods, we move it into the handler as that seems like a better fit.	2022-03-18 17:49:32 +00:00
Patrick Cloke	80e0e1f35e	Only fetch thread participation for events with threads. (#12228 ) We fetch the thread summary in two phases: 1. The summary that is shared by all users (count of messages and latest event). 2. Whether the requesting user has participated in the thread. There's no use in attempting step 2 for events which did not return a summary from step 1.	2022-03-18 17:15:45 +00:00
Dirk Klimpel	c46065fa3d	Add some type hints to datastore (#12248 ) * inherit `MonthlyActiveUsersStore` from `RegistrationWorkerStore` Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-18 15:24:18 +00:00
David Robertson	872dbb0181	Correct `check_username_for_spam` annotations and docs (#12246 ) * Formally type the UserProfile in user searches * export UserProfile in synapse.module_api * Update docs Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-03-18 13:51:41 +00:00
Patrick Cloke	3f7cfbc9e5	Merge branch 'release-v1.55' into develop	2022-03-16 12:22:07 -04:00
Patrick Cloke	96274565ff	Fix bundling aggregations if unsigned is not a returned event field. (#12234 ) An error occured if a filter was supplied with `event_fields` which did not include `unsigned`. In that case, bundled aggregations are still added as the spec states it is allowed for servers to add additional fields.	2022-03-16 12:17:39 -04:00
Sean Quah	6121056740	Handle cancellation in `DatabasePool.runInteraction()` (#12199 ) To handle cancellation, we ensure that `after_callback`s and `exception_callback`s are always run, since the transaction will complete on another thread regardless of cancellation. We also wait until everything is done before releasing the `CancelledError`, so that logging contexts won't get used after they have been finished. Signed-off-by: Sean Quah <seanq@element.io>	2022-03-16 15:07:41 +00:00
Patrick Cloke	fc9bd620ce	Add a relations handler to avoid duplication. (#12227 ) Adds a handler layer between the REST and datastore layers for relations.	2022-03-16 10:39:15 -04:00
Patrick Cloke	c486fa5fd9	Add some missing type hints to cache datastore. (#12216 )	2022-03-16 10:37:04 -04:00
David Robertson	86965605a4	Fix dead link in spam checker warning (#12231 )	2022-03-16 13:52:59 +00:00
Patrick Cloke	4587b35929	Clean-up logic for rebasing URLs during URL preview. (#12219 ) By using urljoin from the standard library and reducing the number of places URLs are rebased.	2022-03-16 07:21:36 -04:00
Patrick Cloke	dda9b7fc4d	Use the ignored_users table to test event visibility & sync. (#12225 ) Instead of fetching the raw account data and re-parsing it. The ignored_users table is a denormalised version of the account data for quick searching.	2022-03-15 14:06:05 -04:00
David Robertson	d1130a249b	1.55.0rc1	2022-03-15 11:00:01 +00:00
Sean Quah	2fcf4b3f6c	Add cancellation support to `@cached` and `@cachedList` decorators (#12183 ) These decorators mostly support cancellation already. Add cancellation tests and fix use of finished logging contexts by delaying cancellation, as suggested by @erikjohnston. Signed-off-by: Sean Quah <seanq@element.io>	2022-03-14 19:04:29 +00:00
Sean Quah	605d161d7d	Add cancellation support to `ReadWriteLock` (#12120 ) Also convert `ReadWriteLock` to use async context managers. Signed-off-by: Sean Quah <seanq@element.io>	2022-03-14 18:49:07 +00:00
Sean Quah	8e5706d144	Fix broken background updates when using sqlite with `enable_search` off (#12215 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-03-14 17:52:58 +00:00
Sean Quah	90b2327066	Add `delay_cancellation` utility function (#12180 ) `delay_cancellation` behaves like `stop_cancellation`, except it delays `CancelledError`s until the original `Deferred` resolves. This is handy for unifying cleanup paths and ensuring that uncancelled coroutines don't use finished logcontexts. Signed-off-by: Sean Quah <seanq@element.io>	2022-03-14 17:52:15 +00:00
Patrick Cloke	54f674f7a9	Deprecate the groups/communities endpoints and add an experimental configuration flag. (#12200 )	2022-03-12 13:23:37 -05:00
Shay	ef3619e61d	Add config settings for background update parameters (#11980 )	2022-03-11 10:46:45 -08:00
Brendan Abolivier	e6a106fd5e	Implement a Jinja2 filter to extract localparts from email addresses (#12212 )	2022-03-11 15:15:11 +00:00
reivilibre	4a53f35737	Improve code documentation for the typing stream over replication. (#12211 )	2022-03-11 14:00:15 +00:00
Nick Mills-Barrett	735e89bd3a	Add an additional HTTP pusher + push rule tests. (#12188 ) And rename the field used for caching from _id to _cache_key.	2022-03-11 08:45:26 -05:00
Brendan Abolivier	003cc6910a	Update the SSO username picker template to comply with SIWA guidelines (#12210 ) Fixes https://github.com/matrix-org/synapse/issues/12205	2022-03-11 13:20:00 +00:00
Patrick Cloke	bc9dff1d95	Remove unnecessary pass statements. (#12206 )	2022-03-11 07:06:21 -05:00
Shay	ed9aea42fa	fix misleading comment in `check_events_for_spam` (#12203 )	2022-03-10 09:40:07 -08:00
reivilibre	72e7f1c420	Remove workaround introduced in Synapse v1.50.0rc1 for Mjolnir compatibility. Breaks compatibility with Mjolnir v1.3.1 and earlier. (#11700 )	2022-03-10 15:53:23 +00:00
Patrick Cloke	ea27528b5d	Support stable identifiers for MSC3440: Threading (#12151 ) The unstable identifiers are still supported if the experimental configuration flag is enabled. The unstable identifiers will be removed in a future release.	2022-03-10 15:36:13 +00:00
Patrick Cloke	88cd6f9378	Allow retrieving the relations of a redacted event. (#12130 ) This is allowed per MSC2675, although the original implementation did not allow for it and would return an empty chunk / not bundle aggregations. The main thing to improve is that the various caches get cleared properly when an event is redacted, and that edits must not leak if the original event is redacted (as that would presumably leak something similar to the original event content).	2022-03-10 09:03:59 -05:00
Patrick Cloke	3e4af36bc8	Rename get_tcp_replication to get_replication_command_handler. (#12192 ) Since the object it returns is a ReplicationCommandHandler. This is clean-up from adding support to Redis where the command handler was added as an additional layer of abstraction from the TCP protocol.	2022-03-10 13:01:56 +00:00
Will Hunt	15382b1afa	Add third_party module callbacks to check if a user can delete a room and deactivate a user (#12028 ) * Add check_can_deactivate_user * Add check_can_shutdown_rooms * Documentation * callbacks, not functions * Various suggested tweaks * Add tests for test_check_can_shutdown_room and test_check_can_deactivate_user * Update check_can_deactivate_user to not take a Requester * Fix check_can_shutdown_room docs * Renegade and use `by_admin` instead of `admin_user_id` * fix lint * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> * Update docs/modules/third_party_rules_callbacks.md Co-authored-by: Brendan Abolivier <babolivier@matrix.org> Co-authored-by: Brendan Abolivier <babolivier@matrix.org>	2022-03-09 18:23:57 +00:00
Patrick Cloke	690cb4f3b3	Allow for ignoring some arguments when caching. (#12189 ) * `@cached` can now take an `uncached_args` which is an iterable of names to not use in the cache key. * Requires `@cached`, @cachedList` and `@lru_cache` to use keyword arguments for clarity. * Asserts that keyword-only arguments in cached functions are not accepted. (I tested this briefly and I don't believe this works properly.)	2022-03-09 18:07:41 +00:00
Patrick Cloke	032688854b	Remove some unused variables/parameters. (#12187 )	2022-03-09 15:29:39 +00:00
Nick Mills-Barrett	180d8ff0d4	Retry some http replication failures (#12182 ) This allows for the target process to be down for around a minute which provides time for restarts during synapse upgrades/config updates. Closes: #12178 Signed off by Nick Mills-Barrett nick@beeper.com	2022-03-09 14:53:28 +00:00
Richard van der Hoff	dc8d825ef2	Skip attempt to get state at backwards-extremities (#12173 ) We don't have the state at a backwards-extremity, so this is never going to do anything useful.	2022-03-09 11:00:48 +00:00
Sean Quah	5627182788	Use `ParamSpec` in type hints for `synapse.logging.context` (#12150 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-03-08 15:58:14 +00:00
Olivier Wilkinson (reivilibre)	0dc9c5653c	Merge branch 'master' into develop	2022-03-08 15:37:35 +00:00
Erik Johnston	2ce27a24fe	Add experimental environment variable to enable asyncio reactor (#12135 )	2022-03-08 13:23:18 +00:00
Patrick Cloke	ca9234a9eb	Do not return allowed_room_ids from /hierarchy response. (#12175 ) This field is only to be used in the Server-Server API, and not the Client-Server API, but was being leaked when a federation response was used in the /hierarchy API.	2022-03-08 08:09:11 -05:00
Patrick Cloke	d8bab6793c	Fix incorrect type hints for txredis. (#12042 ) Some properties were marked as RedisProtocol instead of ConnectionHandler, which wraps RedisProtocol instance(s).	2022-03-08 07:26:05 -05:00
Olivier Wilkinson (reivilibre)	ea992adf86	1.54.0	2022-03-08 10:55:26 +00:00
reivilibre	2eef234ae3	Fix a bug introduced in 1.54.0rc1 which meant that Synapse would refuse to start if pre-release versions of dependencies were installed. (#12177 ) * Add failing test to characterise the regression #12176 * Permit pre-release versions of specified packages * Newsfile (bugfix) Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>	2022-03-08 10:47:28 +00:00
Shay	26211fec24	Fix a bug in background updates wherein background updates are never run using the default batch size (#12157 )	2022-03-07 09:44:33 -08:00
Patrick Cloke	f63bedef07	Invalidate caches when an event with a relation is redacted. (#12121 ) The caches for the target of the relation must be cleared so that the bundled aggregations are re-calculated after the redaction is processed.	2022-03-07 14:00:05 +00:00
Richard van der Hoff	00a67f831a	Merge remote-tracking branch 'origin/release-v1.54' into develop	2022-03-04 22:40:51 +00:00
David Robertson	d2ef1a79cf	Relax version guard for packaging (#12166 ) It’s just occurred to me that #12088 pulled in the “packaging” package (~=21.3). I pulled in the newest version I had at the time. I only use it for packaging.requirements.Requirements. Which was added in packaging 16.1: https://github.com/pypa/packaging/releases/tag/16.1 https://pkgs.org/download/python3-packaging suggests that the oldest version we care about is 17.1 in Ubuntu Bionic. So I think with this bound we're hunky dory.	2022-03-04 22:40:24 +00:00
Erik Johnston	0752ab7a36	Reduce to-device queries for /sync. (#12163 )	2022-03-04 17:57:27 +00:00
Sean Quah	75574726a7	Add type hints for `ObservableDeferred` attributes (#12159 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-03-04 15:37:02 +00:00
Patrick Cloke	cd1ae3d0b4	Remove backwards compatibility with RelationPaginationToken. (#12138 )	2022-03-04 07:10:10 -05:00
David Robertson	4aeb00ca20	Move synctl into `synapse._scripts` and expose as an entrypoint (#12140 )	2022-03-04 11:58:49 +00:00
Erik Johnston	423cca9efe	Spread out sending device lists to remote hosts (#12132 )	2022-03-04 11:48:15 +00:00
Richard van der Hoff	87c230c27c	Update client-visibility filtering for outlier events (#12155 ) Avoid trying to get the state for outliers, which isn't a sensible thing to do.	2022-03-04 10:31:19 +00:00
Richard van der Hoff	d56202b038	Fix type of `events` in `StateGroupStorage` and `StateHandler` (#12156 ) We make multiple passes over this, so a regular iterable won't do.	2022-03-04 10:25:18 +00:00
Richard van der Hoff	8533c8b03d	Avoid generating state groups for local out-of-band leaves (#12154 ) If we locally generate a rejection for an invite received over federation, it is stored as an outlier (because we probably don't have the state for the room). However, currently we still generate a state group for it (even though the state in that state group will be nonsense). By setting the `outlier` param on `create_event`, we avoid the nonsensical state.	2022-03-03 19:58:08 +00:00
Andrew Morgan	fb0ffa9676	Rename various ApplicationServices interested methods (#11915 )	2022-03-03 18:14:09 +00:00
Patrick Cloke	1d11b452b7	Use the proper serialization format when bundling aggregations. (#12090 ) This ensures that the `latest_event` field of the bundled aggregation for threads uses the same format as the other events in the response.	2022-03-03 10:43:06 -05:00
David Robertson	cea1b58c4a	Don't impose version checks on dev extras at runtime (#12129 ) * Fix incorrect argument in test case * Add copyright header * Docstring and __all__ * Exclude dev depenencies * Use changelog from #12088 * Include version in error messages This will hopefully distinguish between the version of the source code and the version of the distribution package that is installed. * Linter script is your friend	2022-03-03 12:47:55 +00:00
Erik Johnston	61fd2a8f59	Limit the size of the aggregation_key (#12101 ) There's no reason to let people use long keys.	2022-03-03 10:52:35 +00:00
Brendan Abolivier	ae8a616b49	Correctly register deactivation and profile update module callbacks (#12141 )	2022-03-03 11:39:58 +01:00
Olivier Wilkinson (reivilibre)	594a07ede4	Synapse 1.54.0rc1 (2022-03-02) ============================== Please note that this will be the last release of Synapse that is compatible with Mjolnir 1.3.1 and earlier. Administrators of servers which have the Mjolnir module installed are advised to upgrade Mjolnir to version 1.3.2 or later. Features -------- - Add support for [MSC3202](https://github.com/matrix-org/matrix-doc/pull/3202): sending one-time key counts and fallback key usage states to Application Services. ([\#11617](https://github.com/matrix-org/synapse/issues/11617)) - Improve the generated URL previews for some web pages. Contributed by @AndrewRyanChama. ([\#11985](https://github.com/matrix-org/synapse/issues/11985)) - Track cache invalidations in Prometheus metrics, as already happens for cache eviction based on size or time. ([\#12000](https://github.com/matrix-org/synapse/issues/12000)) - Implement experimental support for [MSC3720](https://github.com/matrix-org/matrix-doc/pull/3720) (account status endpoints). ([\#12001](https://github.com/matrix-org/synapse/issues/12001), [\#12067](https://github.com/matrix-org/synapse/issues/12067)) - Enable modules to set a custom display name when registering a user. ([\#12009](https://github.com/matrix-org/synapse/issues/12009)) - Advertise Matrix 1.1 and 1.2 support on `/_matrix/client/versions`. ([\#12020](https://github.com/matrix-org/synapse/issues/12020), ([\#12022](https://github.com/matrix-org/synapse/issues/12022)) - Support only the stable identifier for [MSC3069](https://github.com/matrix-org/matrix-doc/pull/3069)'s `is_guest` on `/_matrix/client/v3/account/whoami`. ([\#12021](https://github.com/matrix-org/synapse/issues/12021)) - Use room version 9 as the default room version (per [MSC3589](https://github.com/matrix-org/matrix-doc/pull/3589)). ([\#12058](https://github.com/matrix-org/synapse/issues/12058)) - Add module callbacks to react to user deactivation status changes (i.e. deactivations and reactivations) and profile updates. ([\#12062](https://github.com/matrix-org/synapse/issues/12062)) Bugfixes -------- - Fix a bug introduced in Synapse 1.48.0 where an edit of the latest event in a thread would not be properly applied to the thread summary. ([\#11992](https://github.com/matrix-org/synapse/issues/11992)) - Fix long-standing bug where the `get_rooms_for_user` cache was not correctly invalidated for remote users when the server left a room. ([\#11999](https://github.com/matrix-org/synapse/issues/11999)) - Fix a 500 error with Postgres when looking backwards with the [MSC3030](https://github.com/matrix-org/matrix-doc/pull/3030) `/timestamp_to_event?dir=b` endpoint. ([\#12024](https://github.com/matrix-org/synapse/issues/12024)) - Properly fix a long-standing bug where wrong data could be inserted into the `event_search` table when using SQLite. This could block running `synapse_port_db` with an `argument of type 'int' is not iterable` error. This bug was partially fixed by a change in Synapse 1.44.0. ([\#12037](https://github.com/matrix-org/synapse/issues/12037)) - Fix slow performance of `/logout` in some cases where refresh tokens are in use. The slowness existed since the initial implementation of refresh tokens in version 1.38.0. ([\#12056](https://github.com/matrix-org/synapse/issues/12056)) - Fix a long-standing bug where Synapse would make additional failing requests over federation for missing data. ([\#12077](https://github.com/matrix-org/synapse/issues/12077)) - Fix occasional `Unhandled error in Deferred` error message. ([\#12089](https://github.com/matrix-org/synapse/issues/12089)) - Fix a bug introduced in Synapse 1.51.0 where incoming federation transactions containing at least one EDU would be dropped if debug logging was enabled for `synapse.8631_debug`. ([\#12098](https://github.com/matrix-org/synapse/issues/12098)) - Fix a long-standing bug which could cause push notifications to malfunction if `use_frozen_dicts` was set in the configuration. ([\#12100](https://github.com/matrix-org/synapse/issues/12100)) - Fix an extremely rare, long-standing bug in `ReadWriteLock` that would cause an error when a newly unblocked writer completes instantly. ([\#12105](https://github.com/matrix-org/synapse/issues/12105)) - Make a `POST` to `/rooms/<room_id>/receipt/m.read/<event_id>` only trigger a push notification if the count of unread messages is different to the one in the last successfully sent push. This reduces server load and load on the receiving device. ([\#11835](https://github.com/matrix-org/synapse/issues/11835)) Updates to the Docker image --------------------------- - The Docker image no longer automatically creates a temporary volume at `/data`. This is not expected to affect normal usage. ([\#11997](https://github.com/matrix-org/synapse/issues/11997)) - Use Python 3.9 in Docker images by default. ([\#12112](https://github.com/matrix-org/synapse/issues/12112)) Improved Documentation ---------------------- - Document support for the `to_device`, `account_data`, `receipts`, and `presence` stream writers for workers. ([\#11599](https://github.com/matrix-org/synapse/issues/11599)) - Explain the meaning of spam checker callbacks' return values. ([\#12003](https://github.com/matrix-org/synapse/issues/12003)) - Clarify information about external Identity Provider IDs. ([\#12004](https://github.com/matrix-org/synapse/issues/12004)) Deprecations and Removals ------------------------- - Deprecate using `synctl` with the config option `synctl_cache_factor` and print a warning if a user still uses this option. ([\#11865](https://github.com/matrix-org/synapse/issues/11865)) - Remove support for the legacy structured logging configuration (please see the the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#legacy-structured-logging-configuration-removal) if you are using `structured: true` in the Synapse configuration). ([\#12008](https://github.com/matrix-org/synapse/issues/12008)) - Drop support for [MSC3283](https://github.com/matrix-org/matrix-doc/pull/3283) unstable flags now that the stable flags are supported. ([\#12018](https://github.com/matrix-org/synapse/issues/12018)) - Remove the unstable `/spaces` endpoint from [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946). ([\#12073](https://github.com/matrix-org/synapse/issues/12073)) Internal Changes ---------------- - Make the `get_room_version` method use `get_room_version_id` to benefit from caching. ([\#11808](https://github.com/matrix-org/synapse/issues/11808)) - Remove unnecessary condition on knock -> leave auth rule check. ([\#11900](https://github.com/matrix-org/synapse/issues/11900)) - Add tests for device list changes between local users. ([\#11972](https://github.com/matrix-org/synapse/issues/11972)) - Optimise calculating `device_list` changes in `/sync`. ([\#11974](https://github.com/matrix-org/synapse/issues/11974)) - Add missing type hints to storage classes. ([\#11984](https://github.com/matrix-org/synapse/issues/11984)) - Refactor the search code for improved readability. ([\#11991](https://github.com/matrix-org/synapse/issues/11991)) - Move common deduplication code down into `_auth_and_persist_outliers`. ([\#11994](https://github.com/matrix-org/synapse/issues/11994)) - Limit concurrent joins from applications services. ([\#11996](https://github.com/matrix-org/synapse/issues/11996)) - Preparation for faster-room-join work: when parsing the `send_join` response, get the `m.room.create` event from `state`, not `auth_chain`. ([\#12005](https://github.com/matrix-org/synapse/issues/12005), [\#12039](https://github.com/matrix-org/synapse/issues/12039)) - Preparation for faster-room-join work: parse MSC3706 fields in send_join response. ([\#12011](https://github.com/matrix-org/synapse/issues/12011)) - Preparation for faster-room-join work: persist information on which events and rooms have partial state to the database. ([\#12012](https://github.com/matrix-org/synapse/issues/12012)) - Preparation for faster-room-join work: Support for calling `/federation/v1/state` on a remote server. ([\#12013](https://github.com/matrix-org/synapse/issues/12013)) - Configure `tox` to use `venv` rather than `virtualenv`. ([\#12015](https://github.com/matrix-org/synapse/issues/12015)) - Fix bug in `StateFilter.return_expanded()` and add some tests. ([\#12016](https://github.com/matrix-org/synapse/issues/12016)) - Use Matrix v1.1 endpoints (`/_matrix/client/v3/auth/...`) in fallback auth HTML forms. ([\#12019](https://github.com/matrix-org/synapse/issues/12019)) - Update the `olddeps` CI job to use an old version of `markupsafe`. ([\#12025](https://github.com/matrix-org/synapse/issues/12025)) - Upgrade Mypy to version 0.931. ([\#12030](https://github.com/matrix-org/synapse/issues/12030)) - Remove legacy `HomeServer.get_datastore()`. ([\#12031](https://github.com/matrix-org/synapse/issues/12031), [\#12070](https://github.com/matrix-org/synapse/issues/12070)) - Minor typing fixes. ([\#12034](https://github.com/matrix-org/synapse/issues/12034), [\#12069](https://github.com/matrix-org/synapse/issues/12069)) - After joining a room, create a dedicated logcontext to process the queued events. ([\#12041](https://github.com/matrix-org/synapse/issues/12041)) - Tidy up GitHub Actions config which builds distributions for PyPI. ([\#12051](https://github.com/matrix-org/synapse/issues/12051)) - Move configuration out of `setup.cfg`. ([\#12052](https://github.com/matrix-org/synapse/issues/12052), [\#12059](https://github.com/matrix-org/synapse/issues/12059)) - Fix error message when a worker process fails to talk to another worker process. ([\#12060](https://github.com/matrix-org/synapse/issues/12060)) - Fix using the `complement.sh` script without specifying a directory or a branch. Contributed by Nico on behalf of Famedly. ([\#12063](https://github.com/matrix-org/synapse/issues/12063)) - Add type hints to `tests/rest/client`. ([\#12066](https://github.com/matrix-org/synapse/issues/12066), [\#12072](https://github.com/matrix-org/synapse/issues/12072), [\#12084](https://github.com/matrix-org/synapse/issues/12084), [\#12094](https://github.com/matrix-org/synapse/issues/12094)) - Add some logging to `/sync` to try and track down #11916. ([\#12068](https://github.com/matrix-org/synapse/issues/12068)) - Inspect application dependencies using `importlib.metadata` or its backport. ([\#12088](https://github.com/matrix-org/synapse/issues/12088)) - Use `assertEqual` instead of the deprecated `assertEquals` in test code. ([\#12092](https://github.com/matrix-org/synapse/issues/12092)) - Move experimental support for [MSC3440](https://github.com/matrix-org/matrix-doc/pull/3440) to `/versions`. ([\#12099](https://github.com/matrix-org/synapse/issues/12099)) - Add `stop_cancellation` utility function to stop `Deferred`s from being cancelled. ([\#12106](https://github.com/matrix-org/synapse/issues/12106)) - Improve exception handling for concurrent execution. ([\#12109](https://github.com/matrix-org/synapse/issues/12109)) - Advertise support for Python 3.10 in packaging files. ([\#12111](https://github.com/matrix-org/synapse/issues/12111)) - Move CI checks out of tox, to facilitate a move to using poetry. ([\#12119](https://github.com/matrix-org/synapse/issues/12119)) -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE8SRSDO7gYkSP4chELS76LzL74EcFAmIffxUACgkQLS76LzL7 4EefXxAAvnJb1BxzWwlYyKaDULjmNfsKilRWlT/A1/7VaumB84H4gFQklLuMbJdR pyktlkmVZrnLG+Vz2JfgFm4wTXvLGieACvlAodQWztQX2szqPAHeq0A0vuMgJEay mVKVnU6b83CONBr021/lm6NOBetbUqOVyiFsnuBKlLPs4WdSt+3DvBRZ3hsQTrCV zEOSdzVM67yr0xo3/vmT+nzlfcegJ64EOT+dFwMfKnoWbRK0lMwnob1WZbiOE0+9 9hoqEucbmzf/4IKgURxmNmrUDIPGUlGq4BnKMGMNyrwWv9v+8pXuIqzOYEUnWVBh upvS88OBswk2EXIIk22/rf5gohNShQDmki41CVTH32G+dP72YxCfTGsafwUpS+Hm KlojCRccmo2y2sQnLzrhswsOPFiYP0AORPIp3hO1mVTMZ7EgjsP4Y8C/S54Oe03F 6U3M5pv6aqURiAHAnyC4KbPOVqUbEzthUuRINEDp5QhNSFyvtwV9DTaFixMpMdR0 OJU8tMaGmCtqdsqNOZ4vGhzPVD/1kJ0KapPyJbkVSGoRdlI01sqO7Nu+k8AZ1oEc nkoR5zMTysCAuGCIOtCWB8NOFBNyEgcCdz3356e+wvWx4PazIFsfyEXskzZY50iK dAIdr+w+kyf4d/e9JpK7YHrPP5uP2s0V8Y4MvDx3wUXJ6VZ834Y= =jw9M -----END PGP SIGNATURE----- Merge tag 'v1.54.0rc1' into develop Synapse 1.54.0rc1 (2022-03-02) ============================== Please note that this will be the last release of Synapse that is compatible with Mjolnir 1.3.1 and earlier. Administrators of servers which have the Mjolnir module installed are advised to upgrade Mjolnir to version 1.3.2 or later. Features -------- - Add support for [MSC3202](https://github.com/matrix-org/matrix-doc/pull/3202): sending one-time key counts and fallback key usage states to Application Services. ([\#11617](https://github.com/matrix-org/synapse/issues/11617)) - Improve the generated URL previews for some web pages. Contributed by @AndrewRyanChama. ([\#11985](https://github.com/matrix-org/synapse/issues/11985)) - Track cache invalidations in Prometheus metrics, as already happens for cache eviction based on size or time. ([\#12000](https://github.com/matrix-org/synapse/issues/12000)) - Implement experimental support for [MSC3720](https://github.com/matrix-org/matrix-doc/pull/3720) (account status endpoints). ([\#12001](https://github.com/matrix-org/synapse/issues/12001), [\#12067](https://github.com/matrix-org/synapse/issues/12067)) - Enable modules to set a custom display name when registering a user. ([\#12009](https://github.com/matrix-org/synapse/issues/12009)) - Advertise Matrix 1.1 and 1.2 support on `/_matrix/client/versions`. ([\#12020](https://github.com/matrix-org/synapse/issues/12020), ([\#12022](https://github.com/matrix-org/synapse/issues/12022)) - Support only the stable identifier for [MSC3069](https://github.com/matrix-org/matrix-doc/pull/3069)'s `is_guest` on `/_matrix/client/v3/account/whoami`. ([\#12021](https://github.com/matrix-org/synapse/issues/12021)) - Use room version 9 as the default room version (per [MSC3589](https://github.com/matrix-org/matrix-doc/pull/3589)). ([\#12058](https://github.com/matrix-org/synapse/issues/12058)) - Add module callbacks to react to user deactivation status changes (i.e. deactivations and reactivations) and profile updates. ([\#12062](https://github.com/matrix-org/synapse/issues/12062)) Bugfixes -------- - Fix a bug introduced in Synapse 1.48.0 where an edit of the latest event in a thread would not be properly applied to the thread summary. ([\#11992](https://github.com/matrix-org/synapse/issues/11992)) - Fix long-standing bug where the `get_rooms_for_user` cache was not correctly invalidated for remote users when the server left a room. ([\#11999](https://github.com/matrix-org/synapse/issues/11999)) - Fix a 500 error with Postgres when looking backwards with the [MSC3030](https://github.com/matrix-org/matrix-doc/pull/3030) `/timestamp_to_event?dir=b` endpoint. ([\#12024](https://github.com/matrix-org/synapse/issues/12024)) - Properly fix a long-standing bug where wrong data could be inserted into the `event_search` table when using SQLite. This could block running `synapse_port_db` with an `argument of type 'int' is not iterable` error. This bug was partially fixed by a change in Synapse 1.44.0. ([\#12037](https://github.com/matrix-org/synapse/issues/12037)) - Fix slow performance of `/logout` in some cases where refresh tokens are in use. The slowness existed since the initial implementation of refresh tokens in version 1.38.0. ([\#12056](https://github.com/matrix-org/synapse/issues/12056)) - Fix a long-standing bug where Synapse would make additional failing requests over federation for missing data. ([\#12077](https://github.com/matrix-org/synapse/issues/12077)) - Fix occasional `Unhandled error in Deferred` error message. ([\#12089](https://github.com/matrix-org/synapse/issues/12089)) - Fix a bug introduced in Synapse 1.51.0 where incoming federation transactions containing at least one EDU would be dropped if debug logging was enabled for `synapse.8631_debug`. ([\#12098](https://github.com/matrix-org/synapse/issues/12098)) - Fix a long-standing bug which could cause push notifications to malfunction if `use_frozen_dicts` was set in the configuration. ([\#12100](https://github.com/matrix-org/synapse/issues/12100)) - Fix an extremely rare, long-standing bug in `ReadWriteLock` that would cause an error when a newly unblocked writer completes instantly. ([\#12105](https://github.com/matrix-org/synapse/issues/12105)) - Make a `POST` to `/rooms/<room_id>/receipt/m.read/<event_id>` only trigger a push notification if the count of unread messages is different to the one in the last successfully sent push. This reduces server load and load on the receiving device. ([\#11835](https://github.com/matrix-org/synapse/issues/11835)) Updates to the Docker image --------------------------- - The Docker image no longer automatically creates a temporary volume at `/data`. This is not expected to affect normal usage. ([\#11997](https://github.com/matrix-org/synapse/issues/11997)) - Use Python 3.9 in Docker images by default. ([\#12112](https://github.com/matrix-org/synapse/issues/12112)) Improved Documentation ---------------------- - Document support for the `to_device`, `account_data`, `receipts`, and `presence` stream writers for workers. ([\#11599](https://github.com/matrix-org/synapse/issues/11599)) - Explain the meaning of spam checker callbacks' return values. ([\#12003](https://github.com/matrix-org/synapse/issues/12003)) - Clarify information about external Identity Provider IDs. ([\#12004](https://github.com/matrix-org/synapse/issues/12004)) Deprecations and Removals ------------------------- - Deprecate using `synctl` with the config option `synctl_cache_factor` and print a warning if a user still uses this option. ([\#11865](https://github.com/matrix-org/synapse/issues/11865)) - Remove support for the legacy structured logging configuration (please see the the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#legacy-structured-logging-configuration-removal) if you are using `structured: true` in the Synapse configuration). ([\#12008](https://github.com/matrix-org/synapse/issues/12008)) - Drop support for [MSC3283](https://github.com/matrix-org/matrix-doc/pull/3283) unstable flags now that the stable flags are supported. ([\#12018](https://github.com/matrix-org/synapse/issues/12018)) - Remove the unstable `/spaces` endpoint from [MSC2946](https://github.com/matrix-org/matrix-doc/pull/2946). ([\#12073](https://github.com/matrix-org/synapse/issues/12073)) Internal Changes ---------------- - Make the `get_room_version` method use `get_room_version_id` to benefit from caching. ([\#11808](https://github.com/matrix-org/synapse/issues/11808)) - Remove unnecessary condition on knock -> leave auth rule check. ([\#11900](https://github.com/matrix-org/synapse/issues/11900)) - Add tests for device list changes between local users. ([\#11972](https://github.com/matrix-org/synapse/issues/11972)) - Optimise calculating `device_list` changes in `/sync`. ([\#11974](https://github.com/matrix-org/synapse/issues/11974)) - Add missing type hints to storage classes. ([\#11984](https://github.com/matrix-org/synapse/issues/11984)) - Refactor the search code for improved readability. ([\#11991](https://github.com/matrix-org/synapse/issues/11991)) - Move common deduplication code down into `_auth_and_persist_outliers`. ([\#11994](https://github.com/matrix-org/synapse/issues/11994)) - Limit concurrent joins from applications services. ([\#11996](https://github.com/matrix-org/synapse/issues/11996)) - Preparation for faster-room-join work: when parsing the `send_join` response, get the `m.room.create` event from `state`, not `auth_chain`. ([\#12005](https://github.com/matrix-org/synapse/issues/12005), [\#12039](https://github.com/matrix-org/synapse/issues/12039)) - Preparation for faster-room-join work: parse MSC3706 fields in send_join response. ([\#12011](https://github.com/matrix-org/synapse/issues/12011)) - Preparation for faster-room-join work: persist information on which events and rooms have partial state to the database. ([\#12012](https://github.com/matrix-org/synapse/issues/12012)) - Preparation for faster-room-join work: Support for calling `/federation/v1/state` on a remote server. ([\#12013](https://github.com/matrix-org/synapse/issues/12013)) - Configure `tox` to use `venv` rather than `virtualenv`. ([\#12015](https://github.com/matrix-org/synapse/issues/12015)) - Fix bug in `StateFilter.return_expanded()` and add some tests. ([\#12016](https://github.com/matrix-org/synapse/issues/12016)) - Use Matrix v1.1 endpoints (`/_matrix/client/v3/auth/...`) in fallback auth HTML forms. ([\#12019](https://github.com/matrix-org/synapse/issues/12019)) - Update the `olddeps` CI job to use an old version of `markupsafe`. ([\#12025](https://github.com/matrix-org/synapse/issues/12025)) - Upgrade Mypy to version 0.931. ([\#12030](https://github.com/matrix-org/synapse/issues/12030)) - Remove legacy `HomeServer.get_datastore()`. ([\#12031](https://github.com/matrix-org/synapse/issues/12031), [\#12070](https://github.com/matrix-org/synapse/issues/12070)) - Minor typing fixes. ([\#12034](https://github.com/matrix-org/synapse/issues/12034), [\#12069](https://github.com/matrix-org/synapse/issues/12069)) - After joining a room, create a dedicated logcontext to process the queued events. ([\#12041](https://github.com/matrix-org/synapse/issues/12041)) - Tidy up GitHub Actions config which builds distributions for PyPI. ([\#12051](https://github.com/matrix-org/synapse/issues/12051)) - Move configuration out of `setup.cfg`. ([\#12052](https://github.com/matrix-org/synapse/issues/12052), [\#12059](https://github.com/matrix-org/synapse/issues/12059)) - Fix error message when a worker process fails to talk to another worker process. ([\#12060](https://github.com/matrix-org/synapse/issues/12060)) - Fix using the `complement.sh` script without specifying a directory or a branch. Contributed by Nico on behalf of Famedly. ([\#12063](https://github.com/matrix-org/synapse/issues/12063)) - Add type hints to `tests/rest/client`. ([\#12066](https://github.com/matrix-org/synapse/issues/12066), [\#12072](https://github.com/matrix-org/synapse/issues/12072), [\#12084](https://github.com/matrix-org/synapse/issues/12084), [\#12094](https://github.com/matrix-org/synapse/issues/12094)) - Add some logging to `/sync` to try and track down #11916. ([\#12068](https://github.com/matrix-org/synapse/issues/12068)) - Inspect application dependencies using `importlib.metadata` or its backport. ([\#12088](https://github.com/matrix-org/synapse/issues/12088)) - Use `assertEqual` instead of the deprecated `assertEquals` in test code. ([\#12092](https://github.com/matrix-org/synapse/issues/12092)) - Move experimental support for [MSC3440](https://github.com/matrix-org/matrix-doc/pull/3440) to `/versions`. ([\#12099](https://github.com/matrix-org/synapse/issues/12099)) - Add `stop_cancellation` utility function to stop `Deferred`s from being cancelled. ([\#12106](https://github.com/matrix-org/synapse/issues/12106)) - Improve exception handling for concurrent execution. ([\#12109](https://github.com/matrix-org/synapse/issues/12109)) - Advertise support for Python 3.10 in packaging files. ([\#12111](https://github.com/matrix-org/synapse/issues/12111)) - Move CI checks out of tox, to facilitate a move to using poetry. ([\#12119](https://github.com/matrix-org/synapse/issues/12119))	2022-03-02 15:26:43 +00:00
Patrick Cloke	1103c5fe8a	Check if instances are lists, not sequences. (#12128 ) As a str is a sequence, the checks were not granular enough and would allow lists or strings, when only lists were valid.	2022-03-02 13:18:51 +00:00
David Robertson	f3f0ab10fe	Move scripts directory inside synapse, exposing as setuptools entry_points (#12118 ) * Two scripts are basically entry_points already * Move and rename scripts/* to synapse/_scripts/.py Delete sync_room_to_group.pl * Expose entry points in setup.py * Update linter script and config * Fixup scripts & docs mentioning scripts that moved Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2022-03-02 13:00:16 +00:00
Olivier Wilkinson (reivilibre)	879e4a7bd7	1.54.0rc1	2022-03-02 10:45:16 +00:00
reivilibre	c7b2f1ccdc	Back out in-flight state caching changes. (#12126 )	2022-03-02 10:37:04 +00:00
lukasdenk	8e56a1b73c	Make get_room_version use cached get_room_version_id. (#11808 )	2022-03-02 10:35:34 +00:00
David Robertson	313581e4e9	Use importlib.metadata to read requirements (#12088 ) * Pull runtime dep checks into their own module * Reimplement `check_requirements` using `importlib` I've tried to make this clearer. We start by working out which of Synapse's requirements we need to be installed here and now. I was surprised that there wasn't an easier way to see which packages were installed by a given extra. I've pulled out the error messages into functions that deal with "is this for an extra or not". And I've rearranged the loop over two different sets of requirements into one loop with a "must be instaled" flag. I hope you agree that this is clearer. * Test cases	2022-03-01 17:44:41 +00:00
Sean Quah	4d6b6c17c8	Fix rare error in `ReadWriteLock` when writers complete immediately (#12105 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-03-01 15:27:15 +00:00
Brendan Abolivier	300ed0b8a6	Add module callbacks called for reacting to deactivation status change and profile update (#12062 )	2022-03-01 15:00:03 +00:00
Sean Quah	91bc15c772	Add `stop_cancellation` utility function (#12106 )	2022-03-01 13:51:03 +00:00
reivilibre	c893632319	Order in-flight state group queries in biggest-first order (#11610 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2022-03-01 13:41:57 +00:00
Richard van der Hoff	e2e1d90a5e	Faster joins: persist to database (#12012 ) When we get a partial_state response from send_join, store information in the database about it: * store a record about the room as a whole having partial state, and stash the list of member servers too. * flag the join event itself as having partial state * also, for any new events whose prev-events are partial-stated, note that they will also be partial-stated. We don't yet make any attempt to interpret this data, so API calls (and a bunch of other things) are just going to get incorrect data.	2022-03-01 12:49:54 +00:00
Richard van der Hoff	5458eb8551	Fix 'Unhandled error in Deferred' (#12089 ) * Fix 'Unhandled error in Deferred' Fixes a CRITICAL "Unhandled error in Deferred" log message which happened when a function wrapped with `@cachedList` failed * Minor optimisation to cachedListDescriptor we can avoid re-using `missing`, which saves looking up entries in `deferreds_map`, and means we don't need to copy it. * Improve type annotation on CachedListDescriptor	2022-03-01 09:51:38 +00:00
Richard van der Hoff	9d11fee8f2	Improve exception handling for concurrent execution (#12109 ) * fix incorrect unwrapFirstError import this was being imported from the wrong place * Refactor `concurrently_execute` to use `yieldable_gather_results` * Improve exception handling in `yieldable_gather_results` Try to avoid swallowing so many stack traces. * mark unwrapFirstError deprecated * changelog	2022-03-01 09:34:30 +00:00
Patrick Cloke	7754af24ab	Remove the unstable `/spaces` endpoint. (#12073 ) ...and various code supporting it. The /spaces endpoint was from an old version of MSC2946 and included both a Client-Server and Server-Server API. Note that the unstable /hierarchy endpoint (from the final version of MSC2946) is not yet removed.	2022-02-28 18:33:00 +00:00
Patrick Cloke	1866fb39d7	Move experimental support for MSC3440 to /versions. (#12099 ) Instead of being part of /capabilities, this matches a change to MSC3440 to properly use these endpoints.	2022-02-28 18:29:09 +00:00
Richard van der Hoff	6c0b44a3d7	Fix `PushRuleEvaluator` and `Filter` to work on frozendicts (#12100 ) * Fix `PushRuleEvaluator` to work on frozendicts frozendicts do not (necessarily) inherit from dict, so this needs to handle them correctly. * Fix event filtering for frozen events Looks like this one was introduced by #11194.	2022-02-28 17:40:24 +00:00
David Robertson	5565f454e1	Actually fix bad debug logging rejecting device list & signing key transactions (#12098 )	2022-02-28 14:10:36 +00:00
Patrick Cloke	9e83521af8	Properly failover for unknown endpoints from Conduit/Dendrite. (#12077 ) Before this fix, a legitimate 404 from a federation endpoint (e.g. due to an unknown room) would be treated as an unknown endpoint. This could cause unnecessary federation traffic.	2022-02-28 07:52:44 -05:00
Sean Quah	b43c3ef8e2	Ensure that `get_datastores().main` is typed (#12070 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-02-25 10:20:40 +00:00
Sean Quah	f3fd8558cd	Minor typing fixes for `synapse/storage/persist_events.py` (#12069 ) Signed-off-by: Sean Quah <seanq@element.io>	2022-02-25 10:19:49 +00:00
reivilibre	2cc5ea933d	Add support for MSC3202: sending one-time key counts and fallback key usage states to Application Services. (#11617 ) Co-authored-by: Erik Johnston <erik@matrix.org>	2022-02-24 17:55:45 +00:00
Sean Quah	41cf4c2cf6	Fix non-strings in the `event_search` table (#12037 ) Don't attempt to add non-string `value`s to `event_search` and add a background update to clear out bad rows from `event_search` when using sqlite. Signed-off-by: Sean Quah <seanq@element.io>	2022-02-24 11:52:28 +00:00
Erik Johnston	a711ae78a8	Add logging to `/sync` for debugging #11916 (#12068 )	2022-02-23 14:22:22 +00:00
Richard van der Hoff	5b2b36809f	Remove more references to `get_datastore` (#12067 ) These have snuck in since #12031 was started. Also a couple of other cleanups while we're in the area.	2022-02-23 12:35:53 +00:00
Richard van der Hoff	e24ff8ebe3	Remove `HomeServer.get_datastore()` (#12031 ) The presence of this method was confusing, and mostly present for backwards compatibility. Let's get rid of it. Part of #11733	2022-02-23 11:04:02 +00:00
Travis Ralston	e3fe6347be	Remove excess condition on `knock->leave` check (#11900 )	2022-02-22 18:35:01 +00:00
Erik Johnston	6d14b3dabf	Better error message when failing to request from another process (#12060 )	2022-02-22 15:52:08 +00:00
Brendan Abolivier	250104d357	Implement account status endpoints (MSC3720) (#12001 ) See matrix-org/matrix-doc#3720 Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>	2022-02-22 15:10:10 +00:00
reivilibre	dcb6a37837	Cap the number of in-flight requests for state from a single group (#11608 )	2022-02-22 14:24:31 +00:00
Patrick Cloke	7bcc28f82f	Use room version 9 as the default room version (per MSC3589). (#12058 )	2022-02-22 14:09:40 +00:00

... 6 7 8 9 10 ...

14912 Commits