From 7a0da69eee49ce84ddd8a433288d7ce9cb76e14e Mon Sep 17 00:00:00 2001 From: Erik Johnston Date: Thu, 23 Aug 2018 10:28:10 +0100 Subject: [PATCH 1/3] Add missing yield --- synapse/storage/monthly_active_users.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/synapse/storage/monthly_active_users.py b/synapse/storage/monthly_active_users.py index 06f9a75a9..fd3b630bd 100644 --- a/synapse/storage/monthly_active_users.py +++ b/synapse/storage/monthly_active_users.py @@ -147,6 +147,7 @@ class MonthlyActiveUsersStore(SQLBaseStore): return count return self.runInteraction("count_users", _count_users) + @defer.inlineCallbacks def upsert_monthly_active_user(self, user_id): """ Updates or inserts monthly active user member @@ -155,7 +156,7 @@ class MonthlyActiveUsersStore(SQLBaseStore): Deferred[bool]: True if a new entry was created, False if an existing one was updated. """ - is_insert = self._simple_upsert( + is_insert = yield self._simple_upsert( desc="upsert_monthly_active_user", table="monthly_active_users", keyvalues={ From c5842dff1a792843365becfa3ca666e42fdce869 Mon Sep 17 00:00:00 2001 From: Erik Johnston Date: Thu, 23 Aug 2018 10:35:54 +0100 Subject: [PATCH 2/3] Actually run the tests --- tests/server_notices/__init__.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 tests/server_notices/__init__.py diff --git a/tests/server_notices/__init__.py b/tests/server_notices/__init__.py new file mode 100644 index 000000000..e69de29bb From 4eb8408ed2331bf4a180364e966cb9f93b416202 Mon Sep 17 00:00:00 2001 From: Erik Johnston Date: Thu, 23 Aug 2018 10:46:13 +0100 Subject: [PATCH 3/3] Newsfile --- changelog.d/3746.misc | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/3746.misc diff --git a/changelog.d/3746.misc b/changelog.d/3746.misc new file mode 100644 index 000000000..fc00ee773 --- /dev/null +++ b/changelog.d/3746.misc @@ -0,0 +1 @@ +Fix MAU cache invalidation due to missing yield