From 191396f4baf467023b9913f83a1e3a696aa0e3a0 Mon Sep 17 00:00:00 2001 From: Dan Callahan Date: Tue, 19 Oct 2021 11:16:52 +0100 Subject: [PATCH 1/4] Reword changelog regarding a suspected regression (#11117) Signed-off-by: Dan Callahan --- CHANGES.md | 17 ++++++++++++++--- changelog.d/11117.doc | 1 + 2 files changed, 15 insertions(+), 3 deletions(-) create mode 100644 changelog.d/11117.doc diff --git a/CHANGES.md b/CHANGES.md index c8b078a2f..6a4d5f5c9 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,7 +1,14 @@ Synapse 1.45.0rc2 (2021-10-14) ============================== -**Note:** This release candidate [fixes](https://github.com/matrix-org/synapse/issues/11053) the user directory [bug](https://github.com/matrix-org/synapse/issues/11025) present in 1.45.0rc1. However, the [performance issue](https://github.com/matrix-org/synapse/issues/11049) which appeared in v1.44.0 is yet to be resolved. +This release candidate [fixes](https://github.com/matrix-org/synapse/issues/11053) a user directory [bug](https://github.com/matrix-org/synapse/issues/11025) present in 1.45.0rc1. + +Known Issues +------------ + +- A suspected [performance regression](https://github.com/matrix-org/synapse/issues/11049) which was first reported after the release of v1.44.0 remains unresolved. + + We have not been able to identify a probable cause. Affected users report that setting up a federation sender worker appears to alleviate symptoms of the regression. Bugfixes -------- @@ -24,9 +31,13 @@ Internal Changes Synapse 1.45.0rc1 (2021-10-12) ============================== -**Note:** We are aware of [a performance issue](https://github.com/matrix-org/synapse/issues/11049) introduced in Synapse v1.44.0, as well as [a bug](https://github.com/matrix-org/synapse/issues/11025) with the user directory when using application services. While this release candidate doesn't fix either of those issues, a second release candidate is expected to come out in a few days to address them. +**Note:** Media storage providers module that read from Synapse's configuration need changes as of this version, see the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#upgrading-to-v1450) for more information. -Media storage providers module that read from Synapse's configuration need changes as of this version, see the [upgrade notes](https://matrix-org.github.io/synapse/develop/upgrade#upgrading-to-v1450) for more information. +Known Issues +------------ + +- We are investigating [a performance issue](https://github.com/matrix-org/synapse/issues/11049) which was reported after the release of v1.44.0. +- We are aware of [a bug](https://github.com/matrix-org/synapse/issues/11025) with the user directory when using application services. A second release candidate is expected which will resolve this. Features -------- diff --git a/changelog.d/11117.doc b/changelog.d/11117.doc new file mode 100644 index 000000000..b4809fd6e --- /dev/null +++ b/changelog.d/11117.doc @@ -0,0 +1 @@ +Reword changelog to clarify concerns about a suspected performance regression in 1.44. From 8b1185347a3bfa4530500fe274ffc9006ec027ea Mon Sep 17 00:00:00 2001 From: David Robertson Date: Tue, 19 Oct 2021 11:19:55 +0100 Subject: [PATCH 2/4] 1.45.0 --- CHANGES.md | 11 +++++++++++ changelog.d/11117.doc | 1 - debian/changelog | 6 ++++++ synapse/__init__.py | 2 +- 4 files changed, 18 insertions(+), 2 deletions(-) delete mode 100644 changelog.d/11117.doc diff --git a/CHANGES.md b/CHANGES.md index 6a4d5f5c9..7d1b804e8 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,3 +1,14 @@ +Synapse 1.45.0 (2021-10-19) +=========================== + +No functional changes since Synapse 1.45.0rc2. + +Improved Documentation +---------------------- + +- Reword changelog to clarify concerns about a suspected performance regression in 1.44. ([\#11117](https://github.com/matrix-org/synapse/issues/11117)) + + Synapse 1.45.0rc2 (2021-10-14) ============================== diff --git a/changelog.d/11117.doc b/changelog.d/11117.doc deleted file mode 100644 index b4809fd6e..000000000 --- a/changelog.d/11117.doc +++ /dev/null @@ -1 +0,0 @@ -Reword changelog to clarify concerns about a suspected performance regression in 1.44. diff --git a/debian/changelog b/debian/changelog index f930befbe..5fefb2f2a 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,9 @@ +matrix-synapse-py3 (1.45.0) stable; urgency=medium + + * New synapse release 1.45.0. + + -- Synapse Packaging team Tue, 19 Oct 2021 11:18:53 +0100 + matrix-synapse-py3 (1.45.0~rc2) stable; urgency=medium * New synapse release 1.45.0~rc2. diff --git a/synapse/__init__.py b/synapse/__init__.py index ab90093e7..97452f34f 100644 --- a/synapse/__init__.py +++ b/synapse/__init__.py @@ -47,7 +47,7 @@ try: except ImportError: pass -__version__ = "1.45.0rc2" +__version__ = "1.45.0" if bool(os.environ.get("SYNAPSE_TEST_PATCH_LOG_CONTEXTS", False)): # We import here so that we don't have to install a bunch of deps when From a21f8c4b41adc323adf4a8ac517ff591856a74fb Mon Sep 17 00:00:00 2001 From: David Robertson Date: Tue, 19 Oct 2021 11:21:21 +0100 Subject: [PATCH 3/4] Duplicate known issues under 1.45 release --- CHANGES.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/CHANGES.md b/CHANGES.md index 7d1b804e8..e36b1acf8 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -3,6 +3,13 @@ Synapse 1.45.0 (2021-10-19) No functional changes since Synapse 1.45.0rc2. +Known Issues +------------ + +- A suspected [performance regression](https://github.com/matrix-org/synapse/issues/11049) which was first reported after the release of v1.44.0 remains unresolved. + + We have not been able to identify a probable cause. Affected users report that setting up a federation sender worker appears to alleviate symptoms of the regression. + Improved Documentation ---------------------- From 95813ff43cc08f2064049050a67e027751d9b091 Mon Sep 17 00:00:00 2001 From: David Robertson Date: Tue, 19 Oct 2021 11:30:16 +0100 Subject: [PATCH 4/4] Be less inconsistent about v1.2.3 versus 1.2.3 --- CHANGES.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index e36b1acf8..435387d7b 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -6,14 +6,14 @@ No functional changes since Synapse 1.45.0rc2. Known Issues ------------ -- A suspected [performance regression](https://github.com/matrix-org/synapse/issues/11049) which was first reported after the release of v1.44.0 remains unresolved. +- A suspected [performance regression](https://github.com/matrix-org/synapse/issues/11049) which was first reported after the release of 1.44.0 remains unresolved. We have not been able to identify a probable cause. Affected users report that setting up a federation sender worker appears to alleviate symptoms of the regression. Improved Documentation ---------------------- -- Reword changelog to clarify concerns about a suspected performance regression in 1.44. ([\#11117](https://github.com/matrix-org/synapse/issues/11117)) +- Reword changelog to clarify concerns about a suspected performance regression in 1.44.0. ([\#11117](https://github.com/matrix-org/synapse/issues/11117)) Synapse 1.45.0rc2 (2021-10-14) @@ -24,7 +24,7 @@ This release candidate [fixes](https://github.com/matrix-org/synapse/issues/1105 Known Issues ------------ -- A suspected [performance regression](https://github.com/matrix-org/synapse/issues/11049) which was first reported after the release of v1.44.0 remains unresolved. +- A suspected [performance regression](https://github.com/matrix-org/synapse/issues/11049) which was first reported after the release of 1.44.0 remains unresolved. We have not been able to identify a probable cause. Affected users report that setting up a federation sender worker appears to alleviate symptoms of the regression. @@ -34,7 +34,7 @@ Bugfixes - Fix a long-standing bug when using multiple event persister workers where events were not correctly sent down `/sync` due to a race. ([\#11045](https://github.com/matrix-org/synapse/issues/11045)) - Fix a bug introduced in Synapse 1.45.0rc1 where the user directory would stop updating if it processed an event from a user not in the `users` table. ([\#11053](https://github.com/matrix-org/synapse/issues/11053)) -- Fix a bug introduced in Synapse v1.44.0 when logging errors during oEmbed processing. ([\#11061](https://github.com/matrix-org/synapse/issues/11061)) +- Fix a bug introduced in Synapse 1.44.0 when logging errors during oEmbed processing. ([\#11061](https://github.com/matrix-org/synapse/issues/11061)) Internal Changes @@ -54,7 +54,7 @@ Synapse 1.45.0rc1 (2021-10-12) Known Issues ------------ -- We are investigating [a performance issue](https://github.com/matrix-org/synapse/issues/11049) which was reported after the release of v1.44.0. +- We are investigating [a performance issue](https://github.com/matrix-org/synapse/issues/11049) which was reported after the release of 1.44.0. - We are aware of [a bug](https://github.com/matrix-org/synapse/issues/11025) with the user directory when using application services. A second release candidate is expected which will resolve this. Features