Track a histogram of state res durations (#13036)

This commit is contained in:
David Robertson 2022-06-15 15:19:49 +01:00 committed by GitHub
parent 0dbdc39940
commit 941dc3db13
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 0 deletions

View File

@ -0,0 +1 @@
Add metrics measuring the CPU and DB time spent in state resolution.

View File

@ -444,6 +444,15 @@ _biggest_room_by_db_counter = Counter(
"expensive room for state resolution",
)
_cpu_times = Histogram(
"synapse_state_res_cpu_for_all_rooms_seconds",
"CPU time (utime+stime) spent computing a single state resolution",
)
_db_times = Histogram(
"synapse_state_res_db_for_all_rooms_seconds",
"Database time spent computing a single state resolution",
)
class StateResolutionHandler:
"""Responsible for doing state conflict resolution.
@ -609,6 +618,9 @@ class StateResolutionHandler:
room_metrics.db_time += rusage.db_txn_duration_sec
room_metrics.db_events += rusage.evt_db_fetch_count
_cpu_times.observe(rusage.ru_utime + rusage.ru_stime)
_db_times.observe(rusage.db_txn_duration_sec)
def _report_metrics(self) -> None:
if not self._state_res_metrics:
# no state res has happened since the last iteration: don't bother logging.