Merge pull request #1766 from matrix-org/markjh/linear_logging

More logging for the linearizer and for get_events
This commit is contained in:
Matthew Hodgson 2017-01-05 13:01:31 +00:00 committed by GitHub
commit 7738329672
2 changed files with 13 additions and 2 deletions

View File

@ -1084,8 +1084,10 @@ class EventsStore(SQLBaseStore):
self._do_fetch self._do_fetch
) )
logger.info("Loading %d events", len(events))
with PreserveLoggingContext(): with PreserveLoggingContext():
rows = yield events_d rows = yield events_d
logger.info("Loaded %d events (%d rows)", len(events), len(rows))
if not allow_rejected: if not allow_rejected:
rows[:] = [r for r in rows if not r["rejects"]] rows[:] = [r for r in rows if not r["rejects"]]

View File

@ -166,7 +166,11 @@ class Linearizer(object):
# do some work. # do some work.
""" """
def __init__(self): def __init__(self, name=None):
if name is None:
self.name = id(self)
else:
self.name = name
self.key_to_defer = {} self.key_to_defer = {}
@defer.inlineCallbacks @defer.inlineCallbacks
@ -185,15 +189,20 @@ class Linearizer(object):
self.key_to_defer[key] = new_defer self.key_to_defer[key] = new_defer
if current_defer: if current_defer:
logger.info("Waiting to acquire linearizer lock for key %r", key) logger.info(
"Waiting to acquire linearizer lock %r for key %r", self.name, key
)
with PreserveLoggingContext(): with PreserveLoggingContext():
yield current_defer yield current_defer
logger.info("Acquired linearizer lock %r for key %r", self.name, key)
@contextmanager @contextmanager
def _ctx_manager(): def _ctx_manager():
try: try:
yield yield
finally: finally:
logger.info("Releasing linearizer lock %r for key %r", self.name, key)
new_defer.callback(None) new_defer.callback(None)
current_d = self.key_to_defer.get(key) current_d = self.key_to_defer.get(key)
if current_d is new_defer: if current_d is new_defer: