Change the parameter immediate of send_device_messages to default to True (#15297)

This commit is contained in:
Shay 2023-03-21 17:59:55 -07:00 committed by GitHub
parent b32014578a
commit 72f3f23c4d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 2 deletions

1
changelog.d/15297.bugfix Normal file
View File

@ -0,0 +1 @@
Fix a bug introduced in Synapse v1.55.0 which could delay remote homeservers being able to decrypt encrypted messages sent by local users.

View File

@ -244,7 +244,7 @@ class FederationRemoteSendQueue(AbstractFederationSender):
self.notifier.on_new_replication_data() self.notifier.on_new_replication_data()
def send_device_messages(self, destination: str, immediate: bool = False) -> None: def send_device_messages(self, destination: str, immediate: bool = True) -> None:
"""As per FederationSender""" """As per FederationSender"""
# We don't need to replicate this as it gets sent down a different # We don't need to replicate this as it gets sent down a different
# stream. # stream.

View File

@ -783,7 +783,7 @@ class FederationSender(AbstractFederationSender):
else: else:
queue.send_edu(edu) queue.send_edu(edu)
def send_device_messages(self, destination: str, immediate: bool = False) -> None: def send_device_messages(self, destination: str, immediate: bool = True) -> None:
if destination == self.server_name: if destination == self.server_name:
logger.warning("Not sending device update to ourselves") logger.warning("Not sending device update to ourselves")
return return