Srsly. Don't use closures. Baaaaaad

This commit is contained in:
Erik Johnston 2015-05-15 11:26:00 +01:00
parent 575ec91d82
commit 372d4c6d7b

View File

@ -529,20 +529,18 @@ class EventsStore(SQLBaseStore):
logger.debug("do_fetch got events: %r", row_dict.keys()) logger.debug("do_fetch got events: %r", row_dict.keys())
def fire(evs): def fire(lst, res):
for ids, d in evs: for ids, d in lst:
if not d.called: if not d.called:
try: try:
d.callback( d.callback([
[ res[i]
row_dict[i]
for i in ids for i in ids
if i in row_dict if i in res
] ])
)
except: except:
logger.exception("Failed to callback") logger.exception("Failed to callback")
reactor.callFromThread(fire, event_list) reactor.callFromThread(fire, event_list, row_dict)
except Exception as e: except Exception as e:
logger.exception("do_fetch") logger.exception("do_fetch")