From 29ce6d43b533634a8b743e16e99ef3d025802e96 Mon Sep 17 00:00:00 2001 From: kleph Date: Wed, 28 Oct 2020 13:49:08 +0100 Subject: [PATCH] Run mypy as part of the lint.sh script. (#8633) --- CONTRIBUTING.md | 4 ++-- changelog.d/8633.misc | 1 + scripts-dev/lint.sh | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) create mode 100644 changelog.d/8633.misc diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index c17e3b239..f7bea79b0 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -46,7 +46,7 @@ locally. You'll need python 3.6 or later, and to install a number of tools: ``` # Install the dependencies -pip install -e ".[lint]" +pip install -e ".[lint,mypy]" # Run the linter script ./scripts-dev/lint.sh @@ -63,7 +63,7 @@ run-time: ./scripts-dev/lint.sh path/to/file1.py path/to/file2.py path/to/folder ``` -You can also provided the `-d` option, which will lint the files that have been +You can also provide the `-d` option, which will lint the files that have been changed since the last git commit. This will often be significantly faster than linting the whole codebase. diff --git a/changelog.d/8633.misc b/changelog.d/8633.misc new file mode 100644 index 000000000..8e1d006b3 --- /dev/null +++ b/changelog.d/8633.misc @@ -0,0 +1 @@ +Run `mypy` as part of the lint.sh script. diff --git a/scripts-dev/lint.sh b/scripts-dev/lint.sh index f2b65a210..f14180551 100755 --- a/scripts-dev/lint.sh +++ b/scripts-dev/lint.sh @@ -94,3 +94,4 @@ isort "${files[@]}" python3 -m black "${files[@]}" ./scripts-dev/config-lint.sh flake8 "${files[@]}" +mypy