Matrix-Mirrors/forked-synapse
1
0
Fork 0
mirror of https://mau.dev/maunium/synapse.git synced 2024-10-01 01:36:05 -04:00
Code Issues Packages Projects Releases Wiki Activity

Increase batching when fetching auth chains (#16893)

Browse Source 
This basically reverts a change that was in
https://github.com/element-hq/synapse/pull/16833, where we reduced the
batching.

The smaller batching can cause performance issues on busy servers and
databases.
This commit is contained in:
Erik Johnston 2024-02-09 10:51:00 +00:00 committed by GitHub
parent 7c805f00a7
commit 02a147039c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/16893.bugfix Normal file
View File

@ -0,0 +1 @@
Fix performance regression when fetching auth chains from the DB. Introduced in v1.100.0.

4
synapse/storage/databases/main/event_federation.py
View File

@ -310,7 +310,7 @@ class EventFederationWorkerStore(SignatureWorkerStore, EventsWorkerStore, SQLBas
# Add all linked chains reachable from initial set of chains. # Add all linked chains reachable from initial set of chains.
chains_to_fetch = set(event_chains.keys()) chains_to_fetch = set(event_chains.keys())
while chains_to_fetch: while chains_to_fetch:
batch2 = tuple(itertools.islice(chains_to_fetch, 100)) batch2 = tuple(itertools.islice(chains_to_fetch, 1000))
chains_to_fetch.difference_update(batch2) chains_to_fetch.difference_update(batch2)
clause, args = make_in_list_sql_clause( clause, args = make_in_list_sql_clause(
txn.database_engine, "origin_chain_id", batch2 txn.database_engine, "origin_chain_id", batch2
@ -593,7 +593,7 @@ class EventFederationWorkerStore(SignatureWorkerStore, EventsWorkerStore, SQLBas
# the loop) # the loop)
chains_to_fetch = set(seen_chains) chains_to_fetch = set(seen_chains)
while chains_to_fetch: while chains_to_fetch:
batch2 = tuple(itertools.islice(chains_to_fetch, 100)) batch2 = tuple(itertools.islice(chains_to_fetch, 1000))
clause, args = make_in_list_sql_clause( clause, args = make_in_list_sql_clause(
txn.database_engine, "origin_chain_id", batch2 txn.database_engine, "origin_chain_id", batch2
) )