2020-10-14 18:25:23 -04:00
|
|
|
#
|
2023-11-21 15:29:58 -05:00
|
|
|
# This file is licensed under the Affero General Public License (AGPL) version 3.
|
|
|
|
#
|
2024-01-23 06:26:48 -05:00
|
|
|
# Copyright 2020 The Matrix.org Foundation C.I.C.
|
2023-11-21 15:29:58 -05:00
|
|
|
# Copyright (C) 2023 New Vector, Ltd
|
|
|
|
#
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
|
|
|
# it under the terms of the GNU Affero General Public License as
|
|
|
|
# published by the Free Software Foundation, either version 3 of the
|
|
|
|
# License, or (at your option) any later version.
|
|
|
|
#
|
|
|
|
# See the GNU Affero General Public License for more details:
|
|
|
|
# <https://www.gnu.org/licenses/agpl-3.0.html>.
|
|
|
|
#
|
|
|
|
# Originally licensed under the Apache License, Version 2.0:
|
|
|
|
# <http://www.apache.org/licenses/LICENSE-2.0>.
|
|
|
|
#
|
|
|
|
# [This file includes modifications made by New Vector Limited]
|
2020-10-14 18:25:23 -04:00
|
|
|
#
|
|
|
|
#
|
|
|
|
|
|
|
|
from functools import partial
|
2022-11-22 17:35:54 -05:00
|
|
|
from typing import List, Tuple
|
2020-10-14 18:25:23 -04:00
|
|
|
|
|
|
|
from twisted.internet import defer
|
|
|
|
|
2020-10-14 18:37:23 -04:00
|
|
|
from synapse.util.caches.deferred_cache import DeferredCache
|
2020-10-14 18:25:23 -04:00
|
|
|
|
2020-10-16 07:34:55 -04:00
|
|
|
from tests.unittest import TestCase
|
2020-10-14 18:25:23 -04:00
|
|
|
|
2020-10-16 07:34:55 -04:00
|
|
|
|
|
|
|
class DeferredCacheTestCase(TestCase):
|
2022-11-22 17:35:54 -05:00
|
|
|
def test_empty(self) -> None:
|
|
|
|
cache: DeferredCache[str, int] = DeferredCache("test")
|
2021-01-06 12:33:20 -05:00
|
|
|
with self.assertRaises(KeyError):
|
2020-10-14 18:37:23 -04:00
|
|
|
cache.get("foo")
|
|
|
|
|
2022-11-22 17:35:54 -05:00
|
|
|
def test_hit(self) -> None:
|
|
|
|
cache: DeferredCache[str, int] = DeferredCache("test")
|
2020-10-14 18:37:23 -04:00
|
|
|
cache.prefill("foo", 123)
|
|
|
|
|
2022-02-28 07:12:29 -05:00
|
|
|
self.assertEqual(self.successResultOf(cache.get("foo")), 123)
|
2020-10-14 18:37:23 -04:00
|
|
|
|
2022-11-22 17:35:54 -05:00
|
|
|
def test_hit_deferred(self) -> None:
|
|
|
|
cache: DeferredCache[str, int] = DeferredCache("test")
|
|
|
|
origin_d: "defer.Deferred[int]" = defer.Deferred()
|
2020-10-16 16:32:52 -04:00
|
|
|
set_d = cache.set("k1", origin_d)
|
|
|
|
|
|
|
|
# get should return an incomplete deferred
|
|
|
|
get_d = cache.get("k1")
|
|
|
|
self.assertFalse(get_d.called)
|
|
|
|
|
|
|
|
# add a callback that will make sure that the set_d gets called before the get_d
|
2022-11-22 17:35:54 -05:00
|
|
|
def check1(r: str) -> str:
|
2020-10-16 16:32:52 -04:00
|
|
|
self.assertTrue(set_d.called)
|
|
|
|
return r
|
|
|
|
|
2021-11-01 20:17:35 -04:00
|
|
|
get_d.addCallback(check1)
|
2020-10-16 16:32:52 -04:00
|
|
|
|
|
|
|
# now fire off all the deferreds
|
|
|
|
origin_d.callback(99)
|
|
|
|
self.assertEqual(self.successResultOf(origin_d), 99)
|
|
|
|
self.assertEqual(self.successResultOf(set_d), 99)
|
|
|
|
self.assertEqual(self.successResultOf(get_d), 99)
|
|
|
|
|
2022-11-22 17:35:54 -05:00
|
|
|
def test_callbacks(self) -> None:
|
2020-10-16 16:32:52 -04:00
|
|
|
"""Invalidation callbacks are called at the right time"""
|
2022-11-22 17:35:54 -05:00
|
|
|
cache: DeferredCache[str, int] = DeferredCache("test")
|
2020-10-16 16:32:52 -04:00
|
|
|
callbacks = set()
|
|
|
|
|
|
|
|
# start with an entry, with a callback
|
|
|
|
cache.prefill("k1", 10, callback=lambda: callbacks.add("prefill"))
|
|
|
|
|
|
|
|
# now replace that entry with a pending result
|
2022-11-22 17:35:54 -05:00
|
|
|
origin_d: "defer.Deferred[int]" = defer.Deferred()
|
2020-10-16 16:32:52 -04:00
|
|
|
set_d = cache.set("k1", origin_d, callback=lambda: callbacks.add("set"))
|
|
|
|
|
|
|
|
# ... and also make a get request
|
|
|
|
get_d = cache.get("k1", callback=lambda: callbacks.add("get"))
|
|
|
|
|
|
|
|
# we don't expect the invalidation callback for the original value to have
|
|
|
|
# been called yet, even though get() will now return a different result.
|
|
|
|
# I'm not sure if that is by design or not.
|
|
|
|
self.assertEqual(callbacks, set())
|
|
|
|
|
|
|
|
# now fire off all the deferreds
|
|
|
|
origin_d.callback(20)
|
|
|
|
self.assertEqual(self.successResultOf(set_d), 20)
|
|
|
|
self.assertEqual(self.successResultOf(get_d), 20)
|
|
|
|
|
|
|
|
# now the original invalidation callback should have been called, but none of
|
|
|
|
# the others
|
|
|
|
self.assertEqual(callbacks, {"prefill"})
|
|
|
|
callbacks.clear()
|
|
|
|
|
|
|
|
# another update should invalidate both the previous results
|
|
|
|
cache.prefill("k1", 30)
|
|
|
|
self.assertEqual(callbacks, {"set", "get"})
|
|
|
|
|
2022-11-22 17:35:54 -05:00
|
|
|
def test_set_fail(self) -> None:
|
|
|
|
cache: DeferredCache[str, int] = DeferredCache("test")
|
2020-10-16 16:32:52 -04:00
|
|
|
callbacks = set()
|
|
|
|
|
|
|
|
# start with an entry, with a callback
|
|
|
|
cache.prefill("k1", 10, callback=lambda: callbacks.add("prefill"))
|
|
|
|
|
|
|
|
# now replace that entry with a pending result
|
2022-11-22 17:35:54 -05:00
|
|
|
origin_d: defer.Deferred = defer.Deferred()
|
2020-10-16 16:32:52 -04:00
|
|
|
set_d = cache.set("k1", origin_d, callback=lambda: callbacks.add("set"))
|
|
|
|
|
|
|
|
# ... and also make a get request
|
|
|
|
get_d = cache.get("k1", callback=lambda: callbacks.add("get"))
|
|
|
|
|
|
|
|
# none of the callbacks should have been called yet
|
|
|
|
self.assertEqual(callbacks, set())
|
|
|
|
|
|
|
|
# oh noes! fails!
|
|
|
|
e = Exception("oops")
|
|
|
|
origin_d.errback(e)
|
|
|
|
self.assertIs(self.failureResultOf(set_d, Exception).value, e)
|
|
|
|
self.assertIs(self.failureResultOf(get_d, Exception).value, e)
|
|
|
|
|
|
|
|
# the callbacks for the failed requests should have been called.
|
|
|
|
# I'm not sure if this is deliberate or not.
|
|
|
|
self.assertEqual(callbacks, {"get", "set"})
|
|
|
|
callbacks.clear()
|
|
|
|
|
|
|
|
# the old value should still be returned now?
|
|
|
|
get_d2 = cache.get("k1", callback=lambda: callbacks.add("get2"))
|
|
|
|
self.assertEqual(self.successResultOf(get_d2), 10)
|
|
|
|
|
|
|
|
# replacing the value now should run the callbacks for those requests
|
|
|
|
# which got the original result
|
|
|
|
cache.prefill("k1", 30)
|
|
|
|
self.assertEqual(callbacks, {"prefill", "get2"})
|
|
|
|
|
2022-11-22 17:35:54 -05:00
|
|
|
def test_get_immediate(self) -> None:
|
|
|
|
cache: DeferredCache[str, int] = DeferredCache("test")
|
|
|
|
d1: "defer.Deferred[int]" = defer.Deferred()
|
2020-10-19 10:00:12 -04:00
|
|
|
cache.set("key1", d1)
|
|
|
|
|
|
|
|
# get_immediate should return default
|
|
|
|
v = cache.get_immediate("key1", 1)
|
|
|
|
self.assertEqual(v, 1)
|
|
|
|
|
|
|
|
# now complete the set
|
|
|
|
d1.callback(2)
|
|
|
|
|
|
|
|
# get_immediate should return result
|
|
|
|
v = cache.get_immediate("key1", 1)
|
|
|
|
self.assertEqual(v, 2)
|
|
|
|
|
2022-11-22 17:35:54 -05:00
|
|
|
def test_invalidate(self) -> None:
|
|
|
|
cache: DeferredCache[Tuple[str], int] = DeferredCache("test")
|
2020-10-14 18:37:23 -04:00
|
|
|
cache.prefill(("foo",), 123)
|
|
|
|
cache.invalidate(("foo",))
|
|
|
|
|
2021-01-06 12:33:20 -05:00
|
|
|
with self.assertRaises(KeyError):
|
2020-10-14 18:37:23 -04:00
|
|
|
cache.get(("foo",))
|
|
|
|
|
2022-11-22 17:35:54 -05:00
|
|
|
def test_invalidate_all(self) -> None:
|
|
|
|
cache: DeferredCache[str, str] = DeferredCache("testcache")
|
2020-10-14 18:25:23 -04:00
|
|
|
|
|
|
|
callback_record = [False, False]
|
|
|
|
|
2022-11-22 17:35:54 -05:00
|
|
|
def record_callback(idx: int) -> None:
|
2020-10-14 18:25:23 -04:00
|
|
|
callback_record[idx] = True
|
|
|
|
|
|
|
|
# add a couple of pending entries
|
2022-11-22 17:35:54 -05:00
|
|
|
d1: "defer.Deferred[str]" = defer.Deferred()
|
2020-10-14 18:25:23 -04:00
|
|
|
cache.set("key1", d1, partial(record_callback, 0))
|
|
|
|
|
2022-11-22 17:35:54 -05:00
|
|
|
d2: "defer.Deferred[str]" = defer.Deferred()
|
2020-10-14 18:25:23 -04:00
|
|
|
cache.set("key2", d2, partial(record_callback, 1))
|
|
|
|
|
2020-10-16 07:34:55 -04:00
|
|
|
# lookup should return pending deferreds
|
|
|
|
self.assertFalse(cache.get("key1").called)
|
|
|
|
self.assertFalse(cache.get("key2").called)
|
2020-10-14 18:25:23 -04:00
|
|
|
|
|
|
|
# let one of the lookups complete
|
|
|
|
d2.callback("result2")
|
|
|
|
|
2020-10-16 07:34:55 -04:00
|
|
|
# now the cache will return a completed deferred
|
|
|
|
self.assertEqual(self.successResultOf(cache.get("key2")), "result2")
|
2020-10-14 18:25:23 -04:00
|
|
|
|
|
|
|
# now do the invalidation
|
|
|
|
cache.invalidate_all()
|
|
|
|
|
2020-10-19 10:00:12 -04:00
|
|
|
# lookup should fail
|
|
|
|
with self.assertRaises(KeyError):
|
|
|
|
cache.get("key1")
|
|
|
|
with self.assertRaises(KeyError):
|
|
|
|
cache.get("key2")
|
2020-10-14 18:25:23 -04:00
|
|
|
|
|
|
|
# both callbacks should have been callbacked
|
|
|
|
self.assertTrue(callback_record[0], "Invalidation callback for key1 not called")
|
|
|
|
self.assertTrue(callback_record[1], "Invalidation callback for key2 not called")
|
|
|
|
|
|
|
|
# letting the other lookup complete should do nothing
|
|
|
|
d1.callback("result1")
|
2020-10-19 10:00:12 -04:00
|
|
|
with self.assertRaises(KeyError):
|
|
|
|
cache.get("key1", None)
|
2020-10-14 18:37:23 -04:00
|
|
|
|
2022-11-22 17:35:54 -05:00
|
|
|
def test_eviction(self) -> None:
|
|
|
|
cache: DeferredCache[int, str] = DeferredCache(
|
2020-10-14 18:37:23 -04:00
|
|
|
"test", max_entries=2, apply_cache_factor_from_config=False
|
|
|
|
)
|
|
|
|
|
|
|
|
cache.prefill(1, "one")
|
|
|
|
cache.prefill(2, "two")
|
|
|
|
cache.prefill(3, "three") # 1 will be evicted
|
|
|
|
|
2021-01-06 12:33:20 -05:00
|
|
|
with self.assertRaises(KeyError):
|
2020-10-14 18:37:23 -04:00
|
|
|
cache.get(1)
|
|
|
|
|
|
|
|
cache.get(2)
|
|
|
|
cache.get(3)
|
|
|
|
|
2022-11-22 17:35:54 -05:00
|
|
|
def test_eviction_lru(self) -> None:
|
|
|
|
cache: DeferredCache[int, str] = DeferredCache(
|
2020-10-14 18:37:23 -04:00
|
|
|
"test", max_entries=2, apply_cache_factor_from_config=False
|
|
|
|
)
|
|
|
|
|
|
|
|
cache.prefill(1, "one")
|
|
|
|
cache.prefill(2, "two")
|
|
|
|
|
|
|
|
# Now access 1 again, thus causing 2 to be least-recently used
|
|
|
|
cache.get(1)
|
|
|
|
|
|
|
|
cache.prefill(3, "three")
|
|
|
|
|
2021-01-06 12:33:20 -05:00
|
|
|
with self.assertRaises(KeyError):
|
2020-10-14 18:37:23 -04:00
|
|
|
cache.get(2)
|
|
|
|
|
2021-01-06 12:33:20 -05:00
|
|
|
cache.get(1)
|
|
|
|
cache.get(3)
|
|
|
|
|
2022-11-22 17:35:54 -05:00
|
|
|
def test_eviction_iterable(self) -> None:
|
|
|
|
cache: DeferredCache[int, List[str]] = DeferredCache(
|
2021-01-06 12:33:20 -05:00
|
|
|
"test",
|
|
|
|
max_entries=3,
|
|
|
|
apply_cache_factor_from_config=False,
|
|
|
|
iterable=True,
|
|
|
|
)
|
|
|
|
|
|
|
|
cache.prefill(1, ["one", "two"])
|
|
|
|
cache.prefill(2, ["three"])
|
2020-10-14 18:37:23 -04:00
|
|
|
|
2021-01-06 12:33:20 -05:00
|
|
|
# Now access 1 again, thus causing 2 to be least-recently used
|
|
|
|
cache.get(1)
|
|
|
|
|
|
|
|
# Now add an item to the cache, which evicts 2.
|
|
|
|
cache.prefill(3, ["four"])
|
|
|
|
with self.assertRaises(KeyError):
|
|
|
|
cache.get(2)
|
|
|
|
|
|
|
|
# Ensure 1 & 3 are in the cache.
|
2020-10-14 18:37:23 -04:00
|
|
|
cache.get(1)
|
|
|
|
cache.get(3)
|
2021-01-06 12:33:20 -05:00
|
|
|
|
|
|
|
# Now access 1 again, thus causing 3 to be least-recently used
|
|
|
|
cache.get(1)
|
|
|
|
|
|
|
|
# Now add an item with multiple elements to the cache
|
|
|
|
cache.prefill(4, ["five", "six"])
|
|
|
|
|
|
|
|
# Both 1 and 3 are evicted since there's too many elements.
|
|
|
|
with self.assertRaises(KeyError):
|
|
|
|
cache.get(1)
|
|
|
|
with self.assertRaises(KeyError):
|
|
|
|
cache.get(3)
|
|
|
|
|
|
|
|
# Now add another item to fill the cache again.
|
|
|
|
cache.prefill(5, ["seven"])
|
|
|
|
|
|
|
|
# Now access 4, thus causing 5 to be least-recently used
|
|
|
|
cache.get(4)
|
|
|
|
|
|
|
|
# Add an empty item.
|
|
|
|
cache.prefill(6, [])
|
|
|
|
|
|
|
|
# 5 gets evicted and replaced since an empty element counts as an item.
|
|
|
|
with self.assertRaises(KeyError):
|
|
|
|
cache.get(5)
|
|
|
|
cache.get(4)
|
|
|
|
cache.get(6)
|