David Robertson ffc2ee521d Use mypy 1.0 (#15052) ... * Update mypy and mypy-zope * Remove unused ignores These used to suppress ``` synapse/storage/engines/__init__.py:28: error: "__new__" must return a class instance (got "NoReturn") [misc] ``` and ``` synapse/http/matrixfederationclient.py:1270: error: "BaseException" has no attribute "reasons" [attr-defined] ``` (note that we check `hasattr(e, "reasons")` above) * Avoid empty body warnings, sometimes by marking methods as abstract E.g. ``` tests/handlers/test_register.py:58: error: Missing return statement [empty-body] tests/handlers/test_register.py:108: error: Missing return statement [empty-body] ``` * Suppress false positive about `JaegerConfig` Complaint was ``` synapse/logging/opentracing.py:450: error: Function "Type[Config]" could always be true in boolean context [truthy-function] ``` * Fix not calling `is_state()` Oops! ``` tests/rest/client/test_third_party_rules.py:428: error: Function "Callable[[], bool]" could always be true in boolean context [truthy-function] ``` * Suppress false positives from ParamSpecs ```` synapse/logging/opentracing.py:971: error: Argument 2 to "_custom_sync_async_decorator" has incompatible type "Callable[[Arg(Callable[P, R], 'func'), **P], _GeneratorContextManager[None]]"; expected "Callable[[Callable[P, R], **P], _GeneratorContextManager[None]]" [arg-type] synapse/logging/opentracing.py:1017: error: Argument 2 to "_custom_sync_async_decorator" has incompatible type "Callable[[Arg(Callable[P, R], 'func'), **P], _GeneratorContextManager[None]]"; expected "Callable[[Callable[P, R], **P], _GeneratorContextManager[None]]" [arg-type] ```` * Drive-by improvement to `wrapping_logic` annotation * Workaround false "unreachable" positives See https://github.com/Shoobx/mypy-zope/issues/91 ``` tests/http/test_proxyagent.py:626: error: Statement is unreachable [unreachable] tests/http/test_proxyagent.py:762: error: Statement is unreachable [unreachable] tests/http/test_proxyagent.py:826: error: Statement is unreachable [unreachable] tests/http/test_proxyagent.py:838: error: Statement is unreachable [unreachable] tests/http/test_proxyagent.py:845: error: Statement is unreachable [unreachable] tests/http/federation/test_matrix_federation_agent.py:151: error: Statement is unreachable [unreachable] tests/http/federation/test_matrix_federation_agent.py:452: error: Statement is unreachable [unreachable] tests/logging/test_remote_handler.py:60: error: Statement is unreachable [unreachable] tests/logging/test_remote_handler.py:93: error: Statement is unreachable [unreachable] tests/logging/test_remote_handler.py:127: error: Statement is unreachable [unreachable] tests/logging/test_remote_handler.py:152: error: Statement is unreachable [unreachable] ``` * Changelog * Tweak DBAPI2 Protocol to be accepted by mypy 1.0 Some extra context in: - https://github.com/matrix-org/python-canonicaljson/pull/57 - https://github.com/python/mypy/issues/6002 - https://mypy.readthedocs.io/en/latest/common_issues.html#covariant-subtyping-of-mutable-protocol-members-is-rejected * Pull in updated canonicaljson lib so the protocol check just works * Improve comments in opentracing I tried to workaround the ignores but found it too much trouble. I think the corresponding issue is https://github.com/python/mypy/issues/12909. The mypy repo has a PR claiming to fix this (https://github.com/python/mypy/pull/14677) which might mean this gets resolved soon? * Better annotation for INTERACTIVE_AUTH_CHECKERS * Drive-by AUTH_TYPE annotation, to remove an ignore		2023-02-16 16:09:11 +00:00
..
controllers	Return read-only collections from @cached methods (#13755)	2023-02-10 23:29:00 +00:00
databases	Fix order of partial state tables when purging (#15068)	2023-02-14 23:42:29 +00:00
engines	Use mypy 1.0 (#15052)	2023-02-16 16:09:11 +00:00
schema	Bump schema version (#15036)	2023-02-09 15:28:26 +00:00
util	Always notify replication when a stream advances (#14877)	2023-01-20 18:02:18 +00:00
__init__.py	Rename storage classes (#12913)	2022-05-31 12:17:50 +00:00
_base.py	Add final type hint to synapse.server. (#15035)	2023-02-09 09:49:04 -05:00
background_updates.py	Handle half-created indices in receipts index background update (#14650)	2022-12-09 23:02:11 +00:00
database.py	Add final type hint to synapse.server. (#15035)	2023-02-09 09:49:04 -05:00
keys.py	Use auto_attribs/native type hints for attrs classes. (#11692)	2022-01-13 13:49:28 +00:00
prepare_database.py	Do not always start a db txn on Postgres (#14840)	2023-02-09 19:57:01 +00:00
push_rule.py	Remove redundant "coding: utf-8" lines (#9786)	2021-04-14 15:34:27 +01:00
roommember.py	Do not include rooms with an unknown room version in a sync response. (#10644)	2021-08-19 11:12:55 -04:00
types.py	Use mypy 1.0 (#15052)	2023-02-16 16:09:11 +00:00