mirror of
https://git.anonymousland.org/anonymousland/synapse.git
synced 2025-11-18 22:32:01 -05:00
Revert "Sort internal changes in changelog" Revert "Update CHANGES.md" Revert "1.49.0rc1" Revert "Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505) (#11527)" Revert "Refactors in `_generate_sync_entry_for_rooms` (#11515)" Revert "Correctly register shutdown handler for presence workers (#11518)" Revert "Fix `ModuleApi.looping_background_call` for non-async functions (#11524)" Revert "Fix 'delete room' admin api to work on incomplete rooms (#11523)" Revert "Correctly ignore invites from ignored users (#11511)" Revert "Fix the test breakage introduced by #11435 as a result of concurrent PRs (#11522)" Revert "Stabilise support for MSC2918 refresh tokens as they have now been merged into the Matrix specification. (#11435)" Revert "Save the OIDC session ID (sid) with the device on login (#11482)" Revert "Add admin API to get some information about federation status (#11407)" Revert "Include bundled aggregations in /sync and related fixes (#11478)" Revert "Move `glob_to_regex` and `re_word_boundary` to `matrix-python-common` (#11505)" Revert "Update backward extremity docs to make it clear that it does not indicate whether we have fetched an events' `prev_events` (#11469)" Revert "Support configuring the lifetime of non-refreshable access tokens separately to refreshable access tokens. (#11445)" Revert "Add type hints to `synapse/tests/rest/admin` (#11501)" Revert "Revert accidental commits to develop." Revert "Newsfile" Revert "Give `tests.server.setup_test_homeserver` (nominally!) the same behaviour" Revert "Move `tests.utils.setup_test_homeserver` to `tests.server`" Revert "Convert one of the `setup_test_homeserver`s to `make_test_homeserver_synchronous`" Revert "Disambiguate queries on `state_key` (#11497)" Revert "Comments on the /sync tentacles (#11494)" Revert "Clean up tests.storage.test_appservice (#11492)" Revert "Clean up `tests.storage.test_main` to remove use of legacy code. (#11493)" Revert "Clean up `tests.test_visibility` to remove legacy code. (#11495)" Revert "Minor cleanup on recently ported doc pages (#11466)" Revert "Add most of the missing type hints to `synapse.federation`. (#11483)" Revert "Avoid waiting for zombie processes in `synctl stop` (#11490)" Revert "Fix media repository failing when media store path contains symlinks (#11446)" Revert "Add type annotations to `tests.storage.test_appservice`. (#11488)" Revert "`scripts-dev/sign_json`: support for signing events (#11486)" Revert "Add MSC3030 experimental client and federation API endpoints to get the closest event to a given timestamp (#9445)" Revert "Port wiki pages to documentation website (#11402)" Revert "Add a license header and comment. (#11479)" Revert "Clean-up get_version_string (#11468)" Revert "Link background update controller docs to summary (#11475)" Revert "Additional type hints for config module. (#11465)" Revert "Register the login redirect endpoint for v3. (#11451)" Revert "Update openid.md" Revert "Remove mention of OIDC certification from Dex (#11470)" Revert "Add a note about huge pages to our Postgres doc (#11467)" Revert "Don't start Synapse master process if `worker_app` is set (#11416)" Revert "Expose worker & homeserver as entrypoints in `setup.py` (#11449)" Revert "Bundle relations of relations into the `/relations` result. (#11284)" Revert "Fix `LruCache` corruption bug with a `size_callback` that can return 0 (#11454)" Revert "Eliminate a few `Any`s in `LruCache` type hints (#11453)" Revert "Remove unnecessary `json.dumps` from `tests.rest.admin` (#11461)" Revert "Merge branch 'master' into develop" This reverts commit26b5d2320f. This reverts commitbce4220f38. This reverts commit966b5d0fa0. This reverts commit088d748f2c. This reverts commit14d593f72d. This reverts commit2a3ec6facf. This reverts commiteccc49d755. This reverts commitb1ecd19c5d. This reverts commit9c55dedc8c. This reverts commit2d42e586a8. This reverts commit2f053f3f82. This reverts commita15a893df8. This reverts commit8b4b153c9e. This reverts commit494ebd7347. This reverts commita77c369897. This reverts commit4eb77965cd. This reverts commit637df95de6. This reverts commite5f426cd54. This reverts commit8cd68b8102. This reverts commit6cae125e20. This reverts commit7be88fbf48. This reverts commitb3fd99b74a. This reverts commitf7ec6e7d9e. This reverts commit5640992d17. This reverts commitd26808dd85. This reverts commitf91624a595. This reverts commit16d39a5490. This reverts commit8a4c296987. This reverts commit49e1356ee3. This reverts commitd2279f471b. This reverts commitb50e39df57. This reverts commit858d80bf0f. This reverts commit435f044807. This reverts commitf61462e1be. This reverts commita6f1a3abec. This reverts commit84dc50e160. This reverts commited635d3285. This reverts commit7b62791e00. This reverts commit153194c771. This reverts commitf44d729d4c. This reverts commita265fbd397. This reverts commitb9fef1a7cd. This reverts commitb0eb64ff7b. This reverts commitf1795463bf. This reverts commit70cbb1a5e3. This reverts commit42bf020463. This reverts commit379f2650cf. This reverts commit7ff22d6da4. This reverts commit5a0b652d36. This reverts commit432a174bc1. This reverts commitb14f8a1baf, reversing changes made toe713855dca.
450 lines
16 KiB
Python
450 lines
16 KiB
Python
# Copyright 2021 Dirk Klimpel
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
from typing import List
|
|
|
|
import synapse.rest.admin
|
|
from synapse.api.errors import Codes
|
|
from synapse.rest.client import login, room, sync
|
|
from synapse.storage.roommember import RoomsForUser
|
|
from synapse.types import JsonDict
|
|
|
|
from tests import unittest
|
|
from tests.unittest import override_config
|
|
|
|
|
|
class ServerNoticeTestCase(unittest.HomeserverTestCase):
|
|
|
|
servlets = [
|
|
synapse.rest.admin.register_servlets,
|
|
login.register_servlets,
|
|
room.register_servlets,
|
|
sync.register_servlets,
|
|
]
|
|
|
|
def prepare(self, reactor, clock, hs):
|
|
self.store = hs.get_datastore()
|
|
self.room_shutdown_handler = hs.get_room_shutdown_handler()
|
|
self.pagination_handler = hs.get_pagination_handler()
|
|
self.server_notices_manager = self.hs.get_server_notices_manager()
|
|
|
|
# Create user
|
|
self.admin_user = self.register_user("admin", "pass", admin=True)
|
|
self.admin_user_tok = self.login("admin", "pass")
|
|
|
|
self.other_user = self.register_user("user", "pass")
|
|
self.other_user_token = self.login("user", "pass")
|
|
|
|
self.url = "/_synapse/admin/v1/send_server_notice"
|
|
|
|
def test_no_auth(self):
|
|
"""Try to send a server notice without authentication."""
|
|
channel = self.make_request("POST", self.url)
|
|
|
|
self.assertEqual(401, int(channel.result["code"]), msg=channel.result["body"])
|
|
self.assertEqual(Codes.MISSING_TOKEN, channel.json_body["errcode"])
|
|
|
|
def test_requester_is_no_admin(self):
|
|
"""If the user is not a server admin, an error is returned."""
|
|
channel = self.make_request(
|
|
"POST",
|
|
self.url,
|
|
access_token=self.other_user_token,
|
|
)
|
|
|
|
self.assertEqual(403, int(channel.result["code"]), msg=channel.result["body"])
|
|
self.assertEqual(Codes.FORBIDDEN, channel.json_body["errcode"])
|
|
|
|
@override_config({"server_notices": {"system_mxid_localpart": "notices"}})
|
|
def test_user_does_not_exist(self):
|
|
"""Tests that a lookup for a user that does not exist returns a 404"""
|
|
channel = self.make_request(
|
|
"POST",
|
|
self.url,
|
|
access_token=self.admin_user_tok,
|
|
content={"user_id": "@unknown_person:test", "content": ""},
|
|
)
|
|
|
|
self.assertEqual(404, channel.code, msg=channel.json_body)
|
|
self.assertEqual(Codes.NOT_FOUND, channel.json_body["errcode"])
|
|
|
|
@override_config({"server_notices": {"system_mxid_localpart": "notices"}})
|
|
def test_user_is_not_local(self):
|
|
"""
|
|
Tests that a lookup for a user that is not a local returns a 400
|
|
"""
|
|
channel = self.make_request(
|
|
"POST",
|
|
self.url,
|
|
access_token=self.admin_user_tok,
|
|
content={
|
|
"user_id": "@unknown_person:unknown_domain",
|
|
"content": "",
|
|
},
|
|
)
|
|
|
|
self.assertEqual(400, channel.code, msg=channel.json_body)
|
|
self.assertEqual(
|
|
"Server notices can only be sent to local users", channel.json_body["error"]
|
|
)
|
|
|
|
@override_config({"server_notices": {"system_mxid_localpart": "notices"}})
|
|
def test_invalid_parameter(self):
|
|
"""If parameters are invalid, an error is returned."""
|
|
|
|
# no content, no user
|
|
channel = self.make_request(
|
|
"POST",
|
|
self.url,
|
|
access_token=self.admin_user_tok,
|
|
)
|
|
|
|
self.assertEqual(400, channel.code, msg=channel.json_body)
|
|
self.assertEqual(Codes.NOT_JSON, channel.json_body["errcode"])
|
|
|
|
# no content
|
|
channel = self.make_request(
|
|
"POST",
|
|
self.url,
|
|
access_token=self.admin_user_tok,
|
|
content={"user_id": self.other_user},
|
|
)
|
|
|
|
self.assertEqual(400, channel.code, msg=channel.json_body)
|
|
self.assertEqual(Codes.MISSING_PARAM, channel.json_body["errcode"])
|
|
|
|
# no body
|
|
channel = self.make_request(
|
|
"POST",
|
|
self.url,
|
|
access_token=self.admin_user_tok,
|
|
content={"user_id": self.other_user, "content": ""},
|
|
)
|
|
|
|
self.assertEqual(400, channel.code, msg=channel.json_body)
|
|
self.assertEqual(Codes.UNKNOWN, channel.json_body["errcode"])
|
|
self.assertEqual("'body' not in content", channel.json_body["error"])
|
|
|
|
# no msgtype
|
|
channel = self.make_request(
|
|
"POST",
|
|
self.url,
|
|
access_token=self.admin_user_tok,
|
|
content={"user_id": self.other_user, "content": {"body": ""}},
|
|
)
|
|
|
|
self.assertEqual(400, channel.code, msg=channel.json_body)
|
|
self.assertEqual(Codes.UNKNOWN, channel.json_body["errcode"])
|
|
self.assertEqual("'msgtype' not in content", channel.json_body["error"])
|
|
|
|
def test_server_notice_disabled(self):
|
|
"""Tests that server returns error if server notice is disabled"""
|
|
channel = self.make_request(
|
|
"POST",
|
|
self.url,
|
|
access_token=self.admin_user_tok,
|
|
content={
|
|
"user_id": self.other_user,
|
|
"content": "",
|
|
},
|
|
)
|
|
|
|
self.assertEqual(400, channel.code, msg=channel.json_body)
|
|
self.assertEqual(Codes.UNKNOWN, channel.json_body["errcode"])
|
|
self.assertEqual(
|
|
"Server notices are not enabled on this server", channel.json_body["error"]
|
|
)
|
|
|
|
@override_config({"server_notices": {"system_mxid_localpart": "notices"}})
|
|
def test_send_server_notice(self):
|
|
"""
|
|
Tests that sending two server notices is successfully,
|
|
the server uses the same room and do not send messages twice.
|
|
"""
|
|
# user has no room memberships
|
|
self._check_invite_and_join_status(self.other_user, 0, 0)
|
|
|
|
# send first message
|
|
channel = self.make_request(
|
|
"POST",
|
|
self.url,
|
|
access_token=self.admin_user_tok,
|
|
content={
|
|
"user_id": self.other_user,
|
|
"content": {"msgtype": "m.text", "body": "test msg one"},
|
|
},
|
|
)
|
|
self.assertEqual(200, channel.code, msg=channel.json_body)
|
|
|
|
# user has one invite
|
|
invited_rooms = self._check_invite_and_join_status(self.other_user, 1, 0)
|
|
room_id = invited_rooms[0].room_id
|
|
|
|
# user joins the room and is member now
|
|
self.helper.join(room=room_id, user=self.other_user, tok=self.other_user_token)
|
|
self._check_invite_and_join_status(self.other_user, 0, 1)
|
|
|
|
# get messages
|
|
messages = self._sync_and_get_messages(room_id, self.other_user_token)
|
|
self.assertEqual(len(messages), 1)
|
|
self.assertEqual(messages[0]["content"]["body"], "test msg one")
|
|
self.assertEqual(messages[0]["sender"], "@notices:test")
|
|
|
|
# invalidate cache of server notices room_ids
|
|
self.get_success(
|
|
self.server_notices_manager.get_or_create_notice_room_for_user.invalidate_all()
|
|
)
|
|
|
|
# send second message
|
|
channel = self.make_request(
|
|
"POST",
|
|
self.url,
|
|
access_token=self.admin_user_tok,
|
|
content={
|
|
"user_id": self.other_user,
|
|
"content": {"msgtype": "m.text", "body": "test msg two"},
|
|
},
|
|
)
|
|
self.assertEqual(200, channel.code, msg=channel.json_body)
|
|
|
|
# user has no new invites or memberships
|
|
self._check_invite_and_join_status(self.other_user, 0, 1)
|
|
|
|
# get messages
|
|
messages = self._sync_and_get_messages(room_id, self.other_user_token)
|
|
|
|
self.assertEqual(len(messages), 2)
|
|
self.assertEqual(messages[0]["content"]["body"], "test msg one")
|
|
self.assertEqual(messages[0]["sender"], "@notices:test")
|
|
self.assertEqual(messages[1]["content"]["body"], "test msg two")
|
|
self.assertEqual(messages[1]["sender"], "@notices:test")
|
|
|
|
@override_config({"server_notices": {"system_mxid_localpart": "notices"}})
|
|
def test_send_server_notice_leave_room(self):
|
|
"""
|
|
Tests that sending a server notices is successfully.
|
|
The user leaves the room and the second message appears
|
|
in a new room.
|
|
"""
|
|
# user has no room memberships
|
|
self._check_invite_and_join_status(self.other_user, 0, 0)
|
|
|
|
# send first message
|
|
channel = self.make_request(
|
|
"POST",
|
|
self.url,
|
|
access_token=self.admin_user_tok,
|
|
content={
|
|
"user_id": self.other_user,
|
|
"content": {"msgtype": "m.text", "body": "test msg one"},
|
|
},
|
|
)
|
|
self.assertEqual(200, channel.code, msg=channel.json_body)
|
|
|
|
# user has one invite
|
|
invited_rooms = self._check_invite_and_join_status(self.other_user, 1, 0)
|
|
first_room_id = invited_rooms[0].room_id
|
|
|
|
# user joins the room and is member now
|
|
self.helper.join(
|
|
room=first_room_id, user=self.other_user, tok=self.other_user_token
|
|
)
|
|
self._check_invite_and_join_status(self.other_user, 0, 1)
|
|
|
|
# get messages
|
|
messages = self._sync_and_get_messages(first_room_id, self.other_user_token)
|
|
self.assertEqual(len(messages), 1)
|
|
self.assertEqual(messages[0]["content"]["body"], "test msg one")
|
|
self.assertEqual(messages[0]["sender"], "@notices:test")
|
|
|
|
# user leaves the romm
|
|
self.helper.leave(
|
|
room=first_room_id, user=self.other_user, tok=self.other_user_token
|
|
)
|
|
|
|
# user is not member anymore
|
|
self._check_invite_and_join_status(self.other_user, 0, 0)
|
|
|
|
# invalidate cache of server notices room_ids
|
|
# if server tries to send to a cached room_id the user gets the message
|
|
# in old room
|
|
self.get_success(
|
|
self.server_notices_manager.get_or_create_notice_room_for_user.invalidate_all()
|
|
)
|
|
|
|
# send second message
|
|
channel = self.make_request(
|
|
"POST",
|
|
self.url,
|
|
access_token=self.admin_user_tok,
|
|
content={
|
|
"user_id": self.other_user,
|
|
"content": {"msgtype": "m.text", "body": "test msg two"},
|
|
},
|
|
)
|
|
self.assertEqual(200, channel.code, msg=channel.json_body)
|
|
|
|
# user has one invite
|
|
invited_rooms = self._check_invite_and_join_status(self.other_user, 1, 0)
|
|
second_room_id = invited_rooms[0].room_id
|
|
|
|
# user joins the room and is member now
|
|
self.helper.join(
|
|
room=second_room_id, user=self.other_user, tok=self.other_user_token
|
|
)
|
|
self._check_invite_and_join_status(self.other_user, 0, 1)
|
|
|
|
# get messages
|
|
messages = self._sync_and_get_messages(second_room_id, self.other_user_token)
|
|
|
|
self.assertEqual(len(messages), 1)
|
|
self.assertEqual(messages[0]["content"]["body"], "test msg two")
|
|
self.assertEqual(messages[0]["sender"], "@notices:test")
|
|
# room has the same id
|
|
self.assertNotEqual(first_room_id, second_room_id)
|
|
|
|
@override_config({"server_notices": {"system_mxid_localpart": "notices"}})
|
|
def test_send_server_notice_delete_room(self):
|
|
"""
|
|
Tests that the user get server notice in a new room
|
|
after the first server notice room was deleted.
|
|
"""
|
|
# user has no room memberships
|
|
self._check_invite_and_join_status(self.other_user, 0, 0)
|
|
|
|
# send first message
|
|
channel = self.make_request(
|
|
"POST",
|
|
self.url,
|
|
access_token=self.admin_user_tok,
|
|
content={
|
|
"user_id": self.other_user,
|
|
"content": {"msgtype": "m.text", "body": "test msg one"},
|
|
},
|
|
)
|
|
self.assertEqual(200, channel.code, msg=channel.json_body)
|
|
|
|
# user has one invite
|
|
invited_rooms = self._check_invite_and_join_status(self.other_user, 1, 0)
|
|
first_room_id = invited_rooms[0].room_id
|
|
|
|
# user joins the room and is member now
|
|
self.helper.join(
|
|
room=first_room_id, user=self.other_user, tok=self.other_user_token
|
|
)
|
|
self._check_invite_and_join_status(self.other_user, 0, 1)
|
|
|
|
# get messages
|
|
messages = self._sync_and_get_messages(first_room_id, self.other_user_token)
|
|
self.assertEqual(len(messages), 1)
|
|
self.assertEqual(messages[0]["content"]["body"], "test msg one")
|
|
self.assertEqual(messages[0]["sender"], "@notices:test")
|
|
|
|
# shut down and purge room
|
|
self.get_success(
|
|
self.room_shutdown_handler.shutdown_room(first_room_id, self.admin_user)
|
|
)
|
|
self.get_success(self.pagination_handler.purge_room(first_room_id))
|
|
|
|
# user is not member anymore
|
|
self._check_invite_and_join_status(self.other_user, 0, 0)
|
|
|
|
# It doesn't really matter what API we use here, we just want to assert
|
|
# that the room doesn't exist.
|
|
summary = self.get_success(self.store.get_room_summary(first_room_id))
|
|
# The summary should be empty since the room doesn't exist.
|
|
self.assertEqual(summary, {})
|
|
|
|
# invalidate cache of server notices room_ids
|
|
# if server tries to send to a cached room_id it gives an error
|
|
self.get_success(
|
|
self.server_notices_manager.get_or_create_notice_room_for_user.invalidate_all()
|
|
)
|
|
|
|
# send second message
|
|
channel = self.make_request(
|
|
"POST",
|
|
self.url,
|
|
access_token=self.admin_user_tok,
|
|
content={
|
|
"user_id": self.other_user,
|
|
"content": {"msgtype": "m.text", "body": "test msg two"},
|
|
},
|
|
)
|
|
self.assertEqual(200, channel.code, msg=channel.json_body)
|
|
|
|
# user has one invite
|
|
invited_rooms = self._check_invite_and_join_status(self.other_user, 1, 0)
|
|
second_room_id = invited_rooms[0].room_id
|
|
|
|
# user joins the room and is member now
|
|
self.helper.join(
|
|
room=second_room_id, user=self.other_user, tok=self.other_user_token
|
|
)
|
|
self._check_invite_and_join_status(self.other_user, 0, 1)
|
|
|
|
# get message
|
|
messages = self._sync_and_get_messages(second_room_id, self.other_user_token)
|
|
|
|
self.assertEqual(len(messages), 1)
|
|
self.assertEqual(messages[0]["content"]["body"], "test msg two")
|
|
self.assertEqual(messages[0]["sender"], "@notices:test")
|
|
# second room has new ID
|
|
self.assertNotEqual(first_room_id, second_room_id)
|
|
|
|
def _check_invite_and_join_status(
|
|
self, user_id: str, expected_invites: int, expected_memberships: int
|
|
) -> RoomsForUser:
|
|
"""Check invite and room membership status of a user.
|
|
|
|
Args
|
|
user_id: user to check
|
|
expected_invites: number of expected invites of this user
|
|
expected_memberships: number of expected room memberships of this user
|
|
Returns
|
|
room_ids from the rooms that the user is invited
|
|
"""
|
|
|
|
invited_rooms = self.get_success(
|
|
self.store.get_invited_rooms_for_local_user(user_id)
|
|
)
|
|
self.assertEqual(expected_invites, len(invited_rooms))
|
|
|
|
room_ids = self.get_success(self.store.get_rooms_for_user(user_id))
|
|
self.assertEqual(expected_memberships, len(room_ids))
|
|
|
|
return invited_rooms
|
|
|
|
def _sync_and_get_messages(self, room_id: str, token: str) -> List[JsonDict]:
|
|
"""
|
|
Do a sync and get messages of a room.
|
|
|
|
Args
|
|
room_id: room that contains the messages
|
|
token: access token of user
|
|
|
|
Returns
|
|
list of messages contained in the room
|
|
"""
|
|
channel = self.make_request(
|
|
"GET", "/_matrix/client/r0/sync", access_token=token
|
|
)
|
|
self.assertEqual(channel.code, 200)
|
|
|
|
# Get the messages
|
|
room = channel.json_body["rooms"]["join"][room_id]
|
|
messages = [
|
|
x for x in room["timeline"]["events"] if x["type"] == "m.room.message"
|
|
]
|
|
return messages
|