anonymousland-synapse

mirror of https://git.anonymousland.org/anonymousland/synapse.git synced 2024-10-01 11:49:51 -04:00

Author	SHA1	Message	Date
Erik Johnston	5e42e61609	Merge remote-tracking branch 'origin/release-v1.20.0' into develop	2020-09-18 10:50:04 +01:00
Erik Johnston	14b5b48a22	Fix ratelimiting for federation `/send` requests. (#8342 ) c.f. #8295 for rationale	2020-09-18 10:49:29 +01:00
Jonathan de Jong	efb6b6629c	Move lint dependencies to extras_require (#8330 ) Lint dependencies can now be installed with pip install -e ".[lint]" This should help keep the version in sync between tox and documentation.	2020-09-17 16:45:22 -04:00
Jonathan de Jong	837293c314	Remove obsolete __future__ imports (#8337 )	2020-09-17 08:37:01 -04:00
Patrick Cloke	c3c9732c53	Use admin_patterns for all admin APIs. (#8331 ) This reduces duplication of the admin prefix in regular expressions.	2020-09-17 07:04:15 -04:00
Jonathan de Jong	53284c425e	Fix a potential bug of UnboundLocalError (#8329 ) Replaced with less buggier control flow	2020-09-17 11:54:56 +01:00
Jonathan de Jong	a3f124b821	Switch metaclass initialization to python 3-compatible syntax (#8326 )	2020-09-16 15:15:55 -04:00
Patrick Cloke	44dec6cbc4	Synapse 1.20.0rc4 (2020-09-16) ============================== Synapse 1.20.0rc4 is identical to 1.20.0rc3, with the addition of the security fix that was included in 1.19.2. -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEF3tZXk38tRDFVnUIM/xY9qcRMEgFAl9iC2QACgkQM/xY9qcR MEhQJw/+N158AAvxLQsk4bNu8gscc6CAJaDtdR+QNqQa9UOit8dj7nnIhgRCqvPy ZyNjKpI0LxytTS+NAYWNT88gfOcODR9TkWd7o8rGLCBenF3SwdZ2MM40gmHkola1 WunsRSHuYH1lyVumdOOIw8uOOnglORgRjcuQ4ht5AKYYnWAMBxD+crluXOGdJeLS OdxBzCCHO1s3nb09ybvpxsxtXwbsRqhDKqotZn3gJzPbtV8NUNaer29bA7bAfMJ0 NvIKIEjrg79PEYX2G0i2kGaNqcCne8SY8Mb/nc0/M2KiLPDevy+eKA2jKYmWfUK+ 2MbGYmA5rXUy4RPUB4cmGkqbsZhBPMGT4O6GD8UTJ/9dESUPzTJKcJgv1mZbMA1F HfQOnjTRrsf9incU+QBgkKkrVboBTnpewO2mRoiLtavAUiPiXX0WvWrYfRpXyiSU uihuVHY/tefxEW2uUGYGsCxthm8V2vrIumd8qASdybAO7gZtyrKN/5Z9M1Xhu9Fc FidoOXo1TrAjoqVL2rfslPYdl0Pqed4IoWthwSIV+0C33e3qzeH32X2unY0HX4s/ 3KPvxXqAsdE6T0WdZwKEDrGO33OtrBPkJK+O2yjSV+3d+wdqGm+RVm39lsVysKX2 KJXcJ/An8yDwaN+lemeSLbOxU3TRWGdT/Wrek8HAH/bAULzlLWg= =0feV -----END PGP SIGNATURE----- Merge tag 'v1.20.0rc4' into develop Synapse 1.20.0rc4 (2020-09-16) ============================== Synapse 1.20.0rc4 is identical to 1.20.0rc3, with the addition of the security fix that was included in 1.19.2.	2020-09-16 09:00:20 -04:00
Patrick Cloke	7141057e85	1.20.0rc4	2020-09-16 08:54:30 -04:00
Erik Johnston	5ffd68dca1	1.19.2	2020-09-16 13:37:03 +01:00
Erik Johnston	5dd051acae	Merge branch 'erikj/fix_origin_check' into develop	2020-09-16 12:43:02 +01:00
Erik Johnston	9c8ef134fe	Merge branch 'erikj/fix_origin_check' into release-v1.20.0	2020-09-16 12:42:42 +01:00
Erik Johnston	c570f24acc	Don't assume that an event has an origin field This fixes #8319.	2020-09-16 11:56:23 +01:00
reivilibre	576bc37d31	Catch-up after Federation Outage (split, 4): catch-up loop (#8272 )	2020-09-15 09:07:19 +01:00
Patrick Cloke	aec294ee0d	Use slots in attrs classes where possible (#8296 ) slots use less memory (and attribute access is faster) while slightly limiting the flexibility of the class attributes. This focuses on objects which are instantiated "often" and for short periods of time.	2020-09-14 12:50:06 -04:00
Patrick Cloke	d2a3eb04a4	Fix typos in comments.	2020-09-14 11:46:58 -04:00
Tulir Asokan	b82d68c0bd	Add the topic and avatar to the room details admin API (#8305 )	2020-09-14 10:07:04 -04:00
Patrick Cloke	6605470bfb	Improve SAML error messages (#8248 )	2020-09-14 09:05:36 -04:00
Erik Johnston	04cc249b43	Add experimental support for sharding event persister. Again. (#8294 ) This is not ready for production yet. Caveats: 1. We should write some tests... 2. The stream token that we use for events can get stalled at the minimum position of all writers. This means that new events may not be processed and e.g. sent down sync streams if a writer isn't writing or is slow.	2020-09-14 10:16:41 +01:00
Patrick Cloke	a9dbe98ef9	Synapse 1.20.0rc3 (2020-09-11) ============================== Bugfixes -------- - Fix a bug introduced in v1.20.0rc1 where the wrong exception was raised when invalid JSON data is encountered. ([\#8291](https://github.com/matrix-org/synapse/issues/8291)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEF3tZXk38tRDFVnUIM/xY9qcRMEgFAl9bbA8ACgkQM/xY9qcR MEjjJg//ZGcvPLr8y3F5JXptcjWA3AFja3DgztBA3uNFoDrwVhR9m3+F4rL/Fbat gnaccWsKIXOjZw5WOThQEUIfYMKmHEsaDl7xtlUPC4ylmSV+31ypu1KiRSxND2kT TmOupvqw+4/E4RajpYX6WT3e2oQUpIcBAKsUyZL3ZXECR/yNYrA6w2w7i4wrv3cU QDzBFrCcr5aJql7VUc88BlaZUG6xom2/kkPtjmO6imPnPGBHLN22uPU7zQ4n7Vgi Nrg45v5WHVCx57WoXqAEap1zdKgoRCna1x0NkqYh0OAXq1l6aVwlf/Pdynt91f2x yyaMYjMskjyatHlzONMV4kz0w03dUrGJXiAx2ldEDd32SKBUxLJ/CYtNEdoXZ4Mm o0OJfDbaSJwlqK7FhdZJE3kCSkUvlmVasDErXfQRDVHy5sx9Ufr4P0kkaZyXDys1 UAWFcCJwy9dgFR2679PoXk1s/gHf10wuk6FOs8ESbcJJOvCljxWrOIqKNzSUL3HQ Hj5V1zHYXB6HtgiI7tbKxSn/d2uajHI9b8LVOkyV9RKsb1DGGRgNQQ5Kz4Zud7dC vuQ2jVw7JIo41W3QIXvcL1KdQeje2nwYwuwNREZaEDZJsGLjxaJ6dNyBVgkmYYFP gxhplSOSsFjQRGEsBrc2utWxDnLVGPHEAt7iHVSqjwVUyARvxjo= =e2T1 -----END PGP SIGNATURE----- Merge tag 'v1.20.0rc3' into develop Synapse 1.20.0rc3 (2020-09-11) ============================== Bugfixes -------- - Fix a bug introduced in v1.20.0rc1 where the wrong exception was raised when invalid JSON data is encountered. ([\#8291](https://github.com/matrix-org/synapse/issues/8291))	2020-09-11 08:30:36 -04:00
Patrick Cloke	2832ef5bb7	1.20.0rc3	2020-09-11 08:14:15 -04:00
Erik Johnston	fe8ed1b46f	Make `StreamToken.room_key` be a `RoomStreamToken` instance. (#8281 )	2020-09-11 12:22:55 +01:00
Patrick Cloke	b86764662b	Fix the exception that is raised when invalid JSON is encountered. (#8291 )	2020-09-10 14:55:25 -04:00
Erik Johnston	5d3e306d9f	Clean up `Notifier.on_new_room_event` code path (#8288 ) The idea here is that we pass the `max_stream_id` to everything, and only use the stream ID of the particular event to figure out when the max stream position has caught up to the event and we can notify people about it. This is to maintain the distinction between the position of an item in the stream (i.e. event A has stream ID 513) and a token that can be used to partition the stream (i.e. give me all events after stream ID 352). This distinction becomes important when the tokens are more complicated than a single number, which they will be once we start tracking the position of multiple writers in the tokens. The valid operations here are: 1. Is a position before or after a token 2. Fetching all events between two tokens 3. Merging multiple tokens to get the "max", i.e. `C = max(A, B)` means that for all positions P where P is before A or before B, then P is before C. Future PR will change the token type to a dedicated type.	2020-09-10 13:24:43 +01:00
Andrew Morgan	a3a90ee031	Show a confirmation page during user password reset (#8004 ) This PR adds a confirmation step to resetting your user password between clicking the link in your email and your password actually being reset. This is to better align our password reset flow with the industry standard of requiring a confirmation from the user after email validation.	2020-09-10 11:45:12 +01:00
Richard van der Hoff	e44e9ee518	Merge branch 'release-v1.20.0' into develop	2020-09-10 10:15:02 +01:00
Patrick Cloke	b312769c0e	Do not error when thumbnailing invalid files (#8236 ) If a file cannot be thumbnailed for some reason (e.g. the file is empty), then catch the exception and convert it to a reasonable error message for the client.	2020-09-09 12:59:41 -04:00
Patrick Cloke	2ea1c68249	Remove some unused distributor signals (#8216 ) Removes the `user_joined_room` and stops calling it since there are no observers. Also cleans-up some other unused signals and related code.	2020-09-09 12:22:00 -04:00
Richard van der Hoff	536f4a2482	1.20.0rc2	2020-09-09 17:08:33 +01:00
Erik Johnston	c9dbee50ae	Fixup pusher pool notifications (#8287 ) `pusher_pool.on_new_notifications` expected a min and max stream ID, however that was not what we were passing in. Instead, let's just pass it the current max stream ID and have it track the last stream ID it got passed. I believe that it mostly worked as we called the function for every event. However, it would break for events that got persisted out of order, i.e, that were persisted but the max stream ID wasn't incremented as not all preceding events had finished persisting, and push for that event would be delayed until another event got pushed to the effected users.	2020-09-09 16:56:08 +01:00
Erik Johnston	dc9dcdbd59	Revert "Fixup pusher pool notifications" This reverts commit `e7fd336a53`.	2020-09-09 16:19:22 +01:00
Erik Johnston	e7fd336a53	Fixup pusher pool notifications	2020-09-09 16:17:50 +01:00
reivilibre	a5370072b5	Don't remember `enabled` of deleted push rules and properly return 404 for missing push rules in `.../actions` and `.../enabled` (#7796 ) Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2020-09-09 11:39:39 +01:00
Patrick Cloke	e45b834119	Add types to async_helpers (#8260 )	2020-09-08 16:50:51 -04:00
Erik Johnston	1553adc831	Fix mypy error on develop (#8282 )	2020-09-08 17:43:31 +01:00
DeepBlueV7.X	560f3b8609	Include method in thumbnail media name (#7124 ) This fixes an issue where different methods (crop/scale) overwrite each other. This first tries the new path. If that fails and we are looking for a remote thumbnail, it tries the old path. If that still isn't found, it continues as normal. This should probably be removed in the future, after some of the newer thumbnails were generated with the new path on most deployments. Then the overhead should be minimal if the other thumbnails need to be regenerated. Signed-off-by: Nicolas Werner <nicolas.werner@hotmail.de>	2020-09-08 17:19:50 +01:00
Erik Johnston	63c0e9e195	Add types to StreamToken and RoomStreamToken (#8279 ) The intention here is to change `StreamToken.room_key` to be a `RoomStreamToken` in a future PR, but that is a big enough change without this refactoring too.	2020-09-08 16:48:15 +01:00
Andrew Morgan	094896a69d	Add a config option for validating 'next_link' parameters against a domain whitelist (#8275 ) This is a config option ported over from DINUM's Sydent: https://github.com/matrix-org/sydent/pull/285 They've switched to validating 3PIDs via Synapse rather than Sydent, and would like to retain this functionality. This original purpose for this change is phishing prevention. This solution could also potentially be replaced by a similar one to https://github.com/matrix-org/synapse/pull/8004, but across all `*/submit_token` endpoint. This option may still be useful to enterprise even with that safeguard in place though, if they want to be absolutely sure that their employees don't follow links to other domains.	2020-09-08 16:03:09 +01:00
Brendan Abolivier	d4daff9b59	Fix /notifications and pushers misbehaving because of unread counts (#8280 )	2020-09-08 15:26:06 +01:00
Erik Johnston	0f545e6b96	Clean up types for PaginationConfig (#8250 ) This removes `SourcePaginationConfig` and `get_pagination_rows`. The reasoning behind this is that these generic classes/functions erased the types of the IDs it used (i.e. instead of passing around `StreamToken` it'd pass in e.g. `token.room_key`, which don't have uniform types).	2020-09-08 15:00:17 +01:00
Richard van der Hoff	703e2b8a96	Use the right constructor for log records (#8278 ) Update `log_function` to use the right factory to create log records, to make sure that they have `request` attributes. Fixes: #8267.	2020-09-08 14:52:51 +01:00
Erik Johnston	deedb91732	Fix `MultiWriterIdGenerator.current_position`. (#8257 ) It did not correctly handle IDs finishing being persisted out of order, resulting in the `current_position` lagging until new IDs are persisted.	2020-09-08 14:26:54 +01:00
Richard van der Hoff	cca03dbec8	Synapse 1.20.0rc1 (2020-09-08) ============================== Removal warning --------------- Some older clients used a [disallowed character](https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-register-email-requesttoken) (`:`) in the `client_secret` parameter of various endpoints. The incorrect behaviour was allowed for backwards compatibility, but is now being removed from Synapse as most users have updated their client. Further context can be found at [\#6766](https://github.com/matrix-org/synapse/issues/6766). Features -------- - Add an endpoint to query your shared rooms with another user as an implementation of [MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666). ([\#7785](https://github.com/matrix-org/synapse/issues/7785)) - Iteratively encode JSON to avoid blocking the reactor. ([\#8013](https://github.com/matrix-org/synapse/issues/8013), [\#8116](https://github.com/matrix-org/synapse/issues/8116)) - Add support for shadow-banning users (ignoring any message send requests). ([\#8034](https://github.com/matrix-org/synapse/issues/8034), [\#8092](https://github.com/matrix-org/synapse/issues/8092), [\#8095](https://github.com/matrix-org/synapse/issues/8095), [\#8142](https://github.com/matrix-org/synapse/issues/8142), [\#8152](https://github.com/matrix-org/synapse/issues/8152), [\#8157](https://github.com/matrix-org/synapse/issues/8157), [\#8158](https://github.com/matrix-org/synapse/issues/8158), [\#8176](https://github.com/matrix-org/synapse/issues/8176)) - Use the default template file when its equivalent is not found in a custom template directory. ([\#8037](https://github.com/matrix-org/synapse/issues/8037), [\#8107](https://github.com/matrix-org/synapse/issues/8107), [\#8252](https://github.com/matrix-org/synapse/issues/8252)) - Add unread messages count to sync responses, as specified in [MSC2654](https://github.com/matrix-org/matrix-doc/pull/2654). ([\#8059](https://github.com/matrix-org/synapse/issues/8059), [\#8254](https://github.com/matrix-org/synapse/issues/8254), [\#8270](https://github.com/matrix-org/synapse/issues/8270), [\#8274](https://github.com/matrix-org/synapse/issues/8274)) - Optimise `/federation/v1/user/devices/` API by only returning devices with encryption keys. ([\#8198](https://github.com/matrix-org/synapse/issues/8198)) Bugfixes -------- - Fix a memory leak by limiting the length of time that messages will be queued for a remote server that has been unreachable. ([\#7864](https://github.com/matrix-org/synapse/issues/7864)) - Fix `Re-starting finished log context PUT-nnnn` warning when event persistence failed. ([\#8081](https://github.com/matrix-org/synapse/issues/8081)) - Synapse now correctly enforces the valid characters in the `client_secret` parameter used in various endpoints. ([\#8101](https://github.com/matrix-org/synapse/issues/8101)) - Fix a bug introduced in v1.7.2 impacting message retention policies that would allow federated homeservers to dictate a retention period that's lower than the configured minimum allowed duration in the configuration file. ([\#8104](https://github.com/matrix-org/synapse/issues/8104)) - Fix a long-standing bug where invalid JSON would be accepted by Synapse. ([\#8106](https://github.com/matrix-org/synapse/issues/8106)) - Fix a bug introduced in Synapse v1.12.0 which could cause `/sync` requests to fail with a 404 if you had a very old outstanding room invite. ([\#8110](https://github.com/matrix-org/synapse/issues/8110)) - Return a proper error code when the rooms of an invalid group are requested. ([\#8129](https://github.com/matrix-org/synapse/issues/8129)) - Fix a bug which could cause a leaked postgres connection if synapse was set to daemonize. ([\#8131](https://github.com/matrix-org/synapse/issues/8131)) - Clarify the error code if a user tries to register with a numeric ID. This bug was introduced in v1.15.0. ([\#8135](https://github.com/matrix-org/synapse/issues/8135)) - Fix a bug where appservices with ratelimiting disabled would still be ratelimited when joining rooms. This bug was introduced in v1.19.0. ([\#8139](https://github.com/matrix-org/synapse/issues/8139)) - Fix logging in via OpenID Connect with a provider that uses integer user IDs. ([\#8190](https://github.com/matrix-org/synapse/issues/8190)) - Fix a longstanding bug where user directory updates could break when unexpected profile data was included in events. ([\#8223](https://github.com/matrix-org/synapse/issues/8223)) - Fix a longstanding bug where stats updates could break when unexpected profile data was included in events. ([\#8226](https://github.com/matrix-org/synapse/issues/8226)) - Fix slow start times for large servers by removing a table scan of the `users` table from startup code. ([\#8271](https://github.com/matrix-org/synapse/issues/8271)) Updates to the Docker image --------------------------- - Fix builds of the Docker image on non-x86 platforms. ([\#8144](https://github.com/matrix-org/synapse/issues/8144)) - Added curl for healthcheck support and readme updates for the change. Contributed by @maquis196. ([\#8147](https://github.com/matrix-org/synapse/issues/8147)) Improved Documentation ---------------------- - Link to matrix-synapse-rest-password-provider in the password provider documentation. ([\#8111](https://github.com/matrix-org/synapse/issues/8111)) - Updated documentation to note that Synapse does not follow `HTTP 308` redirects due to an upstream library not supporting them. Contributed by Ryan Cole. ([\#8120](https://github.com/matrix-org/synapse/issues/8120)) - Explain better what GDPR-erased means when deactivating a user. ([\#8189](https://github.com/matrix-org/synapse/issues/8189)) Internal Changes ---------------- - Add filter `name` to the `/users` admin API, which filters by user ID or displayname. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7377](https://github.com/matrix-org/synapse/issues/7377), [\#8163](https://github.com/matrix-org/synapse/issues/8163)) - Reduce run times of some unit tests by advancing the reactor a fewer number of times. ([\#7757](https://github.com/matrix-org/synapse/issues/7757)) - Don't fail `/submit_token` requests on incorrect session ID if `request_token_inhibit_3pid_errors` is turned on. ([\#7991](https://github.com/matrix-org/synapse/issues/7991)) - Convert various parts of the codebase to async/await. ([\#8071](https://github.com/matrix-org/synapse/issues/8071), [\#8072](https://github.com/matrix-org/synapse/issues/8072), [\#8074](https://github.com/matrix-org/synapse/issues/8074), [\#8075](https://github.com/matrix-org/synapse/issues/8075), [\#8076](https://github.com/matrix-org/synapse/issues/8076), [\#8087](https://github.com/matrix-org/synapse/issues/8087), [\#8100](https://github.com/matrix-org/synapse/issues/8100), [\#8119](https://github.com/matrix-org/synapse/issues/8119), [\#8121](https://github.com/matrix-org/synapse/issues/8121), [\#8133](https://github.com/matrix-org/synapse/issues/8133), [\#8156](https://github.com/matrix-org/synapse/issues/8156), [\#8162](https://github.com/matrix-org/synapse/issues/8162), [\#8166](https://github.com/matrix-org/synapse/issues/8166), [\#8168](https://github.com/matrix-org/synapse/issues/8168), [\#8173](https://github.com/matrix-org/synapse/issues/8173), [\#8191](https://github.com/matrix-org/synapse/issues/8191), [\#8192](https://github.com/matrix-org/synapse/issues/8192), [\#8193](https://github.com/matrix-org/synapse/issues/8193), [\#8194](https://github.com/matrix-org/synapse/issues/8194), [\#8195](https://github.com/matrix-org/synapse/issues/8195), [\#8197](https://github.com/matrix-org/synapse/issues/8197), [\#8199](https://github.com/matrix-org/synapse/issues/8199), [\#8200](https://github.com/matrix-org/synapse/issues/8200), [\#8201](https://github.com/matrix-org/synapse/issues/8201), [\#8202](https://github.com/matrix-org/synapse/issues/8202), [\#8207](https://github.com/matrix-org/synapse/issues/8207), [\#8213](https://github.com/matrix-org/synapse/issues/8213), [\#8214](https://github.com/matrix-org/synapse/issues/8214)) - Remove some unused database functions. ([\#8085](https://github.com/matrix-org/synapse/issues/8085)) - Add type hints to various parts of the codebase. ([\#8090](https://github.com/matrix-org/synapse/issues/8090), [\#8127](https://github.com/matrix-org/synapse/issues/8127), [\#8187](https://github.com/matrix-org/synapse/issues/8187), [\#8241](https://github.com/matrix-org/synapse/issues/8241), [\#8140](https://github.com/matrix-org/synapse/issues/8140), [\#8183](https://github.com/matrix-org/synapse/issues/8183), [\#8232](https://github.com/matrix-org/synapse/issues/8232), [\#8235](https://github.com/matrix-org/synapse/issues/8235), [\#8237](https://github.com/matrix-org/synapse/issues/8237), [\#8244](https://github.com/matrix-org/synapse/issues/8244)) - Return the previous stream token if a non-member event is a duplicate. ([\#8093](https://github.com/matrix-org/synapse/issues/8093), [\#8112](https://github.com/matrix-org/synapse/issues/8112)) - Separate `get_current_token` into two since there are two different use cases for it. ([\#8113](https://github.com/matrix-org/synapse/issues/8113)) - Remove `ChainedIdGenerator`. ([\#8123](https://github.com/matrix-org/synapse/issues/8123)) - Reduce the amount of whitespace in JSON stored and sent in responses. ([\#8124](https://github.com/matrix-org/synapse/issues/8124)) - Update the test federation client to handle streaming responses. ([\#8130](https://github.com/matrix-org/synapse/issues/8130)) - Micro-optimisations to `get_auth_chain_ids`. ([\#8132](https://github.com/matrix-org/synapse/issues/8132)) - Refactor `StreamIdGenerator` and `MultiWriterIdGenerator` to have the same interface. ([\#8161](https://github.com/matrix-org/synapse/issues/8161)) - Add functions to `MultiWriterIdGen` used by events stream. ([\#8164](https://github.com/matrix-org/synapse/issues/8164), [\#8179](https://github.com/matrix-org/synapse/issues/8179)) - Fix tests that were broken due to the merge of 1.19.1. ([\#8167](https://github.com/matrix-org/synapse/issues/8167)) - Make `SlavedIdTracker.advance` have the same interface as `MultiWriterIDGenerator`. ([\#8171](https://github.com/matrix-org/synapse/issues/8171)) - Remove unused `is_guest` parameter from, and add safeguard to, `MessageHandler.get_room_data`. ([\#8174](https://github.com/matrix-org/synapse/issues/8174), [\#8181](https://github.com/matrix-org/synapse/issues/8181)) - Standardize the mypy configuration. ([\#8175](https://github.com/matrix-org/synapse/issues/8175)) - Refactor some of `LoginRestServlet`'s helper methods, and move them to `AuthHandler` for easier reuse. ([\#8182](https://github.com/matrix-org/synapse/issues/8182)) - Fix `wait_for_stream_position` to allow multiple waiters on same stream ID. ([\#8196](https://github.com/matrix-org/synapse/issues/8196)) - Make `MultiWriterIDGenerator` work for streams that use negative values. ([\#8203](https://github.com/matrix-org/synapse/issues/8203)) - Refactor queries for device keys and cross-signatures. ([\#8204](https://github.com/matrix-org/synapse/issues/8204), [\#8205](https://github.com/matrix-org/synapse/issues/8205), [\#8222](https://github.com/matrix-org/synapse/issues/8222), [\#8224](https://github.com/matrix-org/synapse/issues/8224), [\#8225](https://github.com/matrix-org/synapse/issues/8225), [\#8231](https://github.com/matrix-org/synapse/issues/8231), [\#8233](https://github.com/matrix-org/synapse/issues/8233), [\#8234](https://github.com/matrix-org/synapse/issues/8234)) - Fix type hints for functions decorated with `@cached`. ([\#8240](https://github.com/matrix-org/synapse/issues/8240)) - Remove obsolete `order` field from federation send queues. ([\#8245](https://github.com/matrix-org/synapse/issues/8245)) - Stop sub-classing from object. ([\#8249](https://github.com/matrix-org/synapse/issues/8249)) - Add more logging to debug slow startup. ([\#8264](https://github.com/matrix-org/synapse/issues/8264)) - Do not attempt to upgrade database schema on worker processes. ([\#8266](https://github.com/matrix-org/synapse/issues/8266), [\#8276](https://github.com/matrix-org/synapse/issues/8276)) -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEv27Axt/F4vrTL/8QOSor00I9eP8FAl9XgG0ACgkQOSor00I9 eP9k9gf8DqxUoYYGGvKrUC0NW5XLLE6qiLI+a+3QqsnWvvAjCzJOPH5xsFWl0YkR phUmz0KyuIvYokr6RYEG37l7U0hWQKck1/LrgBDOtEWTO+n/bacxNawhJyFOXATc AZgnCVyhklALUre43QzwlFL1cGQnIBuAHuHa+etj5AO+9eC/QPuJBMryzUVH8dGY 37B2lLTv4ULpSsQ+neQULSyu1EOEyurxNY/RydYaC8bgrOCQgkWPbssQX6MSdHWz ua+GZ36KAQT6jUmjuTqJXbRKtewjN2anmTb5LrHz1W5GATOY7hH3xsnwHd1oikwW 56vhm1tJZExkWvqfB9XteJcIEZ0epQ== =JecA -----END PGP SIGNATURE----- Merge tag 'v1.20.0rc1' into develop Synapse 1.20.0rc1 (2020-09-08) ============================== Removal warning --------------- Some older clients used a [disallowed character](https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-register-email-requesttoken) (`:`) in the `client_secret` parameter of various endpoints. The incorrect behaviour was allowed for backwards compatibility, but is now being removed from Synapse as most users have updated their client. Further context can be found at [\#6766](https://github.com/matrix-org/synapse/issues/6766). Features -------- - Add an endpoint to query your shared rooms with another user as an implementation of [MSC2666](https://github.com/matrix-org/matrix-doc/pull/2666). ([\#7785](https://github.com/matrix-org/synapse/issues/7785)) - Iteratively encode JSON to avoid blocking the reactor. ([\#8013](https://github.com/matrix-org/synapse/issues/8013), [\#8116](https://github.com/matrix-org/synapse/issues/8116)) - Add support for shadow-banning users (ignoring any message send requests). ([\#8034](https://github.com/matrix-org/synapse/issues/8034), [\#8092](https://github.com/matrix-org/synapse/issues/8092), [\#8095](https://github.com/matrix-org/synapse/issues/8095), [\#8142](https://github.com/matrix-org/synapse/issues/8142), [\#8152](https://github.com/matrix-org/synapse/issues/8152), [\#8157](https://github.com/matrix-org/synapse/issues/8157), [\#8158](https://github.com/matrix-org/synapse/issues/8158), [\#8176](https://github.com/matrix-org/synapse/issues/8176)) - Use the default template file when its equivalent is not found in a custom template directory. ([\#8037](https://github.com/matrix-org/synapse/issues/8037), [\#8107](https://github.com/matrix-org/synapse/issues/8107), [\#8252](https://github.com/matrix-org/synapse/issues/8252)) - Add unread messages count to sync responses, as specified in [MSC2654](https://github.com/matrix-org/matrix-doc/pull/2654). ([\#8059](https://github.com/matrix-org/synapse/issues/8059), [\#8254](https://github.com/matrix-org/synapse/issues/8254), [\#8270](https://github.com/matrix-org/synapse/issues/8270), [\#8274](https://github.com/matrix-org/synapse/issues/8274)) - Optimise `/federation/v1/user/devices/` API by only returning devices with encryption keys. ([\#8198](https://github.com/matrix-org/synapse/issues/8198)) Bugfixes -------- - Fix a memory leak by limiting the length of time that messages will be queued for a remote server that has been unreachable. ([\#7864](https://github.com/matrix-org/synapse/issues/7864)) - Fix `Re-starting finished log context PUT-nnnn` warning when event persistence failed. ([\#8081](https://github.com/matrix-org/synapse/issues/8081)) - Synapse now correctly enforces the valid characters in the `client_secret` parameter used in various endpoints. ([\#8101](https://github.com/matrix-org/synapse/issues/8101)) - Fix a bug introduced in v1.7.2 impacting message retention policies that would allow federated homeservers to dictate a retention period that's lower than the configured minimum allowed duration in the configuration file. ([\#8104](https://github.com/matrix-org/synapse/issues/8104)) - Fix a long-standing bug where invalid JSON would be accepted by Synapse. ([\#8106](https://github.com/matrix-org/synapse/issues/8106)) - Fix a bug introduced in Synapse v1.12.0 which could cause `/sync` requests to fail with a 404 if you had a very old outstanding room invite. ([\#8110](https://github.com/matrix-org/synapse/issues/8110)) - Return a proper error code when the rooms of an invalid group are requested. ([\#8129](https://github.com/matrix-org/synapse/issues/8129)) - Fix a bug which could cause a leaked postgres connection if synapse was set to daemonize. ([\#8131](https://github.com/matrix-org/synapse/issues/8131)) - Clarify the error code if a user tries to register with a numeric ID. This bug was introduced in v1.15.0. ([\#8135](https://github.com/matrix-org/synapse/issues/8135)) - Fix a bug where appservices with ratelimiting disabled would still be ratelimited when joining rooms. This bug was introduced in v1.19.0. ([\#8139](https://github.com/matrix-org/synapse/issues/8139)) - Fix logging in via OpenID Connect with a provider that uses integer user IDs. ([\#8190](https://github.com/matrix-org/synapse/issues/8190)) - Fix a longstanding bug where user directory updates could break when unexpected profile data was included in events. ([\#8223](https://github.com/matrix-org/synapse/issues/8223)) - Fix a longstanding bug where stats updates could break when unexpected profile data was included in events. ([\#8226](https://github.com/matrix-org/synapse/issues/8226)) - Fix slow start times for large servers by removing a table scan of the `users` table from startup code. ([\#8271](https://github.com/matrix-org/synapse/issues/8271)) Updates to the Docker image --------------------------- - Fix builds of the Docker image on non-x86 platforms. ([\#8144](https://github.com/matrix-org/synapse/issues/8144)) - Added curl for healthcheck support and readme updates for the change. Contributed by @maquis196. ([\#8147](https://github.com/matrix-org/synapse/issues/8147)) Improved Documentation ---------------------- - Link to matrix-synapse-rest-password-provider in the password provider documentation. ([\#8111](https://github.com/matrix-org/synapse/issues/8111)) - Updated documentation to note that Synapse does not follow `HTTP 308` redirects due to an upstream library not supporting them. Contributed by Ryan Cole. ([\#8120](https://github.com/matrix-org/synapse/issues/8120)) - Explain better what GDPR-erased means when deactivating a user. ([\#8189](https://github.com/matrix-org/synapse/issues/8189)) Internal Changes ---------------- - Add filter `name` to the `/users` admin API, which filters by user ID or displayname. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7377](https://github.com/matrix-org/synapse/issues/7377), [\#8163](https://github.com/matrix-org/synapse/issues/8163)) - Reduce run times of some unit tests by advancing the reactor a fewer number of times. ([\#7757](https://github.com/matrix-org/synapse/issues/7757)) - Don't fail `/submit_token` requests on incorrect session ID if `request_token_inhibit_3pid_errors` is turned on. ([\#7991](https://github.com/matrix-org/synapse/issues/7991)) - Convert various parts of the codebase to async/await. ([\#8071](https://github.com/matrix-org/synapse/issues/8071), [\#8072](https://github.com/matrix-org/synapse/issues/8072), [\#8074](https://github.com/matrix-org/synapse/issues/8074), [\#8075](https://github.com/matrix-org/synapse/issues/8075), [\#8076](https://github.com/matrix-org/synapse/issues/8076), [\#8087](https://github.com/matrix-org/synapse/issues/8087), [\#8100](https://github.com/matrix-org/synapse/issues/8100), [\#8119](https://github.com/matrix-org/synapse/issues/8119), [\#8121](https://github.com/matrix-org/synapse/issues/8121), [\#8133](https://github.com/matrix-org/synapse/issues/8133), [\#8156](https://github.com/matrix-org/synapse/issues/8156), [\#8162](https://github.com/matrix-org/synapse/issues/8162), [\#8166](https://github.com/matrix-org/synapse/issues/8166), [\#8168](https://github.com/matrix-org/synapse/issues/8168), [\#8173](https://github.com/matrix-org/synapse/issues/8173), [\#8191](https://github.com/matrix-org/synapse/issues/8191), [\#8192](https://github.com/matrix-org/synapse/issues/8192), [\#8193](https://github.com/matrix-org/synapse/issues/8193), [\#8194](https://github.com/matrix-org/synapse/issues/8194), [\#8195](https://github.com/matrix-org/synapse/issues/8195), [\#8197](https://github.com/matrix-org/synapse/issues/8197), [\#8199](https://github.com/matrix-org/synapse/issues/8199), [\#8200](https://github.com/matrix-org/synapse/issues/8200), [\#8201](https://github.com/matrix-org/synapse/issues/8201), [\#8202](https://github.com/matrix-org/synapse/issues/8202), [\#8207](https://github.com/matrix-org/synapse/issues/8207), [\#8213](https://github.com/matrix-org/synapse/issues/8213), [\#8214](https://github.com/matrix-org/synapse/issues/8214)) - Remove some unused database functions. ([\#8085](https://github.com/matrix-org/synapse/issues/8085)) - Add type hints to various parts of the codebase. ([\#8090](https://github.com/matrix-org/synapse/issues/8090), [\#8127](https://github.com/matrix-org/synapse/issues/8127), [\#8187](https://github.com/matrix-org/synapse/issues/8187), [\#8241](https://github.com/matrix-org/synapse/issues/8241), [\#8140](https://github.com/matrix-org/synapse/issues/8140), [\#8183](https://github.com/matrix-org/synapse/issues/8183), [\#8232](https://github.com/matrix-org/synapse/issues/8232), [\#8235](https://github.com/matrix-org/synapse/issues/8235), [\#8237](https://github.com/matrix-org/synapse/issues/8237), [\#8244](https://github.com/matrix-org/synapse/issues/8244)) - Return the previous stream token if a non-member event is a duplicate. ([\#8093](https://github.com/matrix-org/synapse/issues/8093), [\#8112](https://github.com/matrix-org/synapse/issues/8112)) - Separate `get_current_token` into two since there are two different use cases for it. ([\#8113](https://github.com/matrix-org/synapse/issues/8113)) - Remove `ChainedIdGenerator`. ([\#8123](https://github.com/matrix-org/synapse/issues/8123)) - Reduce the amount of whitespace in JSON stored and sent in responses. ([\#8124](https://github.com/matrix-org/synapse/issues/8124)) - Update the test federation client to handle streaming responses. ([\#8130](https://github.com/matrix-org/synapse/issues/8130)) - Micro-optimisations to `get_auth_chain_ids`. ([\#8132](https://github.com/matrix-org/synapse/issues/8132)) - Refactor `StreamIdGenerator` and `MultiWriterIdGenerator` to have the same interface. ([\#8161](https://github.com/matrix-org/synapse/issues/8161)) - Add functions to `MultiWriterIdGen` used by events stream. ([\#8164](https://github.com/matrix-org/synapse/issues/8164), [\#8179](https://github.com/matrix-org/synapse/issues/8179)) - Fix tests that were broken due to the merge of 1.19.1. ([\#8167](https://github.com/matrix-org/synapse/issues/8167)) - Make `SlavedIdTracker.advance` have the same interface as `MultiWriterIDGenerator`. ([\#8171](https://github.com/matrix-org/synapse/issues/8171)) - Remove unused `is_guest` parameter from, and add safeguard to, `MessageHandler.get_room_data`. ([\#8174](https://github.com/matrix-org/synapse/issues/8174), [\#8181](https://github.com/matrix-org/synapse/issues/8181)) - Standardize the mypy configuration. ([\#8175](https://github.com/matrix-org/synapse/issues/8175)) - Refactor some of `LoginRestServlet`'s helper methods, and move them to `AuthHandler` for easier reuse. ([\#8182](https://github.com/matrix-org/synapse/issues/8182)) - Fix `wait_for_stream_position` to allow multiple waiters on same stream ID. ([\#8196](https://github.com/matrix-org/synapse/issues/8196)) - Make `MultiWriterIDGenerator` work for streams that use negative values. ([\#8203](https://github.com/matrix-org/synapse/issues/8203)) - Refactor queries for device keys and cross-signatures. ([\#8204](https://github.com/matrix-org/synapse/issues/8204), [\#8205](https://github.com/matrix-org/synapse/issues/8205), [\#8222](https://github.com/matrix-org/synapse/issues/8222), [\#8224](https://github.com/matrix-org/synapse/issues/8224), [\#8225](https://github.com/matrix-org/synapse/issues/8225), [\#8231](https://github.com/matrix-org/synapse/issues/8231), [\#8233](https://github.com/matrix-org/synapse/issues/8233), [\#8234](https://github.com/matrix-org/synapse/issues/8234)) - Fix type hints for functions decorated with `@cached`. ([\#8240](https://github.com/matrix-org/synapse/issues/8240)) - Remove obsolete `order` field from federation send queues. ([\#8245](https://github.com/matrix-org/synapse/issues/8245)) - Stop sub-classing from object. ([\#8249](https://github.com/matrix-org/synapse/issues/8249)) - Add more logging to debug slow startup. ([\#8264](https://github.com/matrix-org/synapse/issues/8264)) - Do not attempt to upgrade database schema on worker processes. ([\#8266](https://github.com/matrix-org/synapse/issues/8266), [\#8276](https://github.com/matrix-org/synapse/issues/8276))	2020-09-08 14:04:20 +01:00
Richard van der Hoff	525efab612	1.20.0rc1	2020-09-08 12:58:37 +01:00
Patrick Cloke	72bec36d50	Directly import json from the standard library. (#8259 ) By importing from canonicaljson the simplejson module was still being used in some situations. After this change the std lib json is consistenty used throughout Synapse.	2020-09-08 07:33:48 -04:00
Andrew Morgan	68cdb3708e	Rename 'populate_stats_process_rooms_2' background job back to 'populate_stats_process_rooms' again (#8243 ) Fixes https://github.com/matrix-org/synapse/issues/8238 Alongside the delta file, some changes were also necessary to the codebase to remove references to the now defunct `populate_stats_process_rooms_2` background job. Thankfully the latter doesn't seem to have made it into any documentation yet :)	2020-09-08 11:05:59 +01:00
Richard van der Hoff	8d6f97f932	Merge remote-tracking branch 'origin/release-v1.20.0' into develop	2020-09-08 09:58:07 +01:00
Brendan Abolivier	d8762cc116	Only add rows to the push actions table if the event notifies or should be marked unread (#8274 )	2020-09-07 16:56:27 +01:00
Richard van der Hoff	77794ebc77	Fix stack overflow when logging system encounters an error (#8268 )	2020-09-07 16:54:30 +01:00
Richard van der Hoff	ef2804d27c	Avoid table-scanning users at startup (#8271 ) This takes about 10 seconds in the best case; often more.	2020-09-07 16:48:52 +01:00
Brendan Abolivier	a55e2707d7	Fix unread count failing on NULL values (#8270 ) Fix unread counts making sync fail if the value of the `unread_count` column in `event_push_summary` is `None`.	2020-09-07 15:15:06 +01:00
Richard van der Hoff	0dae7d80bf	Add more logging to debug slow startup (#8264 ) I'm hoping this will provide some pointers for debugging https://github.com/matrix-org/synapse/issues/7968.	2020-09-07 13:36:02 +01:00
Richard van der Hoff	96312536f2	Refuse to upgrade database on worker processes (#8266 )	2020-09-07 13:04:10 +01:00
Alexandre Morignot	7586fdf1e8	Bump canonicaljson to version 1.4.0 (#8262 ) The version 1.3.0 has a bug with unicode charecters: ``` >>> from canonicaljson import encode_pretty_printed_json >>> encode_pretty_printed_json({'a': 'à'}) Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/home/erdnaxeli/.pyenv/versions/3.6.7/lib/python3.6/site-packages/canonicaljson.py", line 96, in encode_pretty_printed_json return _pretty_encoder.encode(json_object).encode("ascii") UnicodeEncodeError: 'ascii' codec can't encode character '\xe0' in position 12: ordinal not in range(128) ``` Signed-off-by: Alexandre Morignot <erdnaxeli@cervoi.se> Co-authored-by: Alexandre Morignot <erdnaxeli@cervoi.se>	2020-09-07 12:21:38 +01:00
Richard van der Hoff	5b452df23b	Run database updates in a transaction (#8265 ) Fixes: #6467	2020-09-07 11:41:50 +01:00
Richard van der Hoff	77b4711bc2	Merge branch 'release-v1.20.0' into develop	2020-09-06 23:32:28 +01:00
reivilibre	7513006b09	In light of #8255 , use BIGINTs for destination_rooms (#8256 )	2020-09-04 15:07:29 +01:00
reivilibre	17fa4c7ca7	Catch up after Federation Outage (split, 2): Track last successful stream ordering after transmission (#8247 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2020-09-04 15:06:51 +01:00
Richard van der Hoff	f25af1f9c7	Add cross-signing sigs to the `keys` object (#8234 ) All the callers want this info in the same place, so let's reduce the duplication by doing it here.	2020-09-04 15:06:05 +01:00
Brendan Abolivier	041ee971c9	Unread counts fixes (#8254 ) * Fixup `ALTER TABLE` database queries Make the new columns nullable, because doing otherwise can wedge a server with a big database, as setting a default value rewrites the table. * Switch back to using the notifications count in the push badge Clients are likely to be confused if we send a push but the badge count is the unread messages one, and not the notifications one. * Changelog	2020-09-04 14:14:22 +01:00
Patrick Cloke	db7de4d182	Fix a regression from calling read_templates. (#8252 ) Regressed in #8037.	2020-09-04 09:10:33 -04:00
reivilibre	58f61f10f7	Catch-up after Federation Outage (split, 1) (#8230 ) Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>	2020-09-04 12:22:23 +01:00
reivilibre	e351298444	Fix type signature in simple_select_one_onecol and friends (#8241 ) Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2020-09-04 12:02:29 +01:00
Patrick Cloke	c619253db8	Stop sub-classing object (#8249 )	2020-09-04 06:54:56 -04:00
Brendan Abolivier	9f8abdcc38	Revert "Add experimental support for sharding event persister. (#8170 )" (#8242 ) * Revert "Add experimental support for sharding event persister. (#8170)" This reverts commit `82c1ee1c22`. * Changelog	2020-09-04 10:19:42 +01:00
Erik Johnston	be16ee59a8	Add type hints to more handlers (#8244 )	2020-09-03 22:02:29 +01:00
reivilibre	4535e849d7	Remove obsolete order field in `send_new_transaction` (#8245 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2020-09-03 19:23:07 +01:00
Richard van der Hoff	f97f9485ee	Split fetching device keys and signatures into two transactions (#8233 ) I think this is simpler (and moves stuff out of the db threads)	2020-09-03 18:27:26 +01:00
Erik Johnston	208e1d3eb3	Fix typing for `@cached` wrapped functions (#8240 ) This requires adding a mypy plugin to fiddle with the type signatures a bit.	2020-09-03 15:38:32 +01:00
Patrick Cloke	2aa127c207	Revert pinning of setuptools (#8239 )	2020-09-03 09:45:36 -04:00
Erik Johnston	5bfc79486d	Fix typing for SyncHandler (#8237 )	2020-09-03 12:54:10 +01:00
Richard van der Hoff	6f6f371a87	wrap `_get_e2e_device_keys_and_signatures_txn` in a non-txn method (#8231 ) We have three things which all call `_get_e2e_device_keys_and_signatures_txn` with their own `runInteraction`. Factor out the common code.	2020-09-03 11:50:49 +01:00
Patrick Cloke	c8758cb72f	Add an overload for simple_select_one_onecol_txn. (#8235 )	2020-09-02 15:03:12 -04:00
Patrick Cloke	912e024913	Convert runInteraction to async/await (#8156 )	2020-09-02 13:11:02 -04:00
Erik Johnston	112266eafd	Add StreamStore to mypy (#8232 )	2020-09-02 17:52:38 +01:00
Brendan Abolivier	5a1dd297c3	Re-implement unread counts (again) (#8059 )	2020-09-02 17:19:37 +01:00
Richard van der Hoff	0d4f614fda	Refactor `_get_e2e_device_keys_for_federation_query_txn` (#8225 ) We can use the existing `_get_e2e_device_keys_and_signatures_txn` instead of creating our own txn function	2020-09-02 15:53:26 +01:00
Erik Johnston	82c1ee1c22	Add experimental support for sharding event persister. (#8170 ) This is not ready for production yet. Caveats: 1. We should write some tests... 2. The stream token that we use for events can get stalled at the minimum position of all writers. This means that new events may not be processed and e.g. sent down sync streams if a writer isn't writing or is slow.	2020-09-02 15:48:37 +01:00
Will Hunt	b257c788c0	Add /user/{user_id}/shared_rooms/ api (#7785 ) * Add shared_rooms api * Add changelog * Add . * Wrap response in {"rooms": } * linting * Add unstable_features key * Remove options from isort that aren't part of 5.x `-y` and `-rc` are now default behaviour and no longer exist. `dont-skip` is no longer required https://timothycrosley.github.io/isort/CHANGELOG/#500-penny-july-4-2020 * Update imports to make isort happy * Add changelog * Update tox.ini file with correct invocation * fix linting again for isort * Vendor prefix unstable API * Fix to match spec * import Codes * import Codes * Use FORBIDDEN * Update changelog.d/7785.feature Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Implement get_shared_rooms_for_users * a comma * trailing whitespace * Handle the easy feedback * Switch to using runInteraction * Add tests * Feedback * Seperate unstable endpoint from v2 * Add upgrade node * a line * Fix style by adding a blank line at EOF. * Update synapse/storage/databases/main/user_directory.py Co-authored-by: Tulir Asokan <tulir@maunium.net> * Update synapse/storage/databases/main/user_directory.py Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Update UPGRADE.rst Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Fix UPGRADE/CHANGELOG unstable paths unstable unstable unstable Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Tulir Asokan <tulir@maunium.net> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Tulir Asokan <tulir@maunium.net>	2020-09-02 13:18:40 +01:00
Patrick Cloke	9356656e67	Do not try to store invalid data in the stats table (#8226 )	2020-09-02 07:59:39 -04:00
Patrick Cloke	d250521cf5	Convert the main methods run by the reactor to async. (#8213 )	2020-09-02 07:44:50 -04:00
Richard van der Hoff	abeab964d5	Make _get_e2e_device_keys_and_signatures_txn return an attrs (#8224 ) this makes it a bit clearer what's going on.	2020-09-02 11:47:26 +01:00
Patrick Cloke	b939251c37	Fix errors when updating the user directory with invalid data (#8223 )	2020-09-01 13:02:41 -04:00
Patrick Cloke	37db6252b7	Convert additional databases to async/await part 3 (#8201 )	2020-09-01 11:04:17 -04:00
Patrick Cloke	7d103a594e	Convert appservice code to async/await. (#8207 )	2020-09-01 11:03:49 -04:00
Richard van der Hoff	5615eb5cb4	Rename `_get_e2e_device_keys_txn` (#8222 ) ... to `_get_e2e_device_keys_and_signatures_txn`, to better reflect what it does.	2020-09-01 16:02:17 +01:00
Patrick Cloke	54f8d73c00	Convert additional databases to async/await (#8199 )	2020-09-01 09:21:48 -04:00
Patrick Cloke	5bf8e5f55b	Convert the well known resolver to async (#8214 )	2020-09-01 09:15:22 -04:00
Patrick Cloke	da77520cd1	Convert additional databases to async/await part 2 (#8200 )	2020-09-01 08:39:04 -04:00
Erik Johnston	bbb3c8641c	Make MultiWriterIDGenerator work for streams that use negative stream IDs (#8203 ) This is so that we can use it for the backfill events stream.	2020-09-01 13:36:25 +01:00
Patrick Cloke	318245eaa6	Do not install setuptools 50.0. (#8212 ) This is due to compatibility issues with old Python versions.	2020-09-01 08:16:58 -04:00
Richard van der Hoff	aa07c37cf0	Move and rename `get_devices_with_keys_by_user` (#8204 ) * Move `get_devices_with_keys_by_user` to `EndToEndKeyWorkerStore` this seems a better fit for it. This commit simply moves the existing code: no other changes at all. * Rename `get_devices_with_keys_by_user` to better reflect what it does. * get_device_stream_token abstract method To avoid referencing fields which are declared in the derived classes, make `get_device_stream_token` abstract, and define that in the classes which define `_device_list_id_gen`.	2020-09-01 12:41:21 +01:00
Richard van der Hoff	45e8f7726f	Rename `get_e2e_device_keys` to better reflect its purpose (#8205 ) ... and to show that it does something slightly different to `_get_e2e_device_keys_txn`. `include_all_devices` and `include_deleted_devices` were never used (and `include_deleted_devices` was broken, since that would cause `None`s in the result which were not handled in the loop below. Add some typing too.	2020-08-29 00:14:17 +01:00
Richard van der Hoff	8027166dd5	Add a comment about _LimitedHostnameResolver	2020-08-29 00:06:00 +01:00
Patrick Cloke	d2ac767de2	Convert ReadWriteLock to async/await. (#8202 )	2020-08-28 16:47:11 -04:00
Andrew Morgan	b4826d6eb1	Fix incorrect return signature	2020-08-28 17:39:48 +01:00
Erik Johnston	3b4556cf87	Fix `wait_for_stream_position` for multiple waiters. (#8196 ) This fixes a bug where having multiple callers waiting on the same stream and position will cause it to try and compare two deferreds, which fails (due to the sorted list having an entry of `Tuple[int, Deferred]`).	2020-08-28 17:12:45 +01:00
Patrick Cloke	d58fda99ff	Convert `event_push_actions`, `registration`, and `roommember` datastores to async (#8197 )	2020-08-28 11:34:50 -04:00
Richard van der Hoff	22b926c284	Only return devices with keys from `/federation/v1/user/devices/` (#8198 ) There's not much point in returning all the others, and some people have a silly number of devices.	2020-08-28 15:59:28 +01:00
Patrick Cloke	aec7085179	Convert state and stream stores and related code to async (#8194 )	2020-08-28 09:37:55 -04:00
Patrick Cloke	b055dc9322	Ensure that the OpenID Connect remote ID is a string. (#8190 )	2020-08-28 08:56:36 -04:00
Patrick Cloke	5c03134d0f	Convert additional database code to async/await. (#8195 )	2020-08-28 07:54:27 -04:00
Patrick Cloke	d5e73cb6aa	Define StateMap as immutable and add a MutableStateMap type. (#8183 )	2020-08-28 07:28:53 -04:00
Andrew Morgan	2c2e649be2	Move and refactor LoginRestServlet helper methods (#8182 ) This is split out from https://github.com/matrix-org/synapse/pull/7438, which had gotten rather large. `LoginRestServlet` has a couple helper methods, `login_submission_legacy_convert` and `login_id_thirdparty_from_phone`. They're primarily used for converting legacy user login submissions to "identifier" dicts ([see spec](https://matrix.org/docs/spec/client_server/r0.6.1#post-matrix-client-r0-login)). Identifying information such as usernames or 3PID information used to be top-level in the login body. They're now supposed to be put inside an [identifier](https://matrix.org/docs/spec/client_server/r0.6.1#identifier-types) parameter instead. #7438's purpose is to allow using the new identifier parameter during User-Interactive Authentication, which is currently handled in AuthHandler. That's why I've moved these helper methods there. I also moved the refactoring of these method from #7438 as they're relevant.	2020-08-28 09:58:17 +01:00
Patrick Cloke	b49a5b9307	Convert stats and related calls to async/await (#8192 )	2020-08-27 17:24:37 -04:00
Patrick Cloke	b71d4a094c	Convert simple_delete to async/await. (#8191 )	2020-08-27 14:16:41 -04:00
Patrick Cloke	9b7ac03af3	Convert calls of async database methods to async (#8166 )	2020-08-27 13:38:41 -04:00
Patrick Cloke	c9fa696ea2	simple_search_list_txn should return None, not 0. (#8187 )	2020-08-27 12:07:13 -04:00
Erik Johnston	5649b7f3d0	Fix missing _add_persisted_position (#8179 ) This was forgotten in #8164.	2020-08-27 13:20:34 +01:00
Patrick Cloke	30426c7063	Convert additional database methods to async (select list, search, insert_many, delete_*) (#8168 )	2020-08-27 07:41:01 -04:00
Patrick Cloke	4a739c73b4	Convert simple_update* and simple_select* to async (#8173 )	2020-08-27 07:08:38 -04:00
Brendan Abolivier	9cfc120233	Merge branch 'master' into develop	2020-08-27 11:01:21 +01:00
Brendan Abolivier	eadfda3ebc	1.19.1	2020-08-27 10:50:39 +01:00
Patrick Cloke	6fe12c9512	Do not propagate typing notifications from shadow-banned users. (#8176 )	2020-08-26 12:05:36 -04:00
Andrew Morgan	e0d6244beb	Remove unused parameter from, and add safeguard in, get_room_data (#8174 ) Small cleanup PR. * Removed the unused `is_guest` argument * Added a safeguard to a (currently) impossible code path, fixing static checking at the same time.	2020-08-26 15:07:35 +01:00
Patrick Cloke	2e6c90ff84	Do not propagate profile changes of shadow-banned users into rooms. (#8157 )	2020-08-26 08:49:01 -04:00
Erik Johnston	e3c91a3c55	Make SlavedIdTracker.advance have same interface as MultiWriterIDGenerator (#8171 )	2020-08-26 13:15:20 +01:00
Patrick Cloke	4c6c56dc58	Convert simple_select_one and simple_select_one_onecol to async (#8162 )	2020-08-26 07:19:32 -04:00
Erik Johnston	eba98fb024	Add functions to `MultiWriterIdGen` used by events stream (#8164 )	2020-08-25 17:32:30 +01:00
Patrick Cloke	5099bd68da	Do not allow send_nonmember_event to be called with shadow-banned users. (#8158 )	2020-08-25 10:52:15 -04:00
Brendan Abolivier	6e1c64a668	Synapse 1.19.1rc1 (2020-08-25) ============================== Bugfixes -------- - Fix a bug introduced in v1.19.0 where appservices with ratelimiting disabled would still be ratelimited when joining rooms. ([\#8139](https://github.com/matrix-org/synapse/issues/8139)) - Fix a bug introduced in v1.19.0 that would cause e.g. profile updates to fail due to incorrect application of rate limits on join requests. ([\#8153](https://github.com/matrix-org/synapse/issues/8153)) -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEdVkXOgzrGzds0jtrHgFcFF8ZFs0FAl9FIKkACgkQHgFcFF8Z Fs3zIw/9H40ieb73Iay6ecQeOSfHiMVMzvJqYbKgho/a6h5JDHir+NGpwuLFdeGM eHR07QkQgUU9+dLNTMOQpCKTIsU70wvzH1vTDINS3ChjnRBdrHKqhAG6ZyEt1dJx kxYX54zsQUwiwshMKbJ+DPclHaBFnL+SY5OFfqCNjvaNob59DbHAL3tlSktPc2go tGmj81q0dWY6maMCGI3IIYcrW7oLi+4TwosZual5Hz/xgRBiGaKHXRIJnInvkXpl R+rSOmpYraapfDPHzPyQgLN4Dt7aAccGho843tt7dAVfd2GRSaUkLGXVXCdoruQG CRjY1P3BRBzRBx6o80Uw7Ah0hsoVgpJTSzY008KigJce+IiRWG5sgPjoubhfK0MA BqzmCa3/lrR+/WUOf4+w6HSfRncKawgAp7Y7wVj4nQF5fc8mwpFLz4pA/C2YOyjp nYXCHf60/KSBDhnr0ZRAhAby4MJoYSf03djFG1oef5SVzOzHD7zho9oBnEz15Tab XXkg1iJ7AhNFiQjsY4H1sl2onoF4T7B53NOnUEwD0oll+nXIYGe6hlNuq6x4j6l9 39ZlMoe9zK28LoKKWa1RDug8z+PmarKRJ2zATlHIb2RGeVX+oFfaKVsIbJtupJVC 8HSFt7gcgLCdUazk6taKpOHeVyGxK6WUkLnCMHzD2rzPhzpSyws= =0rHM -----END PGP SIGNATURE----- gpgsig -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEdVkXOgzrGzds0jtrHgFcFF8ZFs0FAl9FJK4ACgkQHgFcFF8Z Fs0O2xAAgxqCfAHylVuwunRppwV49Bvq6H0mMM29hYBogGB5cmh1vRnUm5GsPQt0 9vTKlwMz6XKjLs3TLqYsnZfXqK+lyaN0xFXd7xWCNzFtEXoIvDnq+u3h5WGaKOC9 PcXb2LSZoHC5yECBpoh58ZQEPKtYILEjo+OSDboIqHz4N5HSjMSPGPvMkUn6xMNG roWTAWKPd9juyE2dPzZxIoBWwJGn3D8EMkeTQDlExTTvmnDPyPvJ5MVUY/xaHLgy XV8lapFu/SzWAKotc5+9qkVN64obaxwovYTU9JnlqEc5+WlD+Jl+g0258Q1bV1H9 341aQQJX08iYw3xw13xVgT0zLPRbp82O3/SHC3S1nz27HUWKXqUtsm6woDbgHIz5 UPvKFQsp2dEN4tFXxkEHiossIVNGuXdRYwEjFQrxOwayCuS4cQwDADhqnzDU4hio LSVhtxs9rgLps4iKpcaRAqK8kifTrsomlQfh/7axPJQ43pmBR2PiItetlBW/9Le6 KTH90ghLQzJwKFkIcFcvPhFMVqSyXI32+g5++YAPmNVy9M/7LdJxuEc9ifTWgwds LtV3/F8xlqd0qwl5IbwC6Wf19N06jdlRv/q1zL/Hb6qu3FLQeGd+/1aiC0rsbq15 grdHVZkZi1iVF/zrOx24ctxQvgLyGHA+M7n/oIaIgxlT1S6+FUI= =49ZC -----END PGP SIGNATURE----- Merge tag 'v1.19.1rc1' into develop Synapse 1.19.1rc1 (2020-08-25) ============================== Bugfixes -------- - Fix a bug introduced in v1.19.0 where appservices with ratelimiting disabled would still be ratelimited when joining rooms. ([\#8139](https://github.com/matrix-org/synapse/issues/8139)) - Fix a bug introduced in v1.19.0 that would cause e.g. profile updates to fail due to incorrect application of rate limits on join requests. ([\#8153](https://github.com/matrix-org/synapse/issues/8153))	2020-08-25 15:48:11 +01:00
Brendan Abolivier	b79d69796c	1.19.1rc1	2020-08-25 15:24:39 +01:00
Erik Johnston	2231dffee6	Make StreamIdGen `get_next` and `get_next_mult` async (#8161 ) This is mainly so that `StreamIdGenerator` and `MultiWriterIdGenerator` will have the same interface, allowing them to be used interchangeably.	2020-08-25 15:10:08 +01:00
Andrew Morgan	74bf8d4d06	Wording fixes to 'name' user admin api filter (#8163 ) Some fixes to wording I noticed after merging #7377.	2020-08-25 15:03:24 +01:00
Manuel Stahl	97962ad17b	Search in columns 'name' and 'displayname' in the admin users endpoint (#7377 ) * Search in columns 'name' and 'displayname' in the admin users endpoint Signed-off-by: Manuel Stahl <manuel.stahl@awesome-technologies.de>	2020-08-25 14:18:14 +01:00
Patrick Cloke	5758dcf30c	Add type hints for state. (#8140 )	2020-08-24 14:25:27 -04:00
Patrick Cloke	cbd8d83da7	Stop shadow-banned users from sending non-member events. (#8142 )	2020-08-24 13:58:56 -04:00
Brendan Abolivier	420484a334	Allow capping a room's retention policy (#8104 )	2020-08-24 18:21:04 +01:00
Brendan Abolivier	393a811a41	Fix join ratelimiter breaking profile updates and idempotency (#8153 )	2020-08-24 18:06:04 +01:00
Will Hunt	2df82ae451	Do not apply ratelimiting on joins to appservices (#8139 ) Add new method ratelimiter.can_requester_do_action and ensure that appservices are exempt from being ratelimited. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>	2020-08-24 14:53:53 +01:00
Brendan Abolivier	3f49f74610	Don't fail /submit_token requests on incorrect session ID if request_token_inhibit_3pid_errors is turned on (#7991 ) * Don't raise session_id errors on submit_token if request_token_inhibit_3pid_errors is set * Changelog * Also wait some time before responding to /requestToken * Incorporate review * Update synapse/storage/databases/main/registration.py Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Incorporate review Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>	2020-08-24 11:33:55 +01:00
Will Hunt	cbbf9126cb	Do not apply ratelimiting on joins to appservices (#8139 ) Add new method ratelimiter.can_requester_do_action and ensure that appservices are exempt from being ratelimited. Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Erik Johnston <erik@matrix.org>	2020-08-21 15:07:56 +01:00
Richard van der Hoff	09fd0eda81	Micro-optimisations to get_auth_chain_ids (#8132 )	2020-08-21 10:06:45 +01:00
Patrick Cloke	3f91638da6	Allow denying or shadow banning registrations via the spam checker (#8034 )	2020-08-20 15:42:58 -04:00
Patrick Cloke	e259d63f73	Stop shadow-banned users from sending invites. (#8095 )	2020-08-20 15:07:42 -04:00
Richard van der Hoff	318f4e738e	Be more tolerant of membership events in unknown rooms (#8110 ) It turns out that not all out-of-band membership events are labelled as such, so we need to be more accepting here.	2020-08-20 16:42:12 +01:00
Patrick Cloke	592cdf73be	Improve the error code when trying to register using a name reserved for guests. (#8135 )	2020-08-20 10:39:41 -04:00
Patrick Cloke	dbc630a628	Use the JSON encoder without whitespace in more places. (#8124 )	2020-08-20 10:32:33 -04:00
Patrick Cloke	5eac0b7e76	Add more types to synapse.storage.database. (#8127 )	2020-08-20 09:00:59 -04:00
Patrick Cloke	731dfff347	Ensure a group ID is valid before trying to get rooms for it. (#8129 )	2020-08-20 06:41:32 -04:00
Patrick Cloke	76c43f086a	Do not assume calls to runInteraction return Deferreds. (#8133 )	2020-08-20 06:39:55 -04:00
Richard van der Hoff	12aebdfa5a	Close the database connection we create during startup (#8131 ) ... otherwise it gets leaked.	2020-08-19 20:41:53 +01:00
Erik Johnston	c9c544cda5	Remove `ChainedIdGenerator`. (#8123 ) It's just a thin wrapper around two ID gens to make `get_current_token` and `get_next` return tuples. This can easily be replaced by calling the appropriate methods on the underlying ID gens directly.	2020-08-19 13:41:51 +01:00
Patrick Cloke	f594e434c3	Switch the JSON byte producer from a pull to a push producer. (#8116 )	2020-08-19 08:07:57 -04:00
Patrick Cloke	eebf52be06	Be stricter about JSON that is accepted by Synapse (#8106 )	2020-08-19 07:26:03 -04:00
Patrick Cloke	d89692ea84	Convert runWithConnection to async. (#8121 )	2020-08-19 07:09:24 -04:00
Patrick Cloke	d294f0e7e1	Remove the unused inlineCallbacks code-paths in the caching code (#8119 )	2020-08-19 07:09:07 -04:00
Erik Johnston	76d21d14a0	Separate `get_current_token` into two. (#8113 ) The function is used for two purposes: 1) for subscribers of streams to get a token they can use to get further updates with, and 2) for replication to track position of the writers of the stream. For streams with a single writer the two scenarios produce the same result, however the situation becomes complicated for streams with multiple writers. The current `MultiWriterIdGenerator` does not correctly handle the first case (which is not an issue as its only used for the `caches` stream which nothing subscribes to outside of replication).	2020-08-19 10:39:31 +01:00
Patrick Cloke	f40645e60b	Convert events worker database to async/await. (#8071 )	2020-08-18 16:20:49 -04:00
Patrick Cloke	3c01724b33	Fix the return type of send_nonmember_events. (#8112 )	2020-08-18 09:53:13 -04:00
Andrew Morgan	5cf7c12995	Remove : from allowed client_secret chars (#8101 ) Closes: https://github.com/matrix-org/synapse/issues/6766 Equivalent Sydent PR: https://github.com/matrix-org/sydent/pull/309 I believe it's now time to remove the extra allowed `:` from `client_secret` parameters.	2020-08-18 14:14:27 +01:00
Patrick Cloke	2f4d60a5ba	Iteratively encode JSON responses to avoid blocking the reactor. (#8013 )	2020-08-18 08:49:59 -04:00
Patrick Cloke	25e55d2598	Return the previous stream token if a non-member event is a duplicate. (#8093 )	2020-08-18 07:53:23 -04:00
Andrew Morgan	8b6c176aee	Add resources.consent conditional dependency back (#8107 ) Turns out that part of the codebase (synapse.config.server) checks for this key explicitly. Remove that check.	2020-08-18 10:59:54 +01:00
Patrick Cloke	050e20e7ca	Convert some of the general database methods to async (#8100 )	2020-08-17 12:18:01 -04:00
Andrew Morgan	e04e465b4d	Use the default templates when a custom template file cannot be found (#8037 ) Fixes https://github.com/matrix-org/synapse/issues/6583	2020-08-17 17:05:00 +01:00
Olivier Wilkinson (reivilibre)	8390e00c7f	Merge branch 'master' into develop	2020-08-17 14:28:49 +01:00
Olivier Wilkinson (reivilibre)	ea4e4d2f0b	1.19.0	2020-08-17 14:12:46 +01:00
Patrick Cloke	ad6190c925	Convert stream database to async/await. (#8074 )	2020-08-17 07:24:46 -04:00
Patrick Cloke	ac77cdb64e	Add a shadow-banned flag to users. (#8092 )	2020-08-14 12:37:59 -04:00
Patrick Cloke	b069b78bb4	Convert pusher databases to async/await. (#8075 )	2020-08-14 10:30:16 -04:00
Patrick Cloke	e8861957d9	Convert receipts and events databases to async/await. (#8076 )	2020-08-14 10:05:19 -04:00
Erik Johnston	dc22090a67	Add type hints to synapse.handlers.room (#8090 )	2020-08-14 14:47:53 +01:00
Patrick Cloke	6b7ce1d332	Remove some unused database functions. (#8085 )	2020-08-14 09:25:40 -04:00
Patrick Cloke	894dae74fe	Convert misc database code to async (#8087 )	2020-08-14 07:24:26 -04:00
Olivier Wilkinson (reivilibre)	bfd79c2988	Synapse 1.19.0rc1 (2020-08-13) ============================== Removal warning --------------- As outlined in the [previous release](https://github.com/matrix-org/synapse/releases/tag/v1.18.0), we are no longer publishing Docker images with the `-py3` tag suffix. On top of that, we have also removed the `latest-py3` tag. Please see [the announcement in the upgrade notes for 1.18.0](https://github.com/matrix-org/synapse/blob/develop/UPGRADE.rst#upgrading-to-v1180). Features -------- - Add option to allow server admins to join rooms which fail complexity checks. Contributed by @lugino-emeritus. ([\#7902](https://github.com/matrix-org/synapse/issues/7902)) - Add an option to purge room or not with delete room admin endpoint (`POST /_synapse/admin/v1/rooms/<room_id>/delete`). Contributed by @dklimpel. ([\#7964](https://github.com/matrix-org/synapse/issues/7964)) - Add rate limiting to users joining rooms. ([\#8008](https://github.com/matrix-org/synapse/issues/8008)) - Add a `/health` endpoint to every configured HTTP listener that can be used as a health check endpoint by load balancers. ([\#8048](https://github.com/matrix-org/synapse/issues/8048)) - Allow login to be blocked based on the values of SAML attributes. ([\#8052](https://github.com/matrix-org/synapse/issues/8052)) - Allow guest access to the `GET /_matrix/client/r0/rooms/{room_id}/members` endpoint, according to MSC2689. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7314](https://github.com/matrix-org/synapse/issues/7314)) Bugfixes -------- - Fix a bug introduced in Synapse v1.7.2 which caused inaccurate membership counts in the room directory. ([\#7977](https://github.com/matrix-org/synapse/issues/7977)) - Fix a long standing bug: 'Duplicate key value violates unique constraint "event_relations_id"' when message retention is configured. ([\#7978](https://github.com/matrix-org/synapse/issues/7978)) - Fix "no create event in auth events" when trying to reject invitation after inviter leaves. Bug introduced in Synapse v1.10.0. ([\#7980](https://github.com/matrix-org/synapse/issues/7980)) - Fix various comments and minor discrepencies in server notices code. ([\#7996](https://github.com/matrix-org/synapse/issues/7996)) - Fix a long standing bug where HTTP HEAD requests resulted in a 400 error. ([\#7999](https://github.com/matrix-org/synapse/issues/7999)) - Fix a long-standing bug which caused two copies of some log lines to be written when synctl was used along with a MemoryHandler logger. ([\#8011](https://github.com/matrix-org/synapse/issues/8011), [\#8012](https://github.com/matrix-org/synapse/issues/8012)) Updates to the Docker image --------------------------- - We no longer publish Docker images with the `-py3` tag suffix, as [announced in the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/UPGRADE.rst#upgrading-to-v1180). ([\#8056](https://github.com/matrix-org/synapse/issues/8056)) Improved Documentation ---------------------- - Document how to set up a client .well-known file and fix several pieces of outdated documentation. ([\#7899](https://github.com/matrix-org/synapse/issues/7899)) - Improve workers docs. ([\#7990](https://github.com/matrix-org/synapse/issues/7990), [\#8000](https://github.com/matrix-org/synapse/issues/8000)) - Fix typo in `docs/workers.md`. ([\#7992](https://github.com/matrix-org/synapse/issues/7992)) - Add documentation for how to undo a room shutdown. ([\#7998](https://github.com/matrix-org/synapse/issues/7998), [\#8010](https://github.com/matrix-org/synapse/issues/8010)) Internal Changes ---------------- - Reduce the amount of whitespace in JSON stored and sent in responses. Contributed by David Vo. ([\#7372](https://github.com/matrix-org/synapse/issues/7372)) - Switch to the JSON implementation from the standard library and bump the minimum version of the canonicaljson library to 1.2.0. ([\#7936](https://github.com/matrix-org/synapse/issues/7936), [\#7979](https://github.com/matrix-org/synapse/issues/7979)) - Convert various parts of the codebase to async/await. ([\#7947](https://github.com/matrix-org/synapse/issues/7947), [\#7948](https://github.com/matrix-org/synapse/issues/7948), [\#7949](https://github.com/matrix-org/synapse/issues/7949), [\#7951](https://github.com/matrix-org/synapse/issues/7951), [\#7963](https://github.com/matrix-org/synapse/issues/7963), [\#7973](https://github.com/matrix-org/synapse/issues/7973), [\#7975](https://github.com/matrix-org/synapse/issues/7975), [\#7976](https://github.com/matrix-org/synapse/issues/7976), [\#7981](https://github.com/matrix-org/synapse/issues/7981), [\#7987](https://github.com/matrix-org/synapse/issues/7987), [\#7989](https://github.com/matrix-org/synapse/issues/7989), [\#8003](https://github.com/matrix-org/synapse/issues/8003), [\#8014](https://github.com/matrix-org/synapse/issues/8014), [\#8016](https://github.com/matrix-org/synapse/issues/8016), [\#8027](https://github.com/matrix-org/synapse/issues/8027), [\#8031](https://github.com/matrix-org/synapse/issues/8031), [\#8032](https://github.com/matrix-org/synapse/issues/8032), [\#8035](https://github.com/matrix-org/synapse/issues/8035), [\#8042](https://github.com/matrix-org/synapse/issues/8042), [\#8044](https://github.com/matrix-org/synapse/issues/8044), [\#8045](https://github.com/matrix-org/synapse/issues/8045), [\#8061](https://github.com/matrix-org/synapse/issues/8061), [\#8062](https://github.com/matrix-org/synapse/issues/8062), [\#8063](https://github.com/matrix-org/synapse/issues/8063), [\#8066](https://github.com/matrix-org/synapse/issues/8066), [\#8069](https://github.com/matrix-org/synapse/issues/8069), [\#8070](https://github.com/matrix-org/synapse/issues/8070)) - Move some database-related log lines from the default logger to the database/transaction loggers. ([\#7952](https://github.com/matrix-org/synapse/issues/7952)) - Add a script to detect source code files using non-unix line terminators. ([\#7965](https://github.com/matrix-org/synapse/issues/7965), [\#7970](https://github.com/matrix-org/synapse/issues/7970)) - Log the SAML session ID during creation. ([\#7971](https://github.com/matrix-org/synapse/issues/7971)) - Implement new experimental push rules for some users. ([\#7997](https://github.com/matrix-org/synapse/issues/7997)) - Remove redundant and unreliable signature check for v1 Identity Service lookup responses. ([\#8001](https://github.com/matrix-org/synapse/issues/8001)) - Improve the performance of the register endpoint. ([\#8009](https://github.com/matrix-org/synapse/issues/8009)) - Reduce less useful output in the newsfragment CI step. Add a link to the changelog section of the contributing guide on error. ([\#8024](https://github.com/matrix-org/synapse/issues/8024)) - Rename storage layer objects to be more sensible. ([\#8033](https://github.com/matrix-org/synapse/issues/8033)) - Change the default log config to reduce disk I/O and storage for new servers. ([\#8040](https://github.com/matrix-org/synapse/issues/8040)) - Add an assertion on `prev_events` in `create_new_client_event`. ([\#8041](https://github.com/matrix-org/synapse/issues/8041)) - Add a comment to `ServerContextFactory` about the use of `SSLv23_METHOD`. ([\#8043](https://github.com/matrix-org/synapse/issues/8043)) - Log `OPTIONS` requests at `DEBUG` rather than `INFO` level to reduce amount logged at `INFO`. ([\#8049](https://github.com/matrix-org/synapse/issues/8049)) - Reduce amount of outbound request logging at `INFO` level. ([\#8050](https://github.com/matrix-org/synapse/issues/8050)) - It is no longer necessary to explicitly define `filters` in the logging configuration. (Continuing to do so is redundant but harmless.) ([\#8051](https://github.com/matrix-org/synapse/issues/8051)) - Add and improve type hints. ([\#8058](https://github.com/matrix-org/synapse/issues/8058), [\#8064](https://github.com/matrix-org/synapse/issues/8064), [\#8060](https://github.com/matrix-org/synapse/issues/8060), [\#8067](https://github.com/matrix-org/synapse/issues/8067)) -----BEGIN PGP SIGNATURE----- iQJKBAABCgA0FiEEnGyN+jjiKnCf/nYCBnFee20mPkIFAl81c5QWHG9saXZpZXJA bGlicmVwdXNoLm5ldAAKCRAGcV57bSY+QvA7D/9qMkvldt24XZymcY9WV3Po+SzC Ijb+ZXdbUq/ZmhqJWeK7NRwiYLPuJHOUZ1Bk2GF6U8OOYQLoz+UmtShXxSu32cwc /0UUxsF+CAuxs6NowUq2d4n/5Hkl4A2Oi0NP7sjU4k7TJU9s5wWrG0l20EBUfx0r XPxDjZUPNoVH+Ecj3l3jt8+ixNeyWHPOmJsZmzOYEnfA8eAmHEozJ7ymh6qiR5qQ apfK9VeWR1bLJ/zUv+U4mTWRL8YSkswdtU6PamJjf86lMfEZJPp32l5ydEmq+4KV MaljYo20QuxkOrdQghtjiPakxhxCJAQRDBNMcMFTclicexlwEwoRgT9XjXhujd7G D58q6x+Nsy7YaZdE92ZGqaok3taoV1rmAQOV1qm/7SnmPyomOamlTnuIknvkJdys i5Vir0HcbcStNlVIWAYJdO7/t0JoEerI/eH1j2PJu35d8/Q4RFbuLSwUCaKErmPl BuGPrSGztEfRu604JJn5lpHQKBsI+oS/F68Xet6mlzNeidnY0AYxjyyYj7qJo4X7 z9EX4UY1PTIGHQ13l4iG4wb4KgRk9APPw4G8xwhWDJQWvNVuePOHGM+sw4fV22wP FDKxb4+r2Sa9hnKpUzlGj+AJWbSwldF1Cdyo1l8b/fzo3UJbzeG8216xVfE+K91o pxrQoiSqq0Isn8dtmw== =pUup -----END PGP SIGNATURE----- Merge tag 'v1.19.0rc1' into develop Synapse 1.19.0rc1 (2020-08-13) ============================== Removal warning --------------- As outlined in the [previous release](https://github.com/matrix-org/synapse/releases/tag/v1.18.0), we are no longer publishing Docker images with the `-py3` tag suffix. On top of that, we have also removed the `latest-py3` tag. Please see [the announcement in the upgrade notes for 1.18.0](https://github.com/matrix-org/synapse/blob/develop/UPGRADE.rst#upgrading-to-v1180). Features -------- - Add option to allow server admins to join rooms which fail complexity checks. Contributed by @lugino-emeritus. ([\#7902](https://github.com/matrix-org/synapse/issues/7902)) - Add an option to purge room or not with delete room admin endpoint (`POST /_synapse/admin/v1/rooms/<room_id>/delete`). Contributed by @dklimpel. ([\#7964](https://github.com/matrix-org/synapse/issues/7964)) - Add rate limiting to users joining rooms. ([\#8008](https://github.com/matrix-org/synapse/issues/8008)) - Add a `/health` endpoint to every configured HTTP listener that can be used as a health check endpoint by load balancers. ([\#8048](https://github.com/matrix-org/synapse/issues/8048)) - Allow login to be blocked based on the values of SAML attributes. ([\#8052](https://github.com/matrix-org/synapse/issues/8052)) - Allow guest access to the `GET /_matrix/client/r0/rooms/{room_id}/members` endpoint, according to MSC2689. Contributed by Awesome Technologies Innovationslabor GmbH. ([\#7314](https://github.com/matrix-org/synapse/issues/7314)) Bugfixes -------- - Fix a bug introduced in Synapse v1.7.2 which caused inaccurate membership counts in the room directory. ([\#7977](https://github.com/matrix-org/synapse/issues/7977)) - Fix a long standing bug: 'Duplicate key value violates unique constraint "event_relations_id"' when message retention is configured. ([\#7978](https://github.com/matrix-org/synapse/issues/7978)) - Fix "no create event in auth events" when trying to reject invitation after inviter leaves. Bug introduced in Synapse v1.10.0. ([\#7980](https://github.com/matrix-org/synapse/issues/7980)) - Fix various comments and minor discrepencies in server notices code. ([\#7996](https://github.com/matrix-org/synapse/issues/7996)) - Fix a long standing bug where HTTP HEAD requests resulted in a 400 error. ([\#7999](https://github.com/matrix-org/synapse/issues/7999)) - Fix a long-standing bug which caused two copies of some log lines to be written when synctl was used along with a MemoryHandler logger. ([\#8011](https://github.com/matrix-org/synapse/issues/8011), [\#8012](https://github.com/matrix-org/synapse/issues/8012)) Updates to the Docker image --------------------------- - We no longer publish Docker images with the `-py3` tag suffix, as [announced in the upgrade notes](https://github.com/matrix-org/synapse/blob/develop/UPGRADE.rst#upgrading-to-v1180). ([\#8056](https://github.com/matrix-org/synapse/issues/8056)) Improved Documentation ---------------------- - Document how to set up a client .well-known file and fix several pieces of outdated documentation. ([\#7899](https://github.com/matrix-org/synapse/issues/7899)) - Improve workers docs. ([\#7990](https://github.com/matrix-org/synapse/issues/7990), [\#8000](https://github.com/matrix-org/synapse/issues/8000)) - Fix typo in `docs/workers.md`. ([\#7992](https://github.com/matrix-org/synapse/issues/7992)) - Add documentation for how to undo a room shutdown. ([\#7998](https://github.com/matrix-org/synapse/issues/7998), [\#8010](https://github.com/matrix-org/synapse/issues/8010)) Internal Changes ---------------- - Reduce the amount of whitespace in JSON stored and sent in responses. Contributed by David Vo. ([\#7372](https://github.com/matrix-org/synapse/issues/7372)) - Switch to the JSON implementation from the standard library and bump the minimum version of the canonicaljson library to 1.2.0. ([\#7936](https://github.com/matrix-org/synapse/issues/7936), [\#7979](https://github.com/matrix-org/synapse/issues/7979)) - Convert various parts of the codebase to async/await. ([\#7947](https://github.com/matrix-org/synapse/issues/7947), [\#7948](https://github.com/matrix-org/synapse/issues/7948), [\#7949](https://github.com/matrix-org/synapse/issues/7949), [\#7951](https://github.com/matrix-org/synapse/issues/7951), [\#7963](https://github.com/matrix-org/synapse/issues/7963), [\#7973](https://github.com/matrix-org/synapse/issues/7973), [\#7975](https://github.com/matrix-org/synapse/issues/7975), [\#7976](https://github.com/matrix-org/synapse/issues/7976), [\#7981](https://github.com/matrix-org/synapse/issues/7981), [\#7987](https://github.com/matrix-org/synapse/issues/7987), [\#7989](https://github.com/matrix-org/synapse/issues/7989), [\#8003](https://github.com/matrix-org/synapse/issues/8003), [\#8014](https://github.com/matrix-org/synapse/issues/8014), [\#8016](https://github.com/matrix-org/synapse/issues/8016), [\#8027](https://github.com/matrix-org/synapse/issues/8027), [\#8031](https://github.com/matrix-org/synapse/issues/8031), [\#8032](https://github.com/matrix-org/synapse/issues/8032), [\#8035](https://github.com/matrix-org/synapse/issues/8035), [\#8042](https://github.com/matrix-org/synapse/issues/8042), [\#8044](https://github.com/matrix-org/synapse/issues/8044), [\#8045](https://github.com/matrix-org/synapse/issues/8045), [\#8061](https://github.com/matrix-org/synapse/issues/8061), [\#8062](https://github.com/matrix-org/synapse/issues/8062), [\#8063](https://github.com/matrix-org/synapse/issues/8063), [\#8066](https://github.com/matrix-org/synapse/issues/8066), [\#8069](https://github.com/matrix-org/synapse/issues/8069), [\#8070](https://github.com/matrix-org/synapse/issues/8070)) - Move some database-related log lines from the default logger to the database/transaction loggers. ([\#7952](https://github.com/matrix-org/synapse/issues/7952)) - Add a script to detect source code files using non-unix line terminators. ([\#7965](https://github.com/matrix-org/synapse/issues/7965), [\#7970](https://github.com/matrix-org/synapse/issues/7970)) - Log the SAML session ID during creation. ([\#7971](https://github.com/matrix-org/synapse/issues/7971)) - Implement new experimental push rules for some users. ([\#7997](https://github.com/matrix-org/synapse/issues/7997)) - Remove redundant and unreliable signature check for v1 Identity Service lookup responses. ([\#8001](https://github.com/matrix-org/synapse/issues/8001)) - Improve the performance of the register endpoint. ([\#8009](https://github.com/matrix-org/synapse/issues/8009)) - Reduce less useful output in the newsfragment CI step. Add a link to the changelog section of the contributing guide on error. ([\#8024](https://github.com/matrix-org/synapse/issues/8024)) - Rename storage layer objects to be more sensible. ([\#8033](https://github.com/matrix-org/synapse/issues/8033)) - Change the default log config to reduce disk I/O and storage for new servers. ([\#8040](https://github.com/matrix-org/synapse/issues/8040)) - Add an assertion on `prev_events` in `create_new_client_event`. ([\#8041](https://github.com/matrix-org/synapse/issues/8041)) - Add a comment to `ServerContextFactory` about the use of `SSLv23_METHOD`. ([\#8043](https://github.com/matrix-org/synapse/issues/8043)) - Log `OPTIONS` requests at `DEBUG` rather than `INFO` level to reduce amount logged at `INFO`. ([\#8049](https://github.com/matrix-org/synapse/issues/8049)) - Reduce amount of outbound request logging at `INFO` level. ([\#8050](https://github.com/matrix-org/synapse/issues/8050)) - It is no longer necessary to explicitly define `filters` in the logging configuration. (Continuing to do so is redundant but harmless.) ([\#8051](https://github.com/matrix-org/synapse/issues/8051)) - Add and improve type hints. ([\#8058](https://github.com/matrix-org/synapse/issues/8058), [\#8064](https://github.com/matrix-org/synapse/issues/8064), [\#8060](https://github.com/matrix-org/synapse/issues/8060), [\#8067](https://github.com/matrix-org/synapse/issues/8067))	2020-08-13 18:22:58 +01:00
Olivier Wilkinson (reivilibre)	091ca3910d	1.19.0rc1	2020-08-13 17:12:21 +01:00
Richard van der Hoff	53834bb9c4	Run `remove_push_actions_from_staging` in foreground (#8081 ) If we got an error persisting an event, we would try to remove the push actions asynchronously, which would lead to a 'Re-starting finished log context' warning. I don't think there's any need for this to be asynchronous.	2020-08-13 17:05:31 +01:00
reivilibre	ff0e894656	Drop federation transmission queues during a significant remote outage. (#7864 ) * Empty federation transmission queues when we are backing off. Fixes #7828. Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> * Address feedback Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net> * Reword newsfile	2020-08-13 12:35:04 +01:00
Patrick Cloke	fbe930dad2	Convert the roommember database to async/await. (#8070 )	2020-08-12 12:14:34 -04:00
Patrick Cloke	5ecc8b5825	Convert devices database to async/await. (#8069 )	2020-08-12 10:51:42 -04:00
Erik Johnston	5dd73d029e	Add type hints to handlers.message and events.builder (#8067 )	2020-08-12 15:05:50 +01:00
Patrick Cloke	d68e10f308	Convert account data, device inbox, and censor events databases to async/await (#8063 )	2020-08-12 09:29:06 -04:00
Patrick Cloke	a3a59bab7b	Convert appservice, group server, profile and more databases to async (#8066 )	2020-08-12 09:28:48 -04:00
Erik Johnston	9d1e4942ab	Fix typing for notifier (#8064 )	2020-08-12 14:03:08 +01:00
Erik Johnston	6ba621d786	Merge pull request #8060 from matrix-org/erikj/type_server Change HomeServer definition to work with typing.	2020-08-11 22:32:14 +01:00
Patrick Cloke	04faa0bfa9	Convert tags and metrics databases to async/await (#8062 )	2020-08-11 17:21:20 -04:00
Patrick Cloke	a0acdfa9e9	Converts event_federation and registration databases to async/await (#8061 )	2020-08-11 17:21:13 -04:00
Erik Johnston	fdb46b5442	Merge remote-tracking branch 'origin/develop' into erikj/type_server	2020-08-11 22:03:14 +01:00
Erik Johnston	c066928915	Add comment explaining cast	2020-08-11 22:01:12 +01:00
Erik Johnston	61d8ff0d44	Auto set logging filter (#8051 ) We do this to prevent foot guns. The default config uses a MemoryFilter, but users are free to change to logging to files directly. If they do then they have to ensure to set the `filters: [context]` on the right handler, otherwise records get written with the wrong context. Instead we move the logic to happen when we generate a record, which is when we log rather than handle. (It's possible to add filters to loggers in the config, however they don't apply to descendant loggers and so they have to be manually set on every logger used in the code base)	2020-08-11 21:58:56 +01:00
Erik Johnston	a1e9bb9eae	Add typing info to Notifier (#8058 )	2020-08-11 19:40:02 +01:00
Erik Johnston	8a3dac3c19	Handle optional dependencies for Oidc and Saml	2020-08-11 18:20:45 +01:00
Erik Johnston	0304ad0c3d	Move setting of Filter into code. We do this to prevent foot guns. The default config uses a MemoryFilter, but users are free to change to logging to files directly. If they do then they have to ensure to set the `filters: [context]` on the right handler, otherwise records get written with the wrong context. Instead we move the logic to happen when we generate a record, which is when we log rather than handle. (It's possible to add filters to loggers in the config, however they don't apply to descendant loggers and so they have to be manually set on every logger used in the code base)	2020-08-11 18:10:46 +01:00
Erik Johnston	a0f574f3c2	Reduce INFO logging (#8050 ) c.f. #8021 A lot of the code here is to change the `Completed 200 OK` logging to include the request URI so that we can drop the `Sending request...` log line. Some notes: 1. We won't log retries, which may be confusing considering the time taken log line includes retries and sleeps. 2. The `_send_request_with_optional_trailing_slash` will always be logged without the forward slash, even if it succeeded only with the forward slash.	2020-08-11 18:10:07 +01:00
Erik Johnston	db131b6b22	Change the default log config to reduce disk I/O and storage (#8040 ) * Change default log config to buffer by default. This batches up writes to the filesystem, which is more efficient for disk I/O. This means that it can take some time for logs to get written to disk. Note that ERROR logs (and above) immediately flush the buffer. This only effects new installs, as we only write the log config if started with `--generate-config` (in the same way we do for generating signing keys). * Default to keeping last 4 days of logs. This hopefully reduces the amount of logs kept for new servers. Keeping the last 1GB of logs is likely overkill for new servers, but equally may not be enough for busy ones. Instead, we keep the last four days worth of logs, enough so that admins can investigate any problems that happened over e.g. a long weekend.	2020-08-11 18:09:46 +01:00
Erik Johnston	0f1afbe8dc	Change HomeServer definition to work with typing. Duplicating function signatures between server.py and server.pyi is silly. This commit changes that by changing all `build_` methods to `get_` methods and changing the `_make_dependency_method` to work work as a descriptor that caches the produced value. There are some changes in other files that were made to fix the typing in server.py.	2020-08-11 18:00:17 +01:00
Richard van der Hoff	0cb169900e	Implement login blocking based on SAML attributes (#8052 ) Hopefully this mostly speaks for itself. I also did a bit of cleaning up of the error handling. Fixes #8047	2020-08-11 16:08:10 +01:00
Richard van der Hoff	fcbab08cbd	Add an assertion on prev_events in create_new_client_event (#8041 ) I think this would have caught all the cases in https://github.com/matrix-org/synapse/issues/7642 - and I think a 500 makes more sense here than a 403	2020-08-10 12:29:47 +01:00
Brendan Abolivier	cdbb8e6d6e	Implement new experimental push rules (#7997 ) With an undocumented configuration setting to enable them for specific users.	2020-08-10 11:48:01 +01:00
Brendan Abolivier	5c43c43240	Typo	2020-08-10 11:23:24 +01:00
Brendan Abolivier	1a3aabcf3f	Lint	2020-08-10 11:13:21 +01:00
Brendan Abolivier	cee6c6012e	why mypy why	2020-08-10 11:10:34 +01:00
Patrick Cloke	7f837959ea	Convert directory, e2e_room_keys, end_to_end_keys, monthly_active_users database to async (#8042 )	2020-08-07 13:36:29 -04:00
Patrick Cloke	f3fe6961b2	Convert additional database stores to async/await (#8045 )	2020-08-07 12:17:17 -04:00
Richard van der Hoff	de6f892065	Add a comment about SSLv23_METHOD (#8043 )	2020-08-07 15:14:29 +01:00
Erik Johnston	2f9fd5ab00	Don't log OPTIONS request at INFO (#8049 )	2020-08-07 14:53:05 +01:00
Patrick Cloke	4e874ed593	Remove unnecessary maybeDeferred calls (#8044 )	2020-08-07 09:44:48 -04:00
Erik Johnston	7620912d84	Add health check endpoint (#8048 )	2020-08-07 14:21:24 +01:00
David Vo	4dd27e6d11	Reduce unnecessary whitespace in JSON. (#7372 )	2020-08-07 08:02:55 -04:00
Brendan Abolivier	367e9e6e9e	Lint	2020-08-06 17:57:58 +01:00
Brendan Abolivier	bf33d5c457	Incorporate review	2020-08-06 17:52:34 +01:00
Brendan Abolivier	2ffd6783c7	Revert #7736 (#8039 )	2020-08-06 17:15:35 +01:00
Patrick Cloke	fe6cfc80ec	Convert some util functions to async (#8035 )	2020-08-06 08:39:35 -04:00
Patrick Cloke	d4a7829b12	Convert synapse.api to async/await (#8031 )	2020-08-06 08:30:06 -04:00
Patrick Cloke	c36228c403	Convert run_as_background_process inner function to async. (#8032 )	2020-08-06 08:20:42 -04:00
Patrick Cloke	66f24449dd	Improve performance of the register endpoint (#8009 )	2020-08-06 08:09:55 -04:00
Brendan Abolivier	118a9eafb3	Merge branch 'develop' of github.com:matrix-org/synapse into babolivier/new_push_rules	2020-08-06 10:52:50 +01:00
Brendan Abolivier	dd11f575a2	Incorporate review	2020-08-06 10:52:26 +01:00
Erik Johnston	a7bdf98d01	Rename database classes to make some sense (#8033 )	2020-08-05 21:38:57 +01:00
Richard van der Hoff	0a86850ba3	Stop the parent process flushing the logs on exit (#8012 ) This solves the problem that the first few lines are logged twice on matrix.org. Hopefully the comments explain it.	2020-08-05 09:35:17 +01:00
Patrick Cloke	8ff2deda72	Fix async/await calls for broken media providers. (#8027 )	2020-08-04 09:44:25 -04:00
Patrick Cloke	88a3ff12f0	Convert the SimpleHttpClient to async. (#8016 )	2020-08-04 07:22:04 -04:00
Patrick Cloke	e19de43eb5	Convert streams to async. (#8014 )	2020-08-04 07:21:47 -04:00
Richard van der Hoff	916cf2d439	re-implement daemonize (#8011 ) This has long been something I've wanted to do. Basically the `Daemonize` code is both too flexible and not flexible enough, in that it offers a bunch of features that we don't use (changing UID, closing FDs in the child, logging to syslog) and doesn't offer a bunch that we could do with (redirecting stdout/err to a file instead of /dev/null; having the parent not exit until the child is running). As a first step, I've lifted the Daemonize code and removed the bits we don't use. This should be a non-functional change. Fixing everything else will come later.	2020-08-04 10:03:41 +01:00
Andrew Morgan	481f76c7aa	Remove signature check on v1 identity server lookups (#8001 ) We've [decided](https://github.com/matrix-org/synapse/issues/5253#issuecomment-665976308) to remove the signature check for v1 lookups. The signature check has been removed in v2 lookups. v1 lookups are currently deprecated. As mentioned in the above linked issue, this verification was causing deployments for the vector.im and matrix.org IS deployments, and this change is the simplest solution, without being unjustified. Implementations are encouraged to use the v2 lookup API as it has [increased privacy benefits](https://github.com/matrix-org/matrix-doc/pull/2134).	2020-08-03 21:56:43 +01:00
Andrew Morgan	5d92a1428c	Prevent join->join membership transitions changing member count (#7977 ) `StatsHandler` handles updates to the `current_state_delta_stream`, and updates room stats such as the amount of state events, joined users, etc. However, it counts every new join membership as a new user entering a room (and that user being in another room), whereas it's possible for a user's membership status to go from join -> join, for instance when they change their per-room profile information. This PR adds a check for join->join membership transitions, and bails out early, as none of the further checks are necessary at that point. Due to this bug, membership stats in many rooms have ended up being wildly larger than their true values. I am not sure if we also want to include a migration step which recalculates these statistics (possibly using the `_populate_stats_process_rooms` bg update). Bug introduced in the initial implementation https://github.com/matrix-org/synapse/pull/4338.	2020-08-03 21:54:24 +01:00
Patrick Cloke	6812509807	Implement handling of HTTP HEAD requests. (#7999 )	2020-08-03 08:45:42 -04:00
Patrick Cloke	2a89ce8cd4	Convert the crypto module to async/await. (#8003 )	2020-08-03 08:29:01 -04:00
Michael Albert	b6c6fb7950	Allow guests to operate in encrypted rooms (#7314 ) Signed-off-by: Michael Albert <michael.albert@awesome-technologies.de>	2020-08-03 12:13:49 +01:00
Patrick Cloke	3b415e23a5	Convert replication code to async/await. (#7987 )	2020-08-03 07:12:55 -04:00
Patrick Cloke	db5970ac6d	Convert ACME code to async/await. (#7989 )	2020-08-03 07:09:33 -04:00
Brendan Abolivier	e2f1cccc8a	Fix PUT /pushrules to use the right rule IDs	2020-08-03 11:52:52 +01:00
Brendan Abolivier	1678057b56	Back out the database hack and replace it with a temporary config setting	2020-08-03 11:22:22 +01:00
Patrick Cloke	d1008fe949	Fix some comments and types in service notices (#7996 )	2020-07-31 16:22:06 -04:00
Erik Johnston	faba873d4b	Merge branch 'develop' of github.com:matrix-org/synapse into erikj/add_rate_limiting_to_joins	2020-07-31 15:07:01 +01:00
Erik Johnston	18de00adb4	Add ratelimiting on joins	2020-07-31 15:06:56 +01:00
Brendan Abolivier	cf42d0a60c	Fix cache name	2020-07-31 15:06:41 +01:00
Brendan Abolivier	79d991eff0	Fix cache invalidation calls	2020-07-31 13:58:42 +01:00
Brendan Abolivier	60328ce9fb	Lint	2020-07-30 19:02:28 +01:00
Brendan Abolivier	69158e554f	Merge branch 'develop' of github.com:matrix-org/synapse into babolivier/new_push_rules	2020-07-30 19:00:29 +01:00
Richard van der Hoff	0a7fb24716	Fix invite rejection when we have no forward-extremeties (#7980 ) Thanks to some slightly overzealous cleanup in the `delete_old_current_state_events`, it's possible to end up with no `event_forward_extremities` in a room where we have outstanding local invites. The user would then get a "no create event in auth events" when trying to reject the invite. We can hack around it by using the dangling invite as the prev event.	2020-07-30 16:58:57 +01:00
Olivier Wilkinson (reivilibre)	3aa36b782c	Merge branch 'master' into develop	2020-07-30 15:18:36 +01:00
Patrick Cloke	c978f6c451	Convert federation client to async/await. (#7975 )	2020-07-30 08:01:33 -04:00
Patrick Cloke	4cce8ef74e	Convert appservice to async. (#7973 )	2020-07-30 07:27:39 -04:00
Patrick Cloke	b3a97d6dac	Convert some of the data store to async. (#7976 )	2020-07-30 07:20:41 -04:00
Patrick Cloke	3950ae51ef	Ensure that remove_pusher is always async (#7981 )	2020-07-30 06:56:55 -04:00
Olivier Wilkinson (reivilibre)	a9631b7b4b	1.18.0	2020-07-30 10:56:54 +01:00
Erik Johnston	2c1b9d6763	Update worker docs with recent enhancements (#7969 )	2020-07-29 23:22:13 +01:00
Patrick Cloke	a53e0160a2	Ensure the msg property of HttpResponseException is a string. (#7979 )	2020-07-29 13:56:06 -04:00
Patrick Cloke	d90087cffa	Remove from the event_relations table when purging historical events. (#7978 )	2020-07-29 13:55:01 -04:00
Patrick Cloke	3a00bd1378	Add additional logging for SAML sessions. (#7971 )	2020-07-29 13:54:44 -04:00
Brendan Abolivier	8dff4a1242	Re-implement unread counts (#7736 )	2020-07-29 18:26:55 +01:00
Aaron Raimist	2184f61fae	Various improvements to the docs (#7899 )	2020-07-29 10:35:44 -04:00
Patrick Cloke	3345c166a4	Convert storage layer to async/await. (#7963 )	2020-07-28 16:09:53 -04:00
Dirk Klimpel	e866e3b896	Add an option to disable purge in delete room admin API (#7964 ) Add option ```purge``` to ```POST /_synapse/admin/v1/rooms/<room_id>/delete``` Fixes: #3761 Signed-off-by: Dirk Klimpel dirk@klimpel.org	2020-07-28 20:08:23 +01:00
Brendan Abolivier	9725c59247	Implement new experimental push rules with a database hack to enable them	2020-07-28 19:20:55 +01:00
Andrew Morgan	8a25332d94	Move some log lines from default logger to sql/transaction loggers (#7952 ) Idea from matrix-org/synapse-dinsic#49	2020-07-28 18:52:13 +01:00
Patrick Cloke	2c1e1b153d	Use the JSON module from the std library instead of simplejson. (#7936 )	2020-07-28 10:28:59 -04:00
lugino-emeritus	3857de2194	Option to allow server admins to join complex rooms (#7902 ) Fixes #7901. Signed-off-by: Niklas Tittjung <nik_t.01@web.de>	2020-07-28 13:41:44 +01:00
Richard van der Hoff	349119a340	Synapse 1.18.0rc2 (2020-07-28) ============================== Bugfixes -------- - Fix an `AssertionError` exception introduced in v1.18.0rc1. ([\#7876](https://github.com/matrix-org/synapse/issues/7876)) - Fix experimental support for moving typing off master when worker is restarted, which is broken in v1.18.0rc1. ([\#7967](https://github.com/matrix-org/synapse/issues/7967)) Internal Changes ---------------- - Further optimise queueing of inbound replication commands. ([\#7876](https://github.com/matrix-org/synapse/issues/7876)) -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEv27Axt/F4vrTL/8QOSor00I9eP8FAl8f/f8ACgkQOSor00I9 eP8/Uwf8CiVWvrBsmFZMvxJDkUWm0/f1kN4IQdm8ibDtyNyvFUx+Y1K8KOQS+VwG a3bZqSC2Vv2sO9O9kR+V2tk831l+ujO0Nlaohuqyvhcl9lzh04rRYI9x9IHlAq2H WPb0NMLwMufL6YkXDBwZT/G9TVW1vLRGASu4f7X2rXqek34VNVgYbg1hB2dp4dDa wjKk3iBZ6h34IhKPgu0sLBUcyvX4U5xdOHjEG3HXvNnvDNO0HMD8rGB7065vFMD6 PH4nUK/h+RL0UBs2sJOMK1ZazFUODdURwANJQNAQ6pNvf9/RWgw2okka2bYIcmQQ UT7tiwMsBvKdy4PER5fcDX3COY16qw== =Q+bI -----END PGP SIGNATURE----- Merge tag 'v1.18.0rc2' into develop Synapse 1.18.0rc2 (2020-07-28) ============================== Bugfixes -------- - Fix an `AssertionError` exception introduced in v1.18.0rc1. ([\#7876](https://github.com/matrix-org/synapse/issues/7876)) - Fix experimental support for moving typing off master when worker is restarted, which is broken in v1.18.0rc1. ([\#7967](https://github.com/matrix-org/synapse/issues/7967)) Internal Changes ---------------- - Further optimise queueing of inbound replication commands. ([\#7876](https://github.com/matrix-org/synapse/issues/7876))	2020-07-28 11:31:31 +01:00
Richard van der Hoff	7000a215e6	1.18.0rc2	2020-07-28 11:22:32 +01:00
Erik Johnston	a8f7ed28c6	Typing worker needs to handle stream update requests (#7967 ) IIRC this doesn't break tests because its only hit on reconnection, or something. Basically, when a process needs to fetch missing updates for the `typing` stream it needs to query the writer instance via HTTP (as we don't write typing notifications to the DB), the problem was that the endpoint (`streams`) was only registered on master and specifically not on the typing writer worker.	2020-07-28 11:04:53 +01:00
Patrick Cloke	68626ff8e9	Convert the remaining media repo code to async / await. (#7947 )	2020-07-27 14:40:11 -04:00
Richard van der Hoff	f57b99af22	Handle replication commands synchronously where possible (#7876 ) Most of the stuff we do for replication commands can be done synchronously. There's no point spinning up background processes if we're not going to need them.	2020-07-27 18:54:43 +01:00
Patrick Cloke	8553f46498	Convert a synapse.events to async/await. (#7949 )	2020-07-27 13:40:22 -04:00
Patrick Cloke	5f65e62681	Convert groups and visibility code to async / await. (#7951 )	2020-07-27 12:32:08 -04:00
Patrick Cloke	8144bc26a7	Convert push to async/await. (#7948 )	2020-07-27 12:21:34 -04:00
Richard van der Hoff	f88c48f3b8	1.18.0rc1	2020-07-27 16:57:40 +01:00
Erik Johnston	1ef9efc1e0	Fix error reporting when using `opentracing.trace` (#7961 )	2020-07-27 16:20:24 +01:00
Erik Johnston	84d099ae11	Fix typing replication not being handled on master (#7959 ) Handling of incoming typing stream updates from replication was not hooked up on master, effecting set ups where typing was handled on a different worker. This is really only a problem if the master process is also handling sync requests, which is unlikely for those that are at the stage of moving typing off. The other observable effect is that if a worker restarts or a replication connect drops then the typing worker will issue a `POSITION typing`, triggering master process to try and stream all typing updates from position 0. Fixes #7907	2020-07-27 14:10:53 +01:00
Patrick Cloke	d8a9cd8d3e	Remove hacky error handling for inlineDeferreds. (#7950 )	2020-07-27 08:35:56 -04:00
Patrick Cloke	3fc8fdd150	Support oEmbed for media previews. (#7920 ) Fixes previews of Twitter URLs by using their oEmbed endpoint to grab content.	2020-07-27 07:50:44 -04:00
Patrick Cloke	b975fa2e99	Convert state resolution to async/await (#7942 )	2020-07-24 10:59:51 -04:00
Patrick Cloke	e739b20588	Fix up types and comments that refer to Deferreds. (#7945 )	2020-07-24 10:53:25 -04:00
Patrick Cloke	53f7b49f5b	Do not convert async functions to Deferreds in the interactive_auth_handler (#7944 )	2020-07-24 09:43:49 -04:00
Patrick Cloke	5ea29d7f85	Convert more of the media code to async/await (#7873 )	2020-07-24 09:39:02 -04:00
Patrick Cloke	6a080ea184	Return an empty body for OPTIONS requests. (#7886 )	2020-07-24 07:08:07 -04:00
Richard van der Hoff	1ec688bf21	Downgrade warning on client disconnect to INFO (#7928 ) Clients disconnecting before we finish processing the request happens from time to time. We don't need to yell about it	2020-07-24 09:55:47 +01:00
Patrick Cloke	fefe9943ef	Convert presence handler helpers to async/await. (#7939 )	2020-07-23 16:47:36 -04:00
Patrick Cloke	83434df381	Update the auth providers to be async. (#7935 )	2020-07-23 15:45:39 -04:00
Richard van der Hoff	7078866969	Put a cache on `/state_ids` (#7931 ) If we send out an event which refers to `prev_events` which other servers in the federation are missing, then (after a round or two of backfill attempts), they will end up asking us for `/state_ids` at a particular point in the DAG. As per https://github.com/matrix-org/synapse/issues/7893, this is quite expensive, and we tend to see lots of very similar requests around the same time. We can therefore handle this much more efficiently by using a cache, which (a) ensures that if we see the same request from multiple servers (or even the same server, multiple times), then they share the result, and (b) any other servers that miss the initial excitement can also benefit from the work. [It's interesting to note that `/state` has a cache for exactly this reason. `/state` is now essentially unused and replaced with `/state_ids`, but evidently when we replaced it we forgot to add a cache to the new endpoint.]	2020-07-23 18:38:19 +01:00
Richard van der Hoff	4876af06dd	Abort federation requests if the client disconnects early (#7930 ) For inbound federation requests, if a given remote server makes too many requests at once, we start stacking them up rather than processing them immediatedly. However, that means that there is a fair chance that the requesting server will disconnect before we start processing the request. In that case, if it was a read-only request (ie, a GET request), there is absolutely no point in building a response (and some requests are quite expensive to handle). Even in the case of a POST request, one of two things will happen: * Most likely, the requesting server will retry the request and we'll get the information anyway. * Even if it doesn't, the requesting server has to assume that we didn't get the memo, and act accordingly. In short, we're better off aborting the request at this point rather than ploughing on with what might be a quite expensive request.	2020-07-23 16:52:33 +01:00
Patrick Cloke	68cd935826	Convert the federation agent and related code to async/await. (#7874 )	2020-07-23 07:05:57 -04:00
Patrick Cloke	13d77464c9	Follow-up to admin API to re-activate accounts (#7908 )	2020-07-22 12:33:19 -04:00
Patrick Cloke	cc9bb3dc3f	Convert the message handler to async/await. (#7884 )	2020-07-22 12:29:15 -04:00
Richard van der Hoff	923c995023	Skip serializing /sync response if client has disconnected (#7927 ) ... it's a load of work which may be entirely redundant.	2020-07-22 13:44:16 +01:00
Richard van der Hoff	b74919c72e	Add debugging to sync response generation (#7929 )	2020-07-22 13:43:10 +01:00
Richard van der Hoff	931b026844	Remove an unused prometheus metric (#7878 )	2020-07-22 00:40:55 +01:00
Richard van der Hoff	05060e0223	Track command processing as a background process (#7879 ) I'm going to be doing more stuff synchronously, and I don't want to lose the CPU metrics down the sofa.	2020-07-22 00:40:42 +01:00
Richard van der Hoff	15997618e2	Clean up PreserveLoggingContext (#7877 ) This had some dead code and some just plain wrong docstrings.	2020-07-22 00:40:27 +01:00
Richard van der Hoff	2ccd48e921	fix an incorrect comment	2020-07-22 00:24:56 +01:00
Patrick Cloke	de119063f2	Convert room list handler to async/await. (#7912 )	2020-07-21 07:51:48 -04:00
Jason Robinson	759481af6d	Element CSS and logo in email templates (#7919 ) Use Element CSS and logo in notification emails when app name is Element. Signed-off-by: Jason Robinson <jasonr@matrix.org>	2020-07-21 11:58:01 +01:00
Karthikeyan Singaravelan	5662e2b0f3	Remove unused code from synapse.logging.utils. (#7897 )	2020-07-20 15:20:53 -04:00
Adrian	64d2280299	Fix a typo in the sample config. (#7890 )	2020-07-20 13:42:52 -04:00
Karthikeyan Singaravelan	a7b06a81f0	Fix deprecation warning: import ABC from collections.abc (#7892 )	2020-07-20 13:33:04 -04:00
Andrew Morgan	5ecf98f59e	Change sample config's postgres user to synapse_user (#7889 ) The [postgres setup docs](https://github.com/matrix-org/synapse/blob/develop/docs/postgres.md#set-up-database) recommend setting up your database with user `synapse_user`. However, uncommenting the postgres defaults in the sample config leave you with user `synapse`. This PR switches the sample config to recommend `synapse_user`. Took a me a second to figure this out, so assume this will beneficial to others.	2020-07-20 18:29:25 +01:00
Patrick Cloke	d1d5fa66e4	Fix the trace function for async functions. (#7872 ) Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>	2020-07-17 13:32:01 -04:00
Erik Johnston	2d2acc1cf2	Stop using 'device_max_stream_id' (#7882 ) It serves no purpose and updating everytime we write to the device inbox stream means all such transactions will conflict, causing lots of transaction failures and retries.	2020-07-17 17:03:27 +01:00
Erik Johnston	a3ad045286	Fix TypeError in synapse.notifier (#7880 ) Fixes #7774	2020-07-17 14:11:05 +01:00
Patrick Cloke	852930add7	Add a default limit (of 100) to get/sync operations. (#7858 )	2020-07-17 07:59:23 -04:00
Erik Johnston	4642fd66df	Change "unknown room ver" logging to warning. (#7881 ) It's somewhat expected for us to have unknown room versions in the database due to room version experiments.	2020-07-17 12:10:43 +01:00
Patrick Cloke	6b3ac3b8cd	Convert device handler to async/await (#7871 )	2020-07-17 07:09:25 -04:00
Patrick Cloke	00e57b755c	Convert synapse.app to async/await. (#7868 )	2020-07-17 07:08:56 -04:00
Patrick Cloke	6fca1b3506	Convert _base, profile, and _receipts handlers to async/await (#7860 )	2020-07-17 07:08:30 -04:00
Michael Albert	fff483ea96	Add admin endpoint to get members in a room. (#7842 )	2020-07-16 16:43:23 -04:00
Patrick Cloke	f460da6031	Consistently use `db_to_json` to convert from database values to JSON objects. (#7849 )	2020-07-16 11:32:19 -04:00
Richard van der Hoff	e5300063ed	Optimise queueing of inbound replication commands (#7861 ) When we get behind on replication, we tend to stack up background processes behind a linearizer. Bg processes are heavy (particularly with respect to prometheus metrics) and linearizers aren't terribly efficient once the queue gets long either. A better approach is to maintain a queue of requests to be processed, and nominate a single process to work its way through the queue. Fixes: #7444	2020-07-16 15:49:37 +01:00
Richard van der Hoff	346476df21	Reject attempts to join empty rooms over federation (#7859 ) We shouldn't allow others to make_join through us if we've left the room; reject such attempts with a 404. Fixes #7835. Fixes #6958.	2020-07-16 15:17:31 +01:00
Erik Johnston	f2e38ca867	Allow moving typing off master (#7869 )	2020-07-16 15:12:54 +01:00
Erik Johnston	649a7ead5c	Add ability to run multiple pusher instances (#7855 ) This reuses the same scheme as federation sender sharding	2020-07-16 14:06:28 +01:00
Richard van der Hoff	a827838706	Merge pull request #7866 from matrix-org/rav/fix_guest_user_id Fix guest user registration with lots of client readers	2020-07-16 13:54:45 +01:00
Richard van der Hoff	a973bcb8a4	Add some tiny type annotations (#7870 ) I found these made pycharm have more of a clue as to what was going on in other places.	2020-07-16 13:52:29 +01:00
Richard van der Hoff	c445bc0cad	Use a postgres sequence to generate guest user IDs	2020-07-16 13:00:25 +01:00
Richard van der Hoff	3c36ae17a5	Use SequenceGenerator for state group ID allocation	2020-07-16 11:25:08 +01:00
Richard van der Hoff	42509b8fb6	Use `PostgresSequenceGenerator` from `MultiWriterIdGenerator` partly just to show it works, but alwo to remove a bit of code duplication.	2020-07-16 11:25:08 +01:00
Richard van der Hoff	90b0cdda42	Add some helper classes for generating ID sequences	2020-07-16 11:25:08 +01:00
Olivier Wilkinson (reivilibre)	12528dc42f	Remove obsolete comment. It was correct at the time of our friend Jorik writing it (checking git blame), but the world has moved now and it is no longer a generator. Signed-off-by: Olivier Wilkinson (reivilibre) <olivier@librepush.net>	2020-07-16 11:12:48 +01:00
Patrick Cloke	35450519de	Ensure that calls to `json.dumps` are compatible with the standard library json. (#7836 )	2020-07-15 13:40:54 -04:00
Richard van der Hoff	a57df9b827	Avoid brand new rooms in `delete_old_current_state_events` (#7854 ) When considering rooms to clean up in `delete_old_current_state_events`, skip rooms which we are creating, which otherwise look a bit like rooms we have left. Fixes #7834.	2020-07-15 18:33:03 +01:00
Erik Johnston	97e1159ac1	Merge branch 'erikj/faster_typing' of github.com:matrix-org/synapse into develop	2020-07-15 16:54:30 +01:00
Patrick Cloke	8c7d0f163d	Allow accounts to be re-activated from the admin APIs. (#7847 )	2020-07-15 11:00:21 -04:00
Erik Johnston	62352c3a1b	Fix typo	2020-07-15 15:46:16 +01:00
Erik Johnston	3a3a618460	Use get_users_in_room rather than state handler in typing for speed	2020-07-15 15:42:07 +01:00
Erik Johnston	f13061d515	Fix client reader sharding tests (#7853 ) * Fix client reader sharding tests * Newsfile * Fix typing * Update changelog.d/7853.misc Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Move mocking of http_client to tests Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>	2020-07-15 15:27:35 +01:00
Patrick Cloke	b11450dedc	Convert E2E key and room key handlers to async/await. (#7851 )	2020-07-15 08:48:58 -04:00
Patrick Cloke	111e70d75c	Return the proper 403 Forbidden error during errors with JWT logins. (#7844 )	2020-07-15 07:10:21 -04:00
Richard van der Hoff	1d9dca02f9	remove `retry_on_integrity_error` wrapper for persist_events (#7848 ) As far as I can tell from the sentry logs, the only time this has actually done anything in the last two years is when we had two master workers running at once, and even then, it made a bit of a mess of it (see https://github.com/matrix-org/synapse/issues/7845#issuecomment-658238739). Generally I feel like this code is doing more harm than good.	2020-07-15 10:34:53 +01:00
Patrick Cloke	8d0097bef1	Fix bug in per-room message retention policies. (#7850 )	2020-07-14 15:51:13 -04:00
Brendan Abolivier	85223106f3	Allow email subjects to be customised through Synapse's configuration (#7846 )	2020-07-14 19:10:42 +01:00
Dirk Klimpel	491f0dab1b	Add delete room admin endpoint (#7613 ) The Delete Room admin API allows server admins to remove rooms from server and block these rooms. `DELETE /_synapse/admin/v1/rooms/<room_id>` It is a combination and improvement of "[Shutdown room](https://github.com/matrix-org/synapse/blob/develop/docs/admin_api/shutdown_room.md)" and "[Purge room](https://github.com/matrix-org/synapse/blob/develop/docs/admin_api/purge_room.md)" API. Fixes: #6425 It also fixes a bug in [synapse/storage/data_stores/main/room.py](synapse/storage/data_stores/main/room.py) in ` get_room_with_stats`. It should return `None` if the room is unknown. But it returns an `IndexError`. `901b1fa561/synapse/storage/data_stores/main/room.py (L99-L105)` Related to: - #5575 - https://github.com/Awesome-Technologies/synapse-admin/issues/17 Signed-off-by: Dirk Klimpel dirk@klimpel.org	2020-07-14 12:36:23 +01:00
Patrick Cloke	77d2c05410	Add the option to validate the `iss` and `aud` claims for JWT logins. (#7827 )	2020-07-14 07:16:43 -04:00
Patrick Cloke	4db1509516	Improve the type hints of synapse.api.errors. (#7820 )	2020-07-14 07:03:58 -04:00
Erik Johnston	f886a69916	Correctly pass app_name to all email templates. (#7829 ) We didn't do this for e.g. registration emails.	2020-07-14 10:00:53 +01:00
Patrick Cloke	457096e6df	Support handling registration requests across multiple client readers. (#7830 )	2020-07-13 13:31:46 -04:00
Brendan Abolivier	504c8f3483	Fix handling of "off" in encryption_enabled_by_default_for_room_type (#7822 ) Fixes https://github.com/matrix-org/synapse/issues/7821, introduced in https://github.com/matrix-org/synapse/pull/7639 Turns out PyYAML translates `off` into a `False` boolean if it's unquoted (see https://stackoverflow.com/questions/36463531/pyyaml-automatically-converting-certain-keys-to-boolean-values), which seems to be a liberal interpretation of this bit of the YAML spec: https://yaml.org/spec/1.1/current.html#id864510 An alternative fix would be to implement the solution mentioned in the SO post linked above, but I'm aware it might break existing setups (which might use these values in the configuration file) so it's probably better just to add an extra check for this one. We should be aware that this is a thing for the next times we do that though. I didn't find any other occurrence of this bug elsewhere in the codebase.	2020-07-13 17:14:42 +01:00
Richard van der Hoff	59e64b6d5b	Merge branch 'master' into develop	2020-07-13 11:42:52 +01:00
Richard van der Hoff	29df3d0e9f	1.17.0	2020-07-13 10:20:36 +01:00
Patrick Cloke	66a4af8d96	Do not use canonicaljson to magically handle decoding bytes from JSON. (#7802 )	2020-07-10 14:30:08 -04:00
Patrick Cloke	d9e47af617	Add types to the server code and remove unused parameter (#7813 )	2020-07-10 14:28:42 -04:00
Sorunome	1bca21e1da	Include room states on invite events sent to ASes (#6455 )	2020-07-10 18:44:56 +01:00
Richard van der Hoff	6cef918a4b	Merge branch 'release-v1.17.0' into develop	2020-07-10 18:38:50 +01:00
Richard van der Hoff	8ccb7f08d9	Merge branch 'master' into release-v1.17.0	2020-07-10 18:38:18 +01:00
Erik Johnston	f299441cc6	Add ability to shard the federation sender (#7798 )	2020-07-10 18:26:36 +01:00
Erik Johnston	f1245dc3c0	Fix resync remote devices on receive PDU in worker mode. (#7815 ) The replication client requires that arguments are given as keyword arguments, which was not done in this case. We also pull out the logic so that we can catch and handle any exceptions raised, rather than leaving them unhandled.	2020-07-10 18:23:17 +01:00
Erik Johnston	e29c44340b	Fix recursion error when fetching auth chain over federation (#7817 ) When fetching the state of a room over federation we receive the event IDs of the state and auth chain. We then fetch those events that we don't already have. However, we used a function that recursively fetched any missing auth events for the fetched events, which can lead to a lot of recursion if the server is missing most of the auth chain. This work is entirely pointless because would have queued up the missing events in the auth chain to be fetched already. Let's just diable the recursion, since it only gets called from one place anyway.	2020-07-10 18:15:35 +01:00
Richard van der Hoff	b1beb3ff59	fix migration, again	2020-07-10 12:18:35 +01:00
Richard van der Hoff	c9f7c683ae	1.16.1	2020-07-10 12:11:12 +01:00
Richard van der Hoff	cbabcec05c	Drop incorrectly-added table `local_rejections_stream`. (#7816 )	2020-07-10 12:07:59 +01:00
Richard van der Hoff	43726783e4	1.17.0rc1	2020-07-09 16:53:19 +01:00
Patrick Cloke	38e1fac886	Fix some spelling mistakes / typos. (#7811 )	2020-07-09 09:52:58 -04:00
Richard van der Hoff	53ee214f2f	`update_membership` declaration: now always returns an event id. (#7809 )	2020-07-09 13:01:42 +01:00
Richard van der Hoff	8ca39bd2c3	Improve stacktraces from exceptions in background processes (#7808 ) use `Failure()` to fish out the real exception.	2020-07-09 13:01:33 +01:00
Richard van der Hoff	08c5181a8d	Fix `can only concatenate list (not "tuple") to list` exception (#7810 ) It seems auth_events can be either a list or a tuple, depending on Things.	2020-07-09 12:48:15 +01:00
Patrick Cloke	8fa7fdd4cb	Pass original request headers from workers to the main process. (#7797 )	2020-07-09 07:34:46 -04:00
Richard van der Hoff	2ab0b021f1	Generate real events when we reject invites (#7804 ) Fixes #2181. The basic premise is that, when we fail to reject an invite via the remote server, we can generate our own out-of-band leave event and persist it as an outlier, so that we have something to send to the client.	2020-07-09 10:40:19 +01:00
Richard van der Hoff	67593b1728	Add `HomeServer.signing_key` property (#7805 ) ... instead of duplicating `config.signing_key[0]` everywhere	2020-07-08 17:51:56 +01:00
Patrick Cloke	e7efd8f827	Do not use simplejson in Synapse. (#7800 )	2020-07-08 07:15:08 -04:00
Patrick Cloke	ff0680f69d	Stop passing bytes when dumping JSON (#7799 )	2020-07-08 07:14:56 -04:00

... 5 6 7 8 9 ...

12683 Commits