Matrix-Mirrors/anonymousland-synapse
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse.git synced 2025-05-02 11:06:07 -04:00
Code Issues Projects Releases Packages Wiki Activity

Don't update event cache hit ratio from get_joined_users

Browse source 
Otherwise the hit ration of plain get_events gets completely skewed by
calls to get_joined_users* functions.
This commit is contained in:
Erik Johnston 2017-05-08 16:06:17 +01:00
parent dcabef952c
commit ffad4fe35b
3 changed files with 21 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

13
synapse/storage/events.py
View file

@ -1343,11 +1343,20 @@ class EventsStore(SQLBaseStore):
def _invalidate_get_event_cache(self, event_id):
self._get_event_cache.invalidate((event_id,))
def _get_events_from_cache(self, events, allow_rejected):
def _get_events_from_cache(self, events, allow_rejected, update_metrics=True):
"""
Args:
events (list(str)): list of event_ids to fetch
allow_rejected (bool): Whether to teturn events that were rejected
update_metrics (bool): Whether to update the cache hit ratio metrics
"""
event_map = {}
for event_id in events:
ret = self._get_event_cache.get((event_id,), None)
ret = self._get_event_cache.get(
(event_id,), None,
update_metrics=update_metrics,
)
if not ret:
continue