Call set_avatar_url with target_user, not user_id (#8872)

* Call set_avatar_url with target_user, not user_id

Fixes https://github.com/matrix-org/synapse/issues/8871

* Create 8872.bugfix

* Update synapse/rest/admin/users.py

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>

* Testing

* Update changelog.d/8872.bugfix

Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>

Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com>
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
This commit is contained in:
Will Hunt 2020-12-07 19:13:07 +00:00 committed by GitHub
parent 1f3748f033
commit ff1f0ee094
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 3 deletions

View file

@ -320,9 +320,9 @@ class UserRestServletV2(RestServlet):
data={},
)
if "avatar_url" in body and type(body["avatar_url"]) == str:
if "avatar_url" in body and isinstance(body["avatar_url"], str):
await self.profile_handler.set_avatar_url(
user_id, requester, body["avatar_url"], True
target_user, requester, body["avatar_url"], True
)
ret = await self.admin_handler.get_user(target_user)