Matrix-Mirrors/anonymousland-synapse
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse.git synced 2024-10-01 11:49:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

Time external cache response time (#9904)

Browse Source
This commit is contained in:
Erik Johnston 2021-05-04 15:14:22 +01:00 committed by GitHub
parent b85821aca2
commit e3bc4617fc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changelog.d/9904.misc Normal file
View File

@ -0,0 +1 @@
Time response time for external cache requests.

36
synapse/replication/tcp/external_cache.py
View File

@ -15,7 +15,7 @@
import logging import logging
from typing import TYPE_CHECKING, Any, Optional from typing import TYPE_CHECKING, Any, Optional
from prometheus_client import Counter from prometheus_client import Counter, Histogram
from synapse.logging.context import make_deferred_yieldable from synapse.logging.context import make_deferred_yieldable
from synapse.util import json_decoder, json_encoder from synapse.util import json_decoder, json_encoder
@ -35,6 +35,20 @@ get_counter = Counter(
labelnames=["cache_name", "hit"], labelnames=["cache_name", "hit"],
) )
response_timer = Histogram(
"synapse_external_cache_response_time_seconds",
"Time taken to get a response from Redis for a cache get/set request",
labelnames=["method"],
buckets=(
0.001,
0.002,
0.005,
0.01,
0.02,
0.05,
),
)
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
@ -72,13 +86,14 @@ class ExternalCache:
logger.debug("Caching %s %s: %r", cache_name, key, encoded_value) logger.debug("Caching %s %s: %r", cache_name, key, encoded_value)
return await make_deferred_yieldable( with response_timer.labels("set").time():
self._redis_connection.set( return await make_deferred_yieldable(
self._get_redis_key(cache_name, key), self._redis_connection.set(
encoded_value, self._get_redis_key(cache_name, key),
pexpire=expiry_ms, encoded_value,
pexpire=expiry_ms,
)
) )
)
async def get(self, cache_name: str, key: str) -> Optional[Any]: async def get(self, cache_name: str, key: str) -> Optional[Any]:
"""Look up a key/value in the named cache.""" """Look up a key/value in the named cache."""
@ -86,9 +101,10 @@ class ExternalCache:
if self._redis_connection is None: if self._redis_connection is None:
return None return None
result = await make_deferred_yieldable( with response_timer.labels("get").time():
self._redis_connection.get(self._get_redis_key(cache_name, key)) result = await make_deferred_yieldable(
) self._redis_connection.get(self._get_redis_key(cache_name, key))
)
logger.debug("Got cache result %s %s: %r", cache_name, key, result) logger.debug("Got cache result %s %s: %r", cache_name, key, result)