Apply comment fixups from code review

Co-Authored-By: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
This commit is contained in:
Erik Johnston 2019-07-03 15:03:38 +01:00 committed by GitHub
parent 65dd5543f6
commit d0b849c86d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -100,7 +100,7 @@ class AdminHandler(BaseHandler):
@defer.inlineCallbacks @defer.inlineCallbacks
def exfiltrate_user_data(self, user_id, writer): def exfiltrate_user_data(self, user_id, writer):
"""Write all data we have of the user to the specified directory. """Write all data we have on the user to the given writer.
Args: Args:
user_id (str) user_id (str)
@ -178,7 +178,7 @@ class AdminHandler(BaseHandler):
# We fetch events in the room the user could see by fetching *all* # We fetch events in the room the user could see by fetching *all*
# events that we have and then filtering, this isn't the most # events that we have and then filtering, this isn't the most
# efficient method perhaps but it does guarentee we get everything. # efficient method perhaps but it does guarantee we get everything.
while True: while True:
events, _ = yield self.store.paginate_room_events( events, _ = yield self.store.paginate_room_events(
room_id, from_key, to_key, limit=100, direction="f" room_id, from_key, to_key, limit=100, direction="f"
@ -233,7 +233,7 @@ class AdminHandler(BaseHandler):
class ExfiltrationWriter(object): class ExfiltrationWriter(object):
"""Interfaced used to specify how to write exfilrated data. """Interface used to specify how to write exfiltrated data.
""" """
def write_events(self, room_id, events): def write_events(self, room_id, events):
@ -263,7 +263,7 @@ class ExfiltrationWriter(object):
Args: Args:
room_id (str) room_id (str)
invite (FrozenEvent) event (FrozenEvent)
state (list[dict]): A subset of the state at the invite, with a state (list[dict]): A subset of the state at the invite, with a
subset of the event keys (type, state_key, content and sender) subset of the event keys (type, state_key, content and sender)
""" """
@ -276,13 +276,13 @@ class ExfiltrationWriter(object):
class FileExfiltrationWriter(ExfiltrationWriter): class FileExfiltrationWriter(ExfiltrationWriter):
"""An ExfiltrationWriter that writes the users data to a directory. """An ExfiltrationWriter that writes the user's data to a directory.
Returns the directory location on completion. Returns the directory location on completion.
Args: Args:
user_id (str): The user whose data is being exfiltrated. user_id (str): The user whose data is being exfiltrated.
directory (str|None): The directory to write the data to, if None then directory (str|None): The directory to write the data to. If None then
will write to a temporary directory. will write to a temporary directory.
""" """