Merge pull request #3449 from matrix-org/dbkr/fix_deactivate_account_multiple_pending

Fix error on deleting users pending deactivation
This commit is contained in:
Matthew Hodgson 2018-06-26 10:59:19 +01:00 committed by GitHub
commit c695a8d003
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -623,7 +623,9 @@ class RegistrationStore(RegistrationWorkerStore,
Removes the given user to the table of users who need to be parted from all the Removes the given user to the table of users who need to be parted from all the
rooms they're in, effectively marking that user as fully deactivated. rooms they're in, effectively marking that user as fully deactivated.
""" """
return self._simple_delete_one( # XXX: This should be simple_delete_one but we failed to put a unique index on
# the table, so somehow duplicate entries have ended up in it.
return self._simple_delete(
"users_pending_deactivation", "users_pending_deactivation",
keyvalues={ keyvalues={
"user_id": user_id, "user_id": user_id,