Matrix-Mirrors/anonymousland-synapse
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse.git synced 2025-05-08 00:45:00 -04:00
Code Issues Projects Releases Packages Wiki Activity

Exclude soft-failed events from fwd-extremity candidates. (#5146)

Browse source 
When considering the candidates to be forward-extremities, we must exclude soft
failures.

Hopefully fixes #5090.
This commit is contained in:
Richard van der Hoff 2019-05-21 16:10:54 +01:00 • committed by GitHub
parent bab3eddac4
commit c4aef549ad
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
synapse/handlers/federation.py
View file

@ -1916,6 +1916,11 @@ class FederationHandler(BaseHandler):
event.room_id, latest_event_ids=extrem_ids,
)
logger.debug(
"Doing soft-fail check for %s: state %s",
event.event_id, current_state_ids,
)
# Now check if event pass auth against said current state
auth_types = auth_types_for_event(event)
current_state_ids = [
@ -1932,7 +1937,7 @@ class FederationHandler(BaseHandler):
self.auth.check(room_version, event, auth_events=current_auth_events)
except AuthError as e:
logger.warn(
"Failed current state auth resolution for %r because %s",
"Soft-failing %r because %s",
event, e,
)
event.internal_metadata.soft_failed = True