From bb23055e7d63440de6a9e75c641502037cf17073 Mon Sep 17 00:00:00 2001 From: Tulir Asokan Date: Tue, 27 Sep 2022 16:09:34 +0300 Subject: [PATCH] Remove membership event validation --- synapse/handlers/room_member.py | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/synapse/handlers/room_member.py b/synapse/handlers/room_member.py index 8d01f4bf2..d61638240 100644 --- a/synapse/handlers/room_member.py +++ b/synapse/handlers/room_member.py @@ -675,26 +675,6 @@ class RoomMemberHandler(metaclass=abc.ABCMeta): content.pop("displayname", None) content.pop("avatar_url", None) - if len(content.get("displayname") or "") > MAX_DISPLAYNAME_LEN: - raise SynapseError( - 400, - f"Displayname is too long (max {MAX_DISPLAYNAME_LEN})", - errcode=Codes.BAD_JSON, - ) - - if len(content.get("avatar_url") or "") > MAX_AVATAR_URL_LEN: - raise SynapseError( - 400, - f"Avatar URL is too long (max {MAX_AVATAR_URL_LEN})", - errcode=Codes.BAD_JSON, - ) - - if "avatar_url" in content and content.get("avatar_url") is not None: - if not await self.profile_handler.check_avatar_size_and_mime_type( - content["avatar_url"], - ): - raise SynapseError(403, "This avatar is not allowed", Codes.FORBIDDEN) - # The event content should *not* include the authorising user as # it won't be properly signed. Strip it out since it might come # back from a client updating a display name / avatar.