Avoid attempting to delete push actions for remote users. (#12879)

Remote users will never have push actions, so we can avoid a database
round-trip/transaction completely.
This commit is contained in:
Patrick Cloke 2022-05-26 07:09:16 -04:00 committed by GitHub
parent b83bc5fab5
commit b5707ceaba
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 8 additions and 4 deletions

View file

@ -673,8 +673,11 @@ class ReceiptsWorkerStore(SQLBaseStore):
lock=False,
)
# When updating a local users read receipt, remove any push actions
# which resulted from the receipt's event and all earlier events.
if (
receipt_type in (ReceiptTypes.READ, ReceiptTypes.READ_PRIVATE)
self.hs.is_mine_id(user_id)
and receipt_type in (ReceiptTypes.READ, ReceiptTypes.READ_PRIVATE)
and stream_ordering is not None
):
self._remove_old_push_actions_before_txn( # type: ignore[attr-defined]