Matrix-Mirrors/anonymousland-synapse
1
0
Fork 0
mirror of https://git.anonymousland.org/anonymousland/synapse.git synced 2025-05-04 10:34:52 -04:00
Code Issues Projects Releases Packages Wiki Activity

Fix a bug that corrupted the cache of federated space hierarchies (#11775)

Browse source 
`FederationClient.get_room_hierarchy()` caches its return values, so
refactor the code to avoid modifying the returned room summary.
This commit is contained in:
Sean Quah 2022-01-20 11:03:42 +00:00 • committed by GitHub
parent 5572e6cc4b
commit af13a3be29
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 102 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

3
synapse/handlers/room_summary.py
View file

@ -780,6 +780,7 @@ class RoomSummaryHandler:
try:
(
room_response,
children_state_events,
children,
inaccessible_children,
) = await self._federation_client.get_room_hierarchy(
@ -804,7 +805,7 @@ class RoomSummaryHandler:
}
return (
_RoomEntry(room_id, room_response, room_response.pop("children_state", ())),
_RoomEntry(room_id, room_response, children_state_events),
children_by_room_id,
set(inaccessible_children),
)